]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agocmd/go: test -i should not disable -c
Shenghou Ma [Mon, 27 Feb 2012 17:33:14 +0000 (12:33 -0500)]
cmd/go: test -i should not disable -c
        Fixes #3104.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5699088

13 years agoarchive/zip: use smarter putUintXX functions to hide offsets
Andrew Gerrand [Mon, 27 Feb 2012 06:37:59 +0000 (17:37 +1100)]
archive/zip: use smarter putUintXX functions to hide offsets

R=bradfitz, r, dsymonds, kyle
CC=golang-dev
https://golang.org/cl/5701055

13 years agoarchive/zip: stop using encoding/binary
Andrew Gerrand [Mon, 27 Feb 2012 05:29:22 +0000 (16:29 +1100)]
archive/zip: stop using encoding/binary

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/5694085

13 years agocmd/go: run examples even if -run is set if -example is also set
Rob Pike [Mon, 27 Feb 2012 05:23:22 +0000 (16:23 +1100)]
cmd/go: run examples even if -run is set if -example is also set
Allows one to disable everything but the example being debugged.
This time for sure.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5700079

13 years agomisc/dashboard: fix bug in UI template
Andrew Gerrand [Mon, 27 Feb 2012 05:18:58 +0000 (16:18 +1100)]
misc/dashboard: fix bug in UI template

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5700078

13 years agomisc/dashboard: record install counts for external packages
Andrew Gerrand [Mon, 27 Feb 2012 04:25:41 +0000 (15:25 +1100)]
misc/dashboard: record install counts for external packages

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5699082

13 years agodoc/go1: mention that regexp has changed
Rob Pike [Mon, 27 Feb 2012 03:34:16 +0000 (14:34 +1100)]
doc/go1: mention that regexp has changed
Also restore alphabetical order.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5701053

13 years agodoc: instruct freebsd/linux users to rm the old version first
Andrew Gerrand [Mon, 27 Feb 2012 03:16:56 +0000 (14:16 +1100)]
doc: instruct freebsd/linux users to rm the old version first

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5701052

13 years agotesting: add -test.example flag to control execution of examples
Rob Pike [Mon, 27 Feb 2012 01:49:10 +0000 (12:49 +1100)]
testing: add -test.example flag to control execution of examples
Also, don't run examples if -test.run is set.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5697069

13 years agoos: implement sameFile on windows
Alex Brainman [Mon, 27 Feb 2012 01:29:33 +0000 (12:29 +1100)]
os: implement sameFile on windows

Fixes #2511.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5687072

13 years agocrypto/x509: fix typo in Verify documentation
Mikkel Krautz [Mon, 27 Feb 2012 00:49:06 +0000 (11:49 +1100)]
crypto/x509: fix typo in Verify documentation

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5695070

13 years agohtml/template: use correct method signature, in introduction example.
Mike Rosset [Mon, 27 Feb 2012 00:31:38 +0000 (11:31 +1100)]
html/template: use correct method signature, in introduction example.

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/5695067

13 years agodoc: move wiki tutorial into articles directory, rmdir doc/codelab
Andrew Gerrand [Mon, 27 Feb 2012 00:25:43 +0000 (11:25 +1100)]
doc: move wiki tutorial into articles directory, rmdir doc/codelab

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5701050

13 years agocmd/go: explain x... vs. x/... in help importpath
Rob Pike [Sun, 26 Feb 2012 22:51:58 +0000 (09:51 +1100)]
cmd/go: explain x... vs. x/... in help importpath
Fixes #3110.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5696083

13 years agonet/http/cgi: add an empty response test
Brad Fitzpatrick [Sun, 26 Feb 2012 22:46:22 +0000 (14:46 -0800)]
net/http/cgi: add an empty response test

New test for http://code.google.com/p/go/source/detail?r=a73ba18

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5701046

13 years agodoc/go1: add justification discussions to major changes
Rob Pike [Sun, 26 Feb 2012 20:31:34 +0000 (07:31 +1100)]
doc/go1: add justification discussions to major changes

Fixes #3086.

R=golang-dev, gri, r, kevlar
CC=golang-dev
https://golang.org/cl/5700067

13 years agotime: add a comment about how to use the Duration constants
Rob Pike [Sun, 26 Feb 2012 11:24:51 +0000 (22:24 +1100)]
time: add a comment about how to use the Duration constants

R=golang-dev, bradfitz, r, dsymonds
CC=golang-dev
https://golang.org/cl/5696078

13 years agodoc/install: fix FreeBSD/Linux install command
Shenghou Ma [Sat, 25 Feb 2012 17:40:29 +0000 (01:40 +0800)]
doc/install: fix FreeBSD/Linux install command

R=adg, golang-dev, go.peter.90, rsc
CC=golang-dev
https://golang.org/cl/5700062

13 years agocmd/yacc/units.y: update comment, give better error messages when $GOROOT not set
Shenghou Ma [Sat, 25 Feb 2012 17:36:26 +0000 (01:36 +0800)]
cmd/yacc/units.y: update comment, give better error messages when $GOROOT not set

R=r, golang-dev
CC=golang-dev
https://golang.org/cl/5698062

13 years agodoc: update Go1 release notes to use correct WalkFunc error signature.
Mike Rosset [Sat, 25 Feb 2012 06:17:21 +0000 (22:17 -0800)]
doc: update Go1 release notes to use correct WalkFunc error signature.

filepath's WalkFunc handler now uses errors package, and not
os.Error

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5696067

13 years agogo: fix help text documenting example functions
Robert Griesemer [Fri, 24 Feb 2012 23:42:25 +0000 (15:42 -0800)]
go: fix help text documenting example functions

R=adg, r
CC=golang-dev
https://golang.org/cl/5695062

13 years agogo/test/chan1.go: fix typo
Rob Pike [Fri, 24 Feb 2012 21:47:04 +0000 (08:47 +1100)]
go/test/chan1.go: fix typo
Found by Lucio De Re

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5694071

13 years agogo/ast: examples for ast.Print, ast.Inspect
Robert Griesemer [Fri, 24 Feb 2012 21:44:36 +0000 (13:44 -0800)]
go/ast: examples for ast.Print, ast.Inspect

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5700057

13 years agogo/doc, godoc: fix range of type declarations
Robert Griesemer [Fri, 24 Feb 2012 21:44:22 +0000 (13:44 -0800)]
go/doc, godoc: fix range of type declarations

For grouped type declarations, go/doc introduces
fake individual declarations. Don't use the original
location of the "type" keyword because it will lead
to an overly large source code range for that fake
declaration, and thus an overly large selection shown
via godoc (e.g.: click on the AssignStmt link for:
http://golang.org/pkg/go/ast/#AssignStmt ).

Also: Don't create a fake declaration if not needed.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694061

13 years agodoc/go1: new introduction
Rob Pike [Fri, 24 Feb 2012 21:02:35 +0000 (08:02 +1100)]
doc/go1: new introduction
This distills the motivational discussion and makes it the introduction to the release notes.
After this lands, I'll expand the discussion of the major changes to include more background.

Updates #3086.

R=golang-dev, gri, rsc
CC=golang-dev
https://golang.org/cl/5698057

13 years agocmd/go: in list, don't print blank lines for no output
Rob Pike [Fri, 24 Feb 2012 21:00:55 +0000 (08:00 +1100)]
cmd/go: in list, don't print blank lines for no output
Otherwise
        go list -f "{{if .Stale}}{{.ImportPath}}{{end}}" all
and similar commands can print pages of empty lines.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5696058

13 years agoruntime: size arena to fit in virtual address space limit
Russ Cox [Fri, 24 Feb 2012 20:28:51 +0000 (15:28 -0500)]
runtime: size arena to fit in virtual address space limit

For Brad.
Now FreeBSD/386 binaries run on nearlyfreespeech.net.

Fixes #2302.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5700060

13 years agonet/http/cgi: fix empty response
Russ Cox [Fri, 24 Feb 2012 20:10:46 +0000 (15:10 -0500)]
net/http/cgi: fix empty response

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5693058

13 years agogc: reject import paths containing special characters
Anthony Martin [Fri, 24 Feb 2012 19:48:36 +0000 (14:48 -0500)]
gc: reject import paths containing special characters

Also allow multiple invalid import statements in a
single file.

Fixes #3021. The changes to go/parser and the
language specifcation have already been committed.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5672084

13 years agoencoding/xml: fix anonymous field Unmarshal example
Gustavo Niemeyer [Fri, 24 Feb 2012 19:45:32 +0000 (14:45 -0500)]
encoding/xml: fix anonymous field Unmarshal example

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5697043

13 years agocmd/vet: don't give error for Printf("%+5.2e", x)
Shenghou Ma [Fri, 24 Feb 2012 17:16:17 +0000 (01:16 +0800)]
cmd/vet: don't give error for Printf("%+5.2e", x)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5696048

13 years agodoc: update codelab/wiki to Go 1.
Shenghou Ma [Fri, 24 Feb 2012 17:09:05 +0000 (01:09 +0800)]
doc: update codelab/wiki to Go 1.

R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5683076

13 years agoos: fix minor typo
Sanjay Menakuru [Fri, 24 Feb 2012 11:42:16 +0000 (22:42 +1100)]
os: fix minor typo

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5697051

13 years agotest/bench/shootout: update post-Makefile
Rob Pike [Fri, 24 Feb 2012 05:59:09 +0000 (16:59 +1100)]
test/bench/shootout: update post-Makefile

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5696054

13 years agoreflect.DeepEqual: don't panic comparing functions
Rob Pike [Fri, 24 Feb 2012 05:25:39 +0000 (16:25 +1100)]
reflect.DeepEqual: don't panic comparing functions
Functions are equal iff they are both nil.

Fixes #3122.

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5693057

13 years agotest: document ken/*.go
Rob Pike [Fri, 24 Feb 2012 05:24:24 +0000 (16:24 +1100)]
test: document ken/*.go

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694065

13 years agoruntime: fix arm
Russ Cox [Fri, 24 Feb 2012 04:10:38 +0000 (23:10 -0500)]
runtime: fix arm

signal.test binary passes on my phone; should fix builder

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5694064

13 years agogc: fix escape analysis + inlining + closure bug
Russ Cox [Fri, 24 Feb 2012 04:09:53 +0000 (23:09 -0500)]
gc: fix escape analysis + inlining + closure bug

R=ken2
CC=golang-dev, lvd
https://golang.org/cl/5693056

13 years agotest: fix the fix of the rename tests.
Rob Pike [Fri, 24 Feb 2012 04:06:32 +0000 (15:06 +1100)]
test: fix the fix of the rename tests.
Now they actually test again instead of just setting iota to zero.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5700058

13 years agold: fix alignment of rodata section
Russ Cox [Fri, 24 Feb 2012 04:01:36 +0000 (23:01 -0500)]
ld: fix alignment of rodata section

We were not aligning the code size,
so read-only data, which follows in the same
segment, could be arbitrarily misaligned.

Fixes #2506.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5693055

13 years agospec: allow disallow of \uFFFD in import path
Russ Cox [Fri, 24 Feb 2012 03:46:04 +0000 (22:46 -0500)]
spec: allow disallow of \uFFFD in import path

Turns out U+FFFD is a graphic character too.

http://play.golang.org/p/YblCfKAfko

R=gri
CC=golang-dev
https://golang.org/cl/5699052

13 years agocmd/cc: grow some global arrays
Russ Cox [Fri, 24 Feb 2012 03:45:55 +0000 (22:45 -0500)]
cmd/cc: grow some global arrays

Avoids global array buffer overflows if they are
indexed using some of the values between NTYPE
and NALLTYPE.  It is entirely likely that not all of these
are necessary, but this is the C compiler and not worth
worrying much about.  This change takes up only a
few more bytes of memory and makes the behavior
deterministic.

Fixes #3078.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5693052

13 years agonet/rpc: silence read error on closing connection
Russ Cox [Fri, 24 Feb 2012 03:45:44 +0000 (22:45 -0500)]
net/rpc: silence read error on closing connection

Fixes #3113.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5698056

13 years agonet: reorganize test files
Mikio Hara [Fri, 24 Feb 2012 02:58:30 +0000 (11:58 +0900)]
net: reorganize test files

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694063

13 years agotest: add cmpout to testlib
Brad Fitzpatrick [Fri, 24 Feb 2012 02:17:26 +0000 (13:17 +1100)]
test: add cmpout to testlib

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5699060

13 years agodoc/go1: document ProcessState
Rob Pike [Fri, 24 Feb 2012 02:08:11 +0000 (13:08 +1100)]
doc/go1: document ProcessState
Also reformat the "go fix" references to make them look better by using the non-CW space.

Fixes #3087.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5695057

13 years agotest: add temporary show_skips flag.
Brad Fitzpatrick [Fri, 24 Feb 2012 01:52:15 +0000 (12:52 +1100)]
test: add temporary show_skips flag.

To find test files with legacy headers.

We can remove this flag once everything is converted.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5694060

13 years agogodoc: fine-tuning .css
Robert Griesemer [Fri, 24 Feb 2012 01:42:14 +0000 (17:42 -0800)]
godoc: fine-tuning .css

R=adg
CC=golang-dev
https://golang.org/cl/5699057

13 years agonet/http: add overlooked 418 status code, per RFC 2324.
David Symonds [Fri, 24 Feb 2012 00:55:31 +0000 (11:55 +1100)]
net/http: add overlooked 418 status code, per RFC 2324.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5688067

13 years agotest/[n-z]*.go: add documentation
Rob Pike [Fri, 24 Feb 2012 00:48:19 +0000 (11:48 +1100)]
test/[n-z]*.go: add documentation

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5700056

13 years agohtml/template: make doctype check case-insensitive
Scott Lawrence [Fri, 24 Feb 2012 00:32:33 +0000 (11:32 +1100)]
html/template: make doctype check case-insensitive

Fixes #3094.

R=golang-dev, rsc, nigeltao
CC=golang-dev
https://golang.org/cl/5687065

13 years agotest/[n-r]*.go: add documentation
Rob Pike [Thu, 23 Feb 2012 23:30:39 +0000 (10:30 +1100)]
test/[n-r]*.go: add documentation
The rename ones needed redoing.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5698054

13 years agogodoc: bring back highlighting, selections, and alerts
Robert Griesemer [Thu, 23 Feb 2012 22:54:10 +0000 (14:54 -0800)]
godoc: bring back highlighting, selections, and alerts

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5695054

13 years agogodoc: consistent placement of documentation sections
Robert Griesemer [Thu, 23 Feb 2012 20:44:11 +0000 (12:44 -0800)]
godoc: consistent placement of documentation sections

Fixes #1226.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694052

13 years agoruntime: check for ARM syscall failures
Shenghou Ma [Thu, 23 Feb 2012 20:43:14 +0000 (15:43 -0500)]
runtime: check for ARM syscall failures
    While we are at it, also update some comments.
    Tested on Linux/ARM builder.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5696047

13 years agodist: treat CC as one unit
Scott Lawrence [Thu, 23 Feb 2012 20:38:07 +0000 (15:38 -0500)]
dist: treat CC as one unit

Fixes #3112.

R=golang-dev, 0xe2.0x9a.0x9b, ality, rsc, rsc
CC=golang-dev
https://golang.org/cl/5700044

13 years agobinary: remove unnecessary dummy type.
Stefan Nilsson [Thu, 23 Feb 2012 20:29:17 +0000 (15:29 -0500)]
binary: remove unnecessary dummy type.

R=rsc
CC=golang-dev
https://golang.org/cl/5698052

13 years agogodoc: don't show testdata directories
Robert Griesemer [Thu, 23 Feb 2012 20:23:17 +0000 (12:23 -0800)]
godoc: don't show testdata directories

R=golang-dev, bradfitz, dsymonds, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/5700043

13 years agogo/parser: expand test cases for bad import
Russ Cox [Thu, 23 Feb 2012 19:44:53 +0000 (14:44 -0500)]
go/parser: expand test cases for bad import

R=gri
CC=golang-dev
https://golang.org/cl/5697047

13 years agoruntime: darwin signal masking
Russ Cox [Thu, 23 Feb 2012 19:44:06 +0000 (14:44 -0500)]
runtime: darwin signal masking

Fixes #3101 (darwin).

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5693044

13 years agoruntime: linux signal masking
Russ Cox [Thu, 23 Feb 2012 19:43:58 +0000 (14:43 -0500)]
runtime: linux signal masking

Fixes #3101 (Linux).

R=golang-dev, bradfitz, minux.ma
CC=golang-dev
https://golang.org/cl/5696043

13 years agocc: fix an out of bounds array access
Anthony Martin [Thu, 23 Feb 2012 19:28:16 +0000 (14:28 -0500)]
cc: fix an out of bounds array access

Alternatively, we could expand the ewidth array
in [568]c/txt.c to have NALLTYPES elements and
give all types above NTYPE a width of -1.

I don't think it's worth it since TDOT and TOLD
are the only two type values above NTYPE that
are passed to typ:

$ /tmp/cctypes
cc/dcl.c:683:  t->down = typ(TOLD, T);
cc/dcl.c:919:  return typ(TDOT, T);
$

Fixes #3063.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694047

13 years agomath: slightly more readable comments
Robert Griesemer [Thu, 23 Feb 2012 18:17:24 +0000 (10:17 -0800)]
math: slightly more readable comments

Replaced /*-style comments with line comments;
there are two many *'s already in those lines.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5699051

13 years ago6a/6l: add IMUL3Q and SHLDL
Adam Langley [Thu, 23 Feb 2012 15:51:04 +0000 (10:51 -0500)]
6a/6l: add IMUL3Q and SHLDL

Although Intel considers the three-argument form of IMUL to be a
variant of IMUL, I couldn't make 6l able to differentiate it without
huge changes, so I called it IMUL3.

R=rsc
CC=golang-dev
https://golang.org/cl/5686055

13 years agogo spec: import path implementation restriction
Robert Griesemer [Thu, 23 Feb 2012 07:51:25 +0000 (23:51 -0800)]
go spec: import path implementation restriction

R=rsc, r, r, adg
CC=golang-dev
https://golang.org/cl/5688074

13 years agotest: commentary for [h-m]*.go
Rob Pike [Thu, 23 Feb 2012 07:47:26 +0000 (18:47 +1100)]
test: commentary for [h-m]*.go

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5674112

13 years agoexp/types: fix package comment
Robert Griesemer [Thu, 23 Feb 2012 07:40:28 +0000 (23:40 -0800)]
exp/types: fix package comment

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5695046

13 years agogodoc: remove dead code
Robert Griesemer [Thu, 23 Feb 2012 07:38:18 +0000 (23:38 -0800)]
godoc: remove dead code

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5698044

13 years agogo/parser: check import path restrictions
Robert Griesemer [Thu, 23 Feb 2012 07:21:56 +0000 (23:21 -0800)]
go/parser: check import path restrictions

Replaces pending CL 5674097.
Thanks to ality@pbrane.org for spearheading
the effort.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5683077

13 years agogo cmd: print more than one error when running go test
Robert Griesemer [Thu, 23 Feb 2012 06:33:45 +0000 (22:33 -0800)]
go cmd: print more than one error when running go test

Fixes #3055.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5683079

13 years agotag weekly.2012-02-22
Andrew Gerrand [Thu, 23 Feb 2012 05:59:11 +0000 (16:59 +1100)]
tag weekly.2012-02-22

R=golang-dev
CC=golang-dev
https://golang.org/cl/5699044

13 years agoweekly.2012-02-22 weekly.2012-02-22
Andrew Gerrand [Thu, 23 Feb 2012 05:40:13 +0000 (16:40 +1100)]
weekly.2012-02-22

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/5698043

13 years agonet/http: some more cookie tests
Brad Fitzpatrick [Thu, 23 Feb 2012 04:51:53 +0000 (15:51 +1100)]
net/http: some more cookie tests

Including a commented-out test we might
tackle later, after seeing what browsers do.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5694045

13 years agoencoding/xml: add example and docs for anon fields
Gustavo Niemeyer [Thu, 23 Feb 2012 03:35:50 +0000 (01:35 -0200)]
encoding/xml: add example and docs for anon fields

Anonymous pointer fields is not yet supported.
The problem is documented in issue 3108.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694043

13 years agonet: add a bit clarified multicast listener tests
Mikio Hara [Thu, 23 Feb 2012 03:16:43 +0000 (12:16 +0900)]
net: add a bit clarified multicast listener tests

Also adds -external flag to allow use of external networks on tests.

R=rsc
CC=golang-dev
https://golang.org/cl/5693043

13 years agopprof: add Profile type
Russ Cox [Thu, 23 Feb 2012 02:46:12 +0000 (21:46 -0500)]
pprof: add Profile type

Makes it possible for client code to maintain its own profiles,
and also reduces the API surface by giving us a type that
models built-in profiles.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5684056

13 years agoruntime: goroutine profile, stack dumps
Russ Cox [Thu, 23 Feb 2012 02:45:01 +0000 (21:45 -0500)]
runtime: goroutine profile, stack dumps

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5687076

13 years agoencoding/xml: move Unmarshal example to function
Gustavo Niemeyer [Thu, 23 Feb 2012 01:37:57 +0000 (23:37 -0200)]
encoding/xml: move Unmarshal example to function

This also fixes MarshalIndent's example after the
recent formatting convention changes.

Fixes #2831.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5671062

13 years agotime: run full TestTicker test even during short tests
Alex Brainman [Thu, 23 Feb 2012 01:07:59 +0000 (12:07 +1100)]
time: run full TestTicker test even during short tests

R=golang-dev, r, bradfitz, r
CC=golang-dev
https://golang.org/cl/5689076

13 years ago5a: fix same arm bug
Russ Cox [Wed, 22 Feb 2012 22:36:25 +0000 (17:36 -0500)]
5a: fix same arm bug

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/5689073

13 years ago5c, 5g, 5l: fix arm bug
Russ Cox [Wed, 22 Feb 2012 21:29:14 +0000 (16:29 -0500)]
5c, 5g, 5l: fix arm bug

Using reg as the flag word was unfortunate, since the
default value is not 0 but NREG (==16), which happens
to be the bit NOPTR now.  Clear it.

If I say this will fix the build, it won't.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5690072

13 years agocmd/dist: fix install cmd/5g on non-arm system
Russ Cox [Wed, 22 Feb 2012 21:29:05 +0000 (16:29 -0500)]
cmd/dist: fix install cmd/5g on non-arm system

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5689072

13 years agonet: make raw IP tests robust
Mikio Hara [Wed, 22 Feb 2012 21:27:05 +0000 (06:27 +0900)]
net: make raw IP tests robust

Make it rely on underlying socket's address family.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5673091

13 years agonet: make parseProcNetIGMP more robust
Mikio Hara [Wed, 22 Feb 2012 21:26:31 +0000 (06:26 +0900)]
net: make parseProcNetIGMP more robust

Suggested by Paul Borman.

Fixes #2826.

R=rsc, borman
CC=golang-dev
https://golang.org/cl/5689048

13 years agoos: make the system info a value not a pointer on unix
Rob Pike [Wed, 22 Feb 2012 20:51:49 +0000 (07:51 +1100)]
os: make the system info a value not a pointer on unix
fix a couple of other minor related details.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5690071

13 years agobuilder: reuse existing workspace if possible
Shenghou Ma [Wed, 22 Feb 2012 20:39:53 +0000 (15:39 -0500)]
builder: reuse existing workspace if possible

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5690069

13 years agonet: delete debugging print
Russ Cox [Wed, 22 Feb 2012 20:35:41 +0000 (15:35 -0500)]
net: delete debugging print

Fixes #3030.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5689071

13 years agobuilder: update for os.Wait changes.
Brad Fitzpatrick [Wed, 22 Feb 2012 19:48:41 +0000 (11:48 -0800)]
builder: update for os.Wait changes.

This compiles again.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/5687078

13 years agogo/printer, gofmt: improved comma placement
Robert Griesemer [Wed, 22 Feb 2012 19:27:45 +0000 (11:27 -0800)]
go/printer, gofmt: improved comma placement

Not a Go 1 issue, but appeared to be fairly easy to fix.

- Note that a few existing test cases look slightly worse but
  those cases were not representative for real code. All real
  code looks better now.

- Manual move of the comment in go/scanner/example_test.go
  before applying gofmt.

- gofmt -w $GOROOT/src $GOROOT/misc

Fixes #3062.

R=rsc
CC=golang-dev
https://golang.org/cl/5674093

13 years agogodoc: proper index range checking when extracting example code
Robert Griesemer [Wed, 22 Feb 2012 19:25:21 +0000 (11:25 -0800)]
godoc: proper index range checking when extracting example code

Fixes #3092.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5683075

13 years agocgo: fix definition of opaque types
Gustavo Niemeyer [Wed, 22 Feb 2012 19:10:25 +0000 (17:10 -0200)]
cgo: fix definition of opaque types

Fixes #3082.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5683074

13 years agogo/doc: move firstSentence into go/doc
Robert Griesemer [Wed, 22 Feb 2012 18:49:37 +0000 (10:49 -0800)]
go/doc: move firstSentence into go/doc

- renamed firstSentence -> Synopsis
- also deal with common abbreviations

R=rsc
CC=golang-dev
https://golang.org/cl/5676088

13 years agonet: replace error variable name oserr with err
Mikio Hara [Wed, 22 Feb 2012 10:08:19 +0000 (19:08 +0900)]
net: replace error variable name oserr with err

This CL replaces the last two in source tree.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5685080

13 years agogodoc: fix potential index out-of-bounds error
Robert Griesemer [Wed, 22 Feb 2012 06:50:00 +0000 (22:50 -0800)]
godoc: fix potential index out-of-bounds error

R=golang-dev, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/5683072

13 years agold: get symbol table letters right
Russ Cox [Wed, 22 Feb 2012 06:30:04 +0000 (01:30 -0500)]
ld: get symbol table letters right

Have to assign them before we create the symbol table.
ARM debugging.

TBR=r
CC=golang-dev
https://golang.org/cl/5689067

13 years agogc: new, less strict bool rules
Russ Cox [Wed, 22 Feb 2012 05:29:37 +0000 (00:29 -0500)]
gc: new, less strict bool rules

R=ken2
CC=golang-dev
https://golang.org/cl/5688064

13 years agogc: never crash during a debugging print
Russ Cox [Wed, 22 Feb 2012 05:29:23 +0000 (00:29 -0500)]
gc: never crash during a debugging print

TBR=lvd
CC=golang-dev
https://golang.org/cl/5686063

13 years agospec: refine the wording about variables in type switches
Rob Pike [Wed, 22 Feb 2012 05:25:55 +0000 (16:25 +1100)]
spec: refine the wording about variables in type switches

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5686064

13 years agocmd/go: add tool -n flag
Russ Cox [Wed, 22 Feb 2012 05:06:50 +0000 (00:06 -0500)]
cmd/go: add tool -n flag

As in gdb $(go tool -n 6g).

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5689066

13 years agocmd/fix: remove os.Wait gofix.
David Symonds [Wed, 22 Feb 2012 04:46:31 +0000 (15:46 +1100)]
cmd/fix: remove os.Wait gofix.

The os.Wait function has been removed entirely, so there's no point in fixing code that called it.

R=r
CC=golang-dev
https://golang.org/cl/5685078