]> Cypherpunks repositories - gostls13.git/log
gostls13.git
15 years agobig: add Div, Mod, Exp, GcdExt and several other fixes.
Adam Langley [Thu, 5 Nov 2009 23:55:41 +0000 (15:55 -0800)]
big: add Div, Mod, Exp, GcdExt and several other fixes.

R=gri, rsc
CC=go-dev
http://go/go-review/1017036

15 years agocrypto/tls (part 3)
Adam Langley [Thu, 5 Nov 2009 23:44:32 +0000 (15:44 -0800)]
crypto/tls (part 3)

(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)

R=rsc
CC=r
http://go/go-review/1018032

15 years agogofmt-ify io, json, runtime, encoding
Robert Griesemer [Thu, 5 Nov 2009 23:37:55 +0000 (15:37 -0800)]
gofmt-ify io, json, runtime, encoding

R=rsc
http://go/go-review/1017056

15 years agogofmt'ed godefs
Robert Griesemer [Thu, 5 Nov 2009 23:35:53 +0000 (15:35 -0800)]
gofmt'ed godefs

R=rsc
http://go/go-review/1020001

15 years agogofmt'ed debug
Robert Griesemer [Thu, 5 Nov 2009 23:35:02 +0000 (15:35 -0800)]
gofmt'ed debug
(excluding debug/gosym/symtab.go which has a small issue)

R=rsc
http://go/go-review/1019001

15 years agogofmt'ed 6l 8l cgo
Robert Griesemer [Thu, 5 Nov 2009 23:33:26 +0000 (15:33 -0800)]
gofmt'ed 6l 8l cgo

R=r
http://go/go-review/1020002

15 years agogofmt-ify strings, template
Robert Griesemer [Thu, 5 Nov 2009 23:12:37 +0000 (15:12 -0800)]
gofmt-ify strings, template

R=r
http://go/go-review/1018064

15 years agoadd information comparing the compiler implementations to the installation document
Rob Pike [Thu, 5 Nov 2009 23:07:42 +0000 (15:07 -0800)]
add information comparing the compiler implementations to the installation document

R=rsc
CC=go-dev
http://go/go-review/1018063

15 years agogofmt-ify gob
Robert Griesemer [Thu, 5 Nov 2009 22:53:42 +0000 (14:53 -0800)]
gofmt-ify gob
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)

R=r
http://go/go-review/1016056

15 years agocodereview: new commands
Russ Cox [Thu, 5 Nov 2009 22:44:57 +0000 (14:44 -0800)]
codereview: new commands
* clpatch
* download
* submit, on behalf of clpatch

stir hgpatch to fix a few bugs

R=r
CC=go-dev
http://go/go-review/1016051

15 years agogofmt-ify 4s, iterable
Robert Griesemer [Thu, 5 Nov 2009 22:43:03 +0000 (14:43 -0800)]
gofmt-ify 4s, iterable

R=rsc
http://go/go-review/1016055

15 years agogofmt-ify draw
Robert Griesemer [Thu, 5 Nov 2009 22:42:28 +0000 (14:42 -0800)]
gofmt-ify draw

R=rsc
http://go/go-review/1017055

15 years agogofmt-ify eval
Robert Griesemer [Thu, 5 Nov 2009 22:41:56 +0000 (14:41 -0800)]
gofmt-ify eval

R=rsc
http://go/go-review/1016054

15 years agogofmt-ify ogle
Robert Griesemer [Thu, 5 Nov 2009 22:30:18 +0000 (14:30 -0800)]
gofmt-ify ogle

R=rsc
http://go/go-review/1016053

15 years agogofmt-ify nacl
Robert Griesemer [Thu, 5 Nov 2009 22:29:38 +0000 (14:29 -0800)]
gofmt-ify nacl

R=rsc
http://go/go-review/1018062

15 years agogofmt-ify reflect
Robert Griesemer [Thu, 5 Nov 2009 22:23:20 +0000 (14:23 -0800)]
gofmt-ify reflect
- the single line structs can be fixed in another round

R=rsc
http://go/go-review/1016052

15 years ago2nd attempt: no noIndent for string lists
Robert Griesemer [Thu, 5 Nov 2009 22:03:56 +0000 (14:03 -0800)]
2nd attempt: no noIndent for string lists
- slightly better output in general
- extra indentation where we could do without
  (however that seems better for now that not having the indentation
  where it is needed)
- no information is lost, so a future better approach can fix these
  places up again

R=rsc
http://go/go-review/1017050

15 years agoadd a place-holder link for the hour-long video
Rob Pike [Thu, 5 Nov 2009 21:46:12 +0000 (13:46 -0800)]
add a place-holder link for the hour-long video

R=rsc
CC=go-dev
http://go/go-review/1017054

15 years agoupdate the text on the landing page.
Rob Pike [Thu, 5 Nov 2009 21:39:00 +0000 (13:39 -0800)]
update the text on the landing page.

R=agl, rsc
CC=go-dev
http://go/go-review/1017053

15 years agoforgot a piece of debugging
Ken Thompson [Thu, 5 Nov 2009 21:05:07 +0000 (13:05 -0800)]
forgot a piece of debugging
in previous change

R=rsc
http://go/go-review/1017052

15 years agosame speedup as 6l
Ken Thompson [Thu, 5 Nov 2009 20:47:22 +0000 (12:47 -0800)]
same speedup as 6l

R=rsc
http://go/go-review/1016050

15 years agogodoc: style update.
Adam Langley [Thu, 5 Nov 2009 20:18:54 +0000 (12:18 -0800)]
godoc: style update.

R=r, rsc
CC=go-dev
http://go/go-review/1017051

15 years agogofmt-ify syscall
Robert Griesemer [Thu, 5 Nov 2009 18:55:57 +0000 (10:55 -0800)]
gofmt-ify syscall
(replacement for CL 1018053)

R=r
http://go/go-review/1017047

15 years agogofmt-ify template, time, unsafe, flag, fmt
Robert Griesemer [Thu, 5 Nov 2009 17:40:28 +0000 (09:40 -0800)]
gofmt-ify template, time, unsafe, flag, fmt
(replacement for CLs 1017039101704110170401018054)

R=r
http://go/go-review/1018060

15 years agonew command hgpatch, for use by codereview extension
Russ Cox [Thu, 5 Nov 2009 17:27:19 +0000 (09:27 -0800)]
new command hgpatch, for use by codereview extension

R=r
http://go/go-review/1018059

15 years agogofmt-ify math, expvar, exp/spacewar
Robert Griesemer [Thu, 5 Nov 2009 17:08:08 +0000 (09:08 -0800)]
gofmt-ify math, expvar, exp/spacewar

R=rsc
http://go/go-review/1018061

15 years agogofmt-ify parts of xml
Robert Griesemer [Thu, 5 Nov 2009 16:59:03 +0000 (08:59 -0800)]
gofmt-ify parts of xml

R=rsc
http://go/go-review/1017049

15 years agogofmt-ify encoding
Robert Griesemer [Thu, 5 Nov 2009 16:55:18 +0000 (08:55 -0800)]
gofmt-ify encoding

R=rsc
http://go/go-review/1017048

15 years agoadd -l flag to hg gofmt.
Russ Cox [Thu, 5 Nov 2009 16:11:44 +0000 (08:11 -0800)]
add -l flag to hg gofmt.
don't apply gofmt to non-go files during upload check.

R=r
http://go/go-review/1016048

15 years agoadd "hg gofmt" to run all modified files through gofmt.
Russ Cox [Thu, 5 Nov 2009 07:43:55 +0000 (23:43 -0800)]
add "hg gofmt" to run all modified files through gofmt.

add check before Upload, for now disabled by default,
that files do not change when run through gofmt.
enable by adding

[codereview]
force_gofmt = True

to .hgrc or .hg/hgrc.

add doc strings for a few more commands.
rename codereview-login to code-login
to make module doc visible.

R=r
CC=gri
http://go/go-review/1018056

15 years agogofmt-ify sort, sync
Robert Griesemer [Thu, 5 Nov 2009 07:25:29 +0000 (23:25 -0800)]
gofmt-ify sort, sync

R=rsc
http://go/go-review/1018057

15 years agogofmt-ify strconv
Robert Griesemer [Thu, 5 Nov 2009 07:20:49 +0000 (23:20 -0800)]
gofmt-ify strconv
(and remove an empty line at the end of a file)

R=rsc
http://go/go-review/1017046

15 years agogofmt-ify net
Robert Griesemer [Thu, 5 Nov 2009 07:16:46 +0000 (23:16 -0800)]
gofmt-ify net

R=rsc
http://go/go-review/1017045

15 years agogofmt-ify image
Robert Griesemer [Thu, 5 Nov 2009 06:52:28 +0000 (22:52 -0800)]
gofmt-ify image

R=rsc
http://go/go-review/1017044

15 years agogofmt-ify hash, http
Robert Griesemer [Thu, 5 Nov 2009 06:45:59 +0000 (22:45 -0800)]
gofmt-ify hash, http
(gofmt will be able to re-align map entries as in http nicely,
eventually)

R=rsc
http://go/go-review/1018055

15 years agogofmt-ify tabwriter
Robert Griesemer [Thu, 5 Nov 2009 06:26:48 +0000 (22:26 -0800)]
gofmt-ify tabwriter

R=rsc
http://go/go-review/1017042

15 years agomore comment formatting:
Robert Griesemer [Thu, 5 Nov 2009 06:07:13 +0000 (22:07 -0800)]
more comment formatting:
- preserve (some) indentation of comment text for /*-style comments
  even if the first comment line does not contain any text that might
  suggest the "correct" indentation
- enabled because otherwise existing larger comments get re-formatted
  (this will not introduce a lot of changes since comments of this
  kind - until now - were not changed with respect to indentation)

R=rsc
http://go/go-review/1016047

15 years agobumper for video
Rob Pike [Thu, 5 Nov 2009 05:56:33 +0000 (21:56 -0800)]
bumper for video

R=rsc
http://go/go-review/1017038

15 years agogofmt-ify unicode
Robert Griesemer [Thu, 5 Nov 2009 05:39:55 +0000 (21:39 -0800)]
gofmt-ify unicode

R=r
http://go/go-review/1018051

15 years agofixing (badly) linux_arm syscall.
Kai Backman [Thu, 5 Nov 2009 05:34:54 +0000 (21:34 -0800)]
fixing (badly) linux_arm syscall.

R=rsc
http://go/go-review/1017037

15 years ago- add a blank before the opening { for multi-line composites
Robert Griesemer [Thu, 5 Nov 2009 05:15:47 +0000 (21:15 -0800)]
- add a blank before the opening { for multi-line composites
(request by r)
- feature temporarily disabled

R=rsc
CC=r
http://go/go-review/1018052

15 years agogofmt-ify os
Robert Griesemer [Thu, 5 Nov 2009 04:42:40 +0000 (20:42 -0800)]
gofmt-ify os

R=r
http://go/go-review/1017034

15 years agospeed up 6l
Ken Thompson [Thu, 5 Nov 2009 02:17:57 +0000 (18:17 -0800)]
speed up 6l
hopefully no change

R=rsc
http://go/go-review/1017035

15 years agopackage patch
Russ Cox [Thu, 5 Nov 2009 01:55:06 +0000 (17:55 -0800)]
package patch

R=r
http://go/go-review/1018043

15 years agoadd a final section with a complete example
Rob Pike [Thu, 5 Nov 2009 01:29:20 +0000 (17:29 -0800)]
add a final section with a complete example

R=rsc
CC=go-dev
http://go/go-review/1017033

15 years agogofmt-ify compress
Robert Griesemer [Thu, 5 Nov 2009 01:10:18 +0000 (17:10 -0800)]
gofmt-ify compress

R=rsc
http://go/go-review/1016045

15 years agogofmt-ify ebnf
Robert Griesemer [Thu, 5 Nov 2009 01:05:01 +0000 (17:05 -0800)]
gofmt-ify ebnf

R=r
http://go/go-review/1018050

15 years agogofmt-ify bufio
Robert Griesemer [Thu, 5 Nov 2009 01:04:21 +0000 (17:04 -0800)]
gofmt-ify bufio

R=rsc
http://go/go-review/1018049

15 years agogofmt-ify asn1
Robert Griesemer [Thu, 5 Nov 2009 01:03:08 +0000 (17:03 -0800)]
gofmt-ify asn1

R=rsc
http://go/go-review/1018047

15 years agogofmt-ify src/pkg/archive
Robert Griesemer [Thu, 5 Nov 2009 01:02:47 +0000 (17:02 -0800)]
gofmt-ify src/pkg/archive

R=rsc
http://go/go-review/1018046

15 years agogofmt-ify crypto
Robert Griesemer [Thu, 5 Nov 2009 01:02:30 +0000 (17:02 -0800)]
gofmt-ify crypto

R=agl
CC=rsc
http://go/go-review/1017032

15 years agogofmt-ify src/pkg/go (excluding printer directory due to pending CL,
Robert Griesemer [Thu, 5 Nov 2009 01:02:05 +0000 (17:02 -0800)]
gofmt-ify src/pkg/go (excluding printer directory due to pending CL,
and parser.go and scanner_test.go which have minor formatting issues)

R=rsc
http://go/go-review/1016042

15 years agorename testfiles from .go -> .orig so that they won't be
Robert Griesemer [Thu, 5 Nov 2009 00:50:13 +0000 (16:50 -0800)]
rename testfiles from .go -> .orig so that they won't be
picked up by gofmt (they should not be modified) or godoc
(testdata should not be considered a potential package
directory)

R=rsc
http://go/go-review/1018045

15 years agogofmt-ify bytes
Robert Griesemer [Thu, 5 Nov 2009 00:49:28 +0000 (16:49 -0800)]
gofmt-ify bytes

R=r
http://go/go-review/1016044

15 years agobetter placement of /*-style comments interspersed with code on one line
Robert Griesemer [Wed, 4 Nov 2009 23:33:28 +0000 (15:33 -0800)]
better placement of /*-style comments interspersed with code on one line

R=rsc
http://go/go-review/1017030

15 years agobytes.SplitAfter and strings.SplitAfter
Russ Cox [Wed, 4 Nov 2009 23:19:30 +0000 (15:19 -0800)]
bytes.SplitAfter and strings.SplitAfter
most common usage is:

lines := strings.SplitAfter(text, "\n", 0)

R=r
http://go/go-review/1018042

15 years agodoc doc doc
Russ Cox [Wed, 4 Nov 2009 23:17:36 +0000 (15:17 -0800)]
doc doc doc

R=r
http://go/go-review/1016039

15 years agoavoid infinite recursion in matcher.
Russ Cox [Wed, 4 Nov 2009 23:17:01 +0000 (15:17 -0800)]
avoid infinite recursion in matcher.

after sync (or sync --local), clean up repository:
* look for and close CLs submitted on our behalf
* remove unmodified files from CLs
* warn about empty CLs

R=r
http://go/go-review/1017029

15 years agopanic can't print interfaces well so use err.String()
Rob Pike [Wed, 4 Nov 2009 23:13:16 +0000 (15:13 -0800)]
panic can't print interfaces well so use  err.String()

R=rsc
http://go/go-review/1016041

15 years ago- always format blocks with closing } on a new line, even if empty
Robert Griesemer [Wed, 4 Nov 2009 21:31:20 +0000 (13:31 -0800)]
- always format blocks with closing } on a new line, even if empty
- at the moment this also affects single-line function declarations
  because we have disabled them at the moment (but not single-line
  function literals)

R=rsc
http://go/go-review/1016040

15 years agostylistic issues in a couple of cmd docs
Rob Pike [Wed, 4 Nov 2009 21:13:17 +0000 (13:13 -0800)]
stylistic issues in a couple of cmd docs

R=rsc
http://go/go-review/1017028

15 years agodocument godoc and gofmt
Rob Pike [Wed, 4 Nov 2009 19:33:43 +0000 (11:33 -0800)]
document godoc and gofmt

R=rsc
http://go/go-review/1018036

15 years agoremove reference to /home/r
Robert Griesemer [Wed, 4 Nov 2009 19:15:19 +0000 (11:15 -0800)]
remove reference to /home/r

R=rsc
http://go/go-review/1018039

15 years ago- complete html-escaping also in printer.go
Robert Griesemer [Wed, 4 Nov 2009 18:59:25 +0000 (10:59 -0800)]
- complete html-escaping also in printer.go

R=rsc
http://go/go-review/1017027

15 years ago- respect source line breaks in grouped declarations
Robert Griesemer [Wed, 4 Nov 2009 18:58:54 +0000 (10:58 -0800)]
- respect source line breaks in grouped declarations
- made ast.Spec nodes implement Node interface
- added extra test cases

R=rsc
http://go/go-review/1016038

15 years agofix bufio test case
Robert Griesemer [Wed, 4 Nov 2009 18:58:30 +0000 (10:58 -0800)]
fix bufio test case

R=rsc
http://go/go-review/1018038

15 years agoremove "em" unit from td width specification
Robert Griesemer [Wed, 4 Nov 2009 18:58:13 +0000 (10:58 -0800)]
remove "em" unit from td width specification

R=rsc
http://go/go-review/1018037

15 years agotwo more regexp tweaks
Russ Cox [Wed, 4 Nov 2009 16:34:31 +0000 (08:34 -0800)]
two more regexp tweaks

TBR=r
http://go/go-review/1016037

15 years agoallow "no such host" and also "no answer from server";
Russ Cox [Wed, 4 Nov 2009 16:30:53 +0000 (08:30 -0800)]
allow "no such host" and also "no answer from server";
seems to help on snow leopard.

TBR=r
http://go/go-review/1018035

15 years agovarious tweaks to code review.
Russ Cox [Wed, 4 Nov 2009 11:15:24 +0000 (03:15 -0800)]
various tweaks to code review.
main one is to check at submit time that
user name being used in checkin message
is listed in the CONTRIBUTORS file.
this should catch misconfigurations.

another is to cut the @domain part
from the R= and CC= lines on checkin
messages, so that cc'ing someone on
a change does not mean their email
address is recorded for all time.

R=r
CC=go-dev
http://go/go-review/1016036

15 years agodocument gotest
Rob Pike [Wed, 4 Nov 2009 07:06:16 +0000 (23:06 -0800)]
document gotest

R=rsc
CC=go-dev
http://go/go-review/1017026

15 years agoadd " and ' to list of html-escaped chars
Robert Griesemer [Wed, 4 Nov 2009 06:52:10 +0000 (22:52 -0800)]
add " and ' to list of html-escaped chars

R=rsc
http://go/go-review/1017025

15 years agoadd goyacc to the build
Rob Pike [Wed, 4 Nov 2009 06:48:48 +0000 (22:48 -0800)]
add goyacc to the build

R=rsc
CC=go-dev
http://go/go-review/1018034

15 years agomake goyacc and units.y work again (minor tweaks).
Rob Pike [Wed, 4 Nov 2009 06:38:43 +0000 (22:38 -0800)]
make goyacc and units.y work again (minor tweaks).
document goyacc a little.

R=rsc
CC=go-dev
http://go/go-review/1017024

15 years agodocument gopack.
Rob Pike [Wed, 4 Nov 2009 06:36:31 +0000 (22:36 -0800)]
document gopack.
change string in usage message.

R=rsc
http://go/go-review/1017023

15 years agodocument ebnflint
Rob Pike [Wed, 4 Nov 2009 06:19:56 +0000 (22:19 -0800)]
document ebnflint

R=gri
http://go/go-review/1016034

15 years agodocument the gc go compilers.
Rob Pike [Wed, 4 Nov 2009 06:00:36 +0000 (22:00 -0800)]
document the gc go compilers.
fix the usage message.

R=rsc
CC=go-dev
http://go/go-review/1016033

15 years agoUpdate the styling of the godoc pages.
Adam Langley [Wed, 4 Nov 2009 03:59:45 +0000 (19:59 -0800)]
Update the styling of the godoc pages.

(root.html is just temporary. It'll need some better content.)

R=r
CC=go-dev
http://go/go-review/1017019

15 years agosupport for command documentation:
Robert Griesemer [Wed, 4 Nov 2009 03:40:26 +0000 (19:40 -0800)]
support for command documentation:
- made package tree handler generic so it can work on any fs tree
- cleanups along the way

R=rsc
CC=r
http://go/go-review/1017020

15 years agomore command documentation, including nm and prof
Rob Pike [Wed, 4 Nov 2009 01:46:35 +0000 (17:46 -0800)]
more command documentation, including nm and prof

R=rsc
http://go/go-review/1017022

15 years agoencoding/*: reverse the order of src, dst so that dst is first.
Adam Langley [Wed, 4 Nov 2009 01:32:08 +0000 (17:32 -0800)]
encoding/*: reverse the order of src, dst so that dst is first.

R=rsc
CC=go-dev
http://go/go-review/1017021

15 years agocrypto/tls (part 2)
Adam Langley [Wed, 4 Nov 2009 01:25:13 +0000 (17:25 -0800)]
crypto/tls (part 2)

R=rsc
CC=go-dev
http://go/go-review/1018028

15 years agocrypto/rsa: fix blinding when using a null random source.
Adam Langley [Wed, 4 Nov 2009 01:23:50 +0000 (17:23 -0800)]
crypto/rsa: fix blinding when using a null random source.

For testing it can be useful to use a null random source (one which
always returns zero) to remove non-determinism from the tests.
However, when performing RSA blinding, the random blind ends up being
zero and it's hard to reverse a multiplication by zero.

R=rsc
CC=go-dev
http://go/go-review/1018033

15 years agodocument the assemblers.
Rob Pike [Wed, 4 Nov 2009 00:29:32 +0000 (16:29 -0800)]
document the assemblers.
add details about -d and -e flags in the loaders.

R=rsc
CC=go-dev
http://go/go-review/1018031

15 years agoFirst steps at command documentation: C compilers and linkers.
Rob Pike [Wed, 4 Nov 2009 00:05:47 +0000 (16:05 -0800)]
First steps at command documentation: C compilers and linkers.
Each command gets a doc.go file for godoc to analyze. Its main
element is a package comment.

R=rsc
CC=go-dev
http://go/go-review/1018029

15 years agoremove gccgo restriction with respect to blank identifiers
Robert Griesemer [Tue, 3 Nov 2009 23:10:52 +0000 (15:10 -0800)]
remove gccgo restriction with respect to blank identifiers

R=iant
CC=go-dev
http://go/go-review/1016032

15 years ago6l -e: emit external ELF symbol table.
Russ Cox [Tue, 3 Nov 2009 22:20:37 +0000 (14:20 -0800)]
6l -e: emit external ELF symbol table.
enough to make nm and oprofile work.

R=r
http://go/go-review/1017016

15 years agoNote: This is an exact replica and replacement of CL 1018027
Robert Griesemer [Tue, 3 Nov 2009 22:05:18 +0000 (14:05 -0800)]
Note: This is an exact replica and replacement of CL 1018027
(which I uploaded at home and thus can't upload from here).
CL 1018027 was reviewed.

- added comments to scope.go
- commented out some code that is not yet needed
  (and which showed up prominently in the documentation)

R=rsc
http://go/go-review/1017017

15 years ago- don't loose extra line breaks in struct/interface declarations
Robert Griesemer [Tue, 3 Nov 2009 21:40:11 +0000 (13:40 -0800)]
- don't loose extra line breaks in struct/interface declarations
- start new sections if a field/method declaration spans multiple lines;
  this avoids tabs from the previous line affecting the next field/method

R=rsc
http://go/go-review/1017015

15 years agoAdd testing/script.
Adam Langley [Tue, 3 Nov 2009 20:47:06 +0000 (12:47 -0800)]
Add testing/script.

R=rsc, r
CC=go-dev
http://go/go-review/1016001

15 years agouse default styler when there is no other given
Robert Griesemer [Tue, 3 Nov 2009 18:00:57 +0000 (10:00 -0800)]
use default styler when there is no other given

(No visual change yet since the comments for
exported code snippets - as shown on the pkg
page - are not yet formatted using the standard
comment intersperse mechanism in the printer.
This is a TODO in the printer.)

R=rsc
http://go/go-review/1016031

15 years agofix build
Rob Pike [Tue, 3 Nov 2009 07:06:48 +0000 (23:06 -0800)]
fix build

R=gri
http://go/go-review/1017014

15 years ago- show recursive package directory structure in package pages
Robert Griesemer [Tue, 3 Nov 2009 06:44:01 +0000 (22:44 -0800)]
- show recursive package directory structure in package pages
- removed some underbars in section headings for better looks
- various minor tweaks

R=rsc
http://go/go-review/1018026

15 years agosplit printer.go into two files; it has become too large:
Robert Griesemer [Tue, 3 Nov 2009 04:55:40 +0000 (20:55 -0800)]
split printer.go into two files; it has become too large:
- nodes.go implements ast node formatting
- printer.go implements the core printing functionality
  and public interface

No code changes except for updating the import clauses
and adding a top-level comment to nodes.go.

R=rsc
http://go/go-review/1016026

15 years agoforgot to count newlines when scanning white space.
Rob Pike [Tue, 3 Nov 2009 04:35:52 +0000 (20:35 -0800)]
forgot to count newlines when scanning white space.
also fix a error-printing bug in godoc.

R=gri
http://go/go-review/1016030

15 years agopackage net cleanup
Russ Cox [Tue, 3 Nov 2009 02:37:30 +0000 (18:37 -0800)]
package net cleanup

added ReadFrom/WriteTo for packet protocols like UDP.
simplified the net.Conn interface.
added new net.PacketConn interface for packet protocols.
implemented proper UDP listener.

cleaned up LocalAddr/RemoteAddr methods - cache in netFD.

threw away various unused methods.

an interface change:
introduced net.Addr as a network address interface,
to avoid conversion of UDP host:port to string and
back for every ReadFrom/WriteTo sequence.

another interface change:
since signature of Listener.Accept was changing anyway,
dropped the middle return value, because it is available
as c.RemoteAddr().  (the Accept signature predates the
existence of that method.)

Dial and Listen still accept strings, but the proto-specific
versions DialTCP, ListenUDP, etc. take net.Addr instead.

because the generic Dial didn't change and because
no one calls Accept directly (only indirectly via the http
server), very little code will be affected by these interface
changes.

design comments welcome.

R=p
CC=go-dev, r
http://go/go-review/1018017

15 years agocrypto/tls (part 1)
Adam Langley [Tue, 3 Nov 2009 02:25:20 +0000 (18:25 -0800)]
crypto/tls (part 1)

Rather than drop everything into a single, huge review, I've included
some simple bits of code here.

R=rsc
CC=go-dev
http://go/go-review/1016029

15 years agorecompress go_talk.pdf by running through ghostscript.
Russ Cox [Tue, 3 Nov 2009 02:21:16 +0000 (18:21 -0800)]
recompress go_talk.pdf by running through ghostscript.
was 1153 kB now 247 kB

R=r
http://go/go-review/1018025

15 years agopdf cleanup: fix links, remove internal references.
Rob Pike [Mon, 2 Nov 2009 23:28:41 +0000 (15:28 -0800)]
pdf cleanup: fix links, remove internal references.
fix link in spec.

R=rsc
CC=go-dev
http://go/go-review/1017013

15 years agofix divide by zero in old glibc dynamic loader
Russ Cox [Mon, 2 Nov 2009 22:00:32 +0000 (14:00 -0800)]
fix divide by zero in old glibc dynamic loader

R=r
CC=iant
http://go/go-review/1018024