]>
Cypherpunks repositories - gostls13.git/log
Adam Langley [Mon, 2 Nov 2009 20:02:16 +0000 (12:02 -0800)]
Fix cgo for GCC 4.4
Firstly, with -Werror, GCC switched to printing warnings starting
with "error:". Widening the string matches solves this as the messages
are otherwise unchanged.
Secondly, GCC 4.4 outputs DWARF sections with with NUL bytes in all
the offsets and requires the relocation section for .debug_info to be
processed in order to result in valid DWARF data. Thus we add minimal
handling for relocation sections, which is sufficient for our needs.
BUG=1
Fixes #1.
R=rsc, iant
CC=go-dev
http://go/go-review/
1017003
Ian Lance Taylor [Mon, 2 Nov 2009 19:58:47 +0000 (11:58 -0800)]
We should not silently permit a named type to match an unnamed
type. This is OK in a conversion but not in an assignment.
R=rsc
http://go/go-review/
1016024
Rob Pike [Mon, 2 Nov 2009 19:37:52 +0000 (11:37 -0800)]
use the new routine regexp.MustCompile to clean up some code that uses global regexps.
R=rsc, gri
CC=go-dev
http://go/go-review/
1016025
Russ Cox [Mon, 2 Nov 2009 19:37:21 +0000 (11:37 -0800)]
rietveld does not like code reviews with subjects longer than 100 characters, so trim the line pulled out of the description to avoid the limit.
R=r
http://go/go-review/
1016027
Rob Pike [Mon, 2 Nov 2009 19:24:47 +0000 (11:24 -0800)]
eliminate goroutine from testing/regexp too.
R=rsc
CC=go-dev
http://go/go-review/
1018021
Adam Langley [Mon, 2 Nov 2009 19:12:07 +0000 (11:12 -0800)]
Split constant time functions into crypto/subtle.
R=rsc
CC=go-dev
http://go/go-review/
1018020
Russ Cox [Mon, 2 Nov 2009 18:50:18 +0000 (10:50 -0800)]
do not emit USED for global x when compiling "_ = x;"
R=ken@golang.org
CC=r
http://go/go-review/
1018019
Ian Lance Taylor [Mon, 2 Nov 2009 18:12:40 +0000 (10:12 -0800)]
Recognize gccgo error message.
runtime.go:19:10: error: reference to undefined identifier ‘runtime.printbool’
R=rsc
http://go/go-review/
1018018
Rob Pike [Mon, 2 Nov 2009 18:08:22 +0000 (10:08 -0800)]
take goroutines out of regexp so they can be created
during initialization.
R=rsc
CC=go-dev
http://go/go-review/
1016023
Robert Griesemer [Mon, 2 Nov 2009 17:42:53 +0000 (09:42 -0800)]
cleaning up bug132
R=rsc
http://go/go-review/
1017012
Robert Griesemer [Mon, 2 Nov 2009 17:25:39 +0000 (09:25 -0800)]
- initial steps towards showing directory tree instead of
just a single directory
- all pieces present but not well integrated
- directory tree served at the moment under /tree
R=rsc
http://go/go-review/
1018016
Robert Griesemer [Mon, 2 Nov 2009 17:18:02 +0000 (09:18 -0800)]
- collect line comments for methods in interfaces
(previously not shown in godoc)
- simplify parsing of struct types (match code structure for parsing interface types)
R=rsc, r
http://go/go-review/
1016019
Russ Cox [Mon, 2 Nov 2009 05:04:16 +0000 (21:04 -0800)]
nil pointer checks in 8g.
fix nil pointer check in 6g.
was dereferencing after the ADD;
dereference before instead.
R=ken@golang.org
CC=iant
http://go/go-review/
1016022
Rob Pike [Mon, 2 Nov 2009 04:59:49 +0000 (20:59 -0800)]
reverse the arguments to io.Copy so the destination is on the
left, like an assignment, like strcpy, etc.
R=rsc
CC=go-dev
http://go/go-review/
1016011
Rob Pike [Mon, 2 Nov 2009 04:58:33 +0000 (20:58 -0800)]
fixups for memory model document
R=rsc
CC=go-dev
http://go/go-review/
1016018
Rob Pike [Mon, 2 Nov 2009 04:57:13 +0000 (20:57 -0800)]
correct a few things in Go for C++ Programmers
R=iant, rsc
CC=go-dev
http://go/go-review/
1016015
Rob Pike [Mon, 2 Nov 2009 04:54:11 +0000 (20:54 -0800)]
fixups to "effective go"
R=rsc
CC=go-dev
http://go/go-review/
1016020
Rob Pike [Mon, 2 Nov 2009 04:51:42 +0000 (20:51 -0800)]
a few tweaks to the language design faq
R=rsc
CC=go-dev
http://go/go-review/
1017007
Rob Pike [Mon, 2 Nov 2009 04:50:42 +0000 (20:50 -0800)]
significant cleanup of the main FAQ
R=rsc
CC=go-dev
http://go/go-review/
1017008
Rob Pike [Mon, 2 Nov 2009 04:48:21 +0000 (20:48 -0800)]
save some text from the old FAQ; will get reworked in time
R=rsc
http://go/go-review/
1018008
Rob Pike [Mon, 2 Nov 2009 04:47:03 +0000 (20:47 -0800)]
fixups in the tutorial
also add a section about compiling programs because some found it surprising not to have one
R=rsc
CC=go-dev
http://go/go-review/
1018011
Russ Cox [Mon, 2 Nov 2009 02:46:07 +0000 (18:46 -0800)]
code review: avoid subject changes, fix http_proxy submit bug
R=r
http://go/go-review/
1016021
Ian Lance Taylor [Mon, 2 Nov 2009 00:29:33 +0000 (16:29 -0800)]
Permit the CC environment variable to include arguments
(I should have tested the last change a bit more before
submitting).
R=rsc
http://go/go-review/
1017011
Ian Lance Taylor [Mon, 2 Nov 2009 00:13:37 +0000 (16:13 -0800)]
Use the environment variable CC as the bootstrap compiler used
to build 6g, 6l, etc.
R=rsc
CC=go-dev
http://go/go-review/
1018015
Robert Griesemer [Sun, 1 Nov 2009 23:27:10 +0000 (15:27 -0800)]
enable all (but one) test cases in test.sh that
were excluded before because of incorrect comment
formatting (comment formatting is mostly idempotent
at this point)
R=rsc
http://go/go-review/
1018014
Ian Lance Taylor [Sun, 1 Nov 2009 23:04:46 +0000 (15:04 -0800)]
These files were moved to encoding/base64. The directory was
already removed from the Makefile.
R=rsc
http://go/go-review/
1017006
Russ Cox [Sun, 1 Nov 2009 19:15:34 +0000 (11:15 -0800)]
split ipsock.go, sock.go, and unixsock.go out of net.go
prior to cleanup. no changes, only moving.
remove dependencies on strconv and strings
R=r
http://go/go-review/
1017010
Russ Cox [Sun, 1 Nov 2009 19:13:27 +0000 (11:13 -0800)]
syscall cleanup.
* rename PORT.sh -> mkall.sh (hopefully more obvious),
change behavior: run commands by default.
* pull more constants out of #defines automatically,
instead of editing large lists by hand.
* add Recvfrom, Sendto
add os.O_EXCL.
R=r
http://go/go-review/
1017009
Robert Griesemer [Sun, 1 Nov 2009 18:33:16 +0000 (10:33 -0800)]
don't update sync time if no files have changed
(and thus avoid re-indexing after every sync attempt)
R=rsc
http://go/go-review/
1016010
Russ Cox [Sun, 1 Nov 2009 17:37:13 +0000 (09:37 -0800)]
os cleanup.
dir_* and stat_* are just os specific,
not os+arch-specific.
R=r
http://go/go-review/
1018010
Russ Cox [Sun, 1 Nov 2009 17:25:55 +0000 (09:25 -0800)]
misc cleanup
R=r
http://go/go-review/
1016017
Russ Cox [Sun, 1 Nov 2009 13:49:35 +0000 (05:49 -0800)]
code review fixes
* clean up error handling: show Exception info
* white space fixes
* clean up output when creating CL
* simplify hg change command; add hg file
* fix stale cookie bug (thanks iant)
* in LoadAllCL, load each CL in a different thread,
to parallelize the slow web fetches
* throw away support for Mercurial before version 1.3
* add @CL-number file pattern for commands like diff
* make hg sync show files being sync'ed
R=r
http://go/go-review/
1016016
Russ Cox [Sun, 1 Nov 2009 13:49:07 +0000 (05:49 -0800)]
allow unpacking of json map into Go map,
now that reflection supports it.
R=r
http://go/go-review/
1015008
Russ Cox [Sun, 1 Nov 2009 13:43:26 +0000 (05:43 -0800)]
Make.pkg: add DEPS= support
allow Makefiles using Make.pkg to specify a
list of directories that should be installed
before trying to build the package.
this is a stopgap for small package trees
maintained outside the standard tree.
R=r
http://go/go-review/
1016012
Russ Cox [Sun, 1 Nov 2009 13:20:30 +0000 (05:20 -0800)]
more file patterns to ignore
R=r
http://go/go-review/
1016014
Rob Pike [Sun, 1 Nov 2009 01:29:06 +0000 (18:29 -0700)]
concurrency
R=go-dev, iant, rsc
http://go/go-review/
1018004
Rob Pike [Sat, 31 Oct 2009 20:28:22 +0000 (13:28 -0700)]
return "<nil>" when calling String() on a nil bytes.Buffer.
R=rsc
CC=go-dev
http://go/go-review/
1016005
Rob Pike [Sat, 31 Oct 2009 01:04:32 +0000 (18:04 -0700)]
add PDF for go talk on Oct 30 2009
R=rsc
CC=go-dev
http://go/go-review/
1018007
Ian Lance Taylor [Fri, 30 Oct 2009 23:10:42 +0000 (16:10 -0700)]
Don't use fallthrough in a type switch.
R=rsc
http://go/go-review/
1018005
Robert Griesemer [Fri, 30 Oct 2009 20:19:04 +0000 (13:19 -0700)]
fix build
R=agl
CC=rsc
http://go/go-review/
1016008
Robert Griesemer [Fri, 30 Oct 2009 20:17:14 +0000 (13:17 -0700)]
improved comment formatting:
- print comments line by line, strip common prefix but do not
modify comment contents otherwise
- align comments with subsequent keyword if indicated (e.g. case labels)
- terminate "column section" after multi-line expressions for better alignment
R=rsc
http://go/go-review/
1017002
Russ Cox [Fri, 30 Oct 2009 17:58:53 +0000 (10:58 -0700)]
split godoc/godoc.go into godoc/godoc.go
and godoc/main.go.
R=gri
CC=r
http://go/go-review/
1017005
Rob Pike [Fri, 30 Oct 2009 17:34:01 +0000 (10:34 -0700)]
repair corrupted sieve.gif
R=rsc
CC=go-dev
http://go/go-review/
1016007
Kai Backman [Fri, 30 Oct 2009 16:38:30 +0000 (09:38 -0700)]
added missing sgen reverse character copy code.
R=rsc
http://go/go-review/
1018006
Kai Backman [Fri, 30 Oct 2009 04:21:14 +0000 (21:21 -0700)]
clone and futex
go/test: passes 99% (343/347)
R=rsc
http://go/go-review/
1016004
Adam Langley [Fri, 30 Oct 2009 01:34:44 +0000 (18:34 -0700)]
Forgot to change quickcheck to quick in the Makefile.
TBR=rsc
R=rsc
http://go/go-review/
1017004
Adam Langley [Fri, 30 Oct 2009 00:38:25 +0000 (17:38 -0700)]
Add RSA PKCS#1 v1.5 support.
R=go-dev
APPROVED=rsc
DELTA=407 (400 added, 0 deleted, 7 changed)
OCL=36007
CL=36146
Adam Langley [Wed, 28 Oct 2009 22:16:20 +0000 (15:16 -0700)]
Add a quickcheck package which is a little like the Haskell one of the same
name.
R=rsc
APPROVED=rsc
DELTA=566 (566 added, 0 deleted, 0 changed)
OCL=35974
CL=36111
Stephen Ma [Tue, 27 Oct 2009 04:21:53 +0000 (21:21 -0700)]
Hack to make cgo's generated go code compile when there are no
unsafe.Pointer references inside the C declarations.
R=go-dev
APPROVED=rsc
DELTA=1 (1 added, 0 deleted, 0 changed)
OCL=36063
CL=36063
Ian Lance Taylor [Thu, 29 Oct 2009 22:41:02 +0000 (15:41 -0700)]
Bug: 6g accepts fallthrough in type switch.
R=r
CC=go-dev
http://go/go-review/
1016006
Rob Pike [Thu, 29 Oct 2009 17:53:37 +0000 (10:53 -0700)]
Change Stat to Lstat in Readdir so we don't recur when someone symlinks "."
R=rsc
CC=go-dev
http://go/go-review/
1018003
Adam Langley [Thu, 29 Oct 2009 01:23:53 +0000 (18:23 -0700)]
Fix bug when sending via select.
selfree maintains a cache of Select structures for several sizes. In
newselect, we'll use an entry from the cache if one is found. However,
the Scase structures corresponding to a send may have been allocated
for the wrong size. In this case we'll write off the end of the Scase
into random memory and, generally, read some amount of junk in the
receive.
This patch fixes the issue by removing the cache, on the advice of
rsc.
R=rsc
CC=go-dev
http://go/go-review/
1016002
Robert Griesemer [Thu, 29 Oct 2009 01:17:24 +0000 (18:17 -0700)]
clarify rule for channel send
R=rsc
CC=go-dev
http://go/go-review/
1018002
Ian Lance Taylor [Thu, 29 Oct 2009 00:09:24 +0000 (17:09 -0700)]
Test that the compiler rejects map types which should not be
compatible.
R=rsc
CC=go-dev
http://go/go-review/
1018001
Robert Griesemer [Wed, 28 Oct 2009 23:19:09 +0000 (16:19 -0700)]
- added missing formatters in templates
- replaced deprecated use of </font> with </span> tag
- added html escaping to godoc formatters where missing
- enabled text format for package documentation
R=rsc
http://go/go-review/
1017001
Russ Cox [Wed, 28 Oct 2009 21:03:16 +0000 (14:03 -0700)]
mysterious bug: runtime.acid wasn't getting rebuilt
when switching architectures.
fix bug twice: make sure clean removes the file,
and generate into architecture-specific file names.
R=r
http://go/go-review/
1013018
Robert Griesemer [Wed, 28 Oct 2009 19:52:52 +0000 (12:52 -0700)]
html-escaping of fields that may be user-generated
R=rsc
http://go/go-review/
1013019
Robert Griesemer [Wed, 28 Oct 2009 17:14:59 +0000 (10:14 -0700)]
fix for long label names impacting column width of previous lines
R=rsc
http://go/go-review/
1013017
Russ Cox [Wed, 28 Oct 2009 05:47:54 +0000 (22:47 -0700)]
files that are okay from the last gofmt round
R=gri
http://go/go-review/
1015011
Kai Backman [Wed, 28 Oct 2009 05:38:45 +0000 (22:38 -0700)]
shift for non-64 bit integers.
R=rsc
http://go/go-review/
1015017
Robert Griesemer [Tue, 27 Oct 2009 23:08:12 +0000 (16:08 -0700)]
godoc search bug fixes:
- sort by package name (instead of package path) for results with snippets
- sort line numbers in results without snippets
- properly characterize package clauses
- experiment with a leaner look: no underlines for top-level godoc links in the left side bar
Still using colors to distinguish results. Next step.
R=rsc
http://go/go-review/
1015016
Robert Griesemer [Tue, 27 Oct 2009 17:34:31 +0000 (10:34 -0700)]
code search for godoc:
- added goroutine to automatically index in the background
- added handler for search requests
- added search box to top-level godoc template
- added search.html template for the display of search results
- changes to spec.go because of name conflicts
- added extra styles to style.css (for shorter .html files)
R=rsc
http://go/go-review/
1014011
Ian Lance Taylor [Tue, 27 Oct 2009 05:49:08 +0000 (22:49 -0700)]
Get the right sigaction struct for the 386 rt_sigaction system
call. This uses the header files from a 32-bit Ubuntu Hardy
system.
The use of _LOOSE_KERNEL_NAMES seems right. The
-D__ARCH_SI_UID_T works around a bug which appears to be fixed
in later Linux versions.
R=rsc
http://go/go-review/
1013015
Kai Backman [Tue, 27 Oct 2009 04:49:32 +0000 (21:49 -0700)]
bug162, large indices on nil references
R=rsc
http://go/go-review/
1013016
Robert Griesemer [Tue, 27 Oct 2009 02:21:13 +0000 (19:21 -0700)]
- gofmt-ify walk.go
- fixed several bugs
R=rsc
http://go/go-review/
1015015
Robert Griesemer [Tue, 27 Oct 2009 01:32:51 +0000 (18:32 -0700)]
- indexing component for godoc
R=rsc
http://go/go-review/
1015014
Adam Langley [Mon, 26 Oct 2009 23:34:36 +0000 (16:34 -0700)]
Add encoding/hex
R=rsc
http://go/go-review/
1015012
Ian Lance Taylor [Mon, 26 Oct 2009 23:06:46 +0000 (16:06 -0700)]
Recognize gccgo error messages.
rename1.go:10:8: error: expected type
rename1.go:11:10: error: expected function
rename1.go:13:8: error: incompatible types in binary expression
R=rsc
http://go/go-review/
1015013
Robert Griesemer [Mon, 26 Oct 2009 22:47:56 +0000 (15:47 -0700)]
snippet generator for godoc search results
R=rsc
http://go/go-review/
1013014
Rob Pike [Mon, 26 Oct 2009 17:13:07 +0000 (10:13 -0700)]
add a favicon plus a couple of hi-res versions of gordon
R=rsc
CC=go-dev
http://go/go-review/
1013013
Kai Backman [Mon, 26 Oct 2009 15:02:19 +0000 (08:02 -0700)]
fix defer. gave up on unified code for defer and go for now.
R=rsc
http://go/go-review/
1014010
Kai Backman [Sun, 25 Oct 2009 18:59:58 +0000 (11:59 -0700)]
make 5l ignore multiple defs, remove use of multiple
defs from embed1 and gotest
R=rsc
http://go/go-review/
1014009
Kai Backman [Sun, 25 Oct 2009 18:51:48 +0000 (11:51 -0700)]
frame size > StackBig support
R=rsc
http://go/go-review/
1015010
Kai Backman [Sun, 25 Oct 2009 18:51:16 +0000 (11:51 -0700)]
proper syscall convention for arm
R=rsc
http://go/go-review/
1015009
Kai Backman [Sun, 25 Oct 2009 05:47:25 +0000 (22:47 -0700)]
fix conditional branch instructions for unsigned ints and
float. fix sgen endianess in sgen character copying.
go/test: passes 97% (336/345)
R=rsc
http://go/go-review/
1015007
Rob Pike [Sat, 24 Oct 2009 21:27:49 +0000 (14:27 -0700)]
remove reference to p4 in comment.
R=gri
CC=rsc
http://go/go-review/
1014008
Kai Backman [Sat, 24 Oct 2009 03:31:03 +0000 (20:31 -0700)]
fixed len/cap for chan. disable gc for now.
go/test: passes 93% (323/345)
R=rsc
http://go/go-review/
1015006
Russ Cox [Fri, 23 Oct 2009 22:24:08 +0000 (15:24 -0700)]
write install docs
R=r
CC=go-dev
http://go/go-review/
1015004
Rob Pike [Fri, 23 Oct 2009 21:19:47 +0000 (14:19 -0700)]
publish Request.Write (rename from Request.write)
R=rsc
CC=go-dev
http://go/go-review/
1015003
Kai Backman [Fri, 23 Oct 2009 19:43:01 +0000 (12:43 -0700)]
fix build issue cause by transition to hg
R=rsc
http://go/go-review/
1013012
Kai Backman [Fri, 23 Oct 2009 18:03:16 +0000 (11:03 -0700)]
one more argsize fix. we were copying with the correct
alignment but not enough (duh).
R=rsc
APPROVED=rsc
DELTA=16 (13 added, 0 deleted, 3 changed)
OCL=36020
CL=36024
Kai Backman [Fri, 23 Oct 2009 18:00:59 +0000 (11:00 -0700)]
all of pkg now compiles, fixes a few more tests
go/test: passes 90% (313/345)
R=rsc
APPROVED=rsc
DELTA=90 (83 added, 3 deleted, 4 changed)
OCL=36011
CL=36023
Kai Backman [Fri, 23 Oct 2009 17:59:31 +0000 (10:59 -0700)]
fix off by 4 bug in morestack (lr again). remove storing of r0
now that all arguments are passed on the stack.
go/test: passes 89% (310/345)
R=rsc
APPROVED=rsc
DELTA=33 (13 added, 14 deleted, 6 changed)
OCL=36009
CL=36022
Kai Backman [Fri, 23 Oct 2009 17:58:29 +0000 (10:58 -0700)]
fix broken code produced for ominus
go/test: passes 89% (308/345)
R=rsc
APPROVED=rsc
DELTA=10 (5 added, 0 deleted, 5 changed)
OCL=36005
CL=36021
Kai Backman [Thu, 22 Oct 2009 20:31:52 +0000 (13:31 -0700)]
fix off by 4 in newproc arg copying.
R=rsc
APPROVED=rsc
DELTA=4 (0 added, 0 deleted, 4 changed)
OCL=36001
CL=36004
Robert Griesemer [Fri, 23 Oct 2009 18:35:40 +0000 (11:35 -0700)]
fix computation of sync delay
R=rsc
http://go/go-review/
1013011
Ian Lance Taylor [Fri, 23 Oct 2009 06:51:54 +0000 (23:51 -0700)]
Fix the sigaction declaration to match the system for Linux.
I don't know whether Darwin needs a change here.
R=rsc
http://go/go-review/
1013010
Ian Lance Taylor [Fri, 23 Oct 2009 06:38:34 +0000 (23:38 -0700)]
s/pc/PC/ in traceback output to match amd64.
test/run expects to see "PC".
R=rsc
http://go/go-review/
1015002
Ian Lance Taylor [Fri, 23 Oct 2009 05:19:22 +0000 (22:19 -0700)]
Fix printer_test.go to invoke Fprint as a method of cfg.
This matches the change to printer.go in revision 3632.
R=gri
http://go/go-review/
1015001
Robert Griesemer [Fri, 23 Oct 2009 01:19:49 +0000 (18:19 -0700)]
- make printer interface easily extensible w/o breaking clients (in the future)
- replacement for p4 CL 35999 (abandoned)
R=rsc
http://go/go-review/
1012010
Robert Griesemer [Fri, 23 Oct 2009 01:04:21 +0000 (18:04 -0700)]
minor changes to walk
R=rsc
http://go/go-review/
1012008
Robert Griesemer [Thu, 22 Oct 2009 23:35:53 +0000 (16:35 -0700)]
simple AST walking support
R=rsc
http://go/go-review/
1014006
Rob Pike [Thu, 22 Oct 2009 21:30:56 +0000 (14:30 -0700)]
silly change to test the code review process
R=rsc
http://go/go-review/
1013009
Russ Cox [Thu, 22 Oct 2009 21:14:17 +0000 (14:14 -0700)]
add codereview-login command
R=r
CC=go-dev
http://go/go-review/
1012007
Rob Pike [Thu, 22 Oct 2009 18:52:35 +0000 (11:52 -0700)]
fix build: no acid
R=rsc
http://go/go-review/
1014005
Russ Cox [Thu, 22 Oct 2009 18:21:13 +0000 (11:21 -0700)]
fix handling of escaped characters like ' " & < >
R=r
http://go/go-review/
1013007
Russ Cox [Thu, 22 Oct 2009 18:12:39 +0000 (11:12 -0700)]
Initial checkin of codereview plugin.
The master copy is going to live elsewhere,
but weAPOSTROPHEll keep a copy in the Go tree so that
developers donAPOSTROPHEt have to check out two
different repositories.
R=r
CC=go-dev
http://go/go-review/
1012006
Russ Cox [Thu, 22 Oct 2009 18:07:39 +0000 (11:07 -0700)]
tell Mercurial which files to ignore
R=r
CC=go-dev
http://go/go-review/
1012005
Russ Cox [Thu, 22 Oct 2009 17:59:27 +0000 (10:59 -0700)]
fix build after Mercurial move.
various missing or incorrect files.
R=r
CC=go-dev
http://go/go-review/
1014004
Robert Griesemer [Thu, 22 Oct 2009 16:41:38 +0000 (09:41 -0700)]
go/printer:
- handle HTML tagging via (client-installable) Stylers
go/doc:
- basic styler support
- some factoring
- ready to contain the search code (but for now excluded)
doc/style.css:
- updated
doc/go_spec.css:
- cleanup: replace deprecated uses of <font> tag with <span> tag
R=rsc
DELTA=302 (160 added, 62 deleted, 80 changed)
OCL=35973
CL=35996