]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agoencoding/gob: fix panic when decoding []byte to incompatible slice types
Alexey Borzenkov [Mon, 9 Jan 2012 20:52:03 +0000 (12:52 -0800)]
encoding/gob: fix panic when decoding []byte to incompatible slice types

Fixes #2662.

R=golang-dev, rogpeppe, r, r
CC=golang-dev, r, rogpeppe
https://golang.org/cl/5515050

13 years agogc: remove now redundant typecheck of ->ninit on switches.
Luuk van Dijk [Mon, 9 Jan 2012 20:42:24 +0000 (21:42 +0100)]
gc: remove now redundant typecheck of ->ninit on switches.

Fixes #2576.

R=rsc
CC=golang-dev
https://golang.org/cl/5498105

13 years agocgo: if value for constant did not parse, get it from DWARF info
Ian Lance Taylor [Mon, 9 Jan 2012 19:22:26 +0000 (11:22 -0800)]
cgo: if value for constant did not parse, get it from DWARF info

R=rsc, borman
CC=golang-dev
https://golang.org/cl/5525043

13 years agomath/big: simplify fast string conversion
Robert Griesemer [Mon, 9 Jan 2012 19:20:09 +0000 (11:20 -0800)]
math/big: simplify fast string conversion

- use slice ops for convertWords instead of lo/hi boundaries
- always compute leading zeroes (simplifies logic significantly),
  but remove them once, at the end (since leafSize is small, the
  worst-case scenario is not adding significant overhead)
- various comment cleanups (specifically, replaced direct -> iterative,
  and indirect -> recursive)
- slightly faster overall for -bench=String

(This CL incorporates the changes re: my comments to CL 5418047
https://golang.org/cl/5418047/ )

benchmark                          old ns/op    new ns/op    delta
big.BenchmarkString10Base2               519          527   +1.54%
big.BenchmarkString100Base2             2279         2158   -5.31%
big.BenchmarkString1000Base2           18475        17323   -6.24%
big.BenchmarkString10000Base2         178248       166219   -6.75%
big.BenchmarkString100000Base2       1548494      1431587   -7.55%
big.BenchmarkString10Base8               415          422   +1.69%
big.BenchmarkString100Base8             1025          978   -4.59%
big.BenchmarkString1000Base8            6822         6428   -5.78%
big.BenchmarkString10000Base8          64598        61065   -5.47%
big.BenchmarkString100000Base8        593788       549150   -7.52%
big.BenchmarkString10Base10              654          645   -1.38%
big.BenchmarkString100Base10            1863         1835   -1.50%
big.BenchmarkString1000Base10          12099        11981   -0.98%
big.BenchmarkString10000Base10         57601        56888   -1.24%
big.BenchmarkString100000Base10     20123120     19827890   -1.47%
big.BenchmarkString10Base16              358          362   +1.12%
big.BenchmarkString100Base16             815          776   -4.79%
big.BenchmarkString1000Base16           4710         4421   -6.14%
big.BenchmarkString10000Base16         43938        40968   -6.76%
big.BenchmarkString100000Base16       406307       373930   -7.97%

R=michael.jones, mtj
CC=golang-dev
https://golang.org/cl/5432090

13 years agodoc: use 2012 for year in model standard copyright header
Peter Mundy [Mon, 9 Jan 2012 18:47:28 +0000 (10:47 -0800)]
doc: use 2012 for year in model standard copyright header

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5531048

13 years agogo-mode.el: fix syntax highlighting of backticks
Florian Weimer [Mon, 9 Jan 2012 17:58:29 +0000 (12:58 -0500)]
go-mode.el: fix syntax highlighting of backticks

Instead of syntax-tables, an extended go-mode-cs is used for
from a font-lock callback.

Cache invalidation must happen in a before-change-function
because font-lock runs in an after-change-function, potentially
before the cache invalidation takes place.

Performance is reasonable, even with src/pkg/html/entity.go
and test/fixedbugs/bug257.go.

Fixes #2330.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5529045

13 years agoundo CL 5504108 / 0edee03791f4
Russ Cox [Mon, 9 Jan 2012 17:45:08 +0000 (09:45 -0800)]
undo CL 5504108 / 0edee03791f4

breaks 386 build

««« original CL description
gc: put limit on size of exported recursive interface

Prevents edge-case recursive types from consuming excessive memory.

Fixes #1909.

R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108

»»»

R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5534049

13 years agogc: put limit on size of exported recursive interface
Lorenzo Stoakes [Mon, 9 Jan 2012 16:48:53 +0000 (11:48 -0500)]
gc: put limit on size of exported recursive interface

Prevents edge-case recursive types from consuming excessive memory.

Fixes #1909.

R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108

13 years agosyscall: Linux-only support for parent death signal
Albert Strasheim [Mon, 9 Jan 2012 12:37:46 +0000 (21:37 +0900)]
syscall: Linux-only support for parent death signal

As discussed in this thread:

https://groups.google.com/group/golang-dev/browse_thread/thread/5b76b7700265a787

I've tried to come up with a solution that is minimally invasive for the platforms that don't support "parent death signal", without splitting up exec_unix.go.

See also: http://www.win.tue.nl/~aeb/linux/lk/lk-5.html#ss5.8

R=rsc, dave, borman, iant, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5487061

13 years agodoc: only trim newlines in tmpltohtml, gofmt progs
Andrew Gerrand [Mon, 9 Jan 2012 09:05:34 +0000 (20:05 +1100)]
doc: only trim newlines in tmpltohtml, gofmt progs

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5530048

13 years agogo/build: handle and warn of duplicate GOPATH entries
Andrew Gerrand [Mon, 9 Jan 2012 03:24:05 +0000 (14:24 +1100)]
go/build: handle and warn of duplicate GOPATH entries

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5519050

13 years agodoc: float -> float64 in Effective Go template
Andrew Gerrand [Mon, 9 Jan 2012 01:48:42 +0000 (12:48 +1100)]
doc: float -> float64 in Effective Go template

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5530047

13 years agodoc: float -> float64 in Effective Go
Jeff R. Allen [Mon, 9 Jan 2012 00:53:20 +0000 (11:53 +1100)]
doc: float -> float64 in Effective Go

R=golang-dev
CC=golang-dev
https://golang.org/cl/5531046

13 years agowindows: use ArbitraryUserPointer as TLS slot
Wei Guangjing [Mon, 9 Jan 2012 00:23:07 +0000 (11:23 +1100)]
windows: use ArbitraryUserPointer as TLS slot

R=hectorchu, alex.brainman
CC=golang-dev
https://golang.org/cl/5519054

13 years agoencoding/asn1: document support for *big.Int
Florian Weimer [Sun, 8 Jan 2012 15:02:23 +0000 (10:02 -0500)]
encoding/asn1: document support for *big.Int
        Also add basic tests.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5533045

13 years agotime: fix godoc for After and NewTicker.
Sameer Ajmani [Sun, 8 Jan 2012 01:53:53 +0000 (20:53 -0500)]
time: fix godoc for After and NewTicker.

R=golang-dev, gri, bradfitz, iant
CC=golang-dev, rsc
https://golang.org/cl/5523049

13 years agogc: improve unsafe.Pointer type-check error messages
Ryan Hitchman [Fri, 6 Jan 2012 22:34:16 +0000 (14:34 -0800)]
gc: improve unsafe.Pointer type-check error messages

Fixes #2627.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5498088

13 years agoA+C: add sameer@golang.org to CONTRIBUTORS.
Sameer Ajmani [Fri, 6 Jan 2012 22:11:51 +0000 (14:11 -0800)]
A+C: add sameer@golang.org to CONTRIBUTORS.

R=gri
CC=golang-dev
https://golang.org/cl/5515052

13 years agoAdd Szabolcs Nagy as a contributor.
Adam Langley [Fri, 6 Jan 2012 17:38:01 +0000 (12:38 -0500)]
Add Szabolcs Nagy as a contributor.

R=iant, gri
CC=golang-dev
https://golang.org/cl/5517056

13 years agosort: eliminate extra Len() call
Robert Griesemer [Fri, 6 Jan 2012 02:40:17 +0000 (18:40 -0800)]
sort: eliminate extra Len() call

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5521052

13 years agovarious: fix prints
Robert Hencke [Fri, 6 Jan 2012 02:38:01 +0000 (18:38 -0800)]
various: fix prints

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516049

13 years agogoinstall: fix test data
Andrew Gerrand [Thu, 5 Jan 2012 22:48:03 +0000 (09:48 +1100)]
goinstall: fix test data

R=gri
CC=golang-dev
https://golang.org/cl/5519048

13 years agocmd/go: Pass arguments to command for run
Eric Eisner [Thu, 5 Jan 2012 22:23:00 +0000 (09:23 +1100)]
cmd/go: Pass arguments to command for run

Command arguments are separated from input .go file arguments
by a -- separator.

R=rsc, golang-dev, adg
CC=golang-dev
https://golang.org/cl/5514046

13 years agodoc: add Slices: usage and internals article
Andrew Gerrand [Thu, 5 Jan 2012 22:21:43 +0000 (09:21 +1100)]
doc: add Slices: usage and internals article

Originally published on the Go blog on 5 Jan 2011:
http://blog.golang.org/2011/01/go-slices-usage-and-internals.html

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516046

13 years agogoinstall: use correct checkout URL for Google Code svn repos
Andrew Gerrand [Thu, 5 Jan 2012 22:20:59 +0000 (09:20 +1100)]
goinstall: use correct checkout URL for Google Code svn repos

Fixes #2655.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5510045

13 years agodoc: trim spaces from code snippets
Andrew Gerrand [Thu, 5 Jan 2012 22:20:31 +0000 (09:20 +1100)]
doc: trim spaces from code snippets

gofmt likes to put lines like
  // STOP OMIT
two blank lines from a closing brace, creating an ugly space inside
<pre> blocks in some of these files. This change resolves this issue.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5520044

13 years agogo test: don't try to print package with error message.
Roger Peppe [Thu, 5 Jan 2012 21:19:25 +0000 (13:19 -0800)]
go test: don't try to print package with error message.
If there's a error compiling a _test.go file, the error
message tries to print a *Package with %s. There's no String
method on *Package, so the error message looks bad.
Since the error messages identify the file in question
anyway, this CL removes the package from the error message.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5520045

13 years agomath: fix typo in all_test.go
Charles L. Dorian [Thu, 5 Jan 2012 19:04:14 +0000 (11:04 -0800)]
math: fix typo in all_test.go

Logb errors were reported as Ilogb errors.

R=rsc, golang-dev, gri
CC=golang-dev
https://golang.org/cl/5517045

13 years agonet: fix incorrect mode on ListenIP, ListenUDP
Mikio Hara [Thu, 5 Jan 2012 17:44:25 +0000 (09:44 -0800)]
net: fix incorrect mode on ListenIP, ListenUDP

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5523044

13 years agocrypto/tls: Improve TLS Client Authentication
Jeff R. Allen [Thu, 5 Jan 2012 17:05:38 +0000 (12:05 -0500)]
crypto/tls: Improve TLS Client Authentication

Fix incorrect marshal/unmarshal of certificateRequest.
Add support for configuring client-auth on the server side.
Fix the certificate selection in the client side.
Update generate_cert.go to new time package

Fixes #2521.

R=krautz, agl, bradfitz
CC=golang-dev, mikkel
https://golang.org/cl/5448093

13 years agodoc/progs: test defer programs
Andrew Gerrand [Thu, 5 Jan 2012 05:43:02 +0000 (16:43 +1100)]
doc/progs: test defer programs

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5517044

13 years agonet: update DialIP comments to mention protocols
Andrew Gerrand [Thu, 5 Jan 2012 04:18:08 +0000 (15:18 +1100)]
net: update DialIP comments to mention protocols

Fixes #2637.

R=golang-dev, mikioh.mikioh, iant
CC=golang-dev
https://golang.org/cl/5508043

13 years agomake.bash: remove old dregs
Alex Brainman [Thu, 5 Jan 2012 03:17:32 +0000 (14:17 +1100)]
make.bash: remove old dregs

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5522043

13 years agocmd/go: include external test files in the files sent to gofmt, govet, and gofix
Sanjay Menakuru [Wed, 4 Jan 2012 23:37:15 +0000 (10:37 +1100)]
cmd/go: include external test files in the files sent to gofmt, govet, and gofix

Also, add XTestGoFiles to the go command's public api.

Fixes #2649.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502102

13 years agoruntime: fix typo in comment
Robert Griesemer [Wed, 4 Jan 2012 22:06:54 +0000 (14:06 -0800)]
runtime: fix typo in comment

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5511047

13 years agocrypto/tls: update generate_cert.go for new time package
Adam Langley [Wed, 4 Jan 2012 19:56:16 +0000 (14:56 -0500)]
crypto/tls: update generate_cert.go for new time package

Fixes #2635.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5512043

13 years agoexp/ssh: fix two flow control bugs in chanWriter
Dave Cheney [Wed, 4 Jan 2012 15:36:21 +0000 (10:36 -0500)]
exp/ssh: fix two flow control bugs in chanWriter

This CL fixes two issues sending data to the remote peer.
The first bug occurs when the size of the buffer passed to
Write is larger than the current window, in this case, w.rwin
can become negative.

The second issue is more problematic than the first as the
amount of data passed to writePacket was not limited to w.rwin.
In this case the remote peer could silently drop the additional
data, or drop the connection.

Credit to Jacek Masiulaniec for the bug report.

R=agl, jacek.masiulaniec
CC=golang-dev
https://golang.org/cl/5511043

13 years agounsafe: refer to correct reflect functions
Andrew Gerrand [Wed, 4 Jan 2012 06:14:56 +0000 (17:14 +1100)]
unsafe: refer to correct reflect functions

Fixes #2641.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5509043

13 years agodoc: Fix URL to the Xcode web page
Paul Borman [Wed, 4 Jan 2012 00:31:51 +0000 (11:31 +1100)]
doc: Fix URL to the Xcode web page

R=golang-dev, kevlar
CC=golang-dev
https://golang.org/cl/5504113

13 years agodashboard: increase notification log to 200 lines
Andrew Gerrand [Wed, 4 Jan 2012 00:22:58 +0000 (11:22 +1100)]
dashboard: increase notification log to 200 lines

The go command lists all packages that were built.
A recent breakage notification included this text:

$ tail -100 < log
ok      errors
ok      exp/ebnf
?       exp/ebnflint [no test files]
ok      exp/gotype
ok      exp/norm
ok      exp/spdy

If the breakage occurred before this point it would
not be visible in the output.

R=golang-dev, gri, kevlar
CC=golang-dev
https://golang.org/cl/5504109

13 years agohtml: parse <frameset> inside body
Andrew Balholm [Tue, 3 Jan 2012 22:51:15 +0000 (09:51 +1100)]
html: parse <frameset> inside body

Pass tests6.dat, test 47:
<param><frameset></frameset>

| <html>
|   <head>
|   <frameset>

Also pass remaining tests in tests6.dat.

R=nigeltao
CC=golang-dev
https://golang.org/cl/5489136

13 years agocmd/go: include test files in the files sent to gofmt, govet, and gofix
Sanjay Menakuru [Tue, 3 Jan 2012 03:12:54 +0000 (14:12 +1100)]
cmd/go: include test files in the files sent to gofmt, govet, and gofix

Also, add TestGoFiles to the go command's public api.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5505083

13 years agoA+C: add Sanjay Menakuru
Andrew Gerrand [Tue, 3 Jan 2012 03:10:12 +0000 (14:10 +1100)]
A+C: add Sanjay Menakuru

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5504110

13 years agoencoding/json: don't marshal special float values
Evan Shaw [Tue, 3 Jan 2012 01:30:18 +0000 (12:30 +1100)]
encoding/json: don't marshal special float values

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5500084

13 years agoencoding/xml: use strings.Reader in tests.
Michael Shields [Tue, 3 Jan 2012 01:22:02 +0000 (12:22 +1100)]
encoding/xml: use strings.Reader in tests.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502083

13 years agodoc/codewalk/functions.xml: Fix broken function examples
John DeNero [Tue, 3 Jan 2012 01:15:08 +0000 (12:15 +1100)]
doc/codewalk/functions.xml: Fix broken function examples

I removed the broken function comparison example and fixed a code highlighting regexp.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501078

13 years agocmd/go: refer to the right command in the doc description.
Christoph Hack [Tue, 3 Jan 2012 01:06:12 +0000 (12:06 +1100)]
cmd/go: refer to the right command in the doc description.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501072

13 years agogotest: make _testmain.go conform to gofmt rules
Benny Siegert [Tue, 3 Jan 2012 01:00:39 +0000 (12:00 +1100)]
gotest: make _testmain.go conform to gofmt rules

Otherwise, running "gofmt -d ." after "gotest" gives some
spurious changes.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504101

13 years agodoc/articles: add {{donotedit}} to templates
Olivier Duperray [Tue, 3 Jan 2012 00:40:58 +0000 (11:40 +1100)]
doc/articles: add {{donotedit}} to templates

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502088

13 years agoexp/ssh: various small fixes
Dave Cheney [Tue, 27 Dec 2011 14:49:19 +0000 (09:49 -0500)]
exp/ssh: various small fixes

transport.go:
* remove unused nil check.

doc.go:
* improve documentation about supported auth
methods and update Run example.

Thanks Jacek Masiulaniec for both reports.

R=jacek.masiulaniec, agl
CC=golang-dev
https://golang.org/cl/5501075

13 years agobytes.Buffer: read of 0 bytes at EOF shouldn't be an EOF
Rob Pike [Tue, 27 Dec 2011 07:49:24 +0000 (23:49 -0800)]
bytes.Buffer: read of 0 bytes at EOF shouldn't be an EOF
This corner case arose doing an RPC with a empty-slice payload. Ouch.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5505073

13 years agomisc/windows: add src/pkg/runtime/z* files to installation script
Alex Brainman [Mon, 26 Dec 2011 09:25:31 +0000 (20:25 +1100)]
misc/windows: add src/pkg/runtime/z* files to installation script

Fixes #2614.

R=golang-dev, jdpoirier
CC=golang-dev
https://golang.org/cl/5505070

13 years agolog/syslog: add Alert method
Vadim Vygonets [Mon, 26 Dec 2011 00:34:27 +0000 (09:34 +0900)]
log/syslog: add Alert method

Alert logs a message using the LOG_ALERT priority.

Fixes #2325.

R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/5504058

13 years agoflag: change Set method Value interface to return error instead of bool.
David Symonds [Sun, 25 Dec 2011 05:12:26 +0000 (16:12 +1100)]
flag: change Set method Value interface to return error instead of bool.

This yields much better error messages when a bad flag value is given.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5498078

13 years agotesting: use flag.Duration for -timeout flag.
David Symonds [Sun, 25 Dec 2011 05:07:05 +0000 (16:07 +1100)]
testing: use flag.Duration for -timeout flag.

R=golang-dev, gustavo, r
CC=golang-dev
https://golang.org/cl/5498077

13 years agohtml: adjust foreign attributes.
Nigel Tao [Sun, 25 Dec 2011 01:42:47 +0000 (12:42 +1100)]
html: adjust foreign attributes.

Pass tests10.dat, test 22:
<!DOCTYPE html><body xlink:href=foo><svg xlink:href=foo></svg>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     xlink:href="foo"
|     <svg svg>
|       xlink href="foo"

Also pass tests through test 29:
<div><svg><path></svg><path>

R=andybalholm
CC=golang-dev
https://golang.org/cl/5489117

13 years agohtml: "in select in table" insertion mode.
Andrew Balholm [Sat, 24 Dec 2011 00:07:14 +0000 (11:07 +1100)]
html: "in select in table" insertion mode.

Pass tests10.dat, test 16:
<!DOCTYPE
html><body><table><tr><td><select><svg><g>foo</g><g>bar</g><p>baz</table><p>quux

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <table>
|       <tbody>
|         <tr>
|           <td>
|             <select>
|               "foobarbaz"
|     <p>
|       "quux"

Also pass tests through test 21:
<!DOCTYPE html><frameset></frameset><svg><g></g><g></g><p><span>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5505069

13 years agoexp/norm: fixed two unrelated bugs in normalization library.
Marcel van Lohuizen [Fri, 23 Dec 2011 17:21:26 +0000 (18:21 +0100)]
exp/norm: fixed two unrelated bugs in normalization library.
1) incorrect length given for out buffer in String.
2) patchTail bug that could cause characters to be lost
   when crossing into the out-buffer boundary.

Added tests to expose these bugs.  Also slightly improved
performance of Bytes() and String() by sharing the reorderBuffer
across operations.

Fixes #2567.

R=r
CC=golang-dev
https://golang.org/cl/5502069

13 years agonet/rpc: trivial test cleanup
Robert Hencke [Fri, 23 Dec 2011 13:01:46 +0000 (22:01 +0900)]
net/rpc: trivial test cleanup

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498066

13 years agoflag: add Duration flag type.
David Symonds [Fri, 23 Dec 2011 05:29:38 +0000 (16:29 +1100)]
flag: add Duration flag type.

This works in the expected way: flag.Duration returns a *time.Duration,
and uses time.ParseDuration for parsing the input.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5489113

13 years agotime: add ParseDuration.
David Symonds [Fri, 23 Dec 2011 05:28:56 +0000 (16:28 +1100)]
time: add ParseDuration.

R=rsc, r, r
CC=golang-dev
https://golang.org/cl/5489111

13 years agodashboard: fix todo caching nil
Andrew Gerrand [Fri, 23 Dec 2011 05:04:01 +0000 (16:04 +1100)]
dashboard: fix todo caching nil

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504082

13 years agodashboard: cache packages, introduce caching helpers
Andrew Gerrand [Fri, 23 Dec 2011 03:44:56 +0000 (14:44 +1100)]
dashboard: cache packages, introduce caching helpers

R=rsc, gary.burd, adg
CC=golang-dev
https://golang.org/cl/5498067

13 years agotag weekly.2011-12-22
Andrew Gerrand [Fri, 23 Dec 2011 03:34:15 +0000 (14:34 +1100)]
tag weekly.2011-12-22

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504081

13 years agoweekly.2011-12-22 weekly.2011-12-22
Andrew Gerrand [Fri, 23 Dec 2011 03:28:01 +0000 (14:28 +1100)]
weekly.2011-12-22

R=dsymonds, r, r, rsc, adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5498074

13 years agocmd/go: two testing fixes
Russ Cox [Fri, 23 Dec 2011 03:24:43 +0000 (22:24 -0500)]
cmd/go: two testing fixes

1. Show passing output for "go test" (no args) and with -v flag.
2. Warn about out-of-date packages being rebuilt.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504080

13 years agoruntime: delete old asm_*.h if still around
Russ Cox [Fri, 23 Dec 2011 03:24:34 +0000 (22:24 -0500)]
runtime: delete old asm_*.h if still around

Fixes bug Robert ran into.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5501070

13 years agocmd/go: update "go help remote" to use correct Google Code urls
Andrew Gerrand [Fri, 23 Dec 2011 03:09:44 +0000 (14:09 +1100)]
cmd/go: update "go help remote" to use correct Google Code urls

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5489114

13 years agopath/filepath: implement Base and Dir for windows
Alex Brainman [Fri, 23 Dec 2011 02:23:07 +0000 (13:23 +1100)]
path/filepath: implement Base and Dir for windows

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5501069

13 years agodashboard: Don't highlight first heading row.
David Symonds [Fri, 23 Dec 2011 02:21:25 +0000 (13:21 +1100)]
dashboard: Don't highlight first heading row.

The two heading rows were previously a little hard to pick out,
because they were alternately shaded like the commit rows.

R=adg
CC=golang-dev
https://golang.org/cl/5500074

13 years agotesting: add wrapper methods so the godoc output lists all methods
Rob Pike [Fri, 23 Dec 2011 01:17:19 +0000 (17:17 -0800)]
testing: add wrapper methods so the godoc output lists all methods
To be deleted when godoc catches up.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504079

13 years agohtml: Don't ignore whitespace in "after after frameset" mode.
Andrew Balholm [Fri, 23 Dec 2011 00:07:11 +0000 (11:07 +1100)]
html: Don't ignore whitespace in "after after frameset" mode.

Pass tests6.dat, test 46:
<html><frameset></frameset></html>

| <html>
|   <head>
|   <frameset>
|   " "

R=nigeltao
CC=golang-dev
https://golang.org/cl/5505065

13 years agopartial build fix: add missing argument to NewPackageDoc
Robert Griesemer [Thu, 22 Dec 2011 23:52:56 +0000 (15:52 -0800)]
partial build fix: add missing argument to NewPackageDoc

R=r
CC=golang-dev
https://golang.org/cl/5489112

13 years agofix build: correct build scripts
Robert Griesemer [Thu, 22 Dec 2011 23:52:33 +0000 (15:52 -0800)]
fix build: correct build scripts

R=r
CC=golang-dev
https://golang.org/cl/5498075

13 years agofix build: updated build scripts
Robert Griesemer [Thu, 22 Dec 2011 23:37:09 +0000 (15:37 -0800)]
fix build: updated build scripts

R=golang-dev
CC=golang-dev
https://golang.org/cl/5504078

13 years agogo/doc, godoc: move export filtering into go/doc
Robert Griesemer [Thu, 22 Dec 2011 23:28:15 +0000 (15:28 -0800)]
go/doc, godoc: move export filtering into go/doc

- exports.go contains a stripped-down (but semantically unchanged)
  version of the code in go/ast/filter.go for export filtering
- filter.go contains the documentation filtering code found before
  at the end of doc.go; this is simply a code move w/o any semantic
  changes
- godoc now relies on go/doc for export filtering when creating
  documentation. It still has a separate form of export filtering
  for showing the source code version. This needs to be consolidated
  (perhaps the source form view should just be removed?).
- Stripping of function bodies (stripFunctionBodies function of
  godoc.go) is now happening in doc.go (line 176).
- doc.NewPackageDoc has an extra parameter "exportsOnly. If set
  to false, the behavior is as before. This function is only called
  once in our source code; a gofix module is probably not warranted.
- Deleted doc.NewFileDoc - was never called.

This change is mostly a code move w/ some minimal tweaks. It should
not cause any changes to the behavior of godoc. It's a prerequisite
for extracting anonymous embedded fields.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5502072

13 years agofmt: make the malloc test check its counts
Rob Pike [Thu, 22 Dec 2011 23:16:06 +0000 (15:16 -0800)]
fmt: make the malloc test check its counts
Discover than %g is now down to 1 malloc from 2 from 4.
Have fun with funcs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504077

13 years agogo/build: (*Tree).BinDir should not return path with / in it on windows
Alex Brainman [Thu, 22 Dec 2011 22:46:30 +0000 (09:46 +1100)]
go/build: (*Tree).BinDir should not return path with / in it on windows

R=rsc
CC=golang-dev
https://golang.org/cl/5502064

13 years agostrconv: fix bug in extended-float based conversion.
Rémy Oudompheng [Thu, 22 Dec 2011 22:28:35 +0000 (17:28 -0500)]
strconv: fix bug in extended-float based conversion.

A test intended for denormals erroneously returned true also for
infinities, leading to bad overflows and wrong error estimates.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/5489091

13 years agomath/big: Rand shouldn't hang if argument is also receiver.
Robert Griesemer [Thu, 22 Dec 2011 22:15:41 +0000 (14:15 -0800)]
math/big: Rand shouldn't hang if argument is also receiver.

Fixes #2607.

R=rsc
CC=golang-dev
https://golang.org/cl/5489109

13 years agopath: Dir
Rob Pike [Thu, 22 Dec 2011 22:08:34 +0000 (14:08 -0800)]
path: Dir

There was Base but not Dir, so fill in the gap.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504076

13 years agogo/doc: s/typeDoc/typeInfo/
Robert Griesemer [Thu, 22 Dec 2011 22:00:52 +0000 (14:00 -0800)]
go/doc: s/typeDoc/typeInfo/

To avoid confusion between typeDoc and TypeDoc.
No semantic change.

R=r
CC=golang-dev
https://golang.org/cl/5502071

13 years agopath/filepath: Dir
Rob Pike [Thu, 22 Dec 2011 21:58:58 +0000 (13:58 -0800)]
path/filepath: Dir

There was Base but not Dir, so fill in the gap.

R=n13m3y3r, r, rsc, gustavo
CC=golang-dev
https://golang.org/cl/5503067

13 years agodoc: fix misspelt CSS properties.
David Symonds [Thu, 22 Dec 2011 21:48:21 +0000 (08:48 +1100)]
doc: fix misspelt CSS properties.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5498071

13 years agogo/doc, godoc: show methods of anonymous fields
Robert Griesemer [Thu, 22 Dec 2011 21:11:40 +0000 (13:11 -0800)]
go/doc, godoc: show methods of anonymous fields

Missing: Handling of embedded interfaces.

Also, for reasons outlined in the previous CL (5500055), embedded
types have to be exported for its "inherited" methods to be visible.
This will be addressed w/ a subsequent CL.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5502059

13 years agotesting: fix the fix to the wording about the bug
Rob Pike [Thu, 22 Dec 2011 19:23:10 +0000 (11:23 -0800)]
testing: fix the fix to the wording about the bug
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/5498070

13 years agotesting: fix wording in explanation of potential bug
Rob Pike [Thu, 22 Dec 2011 19:08:51 +0000 (11:08 -0800)]
testing: fix wording in explanation of potential bug
TBR=rsc

R=rsc
CC=golang-dev
https://golang.org/cl/5504075

13 years agotesting: make signalling safer for parallel tests
Rob Pike [Thu, 22 Dec 2011 18:43:54 +0000 (10:43 -0800)]
testing: make signalling safer for parallel tests
Each test gets a private signal channel.
Also fix a bug that prevented parallel tests from running.

R=r, r
CC=golang-dev
https://golang.org/cl/5505061

13 years agotesting: compare Log to Println
Robert Hencke [Thu, 22 Dec 2011 18:05:51 +0000 (10:05 -0800)]
testing: compare Log to Println

Log always adds spaces between operands, like Println but unlike Print

R=golang-dev
CC=golang-dev
https://golang.org/cl/5504069

13 years agogc: better linenumbers for inlined functions
Luuk van Dijk [Thu, 22 Dec 2011 16:31:54 +0000 (17:31 +0100)]
gc: better linenumbers for inlined functions

Fixes #2580 up to a point.

R=rsc
CC=golang-dev
https://golang.org/cl/5498068

13 years agoexp/terminal: several cleanups
Adam Langley [Thu, 22 Dec 2011 16:23:57 +0000 (11:23 -0500)]
exp/terminal: several cleanups

1) Add EscapeCodes to the terminal so that applications don't wire
   them in.
2) Add a callback for auto-complete
3) Fix an issue with input lines longer than the width of the
   terminal.
4) Have Write() not stomp the current line. It now erases the current
   input, writes the output and reprints the prompt and partial input.
5) Support prompting without local echo in Terminal.
6) Add GetSize to report the size of terminal.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5479043

13 years agosyscall: make pipe work on netbsd
Joel Sing [Thu, 22 Dec 2011 15:47:48 +0000 (02:47 +1100)]
syscall: make pipe work on netbsd

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5504070

13 years agoos: update package location of exec to os/exec in comments
Brad Fitzpatrick [Thu, 22 Dec 2011 15:25:43 +0000 (07:25 -0800)]
os: update package location of exec to os/exec in comments

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5503065

13 years agodashboard: horizontal crunch
Russ Cox [Thu, 22 Dec 2011 15:22:38 +0000 (10:22 -0500)]
dashboard: horizontal crunch

* group builders in to columns by OS
* drop builder suffix (moved to hover title)
* cut all domain names from email (full name+email in hover title)
* make ok smaller

This should easily give us room for netbsd and plan9,
even on small laptop screens.

Running at http://build-rsc.golang.org/.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5501064

13 years agodashboard: do not require key in source code
Russ Cox [Thu, 22 Dec 2011 15:21:59 +0000 (10:21 -0500)]
dashboard: do not require key in source code

Or else eventually someone will check it in.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5504071

13 years agocmd/go: fix windows build
Mikio Hara [Thu, 22 Dec 2011 15:14:59 +0000 (00:14 +0900)]
cmd/go: fix windows build

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5502066

13 years agocmd/gc: make sure use of pthread for gcc-4.5 and beyond
Mikio Hara [Thu, 22 Dec 2011 14:18:34 +0000 (23:18 +0900)]
cmd/gc: make sure use of pthread for gcc-4.5 and beyond

R=golang-dev, rsc, n13m3y3r, rogpeppe
CC=golang-dev
https://golang.org/cl/5501060

13 years agosyscall: make getdirentries work on netbsd
Joel Sing [Thu, 22 Dec 2011 12:42:43 +0000 (23:42 +1100)]
syscall: make getdirentries work on netbsd

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5504068

13 years agodoc: refer to http://build.golang.org/ where applicable
Robert Hencke [Thu, 22 Dec 2011 03:21:25 +0000 (14:21 +1100)]
doc: refer to http://build.golang.org/ where applicable

R=golang-dev, bradfitz, adg
CC=golang-dev
https://golang.org/cl/5501062

13 years agoexec: disable the ExtraFiles test on darwin
Brad Fitzpatrick [Thu, 22 Dec 2011 01:08:16 +0000 (17:08 -0800)]
exec: disable the ExtraFiles test on darwin

Still a mystery. New issue 2603 filed.

R=golang-dev, dsymonds, iant
CC=golang-dev
https://golang.org/cl/5503063