]> Cypherpunks repositories - gostls13.git/log
gostls13.git
15 years agomath: atan2 special cases (negative zero)
Charles L. Dorian [Thu, 8 Apr 2010 20:24:04 +0000 (13:24 -0700)]
math: atan2 special cases (negative zero)

Added Signbit(), revised Copysign()

R=rsc
CC=golang-dev
https://golang.org/cl/822045

15 years agoruntime: use explicit flag when finalizer goroutine is waiting
Russ Cox [Thu, 8 Apr 2010 03:38:02 +0000 (20:38 -0700)]
runtime: use explicit flag when finalizer goroutine is waiting

Avoids spurious wakeups during other sleeping by that goroutine.
Fixes #711.

R=r
CC=golang-dev
https://golang.org/cl/902041

15 years agogotest: update URL printed by failure message.
Rob Pike [Thu, 8 Apr 2010 03:30:55 +0000 (20:30 -0700)]
gotest: update URL printed by failure message.
Fixes #677.

R=rsc
CC=golang-dev
https://golang.org/cl/834046

15 years agogp_spec typo fix: code example in the "Handling panics" section
Joe Poirier [Thu, 8 Apr 2010 00:25:57 +0000 (10:25 +1000)]
gp_spec typo fix: code example in the "Handling panics" section

R=rsc, adg
CC=golang-dev
https://golang.org/cl/881047

15 years agoLanguage FAQ: editing tweaks after iant.
Rob Pike [Wed, 7 Apr 2010 23:13:14 +0000 (16:13 -0700)]
Language FAQ: editing tweaks after iant.

R=iant
CC=golang-dev
https://golang.org/cl/874043

15 years agoLanguage FAQ: update the entry on exceptions.
Rob Pike [Wed, 7 Apr 2010 23:03:12 +0000 (16:03 -0700)]
Language FAQ: update the entry on exceptions.

R=rsc, iant
CC=golang-dev
https://golang.org/cl/824045

15 years agoarm: fix build, attempt #2
Russ Cox [Wed, 7 Apr 2010 01:30:36 +0000 (18:30 -0700)]
arm: fix build, attempt #2

TBR=kaib
CC=golang-dev
https://golang.org/cl/897041

15 years agoarm: fix build, attempt #1
Russ Cox [Wed, 7 Apr 2010 00:56:48 +0000 (17:56 -0700)]
arm: fix build, attempt #1

TBR=kaib
CC=golang-dev
https://golang.org/cl/883046

15 years agoanother try at clearing
Ken Thompson [Wed, 7 Apr 2010 00:33:43 +0000 (17:33 -0700)]
another try at clearing
channel recv data.

R=rsc
CC=golang-dev
https://golang.org/cl/896041

15 years agochange channel read to clear
Ken Thompson [Tue, 6 Apr 2010 23:58:52 +0000 (16:58 -0700)]
change channel read to clear
data just read from the channel.
this will make it easier to
recognize when to garbage
collect and finalize.

R=rsc
CC=golang-dev
https://golang.org/cl/882043

15 years agonet: use chan bool instead of chan *netFD to avoid cycle
Russ Cox [Tue, 6 Apr 2010 23:50:27 +0000 (16:50 -0700)]
net: use chan bool instead of chan *netFD to avoid cycle

The cycle is *netFD -> cw chanl *netFD in struct ->
same *netFD in channel read buffer.

Because channels are finalized, the cycle makes them
uncollectable.  A better fix is to make channels not
finalized anymore, and that will happen, but this is
an easy, reasonable workaround until then.

Another good fix would be to zero the channel receive
buffer entry after the receive.  That too will happen.

R=r
CC=golang-dev
https://golang.org/cl/875043

15 years agoflags: better tests.
Rob Pike [Tue, 6 Apr 2010 23:46:52 +0000 (16:46 -0700)]
flags: better tests.

R=rsc
CC=golang-dev
https://golang.org/cl/864044

15 years agoruntime: two proc bug fixes
Russ Cox [Tue, 6 Apr 2010 20:48:31 +0000 (13:48 -0700)]
runtime: two proc bug fixes

1. Fix bug in GOMAXPROCS when trying to cut number of procs
Race could happen on any system but was
manifesting only on Xen hosted Linux.

2. Fix recover on ARM, where FP != caller SP.

R=r
CC=golang-dev
https://golang.org/cl/880043

15 years agoChange goyacc to be reentrant.
Roger Peppe [Tue, 6 Apr 2010 20:29:27 +0000 (13:29 -0700)]
Change goyacc to be reentrant.
Instead of calling the package scope Lex function,
Parse now takes an argument which is used to
do the lexing.
I reverted to having the generated switch
code inside Parse rather than a separate function because
the function needs 7 arguments or a context structure,
which seems unnecessary.
I used yyrun(), not the original $A so that
it's possible to run the backquoted code through gofmt.

R=rsc, ken2, ken3
CC=golang-dev
https://golang.org/cl/879041

15 years agoreplace original float instruction with jump to make branches
Kai Backman [Tue, 6 Apr 2010 19:17:24 +0000 (22:17 +0300)]
replace original float instruction with jump to make branches
to float instructions work correctly.

R=rsc
CC=golang-dev
https://golang.org/cl/870044

15 years agofix deps.bash. \t does not mean tab in some seds.
Rob Pike [Tue, 6 Apr 2010 17:53:48 +0000 (10:53 -0700)]
fix deps.bash. \t does not mean tab in some seds.
also: add /dev/null to the ls args to repair handling of empty dependency lists.

R=rsc
CC=golang-dev
https://golang.org/cl/883045

15 years agosyscall package: document that errno is zeroed on success
Giles Lean [Tue, 6 Apr 2010 17:28:55 +0000 (10:28 -0700)]
syscall package: document that errno is zeroed on success

This is a documentation enhancement only, without any code
change.

The rationale for documenting this precisely is that Unix
programmers who "know" that errno's value is undefined after
a successful system call may be surprised otherwise and
search to be sure that a zero errno may be relied upon after
successful calls.

R=r, rsc1, rsc
CC=golang-dev
https://golang.org/cl/812044

15 years agoGNU/Linux sed requires \? rather than ?. Just use * instead.
Ian Lance Taylor [Tue, 6 Apr 2010 17:23:21 +0000 (10:23 -0700)]
GNU/Linux sed requires \? rather than ?.  Just use * instead.

R=rsc, r
CC=golang-dev
https://golang.org/cl/810043

15 years agolibcgo: initial mingw port work - builds but untested
Joe Poirier [Tue, 6 Apr 2010 06:44:05 +0000 (23:44 -0700)]
libcgo: initial mingw port work - builds but untested

R=rsc
CC=golang-dev
https://golang.org/cl/812041

15 years agoio/ioutil: fix bug in ReadFile when Open succeeds but Stat fails
Russ Cox [Tue, 6 Apr 2010 06:36:52 +0000 (23:36 -0700)]
io/ioutil: fix bug in ReadFile when Open succeeds but Stat fails

R=gri
CC=golang-dev
https://golang.org/cl/867044

15 years agoruntime: fix Caller
Russ Cox [Tue, 6 Apr 2010 06:36:37 +0000 (23:36 -0700)]
runtime: fix Caller
log: add test of Caller

New regexp in log test is picky and will require some
maintenance, but it catches off-by-one mistakes too.

Fixes #710.

R=gri
CC=esko.luontola, golang-dev
https://golang.org/cl/887043

15 years agohttp: fix documentation example
Russ Cox [Tue, 6 Apr 2010 05:55:05 +0000 (22:55 -0700)]
http: fix documentation example

R=adg
CC=golang-dev
https://golang.org/cl/813043

15 years agotest/bench: add k-nucleotide-parallel
Kyle Consalus [Tue, 6 Apr 2010 05:32:36 +0000 (22:32 -0700)]
test/bench: add k-nucleotide-parallel

R=rsc
CC=golang-dev
https://golang.org/cl/881042

15 years agocmath: new package
Charles L. Dorian [Tue, 6 Apr 2010 05:10:27 +0000 (22:10 -0700)]
cmath: new package

Complex math function package. Still needs more special case checking.

R=rsc
CC=golang-dev
https://golang.org/cl/874041

15 years agodeps.bash: be less strict about format of x.go lines
Russ Cox [Tue, 6 Apr 2010 05:08:07 +0000 (22:08 -0700)]
deps.bash: be less strict about format of x.go lines

R=iant
CC=golang-dev
https://golang.org/cl/862042

15 years agodoc/go_mem: remove semicolons
David Symonds [Tue, 6 Apr 2010 01:14:44 +0000 (11:14 +1000)]
doc/go_mem: remove semicolons

R=adg
CC=golang-dev
https://golang.org/cl/893041

15 years agoruntime: handle malloc > 2GB correctly
Russ Cox [Tue, 6 Apr 2010 00:26:59 +0000 (17:26 -0700)]
runtime: handle malloc > 2GB correctly

R=ken2
CC=golang-dev
https://golang.org/cl/821048

15 years agocrypto/tls: good defaults
Russ Cox [Mon, 5 Apr 2010 21:38:02 +0000 (14:38 -0700)]
crypto/tls: good defaults

R=agl1
CC=golang-dev
https://golang.org/cl/851041

15 years agoruntime: various arm fixes
Russ Cox [Mon, 5 Apr 2010 19:51:09 +0000 (12:51 -0700)]
runtime: various arm fixes
  * correct symbol table size
  * do not reorder functions in output
  * traceback
  * signal handling
  * use same code for go + defer
  * handle leaf functions in symbol table

R=kaib, dpx
CC=golang-dev
https://golang.org/cl/884041

15 years agoprogramming_faq: added question on T vs *T method sets
Andrew Gerrand [Mon, 5 Apr 2010 08:17:08 +0000 (18:17 +1000)]
programming_faq: added question on T vs *T method sets

Adding this question on Russ' recommendation - not sure if
there is some detail here I'm missing.

The associated discussion was:
http://groups.google.com/group/golang-nuts/t/ec6b27e332ed7f77

R=rsc, r
CC=golang-dev
https://golang.org/cl/887042

15 years agogc: good syntax error for defer func() {} - missing final ()
Russ Cox [Mon, 5 Apr 2010 06:27:26 +0000 (23:27 -0700)]
gc: good syntax error for defer func() {} - missing final ()

R=ken2
CC=golang-dev
https://golang.org/cl/855044

15 years agonntp: new package, NNTP client
Conrad Meyer [Mon, 5 Apr 2010 06:23:48 +0000 (23:23 -0700)]
nntp: new package, NNTP client

R=rsc, rsc1
CC=golang-dev
https://golang.org/cl/808041

15 years agorun.bash: remove MAKEFLAGS=-j4 to prevent crashing on freebsd
Andrew Gerrand [Mon, 5 Apr 2010 00:53:38 +0000 (10:53 +1000)]
run.bash: remove MAKEFLAGS=-j4 to prevent crashing on freebsd

R=rsc
CC=golang-dev
https://golang.org/cl/881044

15 years agogodashboard: fix benchmarks page (first pass)
Andrew Gerrand [Sun, 4 Apr 2010 21:34:27 +0000 (07:34 +1000)]
godashboard: fix benchmarks page (first pass)

R=rsc
CC=golang-dev
https://golang.org/cl/844044

15 years agodebug/proc: fix typo in package documentation
Robert Griesemer [Fri, 2 Apr 2010 23:20:47 +0000 (16:20 -0700)]
debug/proc: fix typo in package documentation

R=rsc
CC=golang-dev
https://golang.org/cl/829044

15 years agosyscall: implementing some mingw syscalls required by os package
Alex Brainman [Fri, 2 Apr 2010 08:11:17 +0000 (01:11 -0700)]
syscall: implementing some mingw syscalls required by os package

R=rsc
CC=golang-dev
https://golang.org/cl/770041

15 years agoruntime: turn run time errors checks into panics
Russ Cox [Fri, 2 Apr 2010 05:31:27 +0000 (22:31 -0700)]
runtime: turn run time errors checks into panics

R=ken2, r
CC=golang-dev
https://golang.org/cl/871042

15 years agodebug/macho: fix error message format
Robert Griesemer [Thu, 1 Apr 2010 22:58:10 +0000 (15:58 -0700)]
debug/macho: fix error message format

R=rsc
CC=golang-dev
https://golang.org/cl/836046

15 years agodebug/macho: don't crash when reading non-Mach-O files
Robert Griesemer [Thu, 1 Apr 2010 22:36:44 +0000 (15:36 -0700)]
debug/macho: don't crash when reading non-Mach-O files

R=rsc
CC=golang-dev
https://golang.org/cl/838046

15 years agogo spec: correct clarification of type declaration
Robert Griesemer [Thu, 1 Apr 2010 19:48:34 +0000 (12:48 -0700)]
go spec: correct clarification of type declaration

R=rsc, r
CC=golang-dev
https://golang.org/cl/855043

15 years agoruntime: correct memory leak in select
Russ Cox [Thu, 1 Apr 2010 18:56:18 +0000 (11:56 -0700)]
runtime: correct memory leak in select
  * adds pass 3 to dequeue from channels eagerly

various other cleanup/churn:
  * use switch on cas->send in each pass to
    factor out common code.
  * longer goto labels, commented at target
  * be more agressive about can't happen:
    throw instead of print + cope.
  * use "select" instead of "selectgo" in errors
  * use printf for debug prints when possible

R=ken2, ken3
CC=golang-dev, r
https://golang.org/cl/875041

15 years agokate: Update for recent language changes
Evan Shaw [Thu, 1 Apr 2010 02:50:27 +0000 (19:50 -0700)]
kate: Update for recent language changes

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/849045

15 years agobuild script tweaks
Russ Cox [Thu, 1 Apr 2010 02:48:33 +0000 (19:48 -0700)]
build script tweaks

factor out environment variable checks.
infer $GOROOT etc during build if not set.
it's still necessary to set them for yourself
to use the standard Makefiles.

when running all.bash, don't recompile all the
go packages in run.bash, since make.bash already did.

R=r
CC=golang-dev
https://golang.org/cl/609042

15 years agotesting/regexp: use recover.
Rob Pike [Thu, 1 Apr 2010 00:57:50 +0000 (17:57 -0700)]
testing/regexp: use recover.

R=rsc
CC=golang-dev
https://golang.org/cl/816042

15 years agojson: use panic/recover to handle errors in Marshal
Andrew Gerrand [Thu, 1 Apr 2010 00:19:37 +0000 (11:19 +1100)]
json: use panic/recover to handle errors in Marshal

R=r, gri
CC=golang-dev
https://golang.org/cl/872041

15 years agogo spec: clarification of type declarations
Robert Griesemer [Wed, 31 Mar 2010 23:37:22 +0000 (16:37 -0700)]
go spec: clarification of type declarations

R=r, rsc
CC=golang-dev
https://golang.org/cl/849044

15 years agoDelete xgb from the main repository. It has moved to
Nigel Tao [Wed, 31 Mar 2010 23:14:42 +0000 (10:14 +1100)]
Delete xgb from the main repository. It has moved to
http://code.google.com/p/x-go-binding/

R=rsc
CC=golang-dev
https://golang.org/cl/846043

15 years agogc: fix alignment on non-amd64
Russ Cox [Wed, 31 Mar 2010 23:04:03 +0000 (16:04 -0700)]
gc: fix alignment on non-amd64

R=ken2
CC=golang-dev
https://golang.org/cl/870041

15 years agotabwriter: use panic/recover to handle errors
Robert Griesemer [Wed, 31 Mar 2010 23:01:22 +0000 (16:01 -0700)]
tabwriter: use panic/recover to handle errors

R=rsc, r
CC=golang-dev
https://golang.org/cl/864042

15 years agoregexp: use panic/recover to handle errors
Rob Pike [Wed, 31 Mar 2010 22:58:21 +0000 (15:58 -0700)]
regexp: use panic/recover to handle errors

R=rsc, gri
CC=golang-dev
https://golang.org/cl/821046

15 years agoruntime: make type assertion a runtime.Error, the first of many
Russ Cox [Wed, 31 Mar 2010 22:55:10 +0000 (15:55 -0700)]
runtime: make type assertion a runtime.Error, the first of many

R=r
CC=golang-dev
https://golang.org/cl/805043

15 years agotest for panic and recover
Russ Cox [Wed, 31 Mar 2010 18:47:09 +0000 (11:47 -0700)]
test for panic and recover

R=r, adg
CC=golang-dev
https://golang.org/cl/869041

15 years agogc: implement panic and recover
Russ Cox [Wed, 31 Mar 2010 18:46:01 +0000 (11:46 -0700)]
gc: implement panic and recover

R=ken2, r, ken3
CC=golang-dev
https://golang.org/cl/831042

15 years agogodashboard: new stylesheet, build status pagination
Andrew Gerrand [Wed, 31 Mar 2010 06:01:16 +0000 (17:01 +1100)]
godashboard: new stylesheet, build status pagination

R=rsc, gri, r
CC=golang-dev
https://golang.org/cl/822044

15 years agorelease.2010-03-30 part two
Andrew Gerrand [Wed, 31 Mar 2010 01:38:54 +0000 (12:38 +1100)]
release.2010-03-30 part two

R=rsc
CC=golang-dev
https://golang.org/cl/859042

15 years agoUnicode: fix stupid typo in comment.
Rob Pike [Wed, 31 Mar 2010 01:33:06 +0000 (18:33 -0700)]
Unicode: fix stupid typo in comment.

R=rsc
CC=golang-dev
https://golang.org/cl/864041

15 years agoUnicode: provide an ability to supplement the case-mapping tables
Rob Pike [Wed, 31 Mar 2010 00:51:03 +0000 (17:51 -0700)]
Unicode: provide an ability to supplement the case-mapping tables
in character and string case mapping routines.

Add a custom mapper for Turkish and Azeri.

A more general solution for deriving the case information from Unicode's
SpecialCasing.txt will require more work.

Fixes #703.

R=rsc, rsc1
CC=golang-dev, mdakin
https://golang.org/cl/824043

15 years agorelease 2010-03-30 weekly.2010-03-30
Andrew Gerrand [Wed, 31 Mar 2010 00:40:57 +0000 (11:40 +1100)]
release 2010-03-30

R=rsc, gri
CC=golang-dev
https://golang.org/cl/821045

15 years agogodoc: support for title and subtitle headers when serving .html docs
Robert Griesemer [Wed, 31 Mar 2010 00:37:42 +0000 (17:37 -0700)]
godoc: support for title and subtitle headers when serving .html docs
and use it to show version (date) of go spec

Fixes #68.

R=rsc
CC=golang-dev, r
https://golang.org/cl/848042

15 years agoruntime: fix arm build, slightly.
Russ Cox [Wed, 31 Mar 2010 00:00:27 +0000 (17:00 -0700)]
runtime: fix arm build, slightly.

R=r
CC=golang-dev
https://golang.org/cl/842042

15 years agogo/printer: follow-up on CL 802043
Robert Griesemer [Tue, 30 Mar 2010 23:49:51 +0000 (16:49 -0700)]
go/printer: follow-up on CL 802043
- more test cases
- comment fixes
- minor unrelated changes as part of investigation of issue 702

R=rsc
CC=golang-dev
https://golang.org/cl/860041

15 years agotime: do not segment time strings by character class.
Russ Cox [Tue, 30 Mar 2010 21:54:32 +0000 (14:54 -0700)]
time: do not segment time strings by character class.
instead use pure substring matching to find template values.

this makes stdZulu unnecessary and allows formats
like "20060102 030405" (used in some internet protocols).

this makes Parse not handle years < 0000 or > 9999 anymore.
that seems like an okay price to pay, trading hypothetical
functionality for real functionality.

also changed the comments on the Time struct to use the
same reference date as the format and parse routines.

R=r
CC=golang-dev
https://golang.org/cl/833045

15 years agosyscall: add IPV6 constants
Russ Cox [Tue, 30 Mar 2010 21:32:59 +0000 (14:32 -0700)]
syscall: add IPV6 constants

R=r
CC=golang-dev
https://golang.org/cl/848041

15 years agosingle argument panic on non-darwin and in comments
Russ Cox [Tue, 30 Mar 2010 20:15:16 +0000 (13:15 -0700)]
single argument panic on non-darwin and in comments

R=r
CC=golang-dev
https://golang.org/cl/800042

15 years agoGofmt preserves newlines in multiline selector expressions.
Risto Jaakko Saarelma [Tue, 30 Mar 2010 18:46:21 +0000 (11:46 -0700)]
Gofmt preserves newlines in multiline selector expressions.

This is for making the fluent interface idiom usable with gofmt.

R=gri
CC=golang-dev
https://golang.org/cl/802043

15 years agocontributors, authors: add Risto Saarelma
Robert Griesemer [Tue, 30 Mar 2010 18:46:06 +0000 (11:46 -0700)]
contributors, authors: add Risto Saarelma

R=rsc
CC=golang-dev
https://golang.org/cl/836043

15 years agoEffective Go: update maps description regarding lookup of nonexistent entry.
Rob Pike [Tue, 30 Mar 2010 18:21:50 +0000 (11:21 -0700)]
Effective Go: update maps description regarding lookup of nonexistent entry.

R=rsc, gri, iant
CC=golang-dev
https://golang.org/cl/821044

15 years agogodoc: don't print package clause in -src command-line mode with filtering
Robert Griesemer [Tue, 30 Mar 2010 18:19:58 +0000 (11:19 -0700)]
godoc: don't print package clause in -src command-line mode with filtering

R=rsc
CC=golang-dev
https://golang.org/cl/844041

15 years agogc: add panic and recover (still unimplemented in runtime)
Russ Cox [Tue, 30 Mar 2010 17:53:16 +0000 (10:53 -0700)]
gc: add panic and recover (still unimplemented in runtime)
main semantic change is to enforce single argument to panic.

runtime: change to 1-argument panic.
use String method on argument if it has one.

R=ken2, r
CC=golang-dev
https://golang.org/cl/812043

15 years agosimplify various code using new map index rule
Russ Cox [Tue, 30 Mar 2010 17:51:11 +0000 (10:51 -0700)]
simplify various code using new map index rule

R=r
CC=golang-dev
https://golang.org/cl/833044

15 years agomake: use actual dependency for install
Russ Cox [Tue, 30 Mar 2010 17:44:51 +0000 (10:44 -0700)]
make: use actual dependency for install

otherwise "make install" runs cp unconditionally

R=r
CC=golang-dev
https://golang.org/cl/802044

15 years agogodefs: fix handling of negative constants
Russ Cox [Tue, 30 Mar 2010 17:42:13 +0000 (10:42 -0700)]
godefs: fix handling of negative constants

R=r
CC=golang-dev
https://golang.org/cl/849041

15 years agosingle argument panic
Russ Cox [Tue, 30 Mar 2010 17:34:57 +0000 (10:34 -0700)]
single argument panic

note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.

stop on error in doc/progs/run

R=r
CC=golang-dev
https://golang.org/cl/850041

15 years agogc: flush warnings, if any
Russ Cox [Tue, 30 Mar 2010 06:34:59 +0000 (23:34 -0700)]
gc: flush warnings, if any

R=ken2
CC=golang-dev
https://golang.org/cl/811042

15 years agoruntime: Remove unused runtime.write from linux/amd64
Christopher Wedgwood [Tue, 30 Mar 2010 05:51:39 +0000 (22:51 -0700)]
runtime: Remove unused runtime.write from linux/amd64

Also minor reformatting.

R=rsc
CC=golang-dev
https://golang.org/cl/845041

15 years agoruntime: run deferred calls at Goexit
Russ Cox [Tue, 30 Mar 2010 04:48:22 +0000 (21:48 -0700)]
runtime: run deferred calls at Goexit

baby step toward panic+recover.

Fixes #349.

R=r
CC=golang-dev
https://golang.org/cl/825043

15 years agogo/printer: fix a comment
Robert Griesemer [Tue, 30 Mar 2010 01:41:55 +0000 (18:41 -0700)]
go/printer: fix a comment

R=rsc
CC=golang-dev
https://golang.org/cl/826042

15 years agogodoc: support for filtering of command-line output in -src mode
Robert Griesemer [Tue, 30 Mar 2010 01:06:53 +0000 (18:06 -0700)]
godoc: support for filtering of command-line output in -src mode
+ various minor cleanups

Usage: godoc -src math Sin

R=rsc
CC=golang-dev
https://golang.org/cl/791041

15 years agoFlags: add user-defined flag types. The change is really no code; it's just publishing
Rob Pike [Tue, 30 Mar 2010 00:37:22 +0000 (17:37 -0700)]
Flags: add user-defined flag types. The change is really no code; it's just publishing
the set() method and add() functions.  But we rename add() to Var() for consistency.
Also rename FlagValue to Value for simplicity.

Also, delete the check for multiple settings for a flag.  This makes it possible to
define a flag that collects values, such as into a slice of strings.

type flagVar []string

func (f *flagVar) String() string {
return fmt.Sprint(v)
}

func (f *flagVar) Set(value string) bool {
if v == nil {
v = make(flagVar, 1)
} else {
nv := make(flagVar, len(v)+1)
copy(nv, v)
v = nv
}
v[len(v)-1] = value
return true
}

var v flagVar

func main() {
flag.Var(&v, "testV", "multiple values build []string")
flag.Parse()
fmt.Printf("v = %v\n", v)
}

R=rsc
CC=golang-dev
https://golang.org/cl/842041

15 years agoruntime: a couple more memory stats.
Russ Cox [Tue, 30 Mar 2010 00:30:07 +0000 (17:30 -0700)]
runtime: a couple more memory stats.

now runtime.MemStats.Sys really is the sum of all the other Sys fields.

R=r
CC=golang-dev
https://golang.org/cl/843041

15 years agogc: bug265
Russ Cox [Mon, 29 Mar 2010 22:27:59 +0000 (15:27 -0700)]
gc: bug265

Fixes #700.

R=ken2
CC=golang-dev
https://golang.org/cl/839041

15 years agogo/ast: generalized ast filtering
Robert Griesemer [Mon, 29 Mar 2010 22:26:07 +0000 (15:26 -0700)]
go/ast: generalized ast filtering

R=rsc
CC=golang-dev
https://golang.org/cl/788041

15 years agostrings.FIelds: slight simplification.
Rob Pike [Mon, 29 Mar 2010 20:39:16 +0000 (13:39 -0700)]
strings.FIelds: slight simplification.

R=rsc
CC=golang-dev
https://golang.org/cl/833042

15 years agofix build
Russ Cox [Mon, 29 Mar 2010 20:30:32 +0000 (13:30 -0700)]
fix build

R=gri
CC=golang-dev
https://golang.org/cl/837041

15 years agoruntime: more malloc statistics
Russ Cox [Mon, 29 Mar 2010 20:06:26 +0000 (13:06 -0700)]
runtime: more malloc statistics
expvar: default publishings for cmdline, memstats
godoc: import expvar

R=r
CC=golang-dev
https://golang.org/cl/815041

15 years agobug265: test case for issue 700
Robert Griesemer [Mon, 29 Mar 2010 17:34:16 +0000 (10:34 -0700)]
bug265: test case for issue 700
( http://code.google.com/p/go/issues/detail?id=700 )

R=r
CC=golang-dev
https://golang.org/cl/827042

15 years agostrconv.Unquote could wrongly return a nil error on error.
Roger Peppe [Mon, 29 Mar 2010 17:09:29 +0000 (10:09 -0700)]
strconv.Unquote could wrongly return a nil error on error.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/773041

15 years agocomment typos
Andrew Gerrand [Mon, 29 Mar 2010 05:31:41 +0000 (16:31 +1100)]
comment typos

Fixes #698.
Fixes #699.

R=rsc
CC=golang-dev
https://golang.org/cl/824041

15 years agocomment typo in crypto/rsa/rsa.go
Andrew Gerrand [Mon, 29 Mar 2010 02:13:12 +0000 (13:13 +1100)]
comment typo in crypto/rsa/rsa.go

R=rsc
CC=golang-dev
https://golang.org/cl/823041

15 years agospec: typo in switch sample code, missing semicolon
Andrew Gerrand [Mon, 29 Mar 2010 02:12:08 +0000 (13:12 +1100)]
spec: typo in switch sample code, missing semicolon

Fixes #697

R=r
CC=golang-dev
https://golang.org/cl/804042

15 years agohttp: add HandleFunc as shortcut to Handle(path, HandlerFunc(func))
Andrew Gerrand [Sun, 28 Mar 2010 23:02:37 +0000 (10:02 +1100)]
http: add HandleFunc as shortcut to Handle(path, HandlerFunc(func))

R=rsc
CC=golang-dev
https://golang.org/cl/763042

15 years agoxml: use io.ReadByter in place of local readByter
Raif S. Naffah [Sun, 28 Mar 2010 06:12:30 +0000 (23:12 -0700)]
xml: use io.ReadByter in place of local readByter

R=cemeyer, rsc
CC=golang-dev
https://golang.org/cl/809041

15 years agoarm: fix build
Dean Prichard [Sat, 27 Mar 2010 06:27:24 +0000 (23:27 -0700)]
arm: fix build

R=rsc
CC=golang-dev
https://golang.org/cl/800041

15 years agogc: allow taking address of out parameters
Russ Cox [Sat, 27 Mar 2010 01:01:02 +0000 (18:01 -0700)]
gc: allow taking address of out parameters

Fixes #186.

R=ken2
CC=golang-dev
https://golang.org/cl/793041

15 years agofix build
Robert Griesemer [Fri, 26 Mar 2010 23:33:59 +0000 (16:33 -0700)]
fix build

R=r
CC=golang-dev
https://golang.org/cl/790041

15 years agoregexp: don't return non-nil *Regexp if there is an error.
Rob Pike [Fri, 26 Mar 2010 23:18:20 +0000 (16:18 -0700)]
regexp: don't return non-nil *Regexp if there is an error.

R=gri
CC=golang-dev
https://golang.org/cl/787041

15 years agopprof: dump extra heap information at end of heap profile
Russ Cox [Fri, 26 Mar 2010 22:32:53 +0000 (15:32 -0700)]
pprof: dump extra heap information at end of heap profile

R=r
CC=golang-dev
https://golang.org/cl/786041

15 years agofix build
Russ Cox [Fri, 26 Mar 2010 22:01:29 +0000 (15:01 -0700)]
fix build

TBR=r
CC=golang-dev
https://golang.org/cl/785041

15 years agogodoc: export pprof debug information
Russ Cox [Fri, 26 Mar 2010 21:48:04 +0000 (14:48 -0700)]
godoc: export pprof debug information

R=gri
CC=golang-dev
https://golang.org/cl/784041

15 years agoprof: install gopprof too
Russ Cox [Fri, 26 Mar 2010 21:20:50 +0000 (14:20 -0700)]
prof: install gopprof too

This is a modified version of the open source pprof
from code.google.com/p/google-perftools.
That version is likely to catch up to this one,
but it's still useful to ship our own copy since
we only need the one script from that project,
not all the C++ libraries.

R=r
CC=golang-dev
https://golang.org/cl/783041