]>
Cypherpunks repositories - gostls13.git/log
Russ Cox [Wed, 11 Nov 2009 01:39:01 +0000 (17:39 -0800)]
net: disable dns error test
some dns resolvers (opendns, for example)
are willing to make up results for any name.
R=agl, agl1
CC=golang-dev
https://golang.org/cl/152049
Russ Cox [Wed, 11 Nov 2009 01:09:33 +0000 (17:09 -0800)]
net: fix dns bug reported on irc.
if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.
tested by tossing domain and search lines from /etc/resolv.conf
Fixes #2.
R=agl, agl1
CC=golang-dev
https://golang.org/cl/152048
Russ Cox [Wed, 11 Nov 2009 01:05:07 +0000 (17:05 -0800)]
video is ready
R=r
http://codereview.prom.corp.google.com/
1024050
Robert Griesemer [Tue, 10 Nov 2009 23:33:59 +0000 (15:33 -0800)]
better code for a copy loop
R=rsc
https://golang.org/cl/152046
Russ Cox [Tue, 10 Nov 2009 23:18:40 +0000 (15:18 -0800)]
default to codereview.appspot.com
R=r
http://codereview.prom.corp.google.com/
1026040
Ken Thompson [Tue, 10 Nov 2009 23:05:15 +0000 (15:05 -0800)]
spell it with an "e"
R=rsc
http://go/go-review/
1025037
Russ Cox [Tue, 10 Nov 2009 22:47:23 +0000 (14:47 -0800)]
video is coming soon
R=r
http://go/go-review/
1024049
Russ Cox [Tue, 10 Nov 2009 22:15:36 +0000 (14:15 -0800)]
delete old release tag
Russ Cox [Tue, 10 Nov 2009 22:12:32 +0000 (14:12 -0800)]
tag for public release
Russ Cox [Tue, 10 Nov 2009 22:09:01 +0000 (14:09 -0800)]
update video links
R=r
http://go/go-review/
1024048
Robert Griesemer [Tue, 10 Nov 2009 18:55:53 +0000 (10:55 -0800)]
minor adjustments to package comments for better synopsis.
R=rsc
CC=r
http://go/go-review/
1026038
Russ Cox [Tue, 10 Nov 2009 17:44:04 +0000 (09:44 -0800)]
correct mailing list URL
R=r
http://go/go-review/
1024047
Russ Cox [Tue, 10 Nov 2009 17:37:03 +0000 (09:37 -0800)]
remove internal references from doc/install.html
and doc/contribute.html.
add #go-nuts to help section on nav bar.
R=r
http://go/go-review/
1025035
Russ Cox [Tue, 10 Nov 2009 17:36:48 +0000 (09:36 -0800)]
make regexp comment not a package comment
R=r
http://go/go-review/
1025036
Russ Cox [Tue, 10 Nov 2009 17:10:08 +0000 (09:10 -0800)]
allow user agent to mention Go.
R=r
http://go/go-review/
1024046
Ian Lance Taylor [Tue, 10 Nov 2009 08:09:53 +0000 (00:09 -0800)]
Minor tweaks.
The text changes are trivial and may be ignored, but there are
two code corrections.
R=r, rsc
CC=go-dev
http://go/go-review/
1024045
Rob Pike [Tue, 10 Nov 2009 07:54:35 +0000 (23:54 -0800)]
make the titles of the FAQs match their links; adds clarity too. requested by rsc.
R=rsc
CC=go-dev
http://go/go-review/
1025034
Robert Griesemer [Tue, 10 Nov 2009 07:22:04 +0000 (23:22 -0800)]
- add .. link to package directory listing, for easy traversal
- matches style of source file directory listing
R=rsc
http://go/go-review/
1024044
Russ Cox [Tue, 10 Nov 2009 07:12:09 +0000 (23:12 -0800)]
in addition to bison, need to have gcc and c libraries installed.
R=r
http://go/go-review/
1024043
Russ Cox [Tue, 10 Nov 2009 07:11:36 +0000 (23:11 -0800)]
drop output from nilptr tests;
too hard to make it the same everywhere.
still checking for non-zero exit status though.
disable core files while running tests
R=r
http://go/go-review/
1026037
Robert Griesemer [Tue, 10 Nov 2009 06:30:07 +0000 (22:30 -0800)]
- minor cleanups
- better debugging support
- gofmt -l src misc | wc -l is 0
R=rsc
http://go/go-review/
1024042
Robert Griesemer [Tue, 10 Nov 2009 05:23:52 +0000 (21:23 -0800)]
- replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/
1024041
Robert Griesemer [Tue, 10 Nov 2009 05:13:17 +0000 (21:13 -0800)]
- replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/
1026036
Robert Griesemer [Tue, 10 Nov 2009 05:09:34 +0000 (21:09 -0800)]
- replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/
1024040
Rob Pike [Tue, 10 Nov 2009 04:25:45 +0000 (20:25 -0800)]
add a q&a about google's internal use of go
R=rsc
CC=go-dev
http://go/go-review/
1026035
Russ Cox [Tue, 10 Nov 2009 01:09:33 +0000 (17:09 -0800)]
noted by kaib: explicit assignment initialization
didn't match the composite literal initialization.
R=r
CC=kaib
http://go/go-review/
1024039
Russ Cox [Tue, 10 Nov 2009 00:56:17 +0000 (16:56 -0800)]
add id tags to contribute.html
R=r
http://go/go-review/
1025033
Robert Griesemer [Tue, 10 Nov 2009 00:19:38 +0000 (16:19 -0800)]
cleanup style:
- consistently remove all underbars from links
- this removes need for noline style
- removed unused info style
R=r, rsc
http://go/go-review/
1025032
Rob Pike [Tue, 10 Nov 2009 00:09:57 +0000 (16:09 -0800)]
comment out red TODO clauses except for the last one
R=rsc
CC=go-dev
http://go/go-review/
1024037
Russ Cox [Mon, 9 Nov 2009 23:25:18 +0000 (15:25 -0800)]
error rewording suggested by robert.
update comment.
R=ken
http://go/go-review/
1025031
Robert Griesemer [Mon, 9 Nov 2009 22:49:01 +0000 (14:49 -0800)]
make search box ever so slightly wider
R=rsc
http://go/go-review/
1024036
Robert Griesemer [Mon, 9 Nov 2009 22:44:16 +0000 (14:44 -0800)]
TBR:
fix typo that prevented function bodies from being indexed (ouch!)
R=rsc
http://go/go-review/
1024035
Robert Griesemer [Mon, 9 Nov 2009 20:35:56 +0000 (12:35 -0800)]
fix for incorrect composite literal grammar
(issue found by ken)
R=go-dev, rsc
http://go/go-review/
1025030
Robert Griesemer [Mon, 9 Nov 2009 20:07:39 +0000 (12:07 -0800)]
remove semis after statements in one-statement statement lists
R=rsc, r
http://go/go-review/
1025029
Russ Cox [Mon, 9 Nov 2009 19:45:15 +0000 (11:45 -0800)]
tweak documentation of commands
so that first sentence is better for cmd page.
live at http://r45:3456/cmd/
R=gri, r
http://go/go-review/
1024034
Robert Griesemer [Mon, 9 Nov 2009 18:37:36 +0000 (10:37 -0800)]
- rename Context to exprContext to remove it from public interface
(and to match the style of declContext)
R=rsc
http://go/go-review/
1024033
Robert Griesemer [Mon, 9 Nov 2009 18:27:07 +0000 (10:27 -0800)]
make search box width dynamically sized
R=rsc, agl
http://go/go-review/
1024032
Rob Pike [Mon, 9 Nov 2009 17:46:10 +0000 (09:46 -0800)]
delete commented-out section; details now covered elsewhere
R=rsc
CC=go-dev
http://go/go-review/
1025028
Robert Griesemer [Mon, 9 Nov 2009 17:34:55 +0000 (09:34 -0800)]
fix for nodeSize computation, used to determine if
a node fits on one line:
- for purposes of measuring the node size in text,
don't generate html or use a styler that could
generate html as it will lead to overly large
sizes
A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.
This change causes no difference to the gofmt formatting
of any files in src or misc.
R=rsc
http://go/go-review/
1026034
Robert Griesemer [Mon, 9 Nov 2009 07:42:00 +0000 (23:42 -0800)]
- exit godoc w/o crashing if negative tabwidth is provided
- minor related cleanups
R=rsc
http://go/go-review/
1025026
Russ Cox [Mon, 9 Nov 2009 07:38:30 +0000 (23:38 -0800)]
copy help section to install doc,
since most people won't get to the second one.
R=r
http://go/go-review/
1024031
Russ Cox [Mon, 9 Nov 2009 07:37:46 +0000 (23:37 -0800)]
change highlight color from green to yellow
(fits better in the color scheme).
eliminate background color on line numbers at
bottom of search results, now that they are grouped.
live at http://r45:3456/search?q=Reader
R=r, gri
http://go/go-review/
1024030
Robert Griesemer [Mon, 9 Nov 2009 07:34:08 +0000 (23:34 -0800)]
Addressing issue brought up by dsymonds:
- When providing alternative spellings to a query, do not
prefix it with a package qualifier as the suggestion may
not have any results. Correctly filtering is quite a bit
of work, and clicking the alternative spelling will always
also show the qualified hits if they exist (but also others).
Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
package documentation.
- Experimented with excluding main packages and test files
from index with inconclusive results. Code is present and
can be enabled by changing a flag in the source. This needs
some more work.
R=rsc
CC=r, dsymonds
http://go/go-review/
1026033
Russ Cox [Mon, 9 Nov 2009 07:22:06 +0000 (23:22 -0800)]
bug212, bug213.
R=ken
http://go/go-review/
1026032
Russ Cox [Mon, 9 Nov 2009 06:13:10 +0000 (22:13 -0800)]
make hg mail more forgiving:
create CL first, even if gofmt is needed
or no reviewers listed.
R=r
http://go/go-review/
1025025
Russ Cox [Mon, 9 Nov 2009 06:12:51 +0000 (22:12 -0800)]
mention license in install.html.
tighter nav list.
R=r
http://go/go-review/
1024029
Rob Pike [Mon, 9 Nov 2009 06:03:12 +0000 (22:03 -0800)]
link the course slides from early in the tutorial
R=rsc
CC=go-dev
http://go/go-review/
1026031
Rob Pike [Mon, 9 Nov 2009 06:02:15 +0000 (22:02 -0800)]
make "Go for it" link to install.html.
delete the unnecessary "Programming in Go. Watch Now" from the right box.
center the video picture in the right box.
R=rsc
CC=go-dev
http://go/go-review/
1025027
Rob Pike [Mon, 9 Nov 2009 05:57:59 +0000 (21:57 -0800)]
delete a pointless todo in all_test.go.
address one in rpc/client.go
R=rsc
CC=go-dev
http://go/go-review/
1026030
Robert Griesemer [Mon, 9 Nov 2009 05:48:51 +0000 (21:48 -0800)]
improved sentence extraction:
- don't forget first periods
- look at capitalization of last char before periods
R=rsc
http://go/go-review/
1024027
Russ Cox [Mon, 9 Nov 2009 05:46:20 +0000 (21:46 -0800)]
a nagging inconsistency: capitalization of
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/
1024026
Russ Cox [Mon, 9 Nov 2009 05:08:27 +0000 (21:08 -0800)]
assorted cleanup
R=r, iant
CC=go-dev
http://go/go-review/
1025024
Ian Lance Taylor [Mon, 9 Nov 2009 05:00:45 +0000 (21:00 -0800)]
Minor cleanups.
These are all fairly trivial and may be ignored.
R=r
CC=go-dev
http://go/go-review/
1024025
Rob Pike [Mon, 9 Nov 2009 04:45:39 +0000 (20:45 -0800)]
delete TODO now that compiler is better at %
adjust an inconsistency in reflect/type.go's package comment
R=rsc
http://go/go-review/
1026029
Robert Griesemer [Mon, 9 Nov 2009 04:17:04 +0000 (20:17 -0800)]
use grouping instead of colors to show non-global search hits:
- introduced a new run per file containing all spots belonging
to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization
R=rsc
http://go/go-review/
1026028
Robert Griesemer [Mon, 9 Nov 2009 02:19:06 +0000 (18:19 -0800)]
fix sentence extraction
R=rsc
http://go/go-review/
1026027
Robert Griesemer [Mon, 9 Nov 2009 00:47:32 +0000 (16:47 -0800)]
- properly align package synopses
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks
R=rsc
http://go/go-review/
1024024
Rob Pike [Sun, 8 Nov 2009 23:57:25 +0000 (15:57 -0800)]
add top-level package comments for net, reflect, malloc.
reflect is a little more detailed than some because it affords an opportunity
to explain how to approach the library.
R=gri, rsc
CC=go-dev
http://go/go-review/
1026026
Robert Griesemer [Sun, 8 Nov 2009 23:04:30 +0000 (15:04 -0800)]
added package documentation
R=r, rsc
http://go/go-review/
1025023
Russ Cox [Sun, 8 Nov 2009 17:57:37 +0000 (09:57 -0800)]
add a README file, so that if someone finds a
go tar ball or finds themselves staring at
http://code.google.com/p/go/source/browse/,
there is an obvious path back to golang.org
R=r
http://go/go-review/
1026024
Russ Cox [Sun, 8 Nov 2009 17:50:16 +0000 (09:50 -0800)]
links to Go Nuts, issue tracker,
source code browser on code.google.com
(where LICENSE file is visible)
R=r
http://go/go-review/
1024023
Russ Cox [Sun, 8 Nov 2009 17:49:13 +0000 (09:49 -0800)]
another attempt at utf-8 uploads.
the last attempt broke uploads of binary files like .png
R=r
http://go/go-review/
1026025
Russ Cox [Sun, 8 Nov 2009 09:08:26 +0000 (01:08 -0800)]
go for c++ programmers; fixes.
the most substantial are the wording around semicolons
and around the channel manager nits. both were subtly
incorrect.
R=iant, r
CC=go-dev
http://go/go-review/
1025018
Russ Cox [Sun, 8 Nov 2009 09:07:53 +0000 (01:07 -0800)]
effective go: tiny fixes
one real bug: *[]float -> *[3]float
R=r
http://go/go-review/
1024016
Robert Griesemer [Sun, 8 Nov 2009 08:51:08 +0000 (00:51 -0800)]
TBR
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)
R=rsc
http://go/go-review/
1024021
Robert Griesemer [Sun, 8 Nov 2009 08:49:56 +0000 (00:49 -0800)]
TBR
step 2: adding renamed dirlist.html again
R=rsc
http://go/go-review/
1024022
Robert Griesemer [Sun, 8 Nov 2009 08:40:43 +0000 (00:40 -0800)]
- better support for text files: show them nicely formatted
instead of serving them raw
- path-related cleanups
R=rsc
http://go/go-review/
1026021
Rob Pike [Sun, 8 Nov 2009 08:18:15 +0000 (00:18 -0800)]
make the visited color darker instead of lighter
R=rsc
CC=go-dev
http://go/go-review/
1025022
Russ Cox [Sun, 8 Nov 2009 08:16:25 +0000 (00:16 -0800)]
scaled bumpers
R=r
http://go/go-review/
1026023
Robert Griesemer [Sun, 8 Nov 2009 07:59:24 +0000 (23:59 -0800)]
- avoid division-by-zero crash in tabwriter
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing
R=rsc
http://go/go-review/
1026022
Ian Lance Taylor [Sun, 8 Nov 2009 07:42:58 +0000 (23:42 -0800)]
Adjust gccgo license references.
gccgo will be distributed under the same license as the rest
of the Go code.
R=r, rsc
http://go/go-review/
1024019
Rob Pike [Sun, 8 Nov 2009 06:00:59 +0000 (22:00 -0800)]
fixes to spec. mostly minor but several of significance.
- carriage return is white space
- "" strings cannot span newlines
- f(g()) is ok if g is multivalue and matches f's args
R=rsc, gri
CC=go-dev
http://go/go-review/
1024017
Robert Griesemer [Sun, 8 Nov 2009 05:24:48 +0000 (21:24 -0800)]
- added link to sources
- renamed listing.html -> dirList.html
(there is a dirs.html already, it should probably have a better name, too)
R=rsc
http://go/go-review/
1025020
Robert Griesemer [Sun, 8 Nov 2009 05:12:46 +0000 (21:12 -0800)]
nice directory listings
R=rsc
http://go/go-review/
1026020
Russ Cox [Sun, 8 Nov 2009 02:56:29 +0000 (18:56 -0800)]
fix authentication in parallel LoadAllCL
R=r
http://go/go-review/
1024018
Russ Cox [Sun, 8 Nov 2009 02:56:00 +0000 (18:56 -0800)]
contribute.html fixes
R=r
http://go/go-review/
1025019
Russ Cox [Sun, 8 Nov 2009 02:05:30 +0000 (18:05 -0800)]
tutorial fixes
R=r
CC=go-dev
http://go/go-review/
1024014
Russ Cox [Sun, 8 Nov 2009 01:31:22 +0000 (17:31 -0800)]
FAQ edits
R=r
CC=go-dev
http://go/go-review/
1024015
Russ Cox [Sun, 8 Nov 2009 01:30:40 +0000 (17:30 -0800)]
require Mercurial 1.3 again (how did that get dropped?)
avoid deprecation warning about os.popen3
R=r
http://go/go-review/
1026018
Russ Cox [Sun, 8 Nov 2009 01:25:53 +0000 (17:25 -0800)]
language design FAQ edits
R=r
http://go/go-review/
1026019
Russ Cox [Sun, 8 Nov 2009 00:46:49 +0000 (16:46 -0800)]
fix a few style nits; arrange the doc list in
an order we want people to read the docs.
R=r
CC=go-dev
http://go/go-review/
1025017
Vish Subramanian [Sat, 7 Nov 2009 23:52:27 +0000 (15:52 -0800)]
Add flags of type float to the flag package.
R=r, rsc
http://go/go-review/
1026011
Robert Griesemer [Sat, 7 Nov 2009 21:17:53 +0000 (13:17 -0800)]
- support to extract one-line package synopsis for package listings
- formatting in dirs.html is crude, needs better html (open to suggestions),
but shows the synopsis
- many package comments should probably be adjusted such that the first
sentence is more concise
R=rsc, iant
http://go/go-review/
1025014
Robert Griesemer [Sat, 7 Nov 2009 21:01:52 +0000 (13:01 -0800)]
- blank before opening { for multi-line composite literals (as preferred by r)
- blank padding around composite literal contents for a less dense look
(most if not all composite literals were written in that style before gofmt
ran through them)
- corresponding (internal) flag: compositeLitBlank
- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis
- the number of changes in nodes.go is huge because of the removed semis;
hg mail requires that I gofmt the file before
With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.
R=rsc, r
http://go/go-review/
1025015
Ian Lance Taylor [Sat, 7 Nov 2009 20:27:11 +0000 (12:27 -0800)]
Ignore more unimportant files.
- Emacs backup files.
- *.orig files left by hg merge conflicts.
- core files.
- generated enam.c files.
- runtime.acid now has an architecture.
R=rsc
http://go/go-review/
1026017
Russ Cox [Sat, 7 Nov 2009 20:11:28 +0000 (12:11 -0800)]
new style; live at http://r45:3456/
R=r
CC=go-dev
http://go/go-review/
1026015
Rob Pike [Sat, 7 Nov 2009 19:22:30 +0000 (11:22 -0800)]
change --enable-languages flag to include c, c++ in first mention
R=iant
http://go/go-review/
1026016
Rob Pike [Sat, 7 Nov 2009 06:48:05 +0000 (22:48 -0800)]
add an item about open source
R=rsc
CC=go-dev
http://go/go-review/
1025013
David Symonds [Sat, 7 Nov 2009 02:43:57 +0000 (18:43 -0800)]
Typo fixes.
R=rsc
CC=go-dev
http://go/go-review/
1026014
Russ Cox [Sat, 7 Nov 2009 02:40:30 +0000 (18:40 -0800)]
codereview: print gofmt message when aborting
R=r
CC=vish
http://go/go-review/
1026013
Rob Pike [Sat, 7 Nov 2009 01:31:23 +0000 (17:31 -0800)]
8g has an optimizer; update its description
R=rsc
CC=go-dev
http://go/go-review/
1025010
Vish Subramanian [Sat, 7 Nov 2009 01:08:47 +0000 (17:08 -0800)]
Contribute code instructions to use "hg codereview-login" did not work for me. I had to use
"hg code-login".
R=r, rsc
http://go/go-review/
1024012
Vish Subramanian [Sat, 7 Nov 2009 01:05:42 +0000 (17:05 -0800)]
Add vish to contributors.
R=r, rsc
http://go/go-review/
1026012
Russ Cox [Sat, 7 Nov 2009 01:02:47 +0000 (17:02 -0800)]
make temporary google.com -> golang.org hack more sophisticated
R=r
http://go/go-review/
1024013
Ken Thompson [Sat, 7 Nov 2009 00:51:49 +0000 (16:51 -0800)]
8g optimizer
R=rsc
http://go/go-review/
1025011
Robert Griesemer [Sat, 7 Nov 2009 00:34:19 +0000 (16:34 -0800)]
format composite literal types that are "short" struct type literals
on one line for a more compact representation of some composite Literals
R=rsc
http://go/go-review/
1025008
Robert Griesemer [Sat, 7 Nov 2009 00:33:53 +0000 (16:33 -0800)]
- application of gofmt with one-line composite literal structs enabled
- this CL is dependent on CL
1025008
R=r, rsc
http://go/go-review/
1025009
Kai Backman [Fri, 6 Nov 2009 23:58:23 +0000 (15:58 -0800)]
arm port description.
R=r
http://go/go-review/
1026010
Ian Lance Taylor [Fri, 6 Nov 2009 22:36:34 +0000 (14:36 -0800)]
Rename go_gccgo_setup to gccgo_install.
R=rsc
CC=go-dev
http://go/go-review/
1026009
Robert Griesemer [Fri, 6 Nov 2009 22:27:41 +0000 (14:27 -0800)]
- one-line funcs in misc
gofmt -w misc
R=rsc
http://go/go-review/
1025007