]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agodoc/go1: tweaks to address rsc's comments
Rob Pike [Wed, 29 Feb 2012 00:29:33 +0000 (11:29 +1100)]
doc/go1: tweaks to address rsc's comments

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5706054

13 years agonet/http/httputil: fix DumpRequestOut on https URLs
Brad Fitzpatrick [Wed, 29 Feb 2012 00:03:32 +0000 (16:03 -0800)]
net/http/httputil: fix DumpRequestOut on https URLs

Don't try to do an SSL negotiation with a *bytes.Buffer.

Fixes #3135

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5709050

13 years agonet: fix comment on Dial with unixgram
Mikio Hara [Tue, 28 Feb 2012 22:45:38 +0000 (07:45 +0900)]
net: fix comment on Dial with unixgram

We should use DialUnix or ListenPacket for unixgram networks
because Dial doesn't take a local UnixAddr.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5706043

13 years agodoc/style.css: make selectors more selective.
Stefan Nilsson [Tue, 28 Feb 2012 22:38:58 +0000 (09:38 +1100)]
doc/style.css: make selectors more selective.

Change #foo to div#foo to avoid selecting headings
with anchor foo, such as <h1 id="foo">.

(A more extensive change would be to use class
selectors for styling. Perhaps this is better, since id:s
should be unique within a document according to
http://www.w3.org/TR/CSS2/selector.html#id-selectors)

R=golang-dev, gri, adg
CC=golang-dev
https://golang.org/cl/5702044

13 years agogo/build: move code around
Russ Cox [Tue, 28 Feb 2012 21:34:41 +0000 (16:34 -0500)]
go/build: move code around

Only copy+paste here.
Will make next code review's diffs a bit smaller.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5704050

13 years agoruntime/pprof: support OS X CPU profiling
Russ Cox [Tue, 28 Feb 2012 21:18:24 +0000 (16:18 -0500)]
runtime/pprof: support OS X CPU profiling

Work around profiling kernel bug with signal masks.
Still broken on 64-bit Snow Leopard kernel,
but I think we can ignore that one and let people
upgrade to Lion.

Add new trivial tools addr2line and objdump to take
the place of the GNU tools of the same name, since
those are not installed on OS X.

Adapt pprof to invoke 'go tool addr2line' and
'go tool objdump' if the system tools do not exist.

Clean up disassembly of base register on amd64.

Fixes #2008.

R=golang-dev, bradfitz, mikioh.mikioh, r, iant
CC=golang-dev
https://golang.org/cl/5697066

13 years agoall: remove various unused unexported functions and constants.
Rémy Oudompheng [Tue, 28 Feb 2012 20:48:03 +0000 (21:48 +0100)]
all: remove various unused unexported functions and constants.

R=golang-dev, minux.ma, rsc
CC=golang-dev, remy
https://golang.org/cl/5702050

13 years agonet/rpc: API changes, all documentation
Rob Pike [Tue, 28 Feb 2012 20:34:28 +0000 (07:34 +1100)]
net/rpc: API changes, all documentation
except for hiding one type that is only used internally.

Fixes #2944.

R=golang-dev, rsc, kevlar
CC=golang-dev
https://golang.org/cl/5707044

13 years agocmd/dist: force line-buffering stdout/stderr on Unix
Shenghou Ma [Tue, 28 Feb 2012 18:22:28 +0000 (02:22 +0800)]
cmd/dist: force line-buffering stdout/stderr on Unix
        If stdout and stderr are indeed the same file (not a tty), which is
        often the case, fully-buffered stdout will make it harder to see
        progresses, for example, ./make.bash 2>&1 | tee log

R=r, rsc
CC=golang-dev
https://golang.org/cl/5700070

13 years agocrypto/tls: force OS X target version to 10.6 for API compatibility
Mikkel Krautz [Tue, 28 Feb 2012 16:34:48 +0000 (11:34 -0500)]
crypto/tls: force OS X target version to 10.6 for API compatibility

This is a band-aid until we can use weak imports with cgo.

Fixes #3131.

R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/5700083

13 years agoencoding/gob: fix "// +build" comment for debug.go
Shenghou Ma [Tue, 28 Feb 2012 05:39:42 +0000 (13:39 +0800)]
encoding/gob: fix "// +build" comment for debug.go

R=golang-dev, rsc, adg, r, r
CC=golang-dev
https://golang.org/cl/5693060

13 years agogotype: provide -comments flag
Robert Griesemer [Tue, 28 Feb 2012 05:35:26 +0000 (21:35 -0800)]
gotype: provide -comments flag

When debugging ASTs, it's useful to also
see the comments on occasion. Usage:

gotype -ast -comments file.go

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5703043

13 years agogodoc: add Examples link to top-level index
Andrew Gerrand [Tue, 28 Feb 2012 05:05:12 +0000 (16:05 +1100)]
godoc: add Examples link to top-level index

R=golang-dev
CC=golang-dev
https://golang.org/cl/5702043

13 years agotext/template: add example showing use of custom function
Rob Pike [Tue, 28 Feb 2012 04:50:41 +0000 (15:50 +1100)]
text/template: add example showing use of custom function

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5694100

13 years agotext/template: fix redefinition bugs
Rob Pike [Tue, 28 Feb 2012 03:23:57 +0000 (14:23 +1100)]
text/template: fix redefinition bugs

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5696087

13 years agotest: bug424: wrong embedded method called
Robert Griesemer [Tue, 28 Feb 2012 02:52:40 +0000 (18:52 -0800)]
test: bug424: wrong embedded method called

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5695083

13 years agotutorial: delete
Rob Pike [Tue, 28 Feb 2012 02:35:58 +0000 (13:35 +1100)]
tutorial: delete
Instead we'll point people at the Tour and beef up code.html.

Fixes #3107.

R=golang-dev, bradfitz, r, adg
CC=golang-dev
https://golang.org/cl/5697077

13 years agonet: no panic on placeholders for netbsd
Mikio Hara [Tue, 28 Feb 2012 01:58:01 +0000 (10:58 +0900)]
net: no panic on placeholders for netbsd

Perhaps it might be better than panic.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5701064

13 years agoencoding/json: drop MarshalForHTML; gofix calls to Marshal.
David Symonds [Tue, 28 Feb 2012 00:41:16 +0000 (11:41 +1100)]
encoding/json: drop MarshalForHTML; gofix calls to Marshal.

I've elected to omit escaping the output of Marshalers for now.
I haven't thought through the implications of that;
I suspect that double escaping might be the undoing of that idea.

Fixes #3127.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5694098

13 years agonet: add stubs for NetBSD
Benny Siegert [Tue, 28 Feb 2012 00:28:10 +0000 (11:28 +1100)]
net: add stubs for NetBSD

This fixes the build of package net for GOOS=NetBSD.
Of course, a real implementation would be even better.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5693065

13 years agoos: fix NetBSD build
Benny Siegert [Tue, 28 Feb 2012 00:26:01 +0000 (11:26 +1100)]
os: fix NetBSD build

os.fileStat.Sys is no longer exported.

R=golang-dev, m4dh4tt3r, r
CC=golang-dev
https://golang.org/cl/5696074

13 years agogobuilder: send commit time in RFC3339 format
Andrew Gerrand [Tue, 28 Feb 2012 00:21:56 +0000 (11:21 +1100)]
gobuilder: send commit time in RFC3339 format

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5701063

13 years agoencoding/binary: better example
Brad Fitzpatrick [Mon, 27 Feb 2012 23:15:23 +0000 (10:15 +1100)]
encoding/binary: better example

leave that joke to Java.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5695080

13 years agoarchive/zip: use encoding/binary again, add readBuf helper
Andrew Gerrand [Mon, 27 Feb 2012 22:41:30 +0000 (09:41 +1100)]
archive/zip: use encoding/binary again, add readBuf helper

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5699097

13 years agodoc/go1: fix broken link
Stefan Nilsson [Mon, 27 Feb 2012 22:22:55 +0000 (09:22 +1100)]
doc/go1: fix broken link

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5695072

13 years agogo/printer: fix printing of variadic function calls
Anthony Martin [Mon, 27 Feb 2012 21:56:43 +0000 (13:56 -0800)]
go/printer: fix printing of variadic function calls

Fixes #3130.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5697062

13 years agocmd/go: mention examples in docs for -test.run
Rob Pike [Mon, 27 Feb 2012 21:55:25 +0000 (08:55 +1100)]
cmd/go: mention examples in docs for -test.run
Missed in my last round. These things sure appear
in a lot of places.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5699096

13 years agocmd/go: drop -example, apply -run to examples
Rob Pike [Mon, 27 Feb 2012 21:33:06 +0000 (08:33 +1100)]
cmd/go: drop -example, apply -run to examples
Once more, with feeling.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5698080

13 years agomisc/bash: Completion for go tool.
Yissakhar Z. Beck [Mon, 27 Feb 2012 20:41:49 +0000 (07:41 +1100)]
misc/bash: Completion for go tool.

This covers most of the tool's functionality. At some point,
support should probably be added for testflags and the various go
tools.

R=golang-dev, bradfitz, kyle, minux.ma
CC=golang-dev
https://golang.org/cl/5646066

13 years agoA+C: add Yissakhar Z. Beck (Individual CLA)
Brad Fitzpatrick [Mon, 27 Feb 2012 20:40:44 +0000 (07:40 +1100)]
A+C: add Yissakhar Z. Beck (Individual CLA)

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5698079

13 years agostrings: make Count example show results
Robert Griesemer [Mon, 27 Feb 2012 20:22:10 +0000 (12:22 -0800)]
strings: make Count example show results

Thanks to dr.volker.dobler for tracking this down.

Filed a long-term issue (3142) which may eventually
resolve this problem w/o the need for a manual fix.

R=iant
CC=golang-dev
https://golang.org/cl/5698078

13 years agogodoc: don't show directories w/o packages in flat dir mode
Robert Griesemer [Mon, 27 Feb 2012 19:18:00 +0000 (11:18 -0800)]
godoc: don't show directories w/o packages in flat dir mode

The main change is simple: Both the Directory and DirEntry
struct have an extra field 'HasPkg' indicating whether the
directory contains any package files. The remaining changes
are more comments and adjustments to the template files.

Fixes #3121.

R=golang-dev, bradfitz, sameer
CC=golang-dev
https://golang.org/cl/5699072

13 years agogo/printer: fix test for new import path restrictions
Anthony Martin [Mon, 27 Feb 2012 18:01:45 +0000 (10:01 -0800)]
go/printer: fix test for new import path restrictions

Import paths with spaces are now invalid.

The builders would've caught this if they were running
the long tests.  I've removed the check for short tests
in this package since the current tests are fast enough
already.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5694082

13 years agocmd/go: test -i should not disable -c
Shenghou Ma [Mon, 27 Feb 2012 17:33:14 +0000 (12:33 -0500)]
cmd/go: test -i should not disable -c
        Fixes #3104.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5699088

13 years agoarchive/zip: use smarter putUintXX functions to hide offsets
Andrew Gerrand [Mon, 27 Feb 2012 06:37:59 +0000 (17:37 +1100)]
archive/zip: use smarter putUintXX functions to hide offsets

R=bradfitz, r, dsymonds, kyle
CC=golang-dev
https://golang.org/cl/5701055

13 years agoarchive/zip: stop using encoding/binary
Andrew Gerrand [Mon, 27 Feb 2012 05:29:22 +0000 (16:29 +1100)]
archive/zip: stop using encoding/binary

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/5694085

13 years agocmd/go: run examples even if -run is set if -example is also set
Rob Pike [Mon, 27 Feb 2012 05:23:22 +0000 (16:23 +1100)]
cmd/go: run examples even if -run is set if -example is also set
Allows one to disable everything but the example being debugged.
This time for sure.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5700079

13 years agomisc/dashboard: fix bug in UI template
Andrew Gerrand [Mon, 27 Feb 2012 05:18:58 +0000 (16:18 +1100)]
misc/dashboard: fix bug in UI template

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5700078

13 years agomisc/dashboard: record install counts for external packages
Andrew Gerrand [Mon, 27 Feb 2012 04:25:41 +0000 (15:25 +1100)]
misc/dashboard: record install counts for external packages

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5699082

13 years agodoc/go1: mention that regexp has changed
Rob Pike [Mon, 27 Feb 2012 03:34:16 +0000 (14:34 +1100)]
doc/go1: mention that regexp has changed
Also restore alphabetical order.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5701053

13 years agodoc: instruct freebsd/linux users to rm the old version first
Andrew Gerrand [Mon, 27 Feb 2012 03:16:56 +0000 (14:16 +1100)]
doc: instruct freebsd/linux users to rm the old version first

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5701052

13 years agotesting: add -test.example flag to control execution of examples
Rob Pike [Mon, 27 Feb 2012 01:49:10 +0000 (12:49 +1100)]
testing: add -test.example flag to control execution of examples
Also, don't run examples if -test.run is set.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5697069

13 years agoos: implement sameFile on windows
Alex Brainman [Mon, 27 Feb 2012 01:29:33 +0000 (12:29 +1100)]
os: implement sameFile on windows

Fixes #2511.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5687072

13 years agocrypto/x509: fix typo in Verify documentation
Mikkel Krautz [Mon, 27 Feb 2012 00:49:06 +0000 (11:49 +1100)]
crypto/x509: fix typo in Verify documentation

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5695070

13 years agohtml/template: use correct method signature, in introduction example.
Mike Rosset [Mon, 27 Feb 2012 00:31:38 +0000 (11:31 +1100)]
html/template: use correct method signature, in introduction example.

R=golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/5695067

13 years agodoc: move wiki tutorial into articles directory, rmdir doc/codelab
Andrew Gerrand [Mon, 27 Feb 2012 00:25:43 +0000 (11:25 +1100)]
doc: move wiki tutorial into articles directory, rmdir doc/codelab

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5701050

13 years agocmd/go: explain x... vs. x/... in help importpath
Rob Pike [Sun, 26 Feb 2012 22:51:58 +0000 (09:51 +1100)]
cmd/go: explain x... vs. x/... in help importpath
Fixes #3110.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5696083

13 years agonet/http/cgi: add an empty response test
Brad Fitzpatrick [Sun, 26 Feb 2012 22:46:22 +0000 (14:46 -0800)]
net/http/cgi: add an empty response test

New test for http://code.google.com/p/go/source/detail?r=a73ba18

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5701046

13 years agodoc/go1: add justification discussions to major changes
Rob Pike [Sun, 26 Feb 2012 20:31:34 +0000 (07:31 +1100)]
doc/go1: add justification discussions to major changes

Fixes #3086.

R=golang-dev, gri, r, kevlar
CC=golang-dev
https://golang.org/cl/5700067

13 years agotime: add a comment about how to use the Duration constants
Rob Pike [Sun, 26 Feb 2012 11:24:51 +0000 (22:24 +1100)]
time: add a comment about how to use the Duration constants

R=golang-dev, bradfitz, r, dsymonds
CC=golang-dev
https://golang.org/cl/5696078

13 years agodoc/install: fix FreeBSD/Linux install command
Shenghou Ma [Sat, 25 Feb 2012 17:40:29 +0000 (01:40 +0800)]
doc/install: fix FreeBSD/Linux install command

R=adg, golang-dev, go.peter.90, rsc
CC=golang-dev
https://golang.org/cl/5700062

13 years agocmd/yacc/units.y: update comment, give better error messages when $GOROOT not set
Shenghou Ma [Sat, 25 Feb 2012 17:36:26 +0000 (01:36 +0800)]
cmd/yacc/units.y: update comment, give better error messages when $GOROOT not set

R=r, golang-dev
CC=golang-dev
https://golang.org/cl/5698062

13 years agodoc: update Go1 release notes to use correct WalkFunc error signature.
Mike Rosset [Sat, 25 Feb 2012 06:17:21 +0000 (22:17 -0800)]
doc: update Go1 release notes to use correct WalkFunc error signature.

filepath's WalkFunc handler now uses errors package, and not
os.Error

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5696067

13 years agogo: fix help text documenting example functions
Robert Griesemer [Fri, 24 Feb 2012 23:42:25 +0000 (15:42 -0800)]
go: fix help text documenting example functions

R=adg, r
CC=golang-dev
https://golang.org/cl/5695062

13 years agogo/test/chan1.go: fix typo
Rob Pike [Fri, 24 Feb 2012 21:47:04 +0000 (08:47 +1100)]
go/test/chan1.go: fix typo
Found by Lucio De Re

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5694071

13 years agogo/ast: examples for ast.Print, ast.Inspect
Robert Griesemer [Fri, 24 Feb 2012 21:44:36 +0000 (13:44 -0800)]
go/ast: examples for ast.Print, ast.Inspect

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5700057

13 years agogo/doc, godoc: fix range of type declarations
Robert Griesemer [Fri, 24 Feb 2012 21:44:22 +0000 (13:44 -0800)]
go/doc, godoc: fix range of type declarations

For grouped type declarations, go/doc introduces
fake individual declarations. Don't use the original
location of the "type" keyword because it will lead
to an overly large source code range for that fake
declaration, and thus an overly large selection shown
via godoc (e.g.: click on the AssignStmt link for:
http://golang.org/pkg/go/ast/#AssignStmt ).

Also: Don't create a fake declaration if not needed.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694061

13 years agodoc/go1: new introduction
Rob Pike [Fri, 24 Feb 2012 21:02:35 +0000 (08:02 +1100)]
doc/go1: new introduction
This distills the motivational discussion and makes it the introduction to the release notes.
After this lands, I'll expand the discussion of the major changes to include more background.

Updates #3086.

R=golang-dev, gri, rsc
CC=golang-dev
https://golang.org/cl/5698057

13 years agocmd/go: in list, don't print blank lines for no output
Rob Pike [Fri, 24 Feb 2012 21:00:55 +0000 (08:00 +1100)]
cmd/go: in list, don't print blank lines for no output
Otherwise
        go list -f "{{if .Stale}}{{.ImportPath}}{{end}}" all
and similar commands can print pages of empty lines.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5696058

13 years agoruntime: size arena to fit in virtual address space limit
Russ Cox [Fri, 24 Feb 2012 20:28:51 +0000 (15:28 -0500)]
runtime: size arena to fit in virtual address space limit

For Brad.
Now FreeBSD/386 binaries run on nearlyfreespeech.net.

Fixes #2302.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5700060

13 years agonet/http/cgi: fix empty response
Russ Cox [Fri, 24 Feb 2012 20:10:46 +0000 (15:10 -0500)]
net/http/cgi: fix empty response

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5693058

13 years agogc: reject import paths containing special characters
Anthony Martin [Fri, 24 Feb 2012 19:48:36 +0000 (14:48 -0500)]
gc: reject import paths containing special characters

Also allow multiple invalid import statements in a
single file.

Fixes #3021. The changes to go/parser and the
language specifcation have already been committed.

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5672084

13 years agoencoding/xml: fix anonymous field Unmarshal example
Gustavo Niemeyer [Fri, 24 Feb 2012 19:45:32 +0000 (14:45 -0500)]
encoding/xml: fix anonymous field Unmarshal example

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5697043

13 years agocmd/vet: don't give error for Printf("%+5.2e", x)
Shenghou Ma [Fri, 24 Feb 2012 17:16:17 +0000 (01:16 +0800)]
cmd/vet: don't give error for Printf("%+5.2e", x)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5696048

13 years agodoc: update codelab/wiki to Go 1.
Shenghou Ma [Fri, 24 Feb 2012 17:09:05 +0000 (01:09 +0800)]
doc: update codelab/wiki to Go 1.

R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/5683076

13 years agoos: fix minor typo
Sanjay Menakuru [Fri, 24 Feb 2012 11:42:16 +0000 (22:42 +1100)]
os: fix minor typo

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5697051

13 years agotest/bench/shootout: update post-Makefile
Rob Pike [Fri, 24 Feb 2012 05:59:09 +0000 (16:59 +1100)]
test/bench/shootout: update post-Makefile

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5696054

13 years agoreflect.DeepEqual: don't panic comparing functions
Rob Pike [Fri, 24 Feb 2012 05:25:39 +0000 (16:25 +1100)]
reflect.DeepEqual: don't panic comparing functions
Functions are equal iff they are both nil.

Fixes #3122.

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5693057

13 years agotest: document ken/*.go
Rob Pike [Fri, 24 Feb 2012 05:24:24 +0000 (16:24 +1100)]
test: document ken/*.go

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694065

13 years agoruntime: fix arm
Russ Cox [Fri, 24 Feb 2012 04:10:38 +0000 (23:10 -0500)]
runtime: fix arm

signal.test binary passes on my phone; should fix builder

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5694064

13 years agogc: fix escape analysis + inlining + closure bug
Russ Cox [Fri, 24 Feb 2012 04:09:53 +0000 (23:09 -0500)]
gc: fix escape analysis + inlining + closure bug

R=ken2
CC=golang-dev, lvd
https://golang.org/cl/5693056

13 years agotest: fix the fix of the rename tests.
Rob Pike [Fri, 24 Feb 2012 04:06:32 +0000 (15:06 +1100)]
test: fix the fix of the rename tests.
Now they actually test again instead of just setting iota to zero.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5700058

13 years agold: fix alignment of rodata section
Russ Cox [Fri, 24 Feb 2012 04:01:36 +0000 (23:01 -0500)]
ld: fix alignment of rodata section

We were not aligning the code size,
so read-only data, which follows in the same
segment, could be arbitrarily misaligned.

Fixes #2506.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5693055

13 years agospec: allow disallow of \uFFFD in import path
Russ Cox [Fri, 24 Feb 2012 03:46:04 +0000 (22:46 -0500)]
spec: allow disallow of \uFFFD in import path

Turns out U+FFFD is a graphic character too.

http://play.golang.org/p/YblCfKAfko

R=gri
CC=golang-dev
https://golang.org/cl/5699052

13 years agocmd/cc: grow some global arrays
Russ Cox [Fri, 24 Feb 2012 03:45:55 +0000 (22:45 -0500)]
cmd/cc: grow some global arrays

Avoids global array buffer overflows if they are
indexed using some of the values between NTYPE
and NALLTYPE.  It is entirely likely that not all of these
are necessary, but this is the C compiler and not worth
worrying much about.  This change takes up only a
few more bytes of memory and makes the behavior
deterministic.

Fixes #3078.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5693052

13 years agonet/rpc: silence read error on closing connection
Russ Cox [Fri, 24 Feb 2012 03:45:44 +0000 (22:45 -0500)]
net/rpc: silence read error on closing connection

Fixes #3113.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5698056

13 years agonet: reorganize test files
Mikio Hara [Fri, 24 Feb 2012 02:58:30 +0000 (11:58 +0900)]
net: reorganize test files

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694063

13 years agotest: add cmpout to testlib
Brad Fitzpatrick [Fri, 24 Feb 2012 02:17:26 +0000 (13:17 +1100)]
test: add cmpout to testlib

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5699060

13 years agodoc/go1: document ProcessState
Rob Pike [Fri, 24 Feb 2012 02:08:11 +0000 (13:08 +1100)]
doc/go1: document ProcessState
Also reformat the "go fix" references to make them look better by using the non-CW space.

Fixes #3087.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5695057

13 years agotest: add temporary show_skips flag.
Brad Fitzpatrick [Fri, 24 Feb 2012 01:52:15 +0000 (12:52 +1100)]
test: add temporary show_skips flag.

To find test files with legacy headers.

We can remove this flag once everything is converted.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5694060

13 years agogodoc: fine-tuning .css
Robert Griesemer [Fri, 24 Feb 2012 01:42:14 +0000 (17:42 -0800)]
godoc: fine-tuning .css

R=adg
CC=golang-dev
https://golang.org/cl/5699057

13 years agonet/http: add overlooked 418 status code, per RFC 2324.
David Symonds [Fri, 24 Feb 2012 00:55:31 +0000 (11:55 +1100)]
net/http: add overlooked 418 status code, per RFC 2324.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5688067

13 years agotest/[n-z]*.go: add documentation
Rob Pike [Fri, 24 Feb 2012 00:48:19 +0000 (11:48 +1100)]
test/[n-z]*.go: add documentation

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5700056

13 years agohtml/template: make doctype check case-insensitive
Scott Lawrence [Fri, 24 Feb 2012 00:32:33 +0000 (11:32 +1100)]
html/template: make doctype check case-insensitive

Fixes #3094.

R=golang-dev, rsc, nigeltao
CC=golang-dev
https://golang.org/cl/5687065

13 years agotest/[n-r]*.go: add documentation
Rob Pike [Thu, 23 Feb 2012 23:30:39 +0000 (10:30 +1100)]
test/[n-r]*.go: add documentation
The rename ones needed redoing.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5698054

13 years agogodoc: bring back highlighting, selections, and alerts
Robert Griesemer [Thu, 23 Feb 2012 22:54:10 +0000 (14:54 -0800)]
godoc: bring back highlighting, selections, and alerts

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5695054

13 years agogodoc: consistent placement of documentation sections
Robert Griesemer [Thu, 23 Feb 2012 20:44:11 +0000 (12:44 -0800)]
godoc: consistent placement of documentation sections

Fixes #1226.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694052

13 years agoruntime: check for ARM syscall failures
Shenghou Ma [Thu, 23 Feb 2012 20:43:14 +0000 (15:43 -0500)]
runtime: check for ARM syscall failures
    While we are at it, also update some comments.
    Tested on Linux/ARM builder.

R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5696047

13 years agodist: treat CC as one unit
Scott Lawrence [Thu, 23 Feb 2012 20:38:07 +0000 (15:38 -0500)]
dist: treat CC as one unit

Fixes #3112.

R=golang-dev, 0xe2.0x9a.0x9b, ality, rsc, rsc
CC=golang-dev
https://golang.org/cl/5700044

13 years agobinary: remove unnecessary dummy type.
Stefan Nilsson [Thu, 23 Feb 2012 20:29:17 +0000 (15:29 -0500)]
binary: remove unnecessary dummy type.

R=rsc
CC=golang-dev
https://golang.org/cl/5698052

13 years agogodoc: don't show testdata directories
Robert Griesemer [Thu, 23 Feb 2012 20:23:17 +0000 (12:23 -0800)]
godoc: don't show testdata directories

R=golang-dev, bradfitz, dsymonds, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/5700043

13 years agogo/parser: expand test cases for bad import
Russ Cox [Thu, 23 Feb 2012 19:44:53 +0000 (14:44 -0500)]
go/parser: expand test cases for bad import

R=gri
CC=golang-dev
https://golang.org/cl/5697047

13 years agoruntime: darwin signal masking
Russ Cox [Thu, 23 Feb 2012 19:44:06 +0000 (14:44 -0500)]
runtime: darwin signal masking

Fixes #3101 (darwin).

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5693044

13 years agoruntime: linux signal masking
Russ Cox [Thu, 23 Feb 2012 19:43:58 +0000 (14:43 -0500)]
runtime: linux signal masking

Fixes #3101 (Linux).

R=golang-dev, bradfitz, minux.ma
CC=golang-dev
https://golang.org/cl/5696043

13 years agocc: fix an out of bounds array access
Anthony Martin [Thu, 23 Feb 2012 19:28:16 +0000 (14:28 -0500)]
cc: fix an out of bounds array access

Alternatively, we could expand the ewidth array
in [568]c/txt.c to have NALLTYPES elements and
give all types above NTYPE a width of -1.

I don't think it's worth it since TDOT and TOLD
are the only two type values above NTYPE that
are passed to typ:

$ /tmp/cctypes
cc/dcl.c:683:  t->down = typ(TOLD, T);
cc/dcl.c:919:  return typ(TDOT, T);
$

Fixes #3063.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5694047

13 years agomath: slightly more readable comments
Robert Griesemer [Thu, 23 Feb 2012 18:17:24 +0000 (10:17 -0800)]
math: slightly more readable comments

Replaced /*-style comments with line comments;
there are two many *'s already in those lines.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5699051

13 years ago6a/6l: add IMUL3Q and SHLDL
Adam Langley [Thu, 23 Feb 2012 15:51:04 +0000 (10:51 -0500)]
6a/6l: add IMUL3Q and SHLDL

Although Intel considers the three-argument form of IMUL to be a
variant of IMUL, I couldn't make 6l able to differentiate it without
huge changes, so I called it IMUL3.

R=rsc
CC=golang-dev
https://golang.org/cl/5686055

13 years agogo spec: import path implementation restriction
Robert Griesemer [Thu, 23 Feb 2012 07:51:25 +0000 (23:51 -0800)]
go spec: import path implementation restriction

R=rsc, r, r, adg
CC=golang-dev
https://golang.org/cl/5688074

13 years agotest: commentary for [h-m]*.go
Rob Pike [Thu, 23 Feb 2012 07:47:26 +0000 (18:47 +1100)]
test: commentary for [h-m]*.go

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5674112

13 years agoexp/types: fix package comment
Robert Griesemer [Thu, 23 Feb 2012 07:40:28 +0000 (23:40 -0800)]
exp/types: fix package comment

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5695046