]> Cypherpunks repositories - gostls13.git/log
gostls13.git
15 years agochameneosredux test modified, bug fixed, faster
Roger Peppe [Tue, 24 Nov 2009 19:45:30 +0000 (11:45 -0800)]
chameneosredux test modified, bug fixed, faster
based on suggestion from arvindht@gmail.com

R=r, rsc, r1
https://golang.org/cl/157091

15 years agoadd Roger Peppe to AUTHORS/CONTRIBUTORS
Russ Cox [Tue, 24 Nov 2009 19:33:43 +0000 (11:33 -0800)]
add Roger Peppe to AUTHORS/CONTRIBUTORS

R=r
https://golang.org/cl/157157

15 years agoadd Take, TakeWhile, Drop, DropWhile to exp/iterable
Michael Elkins [Tue, 24 Nov 2009 19:31:11 +0000 (11:31 -0800)]
add Take, TakeWhile, Drop, DropWhile to exp/iterable

R=dsymonds1, rsc
https://golang.org/cl/156079

15 years agoAdding myself to AUTHORS/CONTRIBUTORS as a result of https://golang.org/cl/156079
Michael Elkins [Tue, 24 Nov 2009 19:29:51 +0000 (11:29 -0800)]
Adding myself to AUTHORS/CONTRIBUTORS as a result of https://golang.org/cl/156079

R=golang-dev, rsc
CC=r
https://golang.org/cl/157072

15 years agoprint error's string when panicking.
Rob Pike [Tue, 24 Nov 2009 18:55:50 +0000 (10:55 -0800)]
print error's string when panicking.

R=rsc
https://golang.org/cl/157156

15 years agoAdd benchmarks for commonly used routines.
Trevor Strohman [Tue, 24 Nov 2009 08:21:50 +0000 (00:21 -0800)]
Add benchmarks for commonly used routines.

R=rsc, r, r1
https://golang.org/cl/160046

15 years ago cgo translates empty function arguments into void instead of dying with 'unexpected...
Eden Li [Tue, 24 Nov 2009 06:02:12 +0000 (22:02 -0800)]
cgo translates empty function arguments into void instead of dying with 'unexpected type: ...'.
  Fixes #162.

R=rsc
https://golang.org/cl/157147

15 years agojson: expose map in generic representation
Russ Cox [Tue, 24 Nov 2009 02:11:00 +0000 (18:11 -0800)]
json: expose map in generic representation

R=r, r1
https://golang.org/cl/157146

15 years agoProvides implementation of MD4 hashing algorithm.
Chris Lennert [Tue, 24 Nov 2009 01:44:44 +0000 (17:44 -0800)]
Provides implementation of MD4 hashing algorithm.

See IETF RFC 1320, http://tools.ietf.org/html/rfc1320.
Fixes #279.

R=rsc
https://golang.org/cl/159051

15 years agoAdded my name to the AUTHORS and CONTRIBUTORS lists.
Chris Lennert [Tue, 24 Nov 2009 01:44:38 +0000 (17:44 -0800)]
Added my name to the AUTHORS and CONTRIBUTORS lists.

R=rsc
https://golang.org/cl/160047

15 years agoadd an FAQ entry about the logo and mascot
Rob Pike [Tue, 24 Nov 2009 01:34:23 +0000 (17:34 -0800)]
add an FAQ entry about the logo and mascot

R=rsc
CC=golang-dev, reneefrench
https://golang.org/cl/157144

15 years agogo: makes it build for the case $GOROOT has whitespaces
Sergio Luis O. B. Correia [Tue, 24 Nov 2009 01:32:51 +0000 (17:32 -0800)]
go: makes it build for the case $GOROOT has whitespaces

the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.

this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.

Fixes #115.

R=rsc, dsymonds1
https://golang.org/cl/157067

15 years agocmd/cc: change getquoted() to accept whitespaces.
Sergio Luis O. B. Correia [Tue, 24 Nov 2009 00:00:26 +0000 (16:00 -0800)]
cmd/cc: change getquoted() to accept whitespaces.

getquoted() currently checks for whitespaces and returns nil
if it finds one. this prevents us from having go in a path
containing whitespaces, as the #pragma dynld directives are
processed through the said function.

this commit makes getquoted() accept whitespaces, and this is
also needed for solving issue #115.

R=rsc
https://golang.org/cl/157066

15 years agogofmt -r: documentation and minor fixes
Russ Cox [Mon, 23 Nov 2009 23:44:27 +0000 (15:44 -0800)]
gofmt -r: documentation and minor fixes
fix a few paren insertion bugs in the printer too.

R=gri, r
CC=golang-dev
https://golang.org/cl/157119

15 years ago Fix crash in xml.Unmarshal. Occasionally while running a scrape of some xml with...
Vish Subramanian [Mon, 23 Nov 2009 22:26:30 +0000 (14:26 -0800)]
Fix crash in xml.Unmarshal. Occasionally while running a scrape of some xml with many goroutines
I see a crash with the following stack trace:

SIGSEGV: segmentation violation
Faulting address: 0x44
PC=0x44e510

runtime·mapaccess2+0x18 /home/vish/go/src/pkg/runtime/hashmap.c:790
         runtime·mapaccess2(0x0, 0x0)
xml·*Parser·text+0x922 /home/vish/go/src/pkg/xml/xml.go:765
         xml·*Parser·text(0xe44c9870, 0x7fa3, 0xffffffff, 0x7f00, 0x44b5c4, ...)
xml·*Parser·RawToken+0x174 /home/vish/go/src/pkg/xml/xml.go:405
         xml·*Parser·RawToken(0xe44c9870, 0x7fa3, 0x0, 0x0)
xml·*Parser·Token+0x625 /home/vish/go/src/pkg/xml/xml.go:205
         xml·*Parser·Token(0xe44c9870, 0x7fa3, 0x0, 0x0, 0x0, ...)
xml·*Parser·Skip+0x27 /home/vish/go/src/pkg/xml/read.go:371
         xml·*Parser·Skip(0xe44c9870, 0x7fa3, 0x8, 0x0)
xml·*Parser·unmarshal+0xae6 /home/vish/go/src/pkg/xml/read.go:328
         xml·*Parser·unmarshal(0xe44c9870, 0x7fa3, 0xe8127120, 0x7fa3, 0xdc94bc40, ...)
xml·Unmarshal+0xda /home/vish/go/src/pkg/xml/read.go:121
         xml·Unmarshal(0xe65724b0, 0x7fa3, 0xdc94bc00, 0x7fa3, 0x4bcfc0, ...)
scraper·DoSearch+0x3d1 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scraper.go:95
         scraper·DoSearch(0xe7dc28c0, 0x7fa3, 0x33, 0x3, 0x6d2510, ...)
main·scrapeQueries+0x202 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scrape.go:251
         main·scrapeQueries(0xe7da2600, 0x7fa3, 0x64, 0x1db0, 0xe7e10000, ...)
goexit /home/vish/go/src/pkg/runtime/proc.c:135
         goexit()
0x7fa3e7da2600 unknown pc

Clearly xml.Parser is accessing an uninitialized map. Add a check for a nil map before accessing it.

R=r, rsc
https://golang.org/cl/159050

15 years agotwo more if(h<0) that gcc 4.3 -O2 miscompiles
Russ Cox [Mon, 23 Nov 2009 22:23:14 +0000 (14:23 -0800)]
two more if(h<0) that gcc 4.3 -O2 miscompiles

R=r
https://golang.org/cl/160044

15 years agoio.ReadWriter: fix doc comment (ReadWrite -> ReadWriter)
Russ Cox [Mon, 23 Nov 2009 22:22:56 +0000 (14:22 -0800)]
io.ReadWriter: fix doc comment (ReadWrite -> ReadWriter)

R=r
CC=eds
https://golang.org/cl/160045

15 years agofix bug in prefix code: must stop one character before any potential match of an...
Rob Pike [Mon, 23 Nov 2009 22:06:21 +0000 (14:06 -0800)]
fix bug in prefix code: must stop one character before any potential match of an empty string

Fixes #308.

R=rsc
CC=golang-dev
https://golang.org/cl/157142

15 years agoFix doc striing for NewReadLogger.
Rob Pike [Mon, 23 Nov 2009 21:51:10 +0000 (13:51 -0800)]
Fix doc striing for NewReadLogger.

Fixes #315.

R=rsc
https://golang.org/cl/157140

15 years ago8g: call throwindex for array out of bounds
Russ Cox [Mon, 23 Nov 2009 20:58:28 +0000 (12:58 -0800)]
8g: call throwindex for array out of bounds

R=ken2
https://golang.org/cl/160043

15 years agocrypto/tls: add initial client implementation.
Adam Langley [Sat, 21 Nov 2009 23:53:03 +0000 (15:53 -0800)]
crypto/tls: add initial client implementation.

R=rsc, agl
CC=golang-dev
https://golang.org/cl/157076

15 years agomention arrays of arrays and slices of slices
Rob Pike [Fri, 20 Nov 2009 23:47:15 +0000 (15:47 -0800)]
mention arrays of arrays and slices of slices

Fixes #113.

R=gri, rsc
CC=golang-dev
https://golang.org/cl/159049

15 years agogofmt: add -r flag to rewrite source code according to pattern
Russ Cox [Fri, 20 Nov 2009 23:09:54 +0000 (15:09 -0800)]
gofmt: add -r flag to rewrite source code according to pattern
a little slow, but usable (speed unchanged when not using -r)

tweak go/printer to handle nodes without line numbers
more gracefully in a couple cases.

R=gri
https://golang.org/cl/156103

15 years agoMissed a reference to sc instead of mc in 157065.
William Josephson [Fri, 20 Nov 2009 21:46:47 +0000 (13:46 -0800)]
Missed a reference to sc instead of mc in 157065.

R=rsc, dho
https://golang.org/cl/157116

15 years agogofmt -r 'α[β:len(α)] -> α[β:]' -w test/bench
Russ Cox [Fri, 20 Nov 2009 21:11:42 +0000 (13:11 -0800)]
gofmt -r 'α[β:len(α)] -> α[β:]' -w test/bench
except chameneosredux which i know is being edited

require gofmt for test/bench

R=r
https://golang.org/cl/157110

15 years agoFreeBSD's mcontext isn't exactly the same as sigcontext, so
Devon H. O'Dell [Fri, 20 Nov 2009 21:08:16 +0000 (13:08 -0800)]
FreeBSD's mcontext isn't exactly the same as sigcontext, so
we can't use them interchangably.

R=rsc, wjosephson
CC=golang-dev
https://golang.org/cl/156113

15 years agoSupport for basic try-catch style exception handling.
Robert Griesemer [Fri, 20 Nov 2009 19:50:11 +0000 (11:50 -0800)]
Support for basic try-catch style exception handling.
Meant as illustration of the Go pattern that is using
goroutines and channels to handle exceptional situations.

Note: There is no need for "Finally" since the
"try block" (the function f supplied to Try)
cannot do a Smalltalk-style non-local return
and terminate the function surrounding Try.

Replaces CL 157083.

R=r, rsc
https://golang.org/cl/157087

15 years agogofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg
Russ Cox [Fri, 20 Nov 2009 19:45:05 +0000 (11:45 -0800)]
gofmt -r 'α[β:len(α)] -> α[β:]' -w src/cmd src/pkg

R=r, gri
CC=golang-dev
https://golang.org/cl/156115

15 years agox[y:] for strings
Russ Cox [Fri, 20 Nov 2009 19:42:28 +0000 (11:42 -0800)]
x[y:] for strings

R=ken2
https://golang.org/cl/157114

15 years agofix build
Rob Pike [Fri, 20 Nov 2009 19:26:40 +0000 (11:26 -0800)]
fix build

R=rsc
https://golang.org/cl/159044

15 years agocodereview: handle UTF-8 in message descriptions
Russ Cox [Fri, 20 Nov 2009 19:19:16 +0000 (11:19 -0800)]
codereview: handle UTF-8 in message descriptions

what a terrible way to implement strings

R=r
https://golang.org/cl/156116

15 years agoslight simplification made possible by the code now processing match states
Rob Pike [Fri, 20 Nov 2009 19:16:57 +0000 (11:16 -0800)]
slight simplification made possible by the code now processing match states
in order of discovery.

R=rsc
https://golang.org/cl/157112

15 years agoadd unimplemented %+ and % (space) flags to floating-point print.
Rob Pike [Fri, 20 Nov 2009 19:04:51 +0000 (11:04 -0800)]
add unimplemented %+ and %  (space) flags to floating-point print.
fix %E: was same as %e.
add tests.

Fixes #278.

R=rsc
CC=golang-dev
https://golang.org/cl/157111

15 years agox[lo:] - gc and runtime.
Russ Cox [Fri, 20 Nov 2009 17:11:46 +0000 (09:11 -0800)]
x[lo:] - gc and runtime.
  * add runtime sliceslice1 for x[lo:]
  * remove runtime arraytoslice, rewriting &arr into arr[0:len(arr)].
  * port cgen_inline into 8g, 5g.
  * use native memmove in maps

R=ken2
https://golang.org/cl/157106

15 years agotest/bench revisions;
Russ Cox [Fri, 20 Nov 2009 16:59:11 +0000 (08:59 -0800)]
test/bench revisions;
  * reverse-complement: port C algorithm to Go
saves 30% on my MacBook Pro and makes it a fairer comparison.
  * test reverse-complement with and without GC (another 15%)
  * revise timing.sh to work on more systems
  * avoid two glibcisms in fasta.c

R=r
https://golang.org/cl/156110

15 years agocgo: allow .so in subdirectories
Russ Cox [Fri, 20 Nov 2009 08:31:03 +0000 (00:31 -0800)]
cgo: allow .so in subdirectories

R=r
https://golang.org/cl/157103

15 years agocodereview: make hg sync work with Mercurial 1.4
Russ Cox [Fri, 20 Nov 2009 08:30:38 +0000 (00:30 -0800)]
codereview: make hg sync work with Mercurial 1.4

R=r
https://golang.org/cl/157102

15 years agoadd a match arena to regexp to avoid generating garbage.
Rob Pike [Fri, 20 Nov 2009 07:12:01 +0000 (23:12 -0800)]
add a match arena to regexp to avoid generating garbage.
simple regexps run 20x faster.
the regex-dna benchmark goes 3x faster.

R=rsc
CC=golang-dev
https://golang.org/cl/156108

15 years agocgo now renders types with unknown size as [0]byte instead of raising a
Eden Li [Fri, 20 Nov 2009 06:09:01 +0000 (22:09 -0800)]
cgo now renders types with unknown size as [0]byte instead of raising a
fatal error.
Fixes #126.

R=rsc
https://golang.org/cl/157101

15 years agoreflect fixes
Russ Cox [Fri, 20 Nov 2009 06:06:32 +0000 (22:06 -0800)]
reflect fixes

R=r
https://golang.org/cl/156104

15 years agofix arm build.
Russ Cox [Fri, 20 Nov 2009 05:16:26 +0000 (21:16 -0800)]
fix arm build.
once more with feeling.

TBR=kaib
https://golang.org/cl/157100

15 years agoMap support for template.Execute().
James Meneghello [Fri, 20 Nov 2009 05:08:05 +0000 (21:08 -0800)]
Map support for template.Execute().

Allows the developer to pass a map either by itself for
evaluation, or inside a struct. Access to data inside
maps is identical to the current system for structs, ie.

-Psuedocode-

mp map[string]string = {
"header" : "A fantastic header!",
"footer" : "A not-so-fantastic footer!",
}
template.Execute(mp)

...can be accessed using {header} and {footer} in
the template. Similarly, for maps inside structs:

type s struct {
mp map[string]string,
}
s1 = new s
s1.mp["header"] = "A fantastic header!";
template.Execute(s1)

...is accessed using {mp.header}. Multi-maps, ie.
map[string](map[string]string) and maps of structs
containing more maps are unsupported, but then, I'm
not even sure if that's supported by the language.

Map elements can be of any type that can be written
by the formatters. Keys should really only be strings.

Fixes #259.

R=r, rsc
https://golang.org/cl/157088

15 years agoContributions etc.
James Meneghello [Fri, 20 Nov 2009 05:07:54 +0000 (21:07 -0800)]
Contributions etc.

R=rsc, r
https://golang.org/cl/156106

15 years agoAdd json.Marshal to json package
Michael Hoisie [Fri, 20 Nov 2009 04:45:03 +0000 (20:45 -0800)]
Add json.Marshal to json package

R=rsc
CC=golang-dev
https://golang.org/cl/157068

15 years agoAdded my name to the CONTRIBUTORS file
Michael Hoisie [Fri, 20 Nov 2009 04:44:56 +0000 (20:44 -0800)]
Added my name to the CONTRIBUTORS file

R=rsc
https://golang.org/cl/156081

15 years agoarchive/tar: Make Reader and Writer more closely follow io.Reader and io.Writer inter...
Evan Shaw [Fri, 20 Nov 2009 04:43:30 +0000 (20:43 -0800)]
archive/tar: Make Reader and Writer more closely follow io.Reader and io.Writer interfaces

There's no functional change here. io gives the Read and Write methods byte slice arguments, but tar called them uint8. It's the same thing, but I think this is clearer and it matches what other packages do.

R=rsc
CC=golang-dev
https://golang.org/cl/157099

15 years agobig: fix arm build - forgot how to spell JMP
Russ Cox [Fri, 20 Nov 2009 04:32:09 +0000 (20:32 -0800)]
big: fix arm build - forgot how to spell JMP

Fixes #269.

TBR=kaib
https://golang.org/cl/156107

15 years agogc: reject large channel values at compile time
Russ Cox [Fri, 20 Nov 2009 02:20:06 +0000 (18:20 -0800)]
gc: reject large channel values at compile time

Fixes #144.

R=ken2
CC=agl1
https://golang.org/cl/156102

15 years agotwo easy optimizations for regexp:
Rob Pike [Fri, 20 Nov 2009 00:45:50 +0000 (16:45 -0800)]
two easy optimizations for regexp:
1) if char class contains a single character, make it a single character.
(this is used to quote, e.g. [.] rather than \.
2) if regexp begins with ordinary text substring, use plain string match to start engine

R=rsc
CC=golang-dev
https://golang.org/cl/157095

15 years agoupdate test.sh for gofmt
Robert Griesemer [Fri, 20 Nov 2009 00:42:49 +0000 (16:42 -0800)]
update test.sh for gofmt

R=rsc
https://golang.org/cl/157096

15 years agoPermit omission of hi bound in slices.
Robert Griesemer [Fri, 20 Nov 2009 00:42:05 +0000 (16:42 -0800)]
Permit omission of hi bound in slices.

R=r, rsc
https://golang.org/cl/157082

15 years agoAdds benchmark support to gotest.
Trevor Strohman [Fri, 20 Nov 2009 00:35:34 +0000 (16:35 -0800)]
Adds benchmark support to gotest.

No benchmarks are run unless the --benchmarks=<regexp> flag
is specified on the gotest command line.  This change includes
sample benchmarks for regexp.

% gotest --benchmarks=.*
(standard test output redacted)
testing.BenchmarkSimpleMatch 200000       7799 ns/op
testing.BenchmarkUngroupedMatch 20000      76898 ns/op
testing.BenchmarkGroupedMatch 50000      38148 ns/op

R=r, rsc
https://golang.org/cl/154173

15 years agobuild Make.deps during make.bash instead
Russ Cox [Fri, 20 Nov 2009 00:27:13 +0000 (16:27 -0800)]
build Make.deps during make.bash instead
of keeping a checked-in copy.  doesn't
slow down make.bash appreciably.

R=r
https://golang.org/cl/156099

15 years agoput copy into goyacc
Ken Thompson [Thu, 19 Nov 2009 23:34:11 +0000 (15:34 -0800)]
put copy into goyacc

R=rsc
https://golang.org/cl/156100

15 years agoos.ReadAt doesn't return EOF at EOF.
Rob Pike [Thu, 19 Nov 2009 19:51:23 +0000 (11:51 -0800)]
os.ReadAt doesn't return EOF at EOF.
thanks to lionkov for the fix.

Fixes #262.

R=rsc
CC=golang-dev
https://golang.org/cl/156097

15 years agoruntime: mask signals during signal handler on OS X
Russ Cox [Thu, 19 Nov 2009 19:01:16 +0000 (11:01 -0800)]
runtime: mask signals during signal handler on OS X

Fixes #265.

R=r
CC=golang-dev
https://golang.org/cl/157084

15 years agobug219: parsing difficulties with 6g
Robert Griesemer [Thu, 19 Nov 2009 08:04:30 +0000 (00:04 -0800)]
bug219: parsing difficulties with 6g

R=r, rsc
https://golang.org/cl/157085

15 years ago- flip in and out to exercise overlap check a little (could do better)
Rob Pike [Thu, 19 Nov 2009 06:26:36 +0000 (22:26 -0800)]
- flip in and out to exercise overlap check a little (could do better)
- actually test the results

R=rsc, ken2
CC=golang-dev
https://golang.org/cl/156094

15 years agoreplace custom findByte with bytes.IndexByte
Rob Pike [Thu, 19 Nov 2009 03:58:32 +0000 (19:58 -0800)]
replace custom findByte with bytes.IndexByte

R=rsc
https://golang.org/cl/156093

15 years agobig: fix large division.
Adam Langley [Thu, 19 Nov 2009 03:26:12 +0000 (19:26 -0800)]
big: fix large division.

I missed a case.

R=rsc, agl
CC=golang-dev
https://golang.org/cl/156092

15 years agoadd bytes.IndexByte; common case we can make fast later.
Rob Pike [Thu, 19 Nov 2009 03:23:08 +0000 (19:23 -0800)]
add bytes.IndexByte; common case we can make fast later.
also pick off the special case in strings.Index.   don't want strings.IndexByte
because the call site will very rarely need to allocate and we can handle the
test in the code itself.   bytes.IndexByte can avoid a common allocation.

R=rsc
CC=golang-dev
https://golang.org/cl/156091

15 years agoAllow optional second expression in slice expressions.
Robert Griesemer [Thu, 19 Nov 2009 03:15:25 +0000 (19:15 -0800)]
Allow optional second expression in slice expressions.
Built-in function copy.
Addresses issue 203.

R=rsc, r, iant
https://golang.org/cl/156089

15 years agoruntime: fix bug on darwin/amd64 - bad g in bsdthread_start
Russ Cox [Thu, 19 Nov 2009 02:17:11 +0000 (18:17 -0800)]
runtime: fix bug on darwin/amd64 - bad g in bsdthread_start

R=r
https://golang.org/cl/157077

15 years agoMore FreeBSD-touchups. Thundercats are GOOOOO!
Devon H. O'Dell [Thu, 19 Nov 2009 00:51:59 +0000 (16:51 -0800)]
More FreeBSD-touchups. Thundercats are GOOOOO!

R=rsc
CC=golang-dev
https://golang.org/cl/157074

15 years agocrypto/x509: RawContents -> RawContent
Adam Langley [Thu, 19 Nov 2009 00:38:30 +0000 (16:38 -0800)]
crypto/x509: RawContents -> RawContent

TBR=rsc

R=rsc
https://golang.org/cl/157075

15 years agoasn1: add support for RawContent
Adam Langley [Thu, 19 Nov 2009 00:32:44 +0000 (16:32 -0800)]
asn1: add support for RawContent

R=rsc
CC=golang-dev
https://golang.org/cl/157056

15 years agocrypto/x509: add certificate support.
Adam Langley [Thu, 19 Nov 2009 00:08:24 +0000 (16:08 -0800)]
crypto/x509: add certificate support.

R=rsc
CC=golang-dev
https://golang.org/cl/156054

15 years ago6l, 8l: add trivial hash table for dynamic symbols
Russ Cox [Wed, 18 Nov 2009 23:58:44 +0000 (15:58 -0800)]
6l, 8l: add trivial hash table for dynamic symbols

R=r
https://golang.org/cl/156085

15 years agotest for copy()
Rob Pike [Wed, 18 Nov 2009 23:31:22 +0000 (15:31 -0800)]
test for copy()

R=rsc, ken2
CC=golang-dev
https://golang.org/cl/156084

15 years agoremove bytes.Copy
Rob Pike [Wed, 18 Nov 2009 23:24:24 +0000 (15:24 -0800)]
remove bytes.Copy
replace all calls with calls to copy
use copy in regexp and bytes.Buffer

R=rsc
CC=golang-dev
https://golang.org/cl/157073

15 years agobugs in memmove:
Rob Pike [Wed, 18 Nov 2009 23:00:02 +0000 (15:00 -0800)]
bugs in memmove:
- has arguments (no stack split)
- MOVL does not set condition

R=ken2, rsc
https://golang.org/cl/156086

15 years agogc: allow implicit conversion of *[10]int -> []int
Russ Cox [Wed, 18 Nov 2009 22:26:28 +0000 (14:26 -0800)]
gc: allow implicit conversion of *[10]int -> []int
when used as arg to copy.

R=ken2
https://golang.org/cl/157071

15 years agold: move interpreter string into first block of ELF file
Russ Cox [Wed, 18 Nov 2009 21:51:05 +0000 (13:51 -0800)]
ld: move interpreter string into first block of ELF file
necessary on freebsd.

R=r, dho
CC=golang-dev
https://golang.org/cl/157069

15 years agoslicecopy was always using 16 (sizeof slice) for the size instead of size of element.
Rob Pike [Wed, 18 Nov 2009 21:43:48 +0000 (13:43 -0800)]
slicecopy was always using 16 (sizeof slice) for the size instead of size of element.

R=rsc
CC=ken2, golang-dev
https://golang.org/cl/156083

15 years agonet: remove race condition on Close.
Adam Langley [Wed, 18 Nov 2009 21:18:34 +0000 (13:18 -0800)]
net: remove race condition on Close.

Previously a netFd could be queued for reading/writing in the channel,
but close(2)'ed before pollServer got to it. In this case, the kernel
would consider the descriptor closed and the attempt to add it to the
epoll set would fail and panic.

This patch makes Close a roundtrip to the pollServer, although the
actual close(2) still occurs elsewhere to avoid blocking the
pollServer.

Fixes #143.

R=rsc
CC=golang-dev
https://golang.org/cl/152130

15 years agoOn 32-bit x86, one should configure with --with-arch=.
Ian Lance Taylor [Wed, 18 Nov 2009 20:48:48 +0000 (12:48 -0800)]
On 32-bit x86, one should configure with --with-arch=.

R=r
https://golang.org/cl/156080

15 years agoMangle C struct fields that happen to be named after Go keywords by prefixing them...
Eden Li [Wed, 18 Nov 2009 17:59:10 +0000 (09:59 -0800)]
Mangle C struct fields that happen to be named after Go keywords by prefixing them with _.  Collisions with existing fields are resolved by prefixing the new Go identifier with _ until it matches nothing else in the struct.
Fixes #36.

R=rsc
https://golang.org/cl/157061

15 years agobig: implement 386 assembly routines
Russ Cox [Wed, 18 Nov 2009 17:54:51 +0000 (09:54 -0800)]
big: implement 386 assembly routines
7x speedup on big and crypto/rsa unit tests.
also dropped useAsm in favor of making the
asm stubs jump to the Go versions.

R=agl1
CC=golang-dev, gri
https://golang.org/cl/157062

15 years agoRemove unnecessary execute bits.
William Josephson [Wed, 18 Nov 2009 17:19:29 +0000 (09:19 -0800)]
Remove unnecessary execute bits.

R=rsc
https://golang.org/cl/156077

15 years agoMissing flags for FreeBSD shared link as used by cgo in default build.
William Josephson [Wed, 18 Nov 2009 17:18:51 +0000 (09:18 -0800)]
Missing flags for FreeBSD shared link as used by cgo in default build.

R=rsc
https://golang.org/cl/157065

15 years agoUpdate legal.
William Josephson [Wed, 18 Nov 2009 17:17:47 +0000 (09:17 -0800)]
Update legal.

R=rsc
https://golang.org/cl/156075

15 years agoAdd an intptr type to runtime; needed in FreeBSD
Devon H. O'Dell [Wed, 18 Nov 2009 17:11:39 +0000 (09:11 -0800)]
Add an intptr type to runtime; needed in FreeBSD

In thread.c, we need to cast to whatever the native
size of intptr is on the system, but we only have
uintptr available. They're the same size, but can't
do signed casts without this one :).

R=rsc
CC=golang-dev
https://golang.org/cl/156073

15 years agomake all.bash finish on FreeBSD
Russ Cox [Wed, 18 Nov 2009 17:11:17 +0000 (09:11 -0800)]
make all.bash finish on FreeBSD

R=dho
CC=golang-dev
https://golang.org/cl/156067

15 years agoFreeBSD/i386 work
Devon H. O'Dell [Wed, 18 Nov 2009 07:58:51 +0000 (23:58 -0800)]
FreeBSD/i386 work

This patchset gets Go to pretty much the same state that
FreeBSD/amd64 is in.

R=rsc
https://golang.org/cl/157055

15 years agocgo no longer translates function args that are void* into
Eden Li [Wed, 18 Nov 2009 07:42:21 +0000 (23:42 -0800)]
cgo no longer translates function args that are void* into
unsafe.Pointer.
Fixes #254.

R=rsc
https://golang.org/cl/157060

15 years ago Updated AUTHORS/CONTRIBUTORS files according to
Eden Li [Wed, 18 Nov 2009 07:42:15 +0000 (23:42 -0800)]
Updated AUTHORS/CONTRIBUTORS files according to
http://golang.org/doc/contribute.html#copyright

R=rsc
https://golang.org/cl/156066

15 years agoAdded Kate syntax highlighting file.
Evan Shaw [Wed, 18 Nov 2009 07:34:08 +0000 (23:34 -0800)]
Added Kate syntax highlighting file.

R=rsc
https://golang.org/cl/155075

15 years agoAdding my name to authors/contributors.
Evan Shaw [Wed, 18 Nov 2009 07:34:00 +0000 (23:34 -0800)]
Adding my name to authors/contributors.

R=rsc
https://golang.org/cl/154169

15 years agocodereview: more attempts at robustness in the face of unexpected exceptions
Russ Cox [Wed, 18 Nov 2009 07:23:18 +0000 (23:23 -0800)]
codereview: more attempts at robustness in the face of unexpected exceptions

R=r
https://golang.org/cl/156062

15 years agoAdds Trevor Strohman to CONTRIBUTORS.
Trevor Strohman [Wed, 18 Nov 2009 07:22:41 +0000 (23:22 -0800)]
Adds Trevor Strohman to CONTRIBUTORS.
Google is my employer so no AUTHORS change is needed.

R=rsc
https://golang.org/cl/154174

15 years agoruntime: add ARM memmove
Russ Cox [Wed, 18 Nov 2009 06:54:20 +0000 (22:54 -0800)]
runtime: add ARM memmove

R=ken2
https://golang.org/cl/156063

15 years agocopy tweaks
Russ Cox [Wed, 18 Nov 2009 06:16:55 +0000 (22:16 -0800)]
copy tweaks
  * move memmove to arch-specific subdirectories
  * add memmove for arm
  * add copyright notices marking them as copied from Inferno

R=ken2
https://golang.org/cl/156061

15 years agoadd a test for %+v in nested structures.
Rob Pike [Wed, 18 Nov 2009 06:14:34 +0000 (22:14 -0800)]
add a test for %+v in nested structures.
threw in an embedded one for good measure.

R=rsc
CC=golang-dev
https://golang.org/cl/157058

15 years agoallow copy to be used without a return value
Ken Thompson [Wed, 18 Nov 2009 06:00:59 +0000 (22:00 -0800)]
allow copy to be used without a return value

R=rsc
https://golang.org/cl/156060

15 years agoruntime: two trivial but important bug fixes
Russ Cox [Wed, 18 Nov 2009 06:00:30 +0000 (22:00 -0800)]
runtime: two trivial but important bug fixes

R=r
https://golang.org/cl/156059

15 years agorelease.2009-11-17: tag as of earlier this evening
Russ Cox [Wed, 18 Nov 2009 06:00:17 +0000 (22:00 -0800)]
release.2009-11-17: tag as of earlier this evening

R=r
https://golang.org/cl/156058

15 years agobug in copy
Ken Thompson [Wed, 18 Nov 2009 04:44:35 +0000 (20:44 -0800)]
bug in copy

R=rsc
https://golang.org/cl/156056

15 years agoinstall copy predefined
Ken Thompson [Wed, 18 Nov 2009 04:41:44 +0000 (20:41 -0800)]
install copy predefined
did not test 386, but should work
shouldnt matter if copy is not used

R=rsc
https://golang.org/cl/156055

15 years agocrypto/rsa: add PKCS#1 v1.5 signature support. weekly.2009-11-17
Adam Langley [Wed, 18 Nov 2009 02:21:47 +0000 (18:21 -0800)]
crypto/rsa: add PKCS#1 v1.5 signature support.

R=rsc
CC=golang-dev
https://golang.org/cl/156051

15 years agoasn1:
Adam Langley [Wed, 18 Nov 2009 02:09:41 +0000 (18:09 -0800)]
asn1:
  * add Marshal
  * add BitString.RightAlign
  * change to using a *time.Time (from time.Time) since that's what
    the time package uses.
  * return the unparsed data from Unmarshal.

R=rsc
CC=golang-dev
https://golang.org/cl/156047