]>
Cypherpunks repositories - gostls13.git/log
Russ Cox [Sun, 8 Nov 2009 17:49:13 +0000 (09:49 -0800)]
another attempt at utf-8 uploads.
the last attempt broke uploads of binary files like .png
R=r
http://go/go-review/
1026025
Russ Cox [Sun, 8 Nov 2009 09:08:26 +0000 (01:08 -0800)]
go for c++ programmers; fixes.
the most substantial are the wording around semicolons
and around the channel manager nits. both were subtly
incorrect.
R=iant, r
CC=go-dev
http://go/go-review/
1025018
Russ Cox [Sun, 8 Nov 2009 09:07:53 +0000 (01:07 -0800)]
effective go: tiny fixes
one real bug: *[]float -> *[3]float
R=r
http://go/go-review/
1024016
Robert Griesemer [Sun, 8 Nov 2009 08:51:08 +0000 (00:51 -0800)]
TBR
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)
R=rsc
http://go/go-review/
1024021
Robert Griesemer [Sun, 8 Nov 2009 08:49:56 +0000 (00:49 -0800)]
TBR
step 2: adding renamed dirlist.html again
R=rsc
http://go/go-review/
1024022
Robert Griesemer [Sun, 8 Nov 2009 08:40:43 +0000 (00:40 -0800)]
- better support for text files: show them nicely formatted
instead of serving them raw
- path-related cleanups
R=rsc
http://go/go-review/
1026021
Rob Pike [Sun, 8 Nov 2009 08:18:15 +0000 (00:18 -0800)]
make the visited color darker instead of lighter
R=rsc
CC=go-dev
http://go/go-review/
1025022
Russ Cox [Sun, 8 Nov 2009 08:16:25 +0000 (00:16 -0800)]
scaled bumpers
R=r
http://go/go-review/
1026023
Robert Griesemer [Sun, 8 Nov 2009 07:59:24 +0000 (23:59 -0800)]
- avoid division-by-zero crash in tabwriter
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing
R=rsc
http://go/go-review/
1026022
Ian Lance Taylor [Sun, 8 Nov 2009 07:42:58 +0000 (23:42 -0800)]
Adjust gccgo license references.
gccgo will be distributed under the same license as the rest
of the Go code.
R=r, rsc
http://go/go-review/
1024019
Rob Pike [Sun, 8 Nov 2009 06:00:59 +0000 (22:00 -0800)]
fixes to spec. mostly minor but several of significance.
- carriage return is white space
- "" strings cannot span newlines
- f(g()) is ok if g is multivalue and matches f's args
R=rsc, gri
CC=go-dev
http://go/go-review/
1024017
Robert Griesemer [Sun, 8 Nov 2009 05:24:48 +0000 (21:24 -0800)]
- added link to sources
- renamed listing.html -> dirList.html
(there is a dirs.html already, it should probably have a better name, too)
R=rsc
http://go/go-review/
1025020
Robert Griesemer [Sun, 8 Nov 2009 05:12:46 +0000 (21:12 -0800)]
nice directory listings
R=rsc
http://go/go-review/
1026020
Russ Cox [Sun, 8 Nov 2009 02:56:29 +0000 (18:56 -0800)]
fix authentication in parallel LoadAllCL
R=r
http://go/go-review/
1024018
Russ Cox [Sun, 8 Nov 2009 02:56:00 +0000 (18:56 -0800)]
contribute.html fixes
R=r
http://go/go-review/
1025019
Russ Cox [Sun, 8 Nov 2009 02:05:30 +0000 (18:05 -0800)]
tutorial fixes
R=r
CC=go-dev
http://go/go-review/
1024014
Russ Cox [Sun, 8 Nov 2009 01:31:22 +0000 (17:31 -0800)]
FAQ edits
R=r
CC=go-dev
http://go/go-review/
1024015
Russ Cox [Sun, 8 Nov 2009 01:30:40 +0000 (17:30 -0800)]
require Mercurial 1.3 again (how did that get dropped?)
avoid deprecation warning about os.popen3
R=r
http://go/go-review/
1026018
Russ Cox [Sun, 8 Nov 2009 01:25:53 +0000 (17:25 -0800)]
language design FAQ edits
R=r
http://go/go-review/
1026019
Russ Cox [Sun, 8 Nov 2009 00:46:49 +0000 (16:46 -0800)]
fix a few style nits; arrange the doc list in
an order we want people to read the docs.
R=r
CC=go-dev
http://go/go-review/
1025017
Vish Subramanian [Sat, 7 Nov 2009 23:52:27 +0000 (15:52 -0800)]
Add flags of type float to the flag package.
R=r, rsc
http://go/go-review/
1026011
Robert Griesemer [Sat, 7 Nov 2009 21:17:53 +0000 (13:17 -0800)]
- support to extract one-line package synopsis for package listings
- formatting in dirs.html is crude, needs better html (open to suggestions),
but shows the synopsis
- many package comments should probably be adjusted such that the first
sentence is more concise
R=rsc, iant
http://go/go-review/
1025014
Robert Griesemer [Sat, 7 Nov 2009 21:01:52 +0000 (13:01 -0800)]
- blank before opening { for multi-line composite literals (as preferred by r)
- blank padding around composite literal contents for a less dense look
(most if not all composite literals were written in that style before gofmt
ran through them)
- corresponding (internal) flag: compositeLitBlank
- don't print a semi after a one-statement statement list (as preferred by r)
- corresponding (internal flag): fewerSemis
- the number of changes in nodes.go is huge because of the removed semis;
hg mail requires that I gofmt the file before
With both flags set to false, this CL causes no gofmt formatting change. We
can turn them on if we like it (and then remove the flags). Will submit with
flags disabled.
R=rsc, r
http://go/go-review/
1025015
Ian Lance Taylor [Sat, 7 Nov 2009 20:27:11 +0000 (12:27 -0800)]
Ignore more unimportant files.
- Emacs backup files.
- *.orig files left by hg merge conflicts.
- core files.
- generated enam.c files.
- runtime.acid now has an architecture.
R=rsc
http://go/go-review/
1026017
Russ Cox [Sat, 7 Nov 2009 20:11:28 +0000 (12:11 -0800)]
new style; live at http://r45:3456/
R=r
CC=go-dev
http://go/go-review/
1026015
Rob Pike [Sat, 7 Nov 2009 19:22:30 +0000 (11:22 -0800)]
change --enable-languages flag to include c, c++ in first mention
R=iant
http://go/go-review/
1026016
Rob Pike [Sat, 7 Nov 2009 06:48:05 +0000 (22:48 -0800)]
add an item about open source
R=rsc
CC=go-dev
http://go/go-review/
1025013
David Symonds [Sat, 7 Nov 2009 02:43:57 +0000 (18:43 -0800)]
Typo fixes.
R=rsc
CC=go-dev
http://go/go-review/
1026014
Russ Cox [Sat, 7 Nov 2009 02:40:30 +0000 (18:40 -0800)]
codereview: print gofmt message when aborting
R=r
CC=vish
http://go/go-review/
1026013
Rob Pike [Sat, 7 Nov 2009 01:31:23 +0000 (17:31 -0800)]
8g has an optimizer; update its description
R=rsc
CC=go-dev
http://go/go-review/
1025010
Vish Subramanian [Sat, 7 Nov 2009 01:08:47 +0000 (17:08 -0800)]
Contribute code instructions to use "hg codereview-login" did not work for me. I had to use
"hg code-login".
R=r, rsc
http://go/go-review/
1024012
Vish Subramanian [Sat, 7 Nov 2009 01:05:42 +0000 (17:05 -0800)]
Add vish to contributors.
R=r, rsc
http://go/go-review/
1026012
Russ Cox [Sat, 7 Nov 2009 01:02:47 +0000 (17:02 -0800)]
make temporary google.com -> golang.org hack more sophisticated
R=r
http://go/go-review/
1024013
Ken Thompson [Sat, 7 Nov 2009 00:51:49 +0000 (16:51 -0800)]
8g optimizer
R=rsc
http://go/go-review/
1025011
Robert Griesemer [Sat, 7 Nov 2009 00:34:19 +0000 (16:34 -0800)]
format composite literal types that are "short" struct type literals
on one line for a more compact representation of some composite Literals
R=rsc
http://go/go-review/
1025008
Robert Griesemer [Sat, 7 Nov 2009 00:33:53 +0000 (16:33 -0800)]
- application of gofmt with one-line composite literal structs enabled
- this CL is dependent on CL
1025008
R=r, rsc
http://go/go-review/
1025009
Kai Backman [Fri, 6 Nov 2009 23:58:23 +0000 (15:58 -0800)]
arm port description.
R=r
http://go/go-review/
1026010
Ian Lance Taylor [Fri, 6 Nov 2009 22:36:34 +0000 (14:36 -0800)]
Rename go_gccgo_setup to gccgo_install.
R=rsc
CC=go-dev
http://go/go-review/
1026009
Robert Griesemer [Fri, 6 Nov 2009 22:27:41 +0000 (14:27 -0800)]
- one-line funcs in misc
gofmt -w misc
R=rsc
http://go/go-review/
1025007
Robert Griesemer [Fri, 6 Nov 2009 22:24:38 +0000 (14:24 -0800)]
- fine-tuning of one-line func heuristic (nodes.go)
- enabled for function declarations (not just function literals)
- applied gofmt -w $GOROOT/src
(look for instance at src/pkg/debug/elf/elf.go)
R=r, rsc
CC=go-dev
http://go/go-review/
1026006
Ian Lance Taylor [Fri, 6 Nov 2009 22:16:47 +0000 (14:16 -0800)]
Expand section on building gccgo.
R=r
http://go/go-review/
1026008
Ian Lance Taylor [Fri, 6 Nov 2009 22:15:41 +0000 (14:15 -0800)]
Add a document on contributing to gccgo.
R=r, rsc
CC=go-dev
http://go/go-review/
1025005
Robert Griesemer [Fri, 6 Nov 2009 22:00:49 +0000 (14:00 -0800)]
updated godoc documentation
R=r
http://go/go-review/
1026007
Kai Backman [Fri, 6 Nov 2009 21:51:17 +0000 (13:51 -0800)]
fix argument order bug for float
R=rsc
http://go/go-review/
1025006
Kai Backman [Fri, 6 Nov 2009 21:50:58 +0000 (13:50 -0800)]
with rsc: argsize rounding to 8 smashes stack data on 32bit machines.
R=rsc
http://go/go-review/
1024011
Russ Cox [Fri, 6 Nov 2009 21:42:04 +0000 (13:42 -0800)]
Added tag release, release.2009-11-06 for changeset
1f0a01c93d30
Robert Griesemer [Fri, 6 Nov 2009 20:52:04 +0000 (12:52 -0800)]
replaced "Expressive" with "expressive" for a cleaner look
R=r
http://go/go-review/
1024010
Adam Langley [Fri, 6 Nov 2009 19:36:21 +0000 (11:36 -0800)]
big: fix carry error, add test case.
crypto/x509: reenable tests.
R=gri
CC=go-dev
http://go/go-review/
1026004
Robert Griesemer [Fri, 6 Nov 2009 19:00:06 +0000 (11:00 -0800)]
minor fixups by gofmt
R=agl
http://go/go-review/
1024009
Russ Cox [Fri, 6 Nov 2009 18:33:46 +0000 (10:33 -0800)]
expand "this is not just mercurial" section
R=r
CC=go-dev
http://go/go-review/
1024008
Russ Cox [Fri, 6 Nov 2009 18:04:22 +0000 (10:04 -0800)]
contribute.html
R=r, iant
CC=go-dev
http://go/go-review/
1022007
Russ Cox [Fri, 6 Nov 2009 17:45:24 +0000 (09:45 -0800)]
require gofmt for all $GOROOT/src/.../*.go.
try harder to post messages to rietveld.
R=gri, r
CC=go-dev
http://go/go-review/
1024006
Adam Langley [Fri, 6 Nov 2009 17:23:40 +0000 (09:23 -0800)]
crypto/x509: build fix for 32-bit
TBR=rsc
R=rsc
CC=go-dev
http://go/go-review/
1024007
Adam Langley [Fri, 6 Nov 2009 17:05:19 +0000 (09:05 -0800)]
Fix add-back division test so that it triggers the add-back case on
both 64 and 32 bit platforms.
Also, uncomment some tests that were still commented out from
debugging.
R=gri, rsc
CC=go-dev
http://go/go-review/
1026003
Robert Griesemer [Fri, 6 Nov 2009 07:18:06 +0000 (23:18 -0800)]
gofmt -w misc
R=rsc
http://go/go-review/
1025004
Kai Backman [Fri, 6 Nov 2009 06:53:08 +0000 (22:53 -0800)]
make 5g executables run on android/arm hardware. change OABI
usage to EABI.
go/test: passes 85% (296/347) on random android phone.
R=rsc
http://go/go-review/
1024003
Robert Griesemer [Fri, 6 Nov 2009 06:29:29 +0000 (22:29 -0800)]
gofmt src/cmd/goyacc
(with this change: gofmt -l src/cmd/ | wc
is 0 0 0)
R=ken, rsc
http://go/go-review/
1024005
Robert Griesemer [Fri, 6 Nov 2009 06:25:46 +0000 (22:25 -0800)]
gofmt'ed src/cmd
R=rsc
http://go/go-review/
1024004
Robert Griesemer [Fri, 6 Nov 2009 06:05:43 +0000 (22:05 -0800)]
- fix elf.go manually so it is idempotent for gofmt
- with this change, `gofmt -l src/pkg | wc` is 0
R=rsc
http://go/go-review/
1025002
Robert Griesemer [Fri, 6 Nov 2009 02:27:30 +0000 (18:27 -0800)]
missing piece gofmt'ed in reflect
R=r, rsc
http://go/go-review/
1025001
Robert Griesemer [Fri, 6 Nov 2009 02:26:16 +0000 (18:26 -0800)]
gofmt'ed more stragglers
R=rsc
http://go/go-review/
1019004
Robert Griesemer [Fri, 6 Nov 2009 02:25:23 +0000 (18:25 -0800)]
gofmt'ed big
R=agl
http://go/go-review/
1022003
Robert Griesemer [Fri, 6 Nov 2009 02:24:53 +0000 (18:24 -0800)]
gofmt'ed various stragglers
R=rsc
http://go/go-review/
1022002
Robert Griesemer [Fri, 6 Nov 2009 02:24:24 +0000 (18:24 -0800)]
gofmt'ed more stragglers
(now down to a handfull of files in pkg)
R=rsc
http://go/go-review/
1019006
Russ Cox [Fri, 6 Nov 2009 02:23:26 +0000 (18:23 -0800)]
fix UTF-8 upload bug
TBR=r
http://go/go-review/
1026001
Robert Griesemer [Fri, 6 Nov 2009 02:14:47 +0000 (18:14 -0800)]
gofmt the last outstanding files in src/pkg
- added a list of issues to printer/nodes.go
R=rsc
http://go/go-review/
1024002
Robert Griesemer [Fri, 6 Nov 2009 01:35:40 +0000 (17:35 -0800)]
gofmt'ed missing regexp file
(one-line functions will be re-established once we have all
formatted uniformly)
R=r
http://go/go-review/
1023004
Robert Griesemer [Fri, 6 Nov 2009 01:27:02 +0000 (17:27 -0800)]
manual fix for better gofmt result
R=r
http://go/go-review/
1019005
Robert Griesemer [Fri, 6 Nov 2009 01:02:55 +0000 (17:02 -0800)]
- gofmt'ing of some stragglers, now with correct comment indentation
in special cases
- re-gofmt'ing of some files that are now improved
R=r, rsc
http://go/go-review/
1023003
Robert Griesemer [Fri, 6 Nov 2009 01:02:29 +0000 (17:02 -0800)]
fix a comment formatting bug:
- this ensures better comment formatting in template.go and codec_test.go
- it affects only 2 files of all files that have been gofmt'ed already,
see separate CL (it fixes the same issue in those files)
R=rsc
http://go/go-review/
1023002
Adam Langley [Fri, 6 Nov 2009 00:59:39 +0000 (16:59 -0800)]
crypto/tls (part 6/5)
Results of running gofmt again.
R=rsc
CC=go-dev
http://go/go-review/
1022006
Rob Pike [Fri, 6 Nov 2009 00:44:55 +0000 (16:44 -0800)]
fix broken link
R=rsc, iant
CC=go-dev
http://go/go-review/
1019003
Adam Langley [Fri, 6 Nov 2009 00:44:02 +0000 (16:44 -0800)]
crypto/tls (part 5/5)
Make RSA and X509 build by using big. (This involves commenting out
key generation for now since I haven't written Miller-Rabin in big
yet.)
Add entries to the Makefile.
R=rsc
CC=go-dev
http://go/go-review/
1022005
Adam Langley [Fri, 6 Nov 2009 00:43:29 +0000 (16:43 -0800)]
crypto/tls (part 4/5)
R=rsc
CC=go-dev
http://go/go-review/
1019002
Ian Lance Taylor [Fri, 6 Nov 2009 00:04:45 +0000 (16:04 -0800)]
Cleaned up gccgo error messages require minor adjustment to
test.
const1.go:27: error: integer constant overflow
const1.go:29: error: integer constant overflow
const1.go:30: error: integer constant overflow
const1.go:31: error: integer constant overflow
const1.go:32: error: integer constant overflow
const1.go:33: error: integer constant overflow
const1.go:33: error: integer constant overflow
const1.go:34: error: integer constant overflow
const1.go:37: error: integer constant overflow
const1.go:38: error: integer constant overflow
const1.go:40: error: integer constant overflow
const1.go:41: error: integer constant overflow
const1.go:43: error: integer constant overflow
const1.go:44: error: integer constant overflow
const1.go:45: error: integer constant overflow
const1.go:48: error: integer constant overflow
const1.go:50: error: integer constant overflow
const1.go:51: error: integer constant overflow
const1.go:52: error: integer constant overflow
const1.go:53: error: integer constant overflow
const1.go:55: error: integer constant overflow
const1.go:56: error: division by zero
const1.go:59: error: floating point constant overflow
const1.go:61: error: floating point constant overflow
const1.go:62: error: division by zero
const1.go:47: error: integer constant overflow
const1.go:49: error: integer constant overflow
const1.go:60: error: floating point constant overflow
const1.go:68: error: argument 1 has incompatible type (cannot use type int8 as type int)
const1.go:69: error: argument 1 has incompatible type (cannot use type int8 as type int)
const1.go:70: error: argument 1 has incompatible type (cannot use type uint8 as type int)
const1.go:72: error: argument 1 has incompatible type (cannot use type float32 as type int)
const1.go:73: error: argument 1 has incompatible type (cannot use type float as type int)
const1.go:74: error: floating point constant truncated to integer
const1.go:76: error: argument 1 has incompatible type (cannot use type float64 as type int)
const1.go:77: error: argument 1 has incompatible type
const1.go:78: error: argument 1 has incompatible type
R=rsc
http://go/go-review/
1022001
Robert Griesemer [Thu, 5 Nov 2009 23:58:28 +0000 (15:58 -0800)]
gofmt'ed parts of go
R=rsc
http://go/go-review/
1023001
Adam Langley [Thu, 5 Nov 2009 23:55:41 +0000 (15:55 -0800)]
big: add Div, Mod, Exp, GcdExt and several other fixes.
R=gri, rsc
CC=go-dev
http://go/go-review/
1017036
Adam Langley [Thu, 5 Nov 2009 23:44:32 +0000 (15:44 -0800)]
crypto/tls (part 3)
(With hindsight, record_process might have been designed wrong, but it
works for now. It'll get redrawn when client support is added.)
R=rsc
CC=r
http://go/go-review/
1018032
Robert Griesemer [Thu, 5 Nov 2009 23:37:55 +0000 (15:37 -0800)]
gofmt-ify io, json, runtime, encoding
R=rsc
http://go/go-review/
1017056
Robert Griesemer [Thu, 5 Nov 2009 23:35:53 +0000 (15:35 -0800)]
gofmt'ed godefs
R=rsc
http://go/go-review/
1020001
Robert Griesemer [Thu, 5 Nov 2009 23:35:02 +0000 (15:35 -0800)]
gofmt'ed debug
(excluding debug/gosym/symtab.go which has a small issue)
R=rsc
http://go/go-review/
1019001
Robert Griesemer [Thu, 5 Nov 2009 23:33:26 +0000 (15:33 -0800)]
gofmt'ed 6l 8l cgo
R=r
http://go/go-review/
1020002
Robert Griesemer [Thu, 5 Nov 2009 23:12:37 +0000 (15:12 -0800)]
gofmt-ify strings, template
R=r
http://go/go-review/
1018064
Rob Pike [Thu, 5 Nov 2009 23:07:42 +0000 (15:07 -0800)]
add information comparing the compiler implementations to the installation document
R=rsc
CC=go-dev
http://go/go-review/
1018063
Robert Griesemer [Thu, 5 Nov 2009 22:53:42 +0000 (14:53 -0800)]
gofmt-ify gob
(the one-line struct types used in composite literals will become
one line again in another cleanup round; don't worry about them now)
R=r
http://go/go-review/
1016056
Russ Cox [Thu, 5 Nov 2009 22:44:57 +0000 (14:44 -0800)]
codereview: new commands
* clpatch
* download
* submit, on behalf of clpatch
stir hgpatch to fix a few bugs
R=r
CC=go-dev
http://go/go-review/
1016051
Robert Griesemer [Thu, 5 Nov 2009 22:43:03 +0000 (14:43 -0800)]
gofmt-ify 4s, iterable
R=rsc
http://go/go-review/
1016055
Robert Griesemer [Thu, 5 Nov 2009 22:42:28 +0000 (14:42 -0800)]
gofmt-ify draw
R=rsc
http://go/go-review/
1017055
Robert Griesemer [Thu, 5 Nov 2009 22:41:56 +0000 (14:41 -0800)]
gofmt-ify eval
R=rsc
http://go/go-review/
1016054
Robert Griesemer [Thu, 5 Nov 2009 22:30:18 +0000 (14:30 -0800)]
gofmt-ify ogle
R=rsc
http://go/go-review/
1016053
Robert Griesemer [Thu, 5 Nov 2009 22:29:38 +0000 (14:29 -0800)]
gofmt-ify nacl
R=rsc
http://go/go-review/
1018062
Robert Griesemer [Thu, 5 Nov 2009 22:23:20 +0000 (14:23 -0800)]
gofmt-ify reflect
- the single line structs can be fixed in another round
R=rsc
http://go/go-review/
1016052
Robert Griesemer [Thu, 5 Nov 2009 22:03:56 +0000 (14:03 -0800)]
2nd attempt: no noIndent for string lists
- slightly better output in general
- extra indentation where we could do without
(however that seems better for now that not having the indentation
where it is needed)
- no information is lost, so a future better approach can fix these
places up again
R=rsc
http://go/go-review/
1017050
Rob Pike [Thu, 5 Nov 2009 21:46:12 +0000 (13:46 -0800)]
add a place-holder link for the hour-long video
R=rsc
CC=go-dev
http://go/go-review/
1017054
Rob Pike [Thu, 5 Nov 2009 21:39:00 +0000 (13:39 -0800)]
update the text on the landing page.
R=agl, rsc
CC=go-dev
http://go/go-review/
1017053
Ken Thompson [Thu, 5 Nov 2009 21:05:07 +0000 (13:05 -0800)]
forgot a piece of debugging
in previous change
R=rsc
http://go/go-review/
1017052
Ken Thompson [Thu, 5 Nov 2009 20:47:22 +0000 (12:47 -0800)]
same speedup as 6l
R=rsc
http://go/go-review/
1016050
Adam Langley [Thu, 5 Nov 2009 20:18:54 +0000 (12:18 -0800)]
godoc: style update.
R=r, rsc
CC=go-dev
http://go/go-review/
1017051
Robert Griesemer [Thu, 5 Nov 2009 18:55:57 +0000 (10:55 -0800)]
gofmt-ify syscall
(replacement for CL
1018053 )
R=r
http://go/go-review/
1017047
Robert Griesemer [Thu, 5 Nov 2009 17:40:28 +0000 (09:40 -0800)]
gofmt-ify template, time, unsafe, flag, fmt
(replacement for CLs
1017039 ,
1017041 ,
1017040 ,
1018054 )
R=r
http://go/go-review/
1018060