]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agodoc/reference-cmd.html: new introduction
Rob Pike [Fri, 23 Mar 2012 22:29:08 +0000 (09:29 +1100)]
doc/reference-cmd.html: new introduction
Compare and explain go, go cmd, and go tool cmd.
The situation is not concisely explained elsewhere in the main docs.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5906043

13 years agoos: add missing byte to FileMode buffer
Stefan Nilsson [Fri, 23 Mar 2012 21:16:57 +0000 (08:16 +1100)]
os: add missing byte to FileMode buffer

32 bytes is enough for all FileMode bits.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5853044

13 years agocodewalk/sharemem.xml: fix references to files
Rob Pike [Fri, 23 Mar 2012 21:12:52 +0000 (08:12 +1100)]
codewalk/sharemem.xml: fix references to files

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5877064

13 years agotext/template: fix typo in package comment
Robert Griesemer [Fri, 23 Mar 2012 18:31:29 +0000 (11:31 -0700)]
text/template: fix typo in package comment

Fixes #3383.

R=iant, bradfitz
CC=golang-dev
https://golang.org/cl/5891045

13 years agodoc/reference-cmd: doc/fmt can be invoked by cmd/go but also available as independent...
Shenghou Ma [Fri, 23 Mar 2012 15:21:52 +0000 (23:21 +0800)]
doc/reference-cmd: doc/fmt can be invoked by cmd/go but also available as independent command

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/5877050

13 years agocrypto/tls: don't select ECC ciphersuites with no mutual curve.
Adam Langley [Fri, 23 Mar 2012 14:48:51 +0000 (10:48 -0400)]
crypto/tls: don't select ECC ciphersuites with no mutual curve.

The existing code that tried to prevent ECC ciphersuites from being
selected when there were no mutual curves still left |suite| set.
This lead to a panic on a nil pointer when there were no acceptable
ciphersuites at all.

Thanks to George Kadianakis for pointing it out.

R=golang-dev, r, bradfitz
CC=golang-dev
https://golang.org/cl/5857043

13 years agodoc/articles/defer_panic_recover.html: minor tweaks
Rob Pike [Fri, 23 Mar 2012 06:40:27 +0000 (17:40 +1100)]
doc/articles/defer_panic_recover.html: minor tweaks
Delete () from function names and change the reference to some
functions to the correct term, methods.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5874063

13 years agodoc/articles/image_draw.html: fix circle example
Rob Pike [Fri, 23 Mar 2012 06:02:21 +0000 (17:02 +1100)]
doc/articles/image_draw.html: fix circle example
It was showing the same snippet twice instead of the type definition and snippet.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5875045

13 years agopath/filepath: windows drive letter cannot be a digit
Alex Brainman [Fri, 23 Mar 2012 04:57:19 +0000 (15:57 +1100)]
path/filepath: windows drive letter cannot be a digit

R=golang-dev, r
CC=golang-dev, mattn.jp
https://golang.org/cl/5885056

13 years agotag weekly.2012-03-22
Andrew Gerrand [Fri, 23 Mar 2012 01:45:58 +0000 (12:45 +1100)]
tag weekly.2012-03-22

R=golang-dev
CC=golang-dev
https://golang.org/cl/5877063

13 years agomisc/dist: make godoc shortcut work weekly.2012-03-22
Andrew Gerrand [Fri, 23 Mar 2012 01:44:33 +0000 (12:44 +1100)]
misc/dist: make godoc shortcut work

R=golang-dev
CC=golang-dev
https://golang.org/cl/5877062

13 years agodoc/godoc.js: fix error on IE8.
Yasuhiro Matsumoto [Fri, 23 Mar 2012 01:23:53 +0000 (12:23 +1100)]
doc/godoc.js: fix error on IE8.
        * implement simple getElementsByClassName for IE8.
        * remove some lint warnings.

Fixes #3318.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5881054

13 years agoweekly.2012-03-22
Andrew Gerrand [Fri, 23 Mar 2012 00:56:54 +0000 (11:56 +1100)]
weekly.2012-03-22

R=golang-dev, r, dave
CC=golang-dev
https://golang.org/cl/5876068

13 years agomisc/dist: updates to installer script
Andrew Gerrand [Fri, 23 Mar 2012 00:48:54 +0000 (11:48 +1100)]
misc/dist: updates to installer script

Now sets GOROOT.

Fixes #3287.
Fixes #3361.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5877059

13 years agodoc/articles/c_go_cgo.html: correct "C" comment to mention #cgo
Ian Lance Taylor [Fri, 23 Mar 2012 00:44:28 +0000 (17:44 -0700)]
doc/articles/c_go_cgo.html: correct "C" comment to mention #cgo

Also fix invalid apostrophe characters.

R=r, gri, adg
CC=golang-dev
https://golang.org/cl/5874058

13 years agodoc/articles: rename concurrency patterns article
Rob Pike [Thu, 22 Mar 2012 20:51:16 +0000 (07:51 +1100)]
doc/articles: rename concurrency patterns article
The old name, automatically generated, was ludicrously verbose.
Also clean up an example to use time.Second.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5876051

13 years agotest: fix run.bash by spelling out the commands to use for bug424.go
Ian Lance Taylor [Thu, 22 Mar 2012 19:48:41 +0000 (12:48 -0700)]
test: fix run.bash by spelling out the commands to use for bug424.go

R=golang-dev, gri, iant
CC=golang-dev
https://golang.org/cl/5882046

13 years agocmd/gc: fix comment typo, assignment spacing
Ian Lance Taylor [Thu, 22 Mar 2012 18:40:12 +0000 (11:40 -0700)]
cmd/gc: fix comment typo, assignment spacing

R=bradfitz, gri, lvd
CC=golang-dev
https://golang.org/cl/5874053

13 years agocmd/gc: when expanding append inline, preserve arguments
Ian Lance Taylor [Thu, 22 Mar 2012 16:44:31 +0000 (09:44 -0700)]
cmd/gc: when expanding append inline, preserve arguments

Fixes #3369.

R=golang-dev, gri, lvd, r
CC=golang-dev
https://golang.org/cl/5876044

13 years agosort: add time complexity to doc
Stefan Nilsson [Thu, 22 Mar 2012 16:27:02 +0000 (09:27 -0700)]
sort: add time complexity to doc

Let's tell the world that Go's sort is O(n log n).
Surely this is a feature we intend to keep.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5867045

13 years agodoc/articles/gobs_of_data.html: delete extra word
Rob Pike [Thu, 22 Mar 2012 08:20:03 +0000 (19:20 +1100)]
doc/articles/gobs_of_data.html: delete extra word
Putt putt putt our way towards felicity.

R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/5874048

13 years agodoc: add JSON and Go article
Francisco Souza [Thu, 22 Mar 2012 07:25:40 +0000 (18:25 +1100)]
doc: add JSON and Go article

Originally published on The Go Programming Language Blog, January 25, 2011.

http://blog.golang.org/2011/01/json-and-go.html

R=adg
CC=golang-dev
https://golang.org/cl/5846044

13 years agodoc/articles/go_command.html: nits
Rob Pike [Thu, 22 Mar 2012 06:59:06 +0000 (17:59 +1100)]
doc/articles/go_command.html: nits
Fix some English mistakes and minor inaccuracies.

R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/5885046

13 years agoflag: add examples
Rob Pike [Thu, 22 Mar 2012 00:15:43 +0000 (11:15 +1100)]
flag: add examples

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5867049

13 years agodoc: fix typo in The Laws of Reflection article
Francisco Souza [Wed, 21 Mar 2012 23:42:04 +0000 (16:42 -0700)]
doc: fix typo in The Laws of Reflection article

R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/5876047

13 years agoexp/norm/normalize.go: fix typo
Robert Griesemer [Wed, 21 Mar 2012 21:55:05 +0000 (14:55 -0700)]
exp/norm/normalize.go: fix typo

R=golang-dev, r, dsymonds
CC=golang-dev
https://golang.org/cl/5874045

13 years agodoc/effective_go.html: undo local font change
Robert Griesemer [Wed, 21 Mar 2012 21:29:16 +0000 (14:29 -0700)]
doc/effective_go.html: undo local font change

R=r
CC=golang-dev
https://golang.org/cl/5876043

13 years agogo/build: clarify why we exclude files starting with '_' or '.'
Shenghou Ma [Wed, 21 Mar 2012 19:18:47 +0000 (03:18 +0800)]
go/build: clarify why we exclude files starting with '_' or '.'

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5864053

13 years agogodoc: use shorter titles for tabs
Robert Griesemer [Wed, 21 Mar 2012 18:29:30 +0000 (11:29 -0700)]
godoc: use shorter titles for tabs

In a browser with many open tabs, the tab titles become short
and uninformative because they all start with the same prefix
("Package ", "Directory ", etc.).

Permit use of shorter tab titles that start with the relevant
information first.

Fixes #3365.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5865056

13 years agotest: use testlib in a few more cases
Shenghou Ma [Wed, 21 Mar 2012 18:14:44 +0000 (02:14 +0800)]
test: use testlib in a few more cases
        Introduce a new skip cmd.

R=golang-dev, bradfitz, iant, iant
CC=golang-dev
https://golang.org/cl/5868048

13 years agocmd/cgo: fix handling of errno for gccgo
Ian Lance Taylor [Wed, 21 Mar 2012 17:38:58 +0000 (10:38 -0700)]
cmd/cgo: fix handling of errno for gccgo

Fixes #3332.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5868047

13 years agodoc/effective_go: minor corrections
Shenghou Ma [Wed, 21 Mar 2012 16:33:55 +0000 (09:33 -0700)]
doc/effective_go: minor corrections

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5848063

13 years agobuild: lengthen timeout for the lengthy runtime test
Shenghou Ma [Wed, 21 Mar 2012 08:19:37 +0000 (16:19 +0800)]
build: lengthen timeout for the lengthy runtime test
        To fix build on (overheated) Linux/ARM builder.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/5865051

13 years agodoc: remove reference to deleted os.ENOSPC
Brad Fitzpatrick [Tue, 20 Mar 2012 23:50:51 +0000 (16:50 -0700)]
doc: remove reference to deleted os.ENOSPC

R=golang-dev, gri, r, r
CC=golang-dev
https://golang.org/cl/5866046

13 years agohtml/template: fix typo and make grammar consistent in comments.
David Symonds [Tue, 20 Mar 2012 23:10:44 +0000 (10:10 +1100)]
html/template: fix typo and make grammar consistent in comments.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5866044

13 years agosort: fix computation of maxDepth to avoid infinite loop
Stefan Nilsson [Tue, 20 Mar 2012 21:23:12 +0000 (14:23 -0700)]
sort: fix computation of maxDepth to avoid infinite loop

The current computation loops indefinitely if n > 1<<30 (for 32-bit ints).

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5848067

13 years agocmd/go: use .o, not .{5,6,8}, for gccgo created object files
Ian Lance Taylor [Tue, 20 Mar 2012 21:17:06 +0000 (14:17 -0700)]
cmd/go: use .o, not .{5,6,8}, for gccgo created object files

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5861044

13 years agodoc: general update of gccgo_install
Ian Lance Taylor [Tue, 20 Mar 2012 21:16:34 +0000 (14:16 -0700)]
doc: general update of gccgo_install

Fixes #3325.

R=golang-dev, bradfitz, minux.ma, r
CC=golang-dev
https://golang.org/cl/5858043

13 years agosort: document two undocumented functions
Brad Fitzpatrick [Tue, 20 Mar 2012 18:40:41 +0000 (11:40 -0700)]
sort: document two undocumented functions

They looked out of place in godoc.
Includes documenting sort stability.

Fixes #3356

R=golang-dev, gri, trolleriprofessorn
CC=golang-dev
https://golang.org/cl/5855044

13 years agomisc/cgo/gmp: update for Go 1
Shenghou Ma [Tue, 20 Mar 2012 16:51:48 +0000 (00:51 +0800)]
misc/cgo/gmp: update for Go 1
1. make the program go buildable
2. update os.EINVAL and runtime.Cgocalls()
3. wrap mpz_div_2exp() and mpz_mul_2exp to support both
   pre-5.0 and post-5.0 gmp (we really have no reason to
   restrict ourselves to gmp 5.0+)

R=golang-dev, remyoudompheng, iant
CC=golang-dev
https://golang.org/cl/5847061

13 years agoruntime: remove unused goc2c.c
Shenghou Ma [Tue, 20 Mar 2012 16:49:45 +0000 (00:49 +0800)]
runtime: remove unused goc2c.c
        Its functionality has been moved into cmd/dist.

R=golang-dev, r, iant
CC=golang-dev
https://golang.org/cl/5843062

13 years agobuild: unset GOPATH before tests
Shenghou Ma [Tue, 20 Mar 2012 16:47:27 +0000 (00:47 +0800)]
build: unset GOPATH before tests
This is because we disallow local import for non-local packages, if
GOROOT happens to be under one of GOPATH, then some tests will fail
to build.
Fixes #3337.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5852043

13 years agodoc/debugging_with_gdb: format & content update
Shenghou Ma [Tue, 20 Mar 2012 16:42:53 +0000 (00:42 +0800)]
doc/debugging_with_gdb: format & content update

R=adg, lvd
CC=golang-dev
https://golang.org/cl/5845065

13 years agorun.bat: disable test in test\bench\go1 to fix build
Alex Brainman [Tue, 20 Mar 2012 03:59:51 +0000 (14:59 +1100)]
run.bat: disable test in test\bench\go1 to fix build

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5848066

13 years agoapi: update go1.txt after adding functions to html/template
Rob Pike [Tue, 20 Mar 2012 03:53:18 +0000 (14:53 +1100)]
api: update go1.txt after adding functions to html/template
Fixes build, teaches lesson.

R=golang-dev, r
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/5853051

13 years agohtml/template: add Templates and *Escape functions
Rob Pike [Tue, 20 Mar 2012 03:38:07 +0000 (14:38 +1100)]
html/template: add Templates and *Escape functions
to bring it in line with text/template's interface.
Fixes #3296.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5843066

13 years agocmd/godoc: inform users that the playground doesn't work via local godoc
Andrew Gerrand [Tue, 20 Mar 2012 03:11:38 +0000 (14:11 +1100)]
cmd/godoc: inform users that the playground doesn't work via local godoc

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5843065

13 years agodoc: remove defunct playground.html
Andrew Gerrand [Tue, 20 Mar 2012 03:11:17 +0000 (14:11 +1100)]
doc: remove defunct playground.html

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5846071

13 years agobuild: do more during windows build
Alex Brainman [Tue, 20 Mar 2012 03:04:20 +0000 (14:04 +1100)]
build: do more during windows build

- use GO_GCFLAGS and GO_LDFLAGS if supplied
- build misc\dashboard\builder and misc\goplay
- run tests in test\bench\go1
- check api compatibility

R=golang-dev, r, kardianos, bradfitz
CC=golang-dev
https://golang.org/cl/5847063

13 years agodoc: replace mentions of 6g with gc or the go command
Andrew Gerrand [Tue, 20 Mar 2012 02:50:05 +0000 (13:50 +1100)]
doc: replace mentions of 6g with gc or the go command

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5846070

13 years agomisc/dashboard: remove remnants of package dashboard
Andrew Gerrand [Tue, 20 Mar 2012 02:35:31 +0000 (13:35 +1100)]
misc/dashboard: remove remnants of package dashboard

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5847070

13 years agonet: drop unnecessary type assertions and fix leak in test
Mikio Hara [Tue, 20 Mar 2012 01:57:54 +0000 (10:57 +0900)]
net: drop unnecessary type assertions and fix leak in test

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5847064

13 years agogc: fix struct and array comparisons for new bool rules
Anthony Martin [Mon, 19 Mar 2012 22:57:28 +0000 (15:57 -0700)]
gc: fix struct and array comparisons for new bool rules

The two optimizations for small structs and arrays
were missing the implicit cast from ideal bool.

Fixes #3351.

R=rsc, lvd
CC=golang-dev
https://golang.org/cl/5848062

13 years agocrypto/tls: always send a Certificate message if one was requested.
Adam Langley [Mon, 19 Mar 2012 16:34:35 +0000 (12:34 -0400)]
crypto/tls: always send a Certificate message if one was requested.

If a CertificateRequest is received we have to reply with a
Certificate message, even if we don't have a certificate to offer.

Fixes #3339.

R=golang-dev, r, ality
CC=golang-dev
https://golang.org/cl/5845067

13 years agodoc: update format for "C? Go? Cgo!" article
Shenghou Ma [Mon, 19 Mar 2012 14:54:06 +0000 (22:54 +0800)]
doc: update format for "C? Go? Cgo!" article

R=adg
CC=golang-dev
https://golang.org/cl/5841050

13 years agopath/filepath: implement Match and Glob on windows
Alex Brainman [Mon, 19 Mar 2012 05:51:06 +0000 (16:51 +1100)]
path/filepath: implement Match and Glob on windows

As discussed on golang-dev, windows will use
"\" as path separator. No escaping allowed.

R=golang-dev, r, mattn.jp, rsc, rogpeppe, bsiegert, r
CC=golang-dev
https://golang.org/cl/5825044

13 years agodoc: move sub-repos lower on reference page
Andrew Gerrand [Mon, 19 Mar 2012 02:52:26 +0000 (13:52 +1100)]
doc: move sub-repos lower on reference page

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5846065

13 years agosysycall: remove creds_linux_test.go
Rob Pike [Mon, 19 Mar 2012 00:15:28 +0000 (11:15 +1100)]
sysycall: remove creds_linux_test.go
It is unprecedented to add tests to package syscall, especially
system-specific ones. Not a policy worth changing right before Go 1
is cut.

The sole existing test, passfd_test.go, contains the line
        // +build linux darwin probablyfreebsd probablyopenbsd
which argues that this is not a subject to be undertaking likely.
Note that passfd_test.go also went in just now. It's the only test
in syscall.

Deleting for now, will reconsider after Go 1.

R=golang-dev, bradfitz, r, dsymonds
CC=golang-dev
https://golang.org/cl/5846063

13 years agosyscall: delete passfd_test.go
Rob Pike [Mon, 19 Mar 2012 00:12:32 +0000 (11:12 +1100)]
syscall: delete passfd_test.go

We can revisit the issue of testing in syscall after Go 1.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5844057

13 years agodoc: various typos, remove apostrophes from ordinals
Jeremy Jackins [Sun, 18 Mar 2012 21:26:36 +0000 (08:26 +1100)]
doc: various typos, remove apostrophes from ordinals

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5845059

13 years agosyscall: Test SCM_CREDENTIALS, SO_PASSCRED on Linux.
Albert Strasheim [Sun, 18 Mar 2012 17:03:00 +0000 (10:03 -0700)]
syscall: Test SCM_CREDENTIALS, SO_PASSCRED on Linux.

R=bradfitz, iant
CC=golang-dev
https://golang.org/cl/5846059

13 years agosyscall: add a test for passing an fd over a unix socket
Brad Fitzpatrick [Sun, 18 Mar 2012 05:19:57 +0000 (22:19 -0700)]
syscall: add a test for passing an fd over a unix socket

Updates #1101

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5849057

13 years agobuild: catch API changes during build
Brad Fitzpatrick [Sat, 17 Mar 2012 18:20:46 +0000 (11:20 -0700)]
build: catch API changes during build

Adds new file api/go1.txt, locking down the current API.
Any changes to the API will need to update that file.

run.bash (but not make.bash, or Windows) will check for
accidental API changes.

R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5820070

13 years agospec: delete references to unsafe.Reflect,Typeof,Unreflect
Rob Pike [Sat, 17 Mar 2012 11:50:59 +0000 (22:50 +1100)]
spec: delete references to unsafe.Reflect,Typeof,Unreflect
They have been deleted from package unsafe.
Also delete their appearance in exp/types.

Fixes #3338.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5847056

13 years agodoc/install: remove reference to "Go Tutorial"
Shenghou Ma [Sat, 17 Mar 2012 10:13:02 +0000 (18:13 +0800)]
doc/install: remove reference to "Go Tutorial"

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5841054

13 years agodoc/go_faq: minor update
Shenghou Ma [Sat, 17 Mar 2012 07:53:40 +0000 (15:53 +0800)]
doc/go_faq: minor update

R=adg, r
CC=golang-dev
https://golang.org/cl/5849052

13 years agogodoc: use FormatText for formating code in html template.
Johan Euphrosine [Fri, 16 Mar 2012 22:33:05 +0000 (15:33 -0700)]
godoc: use FormatText for formating code in html template.

R=golang-dev, rsc, r, adg, gri, r
CC=golang-dev
https://golang.org/cl/5835046

13 years agocmd/go: don't add detail to errPrintedOutput
Russ Cox [Fri, 16 Mar 2012 20:35:16 +0000 (16:35 -0400)]
cmd/go: don't add detail to errPrintedOutput

This makes the last error-reporting CL a bit less
aggressive.  errPrintedOutput is a sentinel value
that should not be wrapped.

R=gri
CC=golang-dev
https://golang.org/cl/5845052

13 years agocmd/pack: also recognize '\\' as path separator in filenames
Shenghou Ma [Fri, 16 Mar 2012 17:34:44 +0000 (01:34 +0800)]
cmd/pack: also recognize '\\' as path separator in filenames

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5841051

13 years agogodoc: apply gofmt
Robert Griesemer [Fri, 16 Mar 2012 16:58:23 +0000 (09:58 -0700)]
godoc: apply gofmt

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5842043

13 years agomake.bat: don't show error message if old generated files do not exist
Shenghou Ma [Fri, 16 Mar 2012 16:32:48 +0000 (00:32 +0800)]
make.bat: don't show error message if old generated files do not exist

R=golang-dev, alex.brainman, mattn.jp
CC=golang-dev
https://golang.org/cl/5843045

13 years agocmd/go: add -fno-common by default on Darwin
Shenghou Ma [Fri, 16 Mar 2012 16:05:09 +0000 (12:05 -0400)]
cmd/go: add -fno-common by default on Darwin
        Fixes part of issue 3253.
        We still need to support scattered relocations though.

R=golang-dev, bsiegert, rsc, iant
CC=golang-dev
https://golang.org/cl/5822050

13 years agocmd/go: work around occasional ETXTBSY running cgo
Russ Cox [Fri, 16 Mar 2012 14:44:09 +0000 (10:44 -0400)]
cmd/go: work around occasional ETXTBSY running cgo

Fixes #3001.  (This time for sure!)

R=golang-dev, r, fullung
CC=golang-dev
https://golang.org/cl/5845044

13 years agoreflect: panic if MakeSlice is given bad len/cap arguments.
David Symonds [Fri, 16 Mar 2012 06:28:16 +0000 (17:28 +1100)]
reflect: panic if MakeSlice is given bad len/cap arguments.

Fixes #3330.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5847043

13 years agomake.bat: Fix for old files
Christopher Redden [Fri, 16 Mar 2012 03:30:43 +0000 (14:30 +1100)]
make.bat: Fix for old files

Same fix as applied here: https://golang.org/cl/5761044

Fixes #3222.

R=golang-dev, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5838043

13 years agodoc: use time.Duration in Effective Go.
David Symonds [Fri, 16 Mar 2012 03:27:11 +0000 (14:27 +1100)]
doc: use time.Duration in Effective Go.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5841044

13 years agoA+C: Christopher Redden (individual CLA)
Russ Cox [Fri, 16 Mar 2012 03:15:38 +0000 (23:15 -0400)]
A+C: Christopher Redden (individual CLA)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5845043

13 years agoruntime: do not handle signals before configuring handler
Russ Cox [Fri, 16 Mar 2012 02:17:54 +0000 (22:17 -0400)]
runtime: do not handle signals before configuring handler

There was a small window during program initialization
where a signal could come in before the handling mechanisms
were set up to handle it.  Delay the signal-handler installation
until we're ready for the signals.

Fixes #3314.

R=golang-dev, dsymonds, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5833049

13 years agocmd/gofmt: show ascii in usage.
Yasuhiro Matsumoto [Thu, 15 Mar 2012 23:38:27 +0000 (16:38 -0700)]
cmd/gofmt: show ascii in usage.
windows cmd.exe can't show utf-8 correctly basically.
chcp 65001 may make it show, but most people don't have fonts which can
show it.

R=golang-dev, rsc, adg, gri, r
CC=golang-dev
https://golang.org/cl/5820060

13 years agocmd/cgo: add support for function export for gccgo.
Rémy Oudompheng [Thu, 15 Mar 2012 22:50:25 +0000 (23:50 +0100)]
cmd/cgo: add support for function export for gccgo.

A "gccgoprefix" flag is added and used by the go tool,
to mirror the -fgo-prefix flag for gccgo, whose value
is required to know how to access functions from C.

Trying to export Go methods or unexported Go functions
will not work.

Also fix go test on "main" packages.

Updates #2313.
Fixes #3262.

R=mpimenov, rsc, iant
CC=golang-dev
https://golang.org/cl/5797046

13 years agomisc/dist: don't ship cmd/cov or cmd/prof
Brad Fitzpatrick [Thu, 15 Mar 2012 22:22:56 +0000 (15:22 -0700)]
misc/dist: don't ship cmd/cov or cmd/prof

Fixes #3317

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5784083

13 years agocmd/go: quiet some logging
Brad Fitzpatrick [Thu, 15 Mar 2012 22:10:01 +0000 (15:10 -0700)]
cmd/go: quiet some logging

This should've been behind -v before but was missed.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5836046

13 years agoruntime: fix arm build
Russ Cox [Thu, 15 Mar 2012 21:40:17 +0000 (17:40 -0400)]
runtime: fix arm build

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/5832047

13 years agocmd/go: make build errors more visible
Russ Cox [Thu, 15 Mar 2012 21:35:57 +0000 (17:35 -0400)]
cmd/go: make build errors more visible

Fixes #3324.

Robert suggested not reporting errors until the end of the output.
which I'd also like to do, but errPrintedOutput makes that a bigger
change than I want to do before Go 1.  This change should at least
remove the confusion we had.

# Building packages and commands for linux/amd64.
runtime
errors
sync/atomic
unicode
unicode/utf8
math
sync
unicode/utf16
crypto/subtle
io
syscall
hash
crypto
crypto/md5
hash/crc32
crypto/cipher
crypto/hmac
crypto/sha1
go install unicode: copying /tmp/go-build816525784/unicode.a to /home/rsc/g/go/pkg/linux_amd64/unicode.a: short write
hash/adler32
container/list
container/ring
...

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5837054

13 years agodoc: add Gobs of data article
Francisco Souza [Thu, 15 Mar 2012 21:21:13 +0000 (08:21 +1100)]
doc: add Gobs of data article

Originally published on The Go Programming Language Blog, March 24, 2011.

http://blog.golang.org/2011/03/gobs-of-data.html

R=adg
CC=golang-dev
https://golang.org/cl/5834043

13 years agomisc/dashboard: remove old python package dashboard
Andrew Gerrand [Thu, 15 Mar 2012 21:20:02 +0000 (08:20 +1100)]
misc/dashboard: remove old python package dashboard

This leaves only the project page, which now resides at the web root.

R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/5833044

13 years agoreflect: document PkgPath, Method, StructField
Russ Cox [Thu, 15 Mar 2012 21:15:57 +0000 (17:15 -0400)]
reflect: document PkgPath, Method, StructField

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5824053

13 years ago5l, 6l, 8l: fix stack split logic for stacks near default segment size
Russ Cox [Thu, 15 Mar 2012 19:22:30 +0000 (15:22 -0400)]
5l, 6l, 8l: fix stack split logic for stacks near default segment size

Fixes #3310.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5823051

13 years agoos: do not assume syscall.Write will write everything
Russ Cox [Thu, 15 Mar 2012 19:10:19 +0000 (15:10 -0400)]
os: do not assume syscall.Write will write everything

Fixes #3323.

R=golang-dev, remyoudompheng, gri
CC=golang-dev
https://golang.org/cl/5837047

13 years agogo/build: do not report Target for local imports
Russ Cox [Thu, 15 Mar 2012 19:08:57 +0000 (15:08 -0400)]
go/build: do not report Target for local imports

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5820064

13 years agolib/godoc: removing leading / from search links
Russ Cox [Thu, 15 Mar 2012 18:50:51 +0000 (14:50 -0400)]
lib/godoc: removing leading / from search links

srcLink includes the / now; adding another yields //,
which means something else entirely in URLs.

Fixes #3327.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5823060

13 years agodoc: add missing quotation mark
Stefan Nilsson [Thu, 15 Mar 2012 18:06:15 +0000 (14:06 -0400)]
doc: add missing quotation mark

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5833047

13 years agonet/http: couple more triv.go modernizations
Brad Fitzpatrick [Thu, 15 Mar 2012 17:06:25 +0000 (10:06 -0700)]
net/http: couple more triv.go modernizations

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5834049

13 years agodoc/play: use []rune insetead of []int.
Yasuhiro Matsumoto [Thu, 15 Mar 2012 08:28:07 +0000 (19:28 +1100)]
doc/play: use []rune insetead of []int.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5823058

13 years agocmd/godoc: add toys, tour button to playground
Andrew Gerrand [Thu, 15 Mar 2012 06:44:47 +0000 (17:44 +1100)]
cmd/godoc: add toys, tour button to playground

Fixes #3241.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5835043

13 years agoos: return some invented data from Stat(DevNull) on windows
Alex Brainman [Thu, 15 Mar 2012 05:33:45 +0000 (16:33 +1100)]
os: return some invented data from Stat(DevNull) on windows

Fixes #3321.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5831043

13 years agodoc: add "Godoc: documenting Go code" article
Francisco Souza [Thu, 15 Mar 2012 03:51:44 +0000 (14:51 +1100)]
doc: add "Godoc: documenting Go code" article

Originally published on The Go Programming Language Blog, March 31, 2011.

http://blog.golang.org/2011/03/godoc-documenting-go-code.html

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5830043

13 years agonet/http: ensure triv.go compiles and runs
Robert Hencke [Thu, 15 Mar 2012 03:25:57 +0000 (20:25 -0700)]
net/http: ensure triv.go compiles and runs

R=golang-dev, bradfitz, dsymonds, dave, r
CC=golang-dev
https://golang.org/cl/5795069

13 years agocmd/godoc: use *goroot as base path in zip file
Andrew Gerrand [Thu, 15 Mar 2012 00:31:16 +0000 (11:31 +1100)]
cmd/godoc: use *goroot as base path in zip file

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5781069

13 years agodoc: add reference to FAQ to explain warning about concrete type
Stefan Nilsson [Wed, 14 Mar 2012 22:15:16 +0000 (09:15 +1100)]
doc: add reference to FAQ to explain warning about concrete type

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5820048