]>
Cypherpunks repositories - gostls13.git/log
Rob Pike [Fri, 21 Sep 2012 19:53:51 +0000 (05:53 +1000)]
[release-branch.go1] fmt: set p.field before nil check
««« backport
5f13e0662e38
fmt: set p.field before nil check
Fixes #3752.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6331062
»»»
Andrew Gerrand [Fri, 21 Sep 2012 19:53:51 +0000 (05:53 +1000)]
[release-branch.go1] doc: drop video title from homepage
««« backport
9da3902443ca
doc: drop video title from homepage
It's just stutter.
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/
6334053
»»»
Russ Cox [Fri, 21 Sep 2012 19:53:50 +0000 (05:53 +1000)]
[release-branch.go1] A+C: Jonathan Gold (individual CLA)
««« backport
ee62927ec779
A+C: Jonathan Gold (individual CLA)
This is my last one for today, I hope!
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6339052
»»»
Russ Cox [Fri, 21 Sep 2012 19:53:50 +0000 (05:53 +1000)]
[release-branch.go1] A+C: add Michael Stapelberg (individual CLA)
««« backport
04f61caa80cd
A+C: add Michael Stapelberg (individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6325058
»»»
Pieter Droogendijk [Fri, 21 Sep 2012 19:53:49 +0000 (05:53 +1000)]
[release-branch.go1] go/build: fix doc typo
««« backport
e12419d09635
go/build: fix doc typo
go/build section "Build Constraints", first paragraph said:
"... they must be appear near the top of the file ..."
fixed to:
"... they must appear near the top of the file ..."
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6329060
»»»
Amir Mohammad Saied [Fri, 21 Sep 2012 19:53:49 +0000 (05:53 +1000)]
[release-branch.go1] misc/chrome/gophertool: Support for manifest version 1 is being phased out.
««« backport
0f017230e6b4
misc/chrome/gophertool: Support for manifest version 1 is being phased out.
Manifest version 1 was deprecated in Chrome 18, and support will be phased
out according to the schedule available at:
http://code.google.com/chrome/extensions/manifestVersion.html
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6332053
»»»
Russ Cox [Fri, 21 Sep 2012 19:53:48 +0000 (05:53 +1000)]
[release-branch.go1] A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA)
««« backport
565770878659
A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6330059
»»»
Robert Griesemer [Fri, 21 Sep 2012 19:53:48 +0000 (05:53 +1000)]
[release-branch.go1] spec: clarify receive operator
««« backport
c72ac7873261
spec: clarify receive operator
- receiving from a closed channel returns immediately
- in the ,ok form, the 2nd result is of type bool, not
just boolean (gc and ggcgo agree).
Per dsymonds' suggestion.
R=r, rsc, ken, iant, dsymonds
CC=golang-dev
https://golang.org/cl/
6333057
»»»
Russ Cox [Fri, 21 Sep 2012 19:53:47 +0000 (05:53 +1000)]
[release-branch.go1] runtime: detect hash map collision problems
««« backport
f99b9475b914
runtime: detect hash map collision problems
This can only happen if the hash function we're using is getting
far more than it's fair share of collisions, but that has happened
to us repeatedly as we've expanded the allowed use cases for
hash tables (issue 1544, issue 2609, issue 2630, issue 2883, issue 3695).
Maybe this will help the next time we try something new.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6306083
»»»
Han-Wen Nienhuys [Fri, 21 Sep 2012 19:53:47 +0000 (05:53 +1000)]
[release-branch.go1] os: make POSIX StartProcess work with chroot again.
««« backport
2aaa88600d48
os: make POSIX StartProcess work with chroot again.
Skip directory check in startProcess in the presence of
SysProcAttr.
Fixes #3649.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6297083
»»»
Russ Cox [Fri, 21 Sep 2012 19:53:46 +0000 (05:53 +1000)]
[release-branch.go1] CONTRIBUTORS: add Han-Wen Nienhuys (Google CLA)
««« backport
d4b91c10aa5e
CONTRIBUTORS: add Han-Wen Nienhuys (Google CLA)
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6327054
»»»
Dave Cheney [Fri, 21 Sep 2012 19:53:46 +0000 (05:53 +1000)]
[release-branch.go1] runtime: avoid r9/r10 during memmove
««« backport
5ca8acc84025
runtime: avoid r9/r10 during memmove
Fixes #3718.
Requires CL
6300043 .
R=rsc, minux.ma, extraterrestrial.neighbour
CC=golang-dev
https://golang.org/cl/
6305100
»»»
Dave Cheney [Fri, 21 Sep 2012 19:53:45 +0000 (05:53 +1000)]
[release-branch.go1] runtime: avoid r9/r10 during memset
««« backport
572efb136b1a
runtime: avoid r9/r10 during memset
Partially fixes issue 3718.
R=golang-dev, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/
6300043
»»»
David Symonds [Fri, 21 Sep 2012 19:53:45 +0000 (05:53 +1000)]
[release-branch.go1] flag: fix indexing doc.
««« backport
6ca4825bc867
flag: fix indexing doc.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6341046
»»»
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:45 +0000 (05:53 +1000)]
[release-branch.go1] net/http: fix doc inaccuracy and typo; tighten test
««« backport
60041e23de38
net/http: fix doc inaccuracy and typo; tighten test
Note url.Error wrapping, and s/issue/issuing/.
Fixes #3724
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6294093
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:44 +0000 (05:53 +1000)]
[release-branch.go1] runtime: fix struct Sigaction for Linux/386
««« backport
645947213cac
runtime: fix struct Sigaction for Linux/386
We need to use kernel headers to generate defs_linux_$GOARCH.h
R=golang-dev, dave, alex.brainman, iant
CC=golang-dev
https://golang.org/cl/
6296091
»»»
David G. Andersen [Fri, 21 Sep 2012 19:53:44 +0000 (05:53 +1000)]
[release-branch.go1] net/rpc: fix typo in documentation, clarify semantics of error return
««« backport
ef713d7587f2
net/rpc: fix typo in documentation, clarify semantics of error return
Several of my students were confused by trying to use both the error
return and a reply return, so I figured it was worth explicitly clarifying
that returning an error overrides the reply.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6327051
»»»
David G. Andersen [Fri, 21 Sep 2012 19:53:43 +0000 (05:53 +1000)]
[release-branch.go1] encoding/json: fix minor typo in documentation for Marshal
««« backport
093dcfc4d307
encoding/json: fix minor typo in documentation for Marshal
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6325053
»»»
Andrew Gerrand [Fri, 21 Sep 2012 19:53:43 +0000 (05:53 +1000)]
[release-branch.go1] doc: put A Tour of Go video on the front page
««« backport
a95bedca6dae
doc: put A Tour of Go video on the front page
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6337047
»»»
Mats Lidell [Fri, 21 Sep 2012 19:53:42 +0000 (05:53 +1000)]
[release-branch.go1] misc/emacs: Replace replace-{string|regexp} for XEmacs compatible code
««« backport
d730d2e4733d
misc/emacs: Replace replace-{string|regexp} for XEmacs compatible code
Use code to be used in lisp programs as suggested in the doc strings for
replace-{string|regexp}. Bonus: This code works for XEmacs.
R=golang-dev, sameer, jmeurin
CC=golang-dev
https://golang.org/cl/
6296073
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:42 +0000 (05:53 +1000)]
[release-branch.go1] doc/articles/slices_usage_and_internals: fix typo
««« backport
5b56c2c0597f
doc/articles/slices_usage_and_internals: fix typo
Fixes #3753.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6304097
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:41 +0000 (05:53 +1000)]
[release-branch.go1] runtime: fix struct Sigaction for Linux/ARM
««« backport
6eefce99091e
runtime: fix struct Sigaction for Linux/ARM
if we were to use sizeof(sa.sa_mask) instead of 8 as the last argument
to rt_sigaction, we would have already fixed this bug, so also updated
Linux/386 and Linux/amd64 files to use that; also test the return value
of rt_sigaction.
R=dave, rsc
CC=golang-dev
https://golang.org/cl/
6297087
»»»
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:41 +0000 (05:53 +1000)]
[release-branch.go1] net/http: clarify client return values in docs
««« backport
f7839a55036e
net/http: clarify client return values in docs
Also, fixes one violation found during testing where both
response and error could be non-nil when a CheckRedirect test
failed. This is arguably a minor API (behavior, not
signature) change, but it wasn't documented either way and was
inconsistent & non-Go like. Any code depending on the old
behavior was wrong anyway.
R=adg, rsc
CC=golang-dev
https://golang.org/cl/
6307088
»»»
Robert Griesemer [Fri, 21 Sep 2012 19:53:40 +0000 (05:53 +1000)]
[release-branch.go1] go/ast: multiple "blank" imports are permitted
««« backport
2033e1b11a20
go/ast: multiple "blank" imports are permitted
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/
6303099
»»»
Marcel van Lohuizen [Fri, 21 Sep 2012 19:53:40 +0000 (05:53 +1000)]
[release-branch.go1] bytes: fixed typo.
««« backport
a3c2d3c41c45
bytes: fixed typo.
R=r
CC=golang-dev
https://golang.org/cl/
6301096
»»»
Adam Langley [Fri, 21 Sep 2012 19:53:39 +0000 (05:53 +1000)]
[release-branch.go1] A+C: Christine Hansmann (individual CLA)
««« backport
4086a221c497
A+C: Christine Hansmann (individual CLA)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6312045
»»»
Robert Griesemer [Fri, 21 Sep 2012 19:53:39 +0000 (05:53 +1000)]
[release-branch.go1] go/ast: Walk: do not walk comment list
««« backport
5e3661048f2e
go/ast: Walk: do not walk comment list
A comment to that effect was introduced
with rev
d332f4b9cef5 but the respective
code wasn't deleted.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6304086
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:39 +0000 (05:53 +1000)]
[release-branch.go1] doc: delete Mercurial Queues doc
««« backport
47e7c99fbe87
doc: delete Mercurial Queues doc
Fixes #3716.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6310044
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:38 +0000 (05:53 +1000)]
[release-branch.go1] crypto/elliptic: fix doc typo
««« backport
9f9c0363f0ed
crypto/elliptic: fix doc typo
Fixes #3735.
R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/
6301083
»»»
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:38 +0000 (05:53 +1000)]
[release-branch.go1] net/http: use index.html modtime (not directory) for If-Modified-Since
««« backport
c536f328c34b
net/http: use index.html modtime (not directory) for If-Modified-Since
Thanks to Håvid Falch for finding the problem.
Fixes #3414
R=r, rsc
CC=golang-dev
https://golang.org/cl/
6300081
»»»
Russ Cox [Fri, 21 Sep 2012 19:53:37 +0000 (05:53 +1000)]
[release-branch.go1] runtime: replace runtime·rnd function with ROUND macro
««« backport
722bb90ae3ee
runtime: replace runtime·rnd function with ROUND macro
It's sad to introduce a new macro, but rnd shows up consistently
in profiles, and the function call overwhelms the two arithmetic
instructions it performs.
R=r
CC=golang-dev
https://golang.org/cl/
6260051
»»»
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:37 +0000 (05:53 +1000)]
[release-branch.go1] net/http: fix response Connection: close, close client connections
««« backport
4c333000f50b
net/http: fix response Connection: close, close client connections
Fixes #3663
Updates #3540 (fixes it more)
Updates #1967 (fixes it more, re-enables a test)
R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/
6213064
»»»
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:36 +0000 (05:53 +1000)]
[release-branch.go1] net/http: fix regression and mute known test failure for now
««« backport
c3cbd6798cc7
net/http: fix regression and mute known test failure for now
Two tests added in
820ffde8c are expected to fail until the fix
for Issue 3540 goes back in (pending Windows net fixes), so
make those tests just Logf for now, with a TODO to re-enable.
Add a new client test.
Rearrange the transport code to be more readable, and fix the
bug from
820ffde8c where the persistConn was being closed before
the body was fully ready.
Fixes #3644
Updates #1967 (not yet fixed, but should be after Issue 3540)
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6211069
»»»
James Gray [Fri, 21 Sep 2012 19:53:36 +0000 (05:53 +1000)]
[release-branch.go1] net/http: non-keepalive connections close successfully
««« backport
820ffde8c396
net/http: non-keepalive connections close successfully
Connections did not close if Request.Close or Response.Close was true. This meant that if the user wanted the connection to close, or if the server requested it via "Connection: close", the connection would not be closed.
Fixes #1967.
R=golang-dev, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/
6201044
»»»
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:35 +0000 (05:53 +1000)]
[release-branch.go1] net/http: ignore paths on CONNECT requests in ServeMux
««« backport
8eae6e390d20
net/http: ignore paths on CONNECT requests in ServeMux
Fixes #3538
R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/
6117058
»»»
Anthony Martin [Fri, 21 Sep 2012 19:53:35 +0000 (05:53 +1000)]
[release-branch.go1] os: avoid panic when testing errors on Plan 9
««« backport
99b8351bfb9e
os: avoid panic when testing errors on Plan 9
R=golang-dev, bradfitz, akumar
CC=golang-dev
https://golang.org/cl/
6017043
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:34 +0000 (05:53 +1000)]
[release-branch.go1] 5c, 6c, 8c: take GOROOT_FINAL into consideration
««« backport
016c4fefed77
5c, 6c, 8c: take GOROOT_FINAL into consideration
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
5936050
»»»
Shenghou Ma [Fri, 21 Sep 2012 19:53:32 +0000 (05:53 +1000)]
[release-branch.go1] 5a, 6a, 8a: take GOROOT_FINAL into consideration
««« backport
a608a03df703
5a, 6a, 8a: take GOROOT_FINAL into consideration
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
5940052
»»»
Andrew Gerrand [Thu, 14 Jun 2012 02:50:42 +0000 (12:50 +1000)]
[release-branch.go1] syscall: fix windows build
««« CL
6303061 /
17432a753e50
syscall: fix windows build
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/
6303061
»»»
R=golang-dev
CC=golang-dev
https://golang.org/cl/
6295080
Russ Cox [Thu, 14 Jun 2012 02:06:57 +0000 (22:06 -0400)]
[release-branch.go1] syscall: fix GetCurrentProcessId symbol name on Windows
Andrew Gerrand [Thu, 14 Jun 2012 01:50:00 +0000 (11:50 +1000)]
[release-branch.go1] doc: document go1.0.2
««« CL
6298079 /
a19665fe6f33
doc: document go1.0.2
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/
6298079
»»»
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6302076
Russ Cox [Wed, 13 Jun 2012 20:25:02 +0000 (16:25 -0400)]
[release-branch.go1] update VERSION to go1.0.2
Russ Cox [Wed, 13 Jun 2012 20:25:01 +0000 (16:25 -0400)]
[release-branch.go1] syscall: unexport GetCurrentProcessId on Windows
Jan Ziak [Wed, 13 Jun 2012 20:25:00 +0000 (16:25 -0400)]
[release-branch.go1] runtime: improved continuity in hash computation
««« backport
c8d163b7930e
runtime: improved continuity in hash computation
Fixes #3695.
R=r, dave, rsc
CC=golang-dev
https://golang.org/cl/
6304062
»»»
Jean-Marc Eurin [Wed, 13 Jun 2012 20:25:00 +0000 (16:25 -0400)]
[release-branch.go1] misc/emacs: Fix a failure when /tmp/<file>.go exists.
««« backport
903a3cdd92cf
misc/emacs: Fix a failure when /tmp/<file>.go exists.
R=sameer
CC=golang-dev
https://golang.org/cl/
6296060
»»»
Jean-Marc Eurin [Wed, 13 Jun 2012 20:24:59 +0000 (16:24 -0400)]
[release-branch.go1] misc/emacs: Fix the automatic gofmt when creating a new file.
««« backport
5b4920fe3605
misc/emacs: Fix the automatic gofmt when creating a new file.
Patching the buffer with the output from gofmt -d only works if
the file already exists. If it doesn't, replace the content with
the output of gofmt.
R=sameer
CC=golang-dev
https://golang.org/cl/
6302063
»»»
Brad Fitzpatrick [Wed, 13 Jun 2012 20:24:58 +0000 (16:24 -0400)]
[release-branch.go1] encoding/gob: fix doc typo
««« backport
d34766b79c5e
encoding/gob: fix doc typo
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6300078
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:57 +0000 (16:24 -0400)]
[release-branch.go1] syscall: revert API changes in Windows Win32finddata fix.
««« backport
7a7a91c3da32
syscall: revert API changes in Windows Win32finddata fix.
Preserve old API by using correct struct in system call
and then copying the results, as we did for SetsockoptLinger.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6307065
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:56 +0000 (16:24 -0400)]
[release-branch.go1] cmd/api: handle empty API file, ignore -next in release
««« backport
8e7ad2db0833
cmd/api: handle empty API file, ignore -next in release
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6298063
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:55 +0000 (16:24 -0400)]
[release-branch.go1] regexp/syntax: unexport ErrUnexpectedParen
««« backport
b4cdcec897fb
regexp/syntax: unexport ErrUnexpectedParen
This new error is the only API change in the current draft of
Go 1.0.2 CLs. I'd like to include the CL that introduced it,
because it replaces a mysterious 'internal error' with a
useful error message, but I don't want any API changes,
so unexport the error constant for now. It can be
re-exported for Go 1.1.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6294055
»»»
Dave Cheney [Wed, 13 Jun 2012 20:24:54 +0000 (16:24 -0400)]
[release-branch.go1] cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin
««« backport
432f2b7f5458
cmd/5c, cmd/5g, cmd/5l: fix cross compilation failure on darwin
Fixes #3708.
The fix to allow 5{c,g,l} to compile under clang 3.1 broke cross
compilation on darwin using the Apple default compiler on 10.7.3.
This failure was introduced in
9b455eb64690 .
This has been tested by cross compiling on darwin/amd64 to linux/arm using
* gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00)
* clang version 3.1 (branches/release_31)
As well as on linux/arm using
* gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
* Ubuntu clang version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0)
* Debian clang version 3.1-4 (branches/release_31) (based on LLVM 3.1)
R=consalus, rsc
CC=golang-dev
https://golang.org/cl/
6307058
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:54 +0000 (16:24 -0400)]
[release-branch.go1] cmd/cgo: make Go code order deterministic
««« backport
319a9f3330d0
cmd/cgo: make Go code order deterministic
The type declarations were being generated using
a range over a map, which meant that successive
runs produced different orders. This will make sure
successive runs produce the same files.
Fixes #3707.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6300062
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:53 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: limit data disassembly to -SS
««« backport
14ce24bcd818
cmd/gc: limit data disassembly to -SS
This makes -S useful again.
R=ken2
CC=golang-dev
https://golang.org/cl/
6302054
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:52 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: fix LEAQ $0, SI bug
««« backport
c4a344d25b87
cmd/gc: fix LEAQ $0, SI bug
Cannot take effective address of constant.
Fixes #3670.
R=ken2
CC=golang-dev
https://golang.org/cl/
6299055
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:51 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: fix type checking loop
««« backport
e69400ace361
cmd/gc: fix type checking loop
CL
4313064 fixed its test case but did not address a
general enough problem:
type T1 struct { F *T2 }
type T2 T1
type T3 T2
could still end up copying the definition of T1 for T2
before T1 was done being evaluated, or T3 before T2
was done.
In order to propagate the updates correctly,
record a copy of an incomplete type for re-execution
once the type is completed. Roll back CL
4313064 .
Fixes #3709.
R=ken2
CC=golang-dev, lstoakes
https://golang.org/cl/
6301059
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:50 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: delete dead code
««« backport
721d528a4e91
cmd/gc: delete dead code
R=ken2
CC=golang-dev
https://golang.org/cl/
6307050
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:49 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: do not crash on struct with _ field
««« backport
af07f1cd12dc
cmd/gc: do not crash on struct with _ field
Fixes #3607.
R=ken2
CC=golang-dev
https://golang.org/cl/
6296052
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:49 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: preserve side effects during inlining of function with _ argument
««« backport
0ba8e27c7b87
cmd/gc: preserve side effects during inlining of function with _ argument
Fixes #3593.
R=ken2
CC=golang-dev, lvd
https://golang.org/cl/
6305061
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:48 +0000 (16:24 -0400)]
[release-branch.go1] encoding/json: fix panic unmarshaling into non-nil interface value
««« backport
bee83c1509a3
encoding/json: fix panic unmarshaling into non-nil interface value
Fixes #3614.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6306051
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:47 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: mark output of typename as type-checked
««« backport
d39a44280dd3
cmd/gc: mark output of typename as type-checked
R=ken2
CC=golang-dev
https://golang.org/cl/
6302051
»»»
Daniel Morsing [Wed, 13 Jun 2012 20:24:46 +0000 (16:24 -0400)]
[release-branch.go1] fmt: fix doc typo
««« backport
76f136192aac
fmt: fix doc typo
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6308046
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:45 +0000 (16:24 -0400)]
[release-branch.go1] A+C: Daniel Morsing (individual CLA)
««« backport
a47632179cb7
A+C: Daniel Morsing (individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6307048
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:44 +0000 (16:24 -0400)]
[release-branch.go1] A+C: Markus Sonderegger (individual CLA)
««« backport
a6e2b17a16d7
A+C: Markus Sonderegger (individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6303047
»»»
Shenghou Ma [Wed, 13 Jun 2012 20:24:44 +0000 (16:24 -0400)]
[release-branch.go1] build: restore PATH before "dist banner"
««« backport
2787cca7ac8f
build: restore PATH before "dist banner"
Fixes #3699.
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/
6272048
»»»
Dave Cheney [Wed, 13 Jun 2012 20:24:43 +0000 (16:24 -0400)]
[release-branch.go1] cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1
««« backport
9b455eb64690
cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1
This should be the last of them.
R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/
6297043
»»»
Rémy Oudompheng [Wed, 13 Jun 2012 20:24:42 +0000 (16:24 -0400)]
[release-branch.go1] cmd/[568]g: correct freeing of allocated Regs.
««« backport
f1028a23b059
cmd/[568]g: correct freeing of allocated Regs.
R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/
6281050
»»»
Robert Griesemer [Wed, 13 Jun 2012 20:24:41 +0000 (16:24 -0400)]
[release-branch.go1] go spec: clarify promotion rules for methods/fields of anonymous fields
««« backport
ae0301294b9b
go spec: clarify promotion rules for methods/fields of anonymous fields
Fixes #3635.
R=rsc, r, iant, kevlar, iant
CC=golang-dev
https://golang.org/cl/
6217045
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:40 +0000 (16:24 -0400)]
[release-branch.go1] doc/install: we don't print 'The compiler is 6g' anymore
««« backport
008b163fb38a
doc/install: we don't print 'The compiler is 6g' anymore
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6273050
»»»
Ryan Barrett [Wed, 13 Jun 2012 20:24:40 +0000 (16:24 -0400)]
[release-branch.go1] misc/emacs: make compilation-mode's next-error understand test failure output.
««« backport
f469c9d212c4
misc/emacs: make compilation-mode's next-error understand test failure output.
specifically, adds a go-test element to compilation-error-regexp-alist[-alist].
Fixes #3629.
R=golang-dev, rsc, sameer
CC=golang-dev, jba
https://golang.org/cl/
6197091
»»»
Shenghou Ma [Wed, 13 Jun 2012 20:24:39 +0000 (16:24 -0400)]
[release-branch.go1] api: add Linux/ARM to go1 API
««« backport
5538444d6f32
api: add Linux/ARM to go1 API
It's very unfortunate that the type of Data field of struct
RawSockaddr is [14]uint8 on Linux/ARM instead of [14]int8
on all the others.
btw, it should be [14]int8 according to my header files.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6275050
»»»
Mikio Hara [Wed, 13 Jun 2012 20:24:38 +0000 (16:24 -0400)]
[release-branch.go1] path/filepath: fix test
««« backport
912fdfb20cc6
path/filepath: fix test
Make it possible to run test over symlinked GOROOT.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6268046
»»»
Alex Brainman [Wed, 13 Jun 2012 20:24:37 +0000 (16:24 -0400)]
[release-branch.go1] syscall: correct Win32finddata definition
««« backport
45d1063d8520
syscall: correct Win32finddata definition
Fixes #3685.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6261053
»»»
Shenghou Ma [Wed, 13 Jun 2012 20:24:36 +0000 (16:24 -0400)]
[release-branch.go1] syscall: fix 32-bit uid calls
««« backport
31e36672e3df
syscall: fix 32-bit uid calls
16-bit uid calls are not always supported in newer kernels.
R=dave, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/
6279047
»»»
Jan Mercl [Wed, 13 Jun 2012 20:24:35 +0000 (16:24 -0400)]
[release-branch.go1] path/filepath: implement documented SkipDir behavior
««« backport
4ef88bab4b0d
path/filepath: implement documented SkipDir behavior
Currently walk() doesn't check for err == SkipDir when iterating
a directory list, but such promise is made in the docs for WalkFunc.
Fixes #3486.
R=rsc, r
CC=golang-dev
https://golang.org/cl/
6257059
»»»
Brad Fitzpatrick [Wed, 13 Jun 2012 20:24:34 +0000 (16:24 -0400)]
[release-branch.go1] api: add FreeBSD to go1 API
««« backport
d8e47164f8dd
api: add FreeBSD to go1 API
Now that gri has made go/parser 15% faster, I offer this
change to slow back down cmd/api ~proportionately, adding
FreeBSD to the go1-checked set of platforms.
Really we should have done this earlier. This will prevent us
from breaking FreeBSD compatibility accidentally in the
future.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6279044
»»»
Ryan Barrett [Wed, 13 Jun 2012 20:24:34 +0000 (16:24 -0400)]
[release-branch.go1] misc/emacs: stop go-mode from spuriously marking the buffer modified when it loads
««« backport
f0fc2ba71361
misc/emacs: stop go-mode from spuriously marking the buffer modified when it loads
R=golang-dev, sameer, bradfitz
CC=golang-dev, jba
https://golang.org/cl/
6213056
»»»
Sameer Ajmani [Wed, 13 Jun 2012 20:24:33 +0000 (16:24 -0400)]
[release-branch.go1] CONTRIBUTORS: Add Ryan Barrett (Google CLA)
««« backport
d7030ef36339
CONTRIBUTORS: Add Ryan Barrett (Google CLA)
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6244071
»»»
Rob Pike [Wed, 13 Jun 2012 20:24:32 +0000 (16:24 -0400)]
[release-branch.go1] regexp: fix a couple of bugs in the documentation
««« backport
97295af6ee9b
regexp: fix a couple of bugs in the documentation
Byte slices are not strings.
Fixes #3687.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6257074
»»»
Ivan Krasin [Wed, 13 Jun 2012 20:24:31 +0000 (16:24 -0400)]
[release-branch.go1] compress/flate: fix overflow on 2GB input. Reset hashOffset every 16 MB.
««« backport
00a1ca1ea3bd
compress/flate: fix overflow on 2GB input. Reset hashOffset every 16 MB.
This bug has been introduced in the following revision:
changeset: 11404:
26dceba5c610
user: Ivan Krasin <krasin@golang.org>
date: Mon Jan 23 09:19:39 2012 -0500
summary: compress/flate: reduce memory pressure at cost of additional arithmetic operation.
This is the review page for that CL: https://golang.org/cl/
5555070 /
R=rsc, imkrasin
CC=golang-dev
https://golang.org/cl/
6249067
»»»
Mats Lidell [Wed, 13 Jun 2012 20:24:30 +0000 (16:24 -0400)]
[release-branch.go1] go-mode: Works for both GNU-Emacs and XEmacs-21.5
««« backport
83f7ee1fa792
go-mode: Works for both GNU-Emacs and XEmacs-21.5
Fixes some portability issues between the Emacsen.
R=golang-dev, sameer, bradfitz, ryanb
CC=golang-dev
https://golang.org/cl/
6206043
»»»
Sameer Ajmani [Wed, 13 Jun 2012 20:24:30 +0000 (16:24 -0400)]
[release-branch.go1] A+C: add Mats Lidell. He signed the agreement with the Sweden email
««« backport
700728feacc8
A+C: add Mats Lidell. He signed the agreement with the Sweden email
address, but his changelist is under the Gmail address.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6248069
»»»
Jean-Marc Eurin [Wed, 13 Jun 2012 20:24:29 +0000 (16:24 -0400)]
[release-branch.go1] misc/emacs: Use patch output of gofmt instead of replacing the buffer.
««« backport
6c2e9ed1f714
misc/emacs: Use patch output of gofmt instead of replacing the buffer.
This uses the patch output of gofmt (-d option) and applies each
chunk to the buffer, instead of replacing the whole buffer. The
main advantage is that the undo history is kept across gofmt'ings,
so it can really be used as a before-save-hook.
R=sameer, sameer
CC=golang-dev
https://golang.org/cl/
6198047
»»»
Rémy Oudompheng [Wed, 13 Jun 2012 20:24:28 +0000 (16:24 -0400)]
[release-branch.go1] runtime: do not unset the special bit after finalization.
««« backport
4a10c887bb3e
runtime: do not unset the special bit after finalization.
A block with finalizer might also be profiled. The special bit
is needed to unregister the block from the profile. It will be
unset only when the block is freed.
Fixes #3668.
R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/
6249066
»»»
Peter Kleiweg [Wed, 13 Jun 2012 20:24:27 +0000 (16:24 -0400)]
[release-branch.go1] Emacs go-mode: don't indent the inside of strings.
««« backport
8888febbe757
Emacs go-mode: don't indent the inside of strings.
Two fixes for indentation problems:
1. Properly recognize multi-line strings. These start with `, not ".
2. Don't indent a line if the beginning of the line is the end of a multi-line string. This happened for instance when inserting a closing bracket after a multi-line string.
R=sameer
CC=golang-dev
https://golang.org/cl/
6157044
»»»
Dmitriy Vyukov [Wed, 13 Jun 2012 20:24:26 +0000 (16:24 -0400)]
[release-branch.go1] time: fix deadlock in Sleep(0)
««« backport
085b20e6e0aa
time: fix deadlock in Sleep(0)
See time/sleep_test.go for repro.
R=golang-dev, r, rsc
CC=golang-dev, patrick.allen.higgins
https://golang.org/cl/
6250072
»»»
Mikio Hara [Wed, 13 Jun 2012 20:24:26 +0000 (16:24 -0400)]
[release-branch.go1] net: fix comment on FileListener
««« backport
3dfcac5f8254
net: fix comment on FileListener
R=rsc
CC=golang-dev
https://golang.org/cl/
6242067
»»»
Peter Kleiweg [Wed, 13 Jun 2012 20:24:25 +0000 (16:24 -0400)]
[release-branch.go1] Emacs go-mode: fix Emacs freeze-up when copy/pasting from string or comment.
««« backport
798239220647
Emacs go-mode: fix Emacs freeze-up when copy/pasting from string or comment.
Fixes #3509.
Fixes #2767.
R=golang-dev, sameer
CC=golang-dev
https://golang.org/cl/
6139066
»»»
Sameer Ajmani [Wed, 13 Jun 2012 20:24:24 +0000 (16:24 -0400)]
[release-branch.go1] A+C: Peter Kleiweg (individual CLA)
««« backport
771b60b029d4
A+C: Peter Kleiweg (individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6260049
»»»
Alexey Borzenkov [Wed, 13 Jun 2012 20:24:23 +0000 (16:24 -0400)]
[release-branch.go1] net/http: reuse http proxy connections for different http requests
««« backport
d0bc02d414c7
net/http: reuse http proxy connections for different http requests
Comment on cache keys above connectMethod says "http to proxy, http
anywhere after that", however in reality target address was always
included, which prevented http requests to different target
addresses to reuse the same http proxy connection.
R=golang-dev, r, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/
5901064
»»»
Alex Brainman [Wed, 13 Jun 2012 20:24:22 +0000 (16:24 -0400)]
[release-branch.go1] syscall: simplify text returned by Errno.Error() when FormatMessage fails
««« backport
ac7250065a04
syscall: simplify text returned by Errno.Error() when FormatMessage fails
Fixes #3623.
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/
6218072
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:21 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: fix parallel assignment in range
««« backport
2252777854d2
cmd/gc: fix parallel assignment in range
for expr1, expr2 = range slice
was assigning to expr1 and expr2 in sequence
instead of in parallel. Now it assigns in parallel,
as it should. This matters for things like
for i, x[i] = range slice.
Fixes #3464.
R=ken2
CC=golang-dev
https://golang.org/cl/
6252048
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:21 +0000 (16:24 -0400)]
[release-branch.go1] runtime: handle and test large map values
««« backport
98488e2e38ee
runtime: handle and test large map values
This is from CL
5451105 but was dropped from that CL.
See also CL
6137051 .
The only change compared to
5451105 is to check for
h != nil in reflect·mapiterinit; allowing use of nil maps
must have happened after that original CL.
Fixes #3573.
R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/
6215078
»»»
Robert Griesemer [Wed, 13 Jun 2012 20:24:20 +0000 (16:24 -0400)]
[release-branch.go1] strconv: better documentation for FormatInt, FormatUint.
««« backport
e2e4e44b1804
strconv: better documentation for FormatInt, FormatUint.
Fixes #3580.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6252047
»»»
Bill Thiede [Wed, 13 Jun 2012 20:24:19 +0000 (16:24 -0400)]
[release-branch.go1] net/mail: more liberal parsing of Date headers.
««« backport
e995a1bfe589
net/mail: more liberal parsing of Date headers.
Fixes #3639.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6243045
»»»
David Symonds [Wed, 13 Jun 2012 20:24:18 +0000 (16:24 -0400)]
[release-branch.go1] C: Bill Thiede (Google CLA)
««« backport
2088c4af2ff8
C: Bill Thiede (Google CLA)
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6257050
»»»
Rob Pike [Wed, 13 Jun 2012 20:24:17 +0000 (16:24 -0400)]
[release-branch.go1] runtime: fix docs for Caller and Callers
««« backport
443c7a2dabe9
runtime: fix docs for Caller and Callers
The previous attempt to explain this got it backwards (all the more reason to be
sad we couldn't make the two functions behave the same).
Fixes #3669.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6249051
»»»
Russ Cox [Wed, 13 Jun 2012 20:24:17 +0000 (16:24 -0400)]
[release-branch.go1] cmd/gc: fix small integer bounds check bug
««« backport
967ae8baf398
cmd/gc: fix small integer bounds check bug
R=ken2
CC=golang-dev
https://golang.org/cl/
6254046
»»»
Robert Griesemer [Wed, 13 Jun 2012 20:24:16 +0000 (16:24 -0400)]
[release-branch.go1] spec: clarify evaluation order of "i, x[i] = range ..."
««« backport
1c4d1ba268ca
spec: clarify evaluation order of "i, x[i] = range ..."
Part of fix for issue 3464.
R=golang-dev, rsc, mirtchovski, iant, r
CC=golang-dev
https://golang.org/cl/
6246045
»»»
Shenghou Ma [Wed, 13 Jun 2012 20:24:15 +0000 (16:24 -0400)]
[release-branch.go1] cmd/cc: fix uint right shift in constant evaluation
««« backport
aa2d2fa1e5a9
cmd/cc: fix uint right shift in constant evaluation
Fixes #3664.
R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
6249048
»»»
David Symonds [Wed, 13 Jun 2012 20:24:14 +0000 (16:24 -0400)]
[release-branch.go1] flag: include flag name in redefinition panic.
««« backport
64a249c65d51
flag: include flag name in redefinition panic.
R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/
6250043
»»»