]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agoexp/sql: rename NullableString to NullString and allow its use as a parameter
Brad Fitzpatrick [Thu, 19 Jan 2012 17:27:45 +0000 (09:27 -0800)]
exp/sql: rename NullableString to NullString and allow its use as a parameter

Prep for Issue 2699

R=rsc
CC=golang-dev
https://golang.org/cl/5536045

13 years agogo/doc, godoc: don't shadow receiver
Robert Griesemer [Thu, 19 Jan 2012 16:52:53 +0000 (08:52 -0800)]
go/doc, godoc: don't shadow receiver

Fixes #2737.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5553062

13 years agonet/http: the documentation should call NewRequest with the right signature.
Christoph Hack [Thu, 19 Jan 2012 14:11:02 +0000 (06:11 -0800)]
net/http: the documentation should call NewRequest with the right signature.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5554063

13 years agocrypto/x509: remove explicit uses of rsa.
Adam Langley [Thu, 19 Jan 2012 13:49:52 +0000 (08:49 -0500)]
crypto/x509: remove explicit uses of rsa.

(Sending to r because of the API change.)

Over time we might want to add support for other key types.

While I was in the code, I also made the use of RawSubject the same
between Subject and Issuer when creating certificates.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5554049

13 years agocrypto/elliptic: add constant-time P224.
Adam Langley [Thu, 19 Jan 2012 13:39:03 +0000 (08:39 -0500)]
crypto/elliptic: add constant-time P224.

(Sending to r because of the API change.)

This change alters the API for crypto/elliptic to permit different
implementations in the future. This will allow us to add faster,
constant-time implementations of the standard curves without any more
API changes.

As a demonstration, it also adds a constant-time implementation of
P224. Since it's only 32-bit, it's actually only about 40% the speed
of the generic code on a 64-bit system.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5528088

13 years agomath/rand: decrease test duration in short mode
Dmitriy Vyukov [Thu, 19 Jan 2012 12:17:44 +0000 (16:17 +0400)]
math/rand: decrease test duration in short mode
TestNonStandardNormalValues runs 1.5s,
the change reduces it to 0.2s in short mode.
The problem is with slow machines, emulators and dynamic tools.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5540065

13 years agogodoc: add anchors to cmd documentation headings
Andrew Gerrand [Thu, 19 Jan 2012 07:59:06 +0000 (18:59 +1100)]
godoc: add anchors to cmd documentation headings

Also, disable server-side generation of TOC for commands as they would
only ever show Overview. The JS does a better job (for now).

Fixes #2732.

R=gri, dsymonds
CC=golang-dev
https://golang.org/cl/5558046

13 years agohtml: in foreign content, check for HTML integration points in breakout
Nigel Tao [Thu, 19 Jan 2012 06:41:10 +0000 (17:41 +1100)]
html: in foreign content, check for HTML integration points in breakout
elements.

Pass tests10.dat, test 33:
<!DOCTYPE html><svg><desc><svg><ul>a

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <svg svg>
|       <svg desc>
|         <svg svg>
|         <ul>
|           "a"

Also pass test 34:
<!DOCTYPE html><p><svg><desc><p>

R=andybalholm, dsymonds
CC=golang-dev
https://golang.org/cl/5536048

13 years agoencoding/json: fix comments, tweak tests for tag names
Mikio Hara [Thu, 19 Jan 2012 06:33:29 +0000 (15:33 +0900)]
encoding/json: fix comments, tweak tests for tag names

R=bradfitz
CC=golang-dev
https://golang.org/cl/5558047

13 years agoregexp: add SubexpNames
Russ Cox [Thu, 19 Jan 2012 06:24:01 +0000 (01:24 -0500)]
regexp: add SubexpNames

Fixes #2440.

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5559043

13 years agosyscall: fix plan9 build
Mikio Hara [Thu, 19 Jan 2012 05:52:28 +0000 (14:52 +0900)]
syscall: fix plan9 build

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5532097

13 years agogodoc: remove "need more packages?" link
Andrew Gerrand [Thu, 19 Jan 2012 04:00:27 +0000 (15:00 +1100)]
godoc: remove "need more packages?" link

Its need will be addressed in another way by the redesign.

Fixes #2719.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5536062

13 years agodoc/codewalk: update urlpoll to use time.Duration.
Stefan Nilsson [Thu, 19 Jan 2012 03:45:59 +0000 (14:45 +1100)]
doc/codewalk: update urlpoll to use time.Duration.

R=adg
CC=golang-dev
https://golang.org/cl/5545061

13 years agoA+C: add Stefan Nilsson's gmail account
Andrew Gerrand [Thu, 19 Jan 2012 03:44:21 +0000 (14:44 +1100)]
A+C: add Stefan Nilsson's gmail account

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5541064

13 years agogo/doc: collect imports
Robert Griesemer [Thu, 19 Jan 2012 03:35:53 +0000 (19:35 -0800)]
go/doc: collect imports

R=r
CC=golang-dev
https://golang.org/cl/5556051

13 years agocmd/go: skip _obj directories in package scans
Brad Fitzpatrick [Thu, 19 Jan 2012 03:27:16 +0000 (19:27 -0800)]
cmd/go: skip _obj directories in package scans

Fixes #2693

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5557057

13 years agonet: fix plan9 build
Mikio Hara [Thu, 19 Jan 2012 03:25:37 +0000 (12:25 +0900)]
net: fix plan9 build

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5554058

13 years agonet: fix comments
Mikio Hara [Thu, 19 Jan 2012 03:23:30 +0000 (12:23 +0900)]
net: fix comments

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5557059

13 years agonet/http: update the Client docs a bit
Brad Fitzpatrick [Thu, 19 Jan 2012 03:05:53 +0000 (19:05 -0800)]
net/http: update the Client docs a bit

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/5557058

13 years agosyscall: add Unix method to TimeSpec, TimeVal
Brad Fitzpatrick [Thu, 19 Jan 2012 03:05:44 +0000 (19:05 -0800)]
syscall: add Unix method to TimeSpec, TimeVal

Fixes #2534

R=golang-dev, dave, alex.brainman
CC=golang-dev
https://golang.org/cl/5554057

13 years agoencoding/json: allow / and % in tag names
Brad Fitzpatrick [Thu, 19 Jan 2012 03:05:15 +0000 (19:05 -0800)]
encoding/json: allow / and % in tag names

Fixes #2718

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5532095

13 years agopath: added examples
Sanjay Menakuru [Thu, 19 Jan 2012 02:28:25 +0000 (13:28 +1100)]
path: added examples

R=rsc, adg
CC=golang-dev
https://golang.org/cl/5503089

13 years agoimage: add PixOffset methods; use them in image/draw and image/tiff.
Nigel Tao [Thu, 19 Jan 2012 01:59:39 +0000 (12:59 +1100)]
image: add PixOffset methods; use them in image/draw and image/tiff.

image/draw benchmarks show <1% change for the fast paths.
The slow paths got worse by 1-4%, but they're the slow paths.
I don't care so much about them, and presumably compiler improvements
could claw it back.

IIUC 6g's inlining is enabled by default now.

benchmark                        old ns/op    new ns/op    delta
draw.BenchmarkFillOver             2988384      2999624   +0.38%
draw.BenchmarkFillSrc               153141       153262   +0.08%
draw.BenchmarkCopyOver             2155756      2170831   +0.70%
draw.BenchmarkCopySrc                72591        72646   +0.08%
draw.BenchmarkNRGBAOver            2487372      2491576   +0.17%
draw.BenchmarkNRGBASrc             1361306      1409180   +3.52%
draw.BenchmarkYCbCr                2540712      2562359   +0.85%
draw.BenchmarkGlyphOver            1004879      1023308   +1.83%
draw.BenchmarkRGBA                 8746670      8844455   +1.12%
draw.BenchmarkGenericOver         31860960     32512960   +2.05%
draw.BenchmarkGenericMaskOver     16369060     16435720   +0.41%
draw.BenchmarkGenericSrc          13128540     13127810   -0.01%
draw.BenchmarkGenericMaskSrc      30059300     28883210   -3.91%

R=r, gri
CC=golang-dev, rsc
https://golang.org/cl/5536059

13 years agonet: use NewTimer, not NewTicker, in fd_windows.go
Brad Fitzpatrick [Thu, 19 Jan 2012 00:49:59 +0000 (16:49 -0800)]
net: use NewTimer, not NewTicker, in fd_windows.go

It works with NewTicker too, but is potentially a bit less efficient,
and reads wrong.

This is what happens when you TBR Windows changes, I guess.

R=golang-dev, gri, iant
CC=golang-dev
https://golang.org/cl/5536060

13 years agogodoc: specify HTML page metadata with a JSON blob
Andrew Gerrand [Thu, 19 Jan 2012 00:24:54 +0000 (11:24 +1100)]
godoc: specify HTML page metadata with a JSON blob

This allows HTML pages to specify arbitrary data in a header:

<!--{
        "Title": "The page title",
        ...
}-->

replacing the old style comments:

<!-- title The page title -->

R=gri, rsc, r, bradfitz, dsymonds
CC=golang-dev
https://golang.org/cl/5532093

13 years agonet: change SetTimeout to SetDeadline
Brad Fitzpatrick [Thu, 19 Jan 2012 00:24:06 +0000 (16:24 -0800)]
net: change SetTimeout to SetDeadline

Previously, a timeout (in int64 nanoseconds) applied to a granularity
even smaller than one operation:  a 100 byte read with a 1 second timeout
could take 100 seconds, if the bytes all arrived on the network 1 second
apart.  This was confusing.

Rather than making the timeout granularity be per-Read/Write,
this CL makes callers set an absolute deadline (in time.Time)
after which operations will fail.  This makes it possible to
set deadlines at higher levels, without knowing exactly how
many read/write operations will happen in e.g. reading an HTTP
request.

Fixes #2723

R=r, rsc, dave
CC=golang-dev
https://golang.org/cl/5555048

13 years agotest: split golden.out into expected output per test
Ian Lance Taylor [Thu, 19 Jan 2012 00:12:24 +0000 (16:12 -0800)]
test: split golden.out into expected output per test

This will permit gccgo to check test output.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5554056

13 years agofix windows build: always use / in filenames of go/doc test output
Robert Griesemer [Wed, 18 Jan 2012 22:59:58 +0000 (14:59 -0800)]
fix windows build: always use / in filenames of go/doc test output

R=r
CC=golang-dev
https://golang.org/cl/5554055

13 years agodoc/go1.*: documented changes to go/* package tree
Robert Griesemer [Wed, 18 Jan 2012 22:35:23 +0000 (14:35 -0800)]
doc/go1.*: documented changes to go/* package tree

R=r
CC=golang-dev
https://golang.org/cl/5557053

13 years agoimage/color: rename modelYCbCr to yCbCrModel.
Benny Siegert [Wed, 18 Jan 2012 22:34:37 +0000 (09:34 +1100)]
image/color: rename modelYCbCr to yCbCrModel.

This matches the other color models. It seems that this was missed
during the review of 5544073.

R=nigeltao, david.crawshaw
CC=golang-dev
https://golang.org/cl/5536057

13 years agotest: change several tests to not print
Ian Lance Taylor [Wed, 18 Jan 2012 22:31:31 +0000 (14:31 -0800)]
test: change several tests to not print

This will make these tests more meaningful for gccgo, which
runs tests in parallel and has no equivalent to golden.out.

Remove ken/simpprint.go since it duplicates helloworld.go.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5536058

13 years agogo/doc: rewrote and completed test framework
Robert Griesemer [Wed, 18 Jan 2012 22:11:31 +0000 (14:11 -0800)]
go/doc: rewrote and completed test framework

Packages to test are kept in ./testdata together
with the corresponding golden (packagename.out)
file.

To update the golden files, run: go test -update

R=rsc
CC=golang-dev
https://golang.org/cl/5543054

13 years agogo/token: replaced Files() with Iterate()
Robert Griesemer [Wed, 18 Jan 2012 22:10:42 +0000 (14:10 -0800)]
go/token: replaced Files() with Iterate()

- Use a faster closure-based iterator rather than a channel-based one.
- Otherwise: better code organization, but no other API changes.

R=r, r
CC=golang-dev
https://golang.org/cl/5557051

13 years agotest: gofmt a few tests
Ian Lance Taylor [Wed, 18 Jan 2012 21:20:55 +0000 (13:20 -0800)]
test: gofmt a few tests

I'm planning to change these tests, but the gofmt changes are
fairly extensive, so I'm separating the gofmt changes from the
substantive changes.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5557052

13 years agotime: add Since, which returns the time elapsed since some past time t.
Sameer Ajmani [Wed, 18 Jan 2012 20:25:00 +0000 (15:25 -0500)]
time: add Since, which returns the time elapsed since some past time t.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5532088

13 years agoexp/ssh: handle versions with just '\n'
Adam Langley [Wed, 18 Jan 2012 20:04:17 +0000 (15:04 -0500)]
exp/ssh: handle versions with just '\n'

djm recommend that we do this because OpenSSL was only fixed in 2008:
http://anoncvs.mindrot.org/index.cgi/openssh/sshd.c?revision=1.380&view=markup

R=dave, jonathan.mark.pittman
CC=golang-dev
https://golang.org/cl/5555044

13 years agocrypto/tls: add FreeBSD root certificate location
Shenghou Ma [Wed, 18 Jan 2012 18:03:00 +0000 (10:03 -0800)]
crypto/tls: add FreeBSD root certificate location
    Fixes #2721.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5532090

13 years agopkg/bytes: add the usual copyright notice to example_test.go
Olivier Duperray [Wed, 18 Jan 2012 17:40:50 +0000 (09:40 -0800)]
pkg/bytes: add the usual copyright notice to example_test.go

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5553050

13 years agogo/scanner: fix example
Olivier Duperray [Wed, 18 Jan 2012 17:33:50 +0000 (09:33 -0800)]
go/scanner: fix example

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5532085

13 years agogc: fieldnames in structliterals in exported inlines should not be qualified if they...
Luuk van Dijk [Wed, 18 Jan 2012 16:51:28 +0000 (17:51 +0100)]
gc: fieldnames in structliterals in exported inlines should not be qualified if they're embedded builtin types.

Trust me.
Fixes #2687.

R=rsc
CC=golang-dev
https://golang.org/cl/5545047

13 years agodoc/go1.html: add notes about hash.Hash
Russ Cox [Wed, 18 Jan 2012 15:36:43 +0000 (10:36 -0500)]
doc/go1.html: add notes about hash.Hash

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5536053

13 years agocrypto/hmac: Add HMAC-SHA224 and HMAC-SHA384/512
Luit van Drongelen [Wed, 18 Jan 2012 15:36:28 +0000 (10:36 -0500)]
crypto/hmac: Add HMAC-SHA224 and HMAC-SHA384/512

First was, apart from adding tests, a single line of code (to add the
constructor function). Adding SHA512-based hashing to crypto/hmac
required minor rework of the package because of a previously hardcoded
block-size in it's implementation. Instead of using a hash.Hash
generator function the constructor function now uses a crypto.Hash
type, which was extended to expose information about block size.

The only standard library package impacted by the change is
crypto/tls, for which the fix is included in this patch. It might be
useful to extend gofix to include this API change too.

R=agl, r, rsc, r
CC=golang-dev
https://golang.org/cl/5550043

13 years agogc: handle printing of string/arrayrune conversions
Luuk van Dijk [Wed, 18 Jan 2012 08:52:16 +0000 (09:52 +0100)]
gc: handle printing of string/arrayrune conversions

Fixes #2714.

R=rsc
CC=golang-dev
https://golang.org/cl/5540066

13 years agoos: remove old note about NewSyscallError being special
Alex Brainman [Wed, 18 Jan 2012 05:59:40 +0000 (16:59 +1100)]
os: remove old note about NewSyscallError being special

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5556044

13 years agotest: match gccgo error messages for bug345
Ian Lance Taylor [Wed, 18 Jan 2012 02:00:34 +0000 (18:00 -0800)]
test: match gccgo error messages for bug345

bug345.dir/main.go:25:18: error: argument 1 has incompatible type (need explicit conversion; missing method ‘Write’)
bug345.dir/main.go:27:8: error: argument 1 has incompatible type

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5556043

13 years agotest: fix bug364 to actually run
Ian Lance Taylor [Wed, 18 Jan 2012 02:00:11 +0000 (18:00 -0800)]
test: fix bug364 to actually run

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5536044

13 years agoencoding/json: document angle bracket escaping.
David Symonds [Wed, 18 Jan 2012 01:56:24 +0000 (12:56 +1100)]
encoding/json: document angle bracket escaping.

Fixes #2643.

R=rsc, d_smithson
CC=golang-dev
https://golang.org/cl/5543068

13 years agoimage: fix typo in Rectangle.Sub comment.
Nigel Tao [Tue, 17 Jan 2012 23:55:03 +0000 (10:55 +1100)]
image: fix typo in Rectangle.Sub comment.

Fixes #2724.

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5555043

13 years agofmt: fix Malloc test
Rob Pike [Tue, 17 Jan 2012 23:42:02 +0000 (15:42 -0800)]
fmt: fix Malloc test
We need to avoid allocating an extra word for the interface value
passing the floating-point value as an interface{}. It's easy.

Fixes #2722.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5553044

13 years agoutf8.String: move to exp/utf8string.String
Rob Pike [Tue, 17 Jan 2012 22:21:50 +0000 (14:21 -0800)]
utf8.String: move to exp/utf8string.String

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5528115

13 years agotesting: document examples
Rob Pike [Tue, 17 Jan 2012 22:20:27 +0000 (14:20 -0800)]
testing: document examples
The package documentation did not mention them.
They were described only in godoc for gotest, and that's going away.

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/5539079

13 years agonet/http: change test to use override param instead of chan.
David Symonds [Tue, 17 Jan 2012 21:28:09 +0000 (08:28 +1100)]
net/http: change test to use override param instead of chan.

Follow-on from https://golang.org/cl/5543062.

R=bradfitz, dvyukov
CC=golang-dev
https://golang.org/cl/5539071

13 years agotext/template: fix nil error on redefinition
Rob Pike [Tue, 17 Jan 2012 21:24:59 +0000 (13:24 -0800)]
text/template: fix nil error on redefinition
Fixes #2720.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5545072

13 years agonet/http/cgi: increase a flaky test timeout
Brad Fitzpatrick [Tue, 17 Jan 2012 21:14:27 +0000 (13:14 -0800)]
net/http/cgi: increase a flaky test timeout

Fixes 2450, probably.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5540074

13 years agocmd/go: remove mentions of 'gotest' from the documentation
Rob Pike [Tue, 17 Jan 2012 21:13:50 +0000 (13:13 -0800)]
cmd/go: remove mentions of 'gotest' from the documentation
go test runs the tests itself; it does not run the gotest command,
so these mentions are confusing.

R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5551043

13 years agocontainer/heap: better package documentation
Rob Pike [Tue, 17 Jan 2012 21:07:47 +0000 (13:07 -0800)]
container/heap: better package documentation
Fixes #1820.

R=golang-dev, bradfitz, gri
CC=golang-dev
https://golang.org/cl/5540073

13 years agomime: make FormatMediaType take full type for consistency
Brad Fitzpatrick [Tue, 17 Jan 2012 19:57:42 +0000 (11:57 -0800)]
mime: make FormatMediaType take full type for consistency

Fixes #2405

R=rsc
CC=golang-dev
https://golang.org/cl/5539048

13 years agofmt: enable and fix malloc test
Rob Pike [Tue, 17 Jan 2012 18:45:36 +0000 (10:45 -0800)]
fmt: enable and fix malloc test
On 32-bit machines, %g takes an extra malloc. I don't know why yet,
but this makes the test pass again, and enables it even for -short.

Fixes #2653.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5542055

13 years agoexp/sql: copy when scanning into []byte by default
Brad Fitzpatrick [Tue, 17 Jan 2012 18:44:35 +0000 (10:44 -0800)]
exp/sql: copy when scanning into []byte by default

Fixes #2698

R=rsc
CC=golang-dev
https://golang.org/cl/5539060

13 years agodoc/docs: fix broken links
Scott Lawrence [Tue, 17 Jan 2012 18:29:08 +0000 (10:29 -0800)]
doc/docs: fix broken links

R=golang-dev
CC=golang-dev
https://golang.org/cl/5539076

13 years agodoc: I have modified the broken links.
Jongmin Kim [Tue, 17 Jan 2012 17:47:34 +0000 (09:47 -0800)]
doc: I have modified the broken links.

R=golang-dev, duperray.olivier, r
CC=adg, golang-dev
https://golang.org/cl/5542054

13 years agobuildscripts: move to buildscript directory
Shenghou Ma [Tue, 17 Jan 2012 16:18:15 +0000 (11:18 -0500)]
buildscripts: move to buildscript directory
        Fixes #2717.

R=r, rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5545069

13 years agogc: give esc.c's sink an orig so -mm diagnostics work again.
Luuk van Dijk [Tue, 17 Jan 2012 09:01:12 +0000 (10:01 +0100)]
gc: give esc.c's sink an orig so -mm diagnostics work again.

R=rsc
CC=golang-dev
https://golang.org/cl/5543063

13 years agogc: fix infinite recursion for embedded interfaces
Luuk van Dijk [Tue, 17 Jan 2012 09:00:57 +0000 (10:00 +0100)]
gc: fix infinite recursion for embedded interfaces

Fixes #1909

R=rsc, gri
CC=golang-dev
https://golang.org/cl/5523047

13 years agoold/netchan: fix data race on client hashmap
Dmitriy Vyukov [Tue, 17 Jan 2012 07:48:20 +0000 (11:48 +0400)]
old/netchan: fix data race on client hashmap
Fixes #2713.

R=golang-dev, r
CC=golang-dev, mpimenov
https://golang.org/cl/5545065

13 years agopkg: add missing godoc comments to windows versions
Alex Brainman [Tue, 17 Jan 2012 05:51:54 +0000 (16:51 +1100)]
pkg: add missing godoc comments to windows versions

Mostly copied comments from unix files.

R=rsc
CC=golang-dev
https://golang.org/cl/5533057

13 years agogo/build: no back slash in FindTree returned pkg name
Alex Brainman [Tue, 17 Jan 2012 05:51:02 +0000 (16:51 +1100)]
go/build: no back slash in FindTree returned pkg name

Fixes #2652.

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5516045

13 years agoexp/proxy: fix build after URL changes
Gustavo Niemeyer [Tue, 17 Jan 2012 02:55:35 +0000 (00:55 -0200)]
exp/proxy: fix build after URL changes

R=golang-dev
CC=golang-dev
https://golang.org/cl/5540062

13 years agonet/url: cleaned up URL interface (v2)
Gustavo Niemeyer [Tue, 17 Jan 2012 02:49:05 +0000 (00:49 -0200)]
net/url: cleaned up URL interface (v2)

Duplicated fields from URL were dropped so that its behavior
is simple and expected when being stringified and when being
operated by packages like http. Most of the preserved fields
are in unencoded form, except for RawQuery which continues to
exist and be more easily handled via url.Query().

The RawUserinfo field was also replaced since it wasn't practical
to use and had limitations when operating with empty usernames
and passwords which are allowed by the RFC. In its place the
Userinfo type was introduced and made accessible through the
url.User and url.UserPassword functions.

What was previous built as:

        url.URL{RawUserinfo: url.EncodeUserinfo("user", ""), ...}

Is now built as:

        url.URL{User: url.User("user"), ...}

R=rsc, bradfitz, gustavo
CC=golang-dev
https://golang.org/cl/5498076

13 years agonet: fix unintentional error variable shadowing
Mikio Hara [Tue, 17 Jan 2012 01:59:39 +0000 (10:59 +0900)]
net: fix unintentional error variable shadowing

R=rsc
CC=golang-dev
https://golang.org/cl/5543065

13 years ago5l: remove redundant code
Shenghou Ma [Tue, 17 Jan 2012 00:29:54 +0000 (19:29 -0500)]
5l: remove redundant code
        5l/asm.c: code in line 311-319 has already outputed segtext.sect->next;

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5532048

13 years agomath/rand: document default initial seed for global generator
Scott Lawrence [Mon, 16 Jan 2012 23:13:34 +0000 (18:13 -0500)]
math/rand: document default initial seed for global generator

Fixes #2044.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5541056

13 years agogc: don't fault on return outside function
Scott Lawrence [Mon, 16 Jan 2012 23:12:25 +0000 (18:12 -0500)]
gc: don't fault on return outside function

Fixes #2598.

R=golang-dev, ality, minux.ma, mpimenov, rsc
CC=golang-dev
https://golang.org/cl/5510043

13 years agoexp/terminal: fix build on non-Linux using Makefiles
Russ Cox [Mon, 16 Jan 2012 22:49:58 +0000 (17:49 -0500)]
exp/terminal: fix build on non-Linux using Makefiles

The Makefiles will go away soon.

R=agl
CC=golang-dev
https://golang.org/cl/5544081

13 years agodoc: fix anchor tag for latest weekly.
David Symonds [Mon, 16 Jan 2012 22:04:51 +0000 (09:04 +1100)]
doc: fix anchor tag for latest weekly.

R=golang-dev
TBR=adg
CC=golang-dev
https://golang.org/cl/5545068

13 years agonet/http: send cookies in jar on redirect
Jeff Hodges [Mon, 16 Jan 2012 20:57:59 +0000 (12:57 -0800)]
net/http: send cookies in jar on redirect

Until a RFC 6265 jar lands, Request.AddCookie() will work incorrectly.

Fixes #2692

R=bradfitz, rsc
CC=golang-dev, r
https://golang.org/cl/5544069

13 years agoruntime: implement runtime.usleep for FreeBSD/386 and amd64.
Shenghou Ma [Mon, 16 Jan 2012 16:22:34 +0000 (03:22 +1100)]
runtime: implement runtime.usleep for FreeBSD/386 and amd64.

R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/5528106

13 years agoexp/ssh: rename (some) fields
Christopher Wedgwood [Mon, 16 Jan 2012 15:09:36 +0000 (10:09 -0500)]
exp/ssh: rename (some) fields

R=dave, agl, agl
CC=golang-dev
https://golang.org/cl/5494057

13 years agoruntime: fix typo in comment
Maxim Pimenov [Mon, 16 Jan 2012 14:42:18 +0000 (18:42 +0400)]
runtime: fix typo in comment

R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/5540059

13 years agonet/http: fix data race in test
Dmitriy Vyukov [Mon, 16 Jan 2012 10:47:33 +0000 (14:47 +0400)]
net/http: fix data race in test
Fixes #2712.

R=golang-dev, dsymonds
CC=golang-dev, mpimenov
https://golang.org/cl/5543062

13 years agosync/atomic: fix data race in tests
Dmitriy Vyukov [Mon, 16 Jan 2012 07:43:36 +0000 (11:43 +0400)]
sync/atomic: fix data race in tests
Fixes #2710.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5541066

13 years agoexp/inotify: fix data race in linux tests
Dmitriy Vyukov [Mon, 16 Jan 2012 07:11:58 +0000 (11:11 +0400)]
exp/inotify: fix data race in linux tests
Fixes #2708.

R=golang-dev, bradfitz
CC=golang-dev, mpimenov
https://golang.org/cl/5543060

13 years agonet: consistent log format in test
Mikio Hara [Mon, 16 Jan 2012 05:57:18 +0000 (14:57 +0900)]
net: consistent log format in test

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5545062

13 years agoimage/color: simplify documentation
David Crawshaw [Mon, 16 Jan 2012 05:02:31 +0000 (16:02 +1100)]
image/color: simplify documentation

R=nigeltao, dsymonds, adg
CC=golang-dev
https://golang.org/cl/5544073

13 years agoexp/ssh: add marshal functions for uint32 and uint64 types
Jonathan Pittman [Mon, 16 Jan 2012 00:54:17 +0000 (19:54 -0500)]
exp/ssh: add marshal functions for uint32 and uint64 types

R=golang-dev, dave, agl
CC=golang-dev
https://golang.org/cl/5533081

13 years agoCONTRIBUTORS: add Johnathan Pittman
Adam Langley [Mon, 16 Jan 2012 00:52:45 +0000 (19:52 -0500)]
CONTRIBUTORS: add Johnathan Pittman

(Google CLA)

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5544072

13 years agotag weekly.2012-01-15
Andrew Gerrand [Sun, 15 Jan 2012 22:52:35 +0000 (09:52 +1100)]
tag weekly.2012-01-15

R=golang-dev
CC=golang-dev
https://golang.org/cl/5539064

13 years agoweekly.2012-01-15 weekly.2012-01-15
Andrew Gerrand [Sun, 15 Jan 2012 22:45:20 +0000 (09:45 +1100)]
weekly.2012-01-15

R=golang-dev, dsymonds, r, n13m3y3r
CC=golang-dev
https://golang.org/cl/5543049

13 years agoexp/terminal: still trying to unbreak non-Linux builds.
Adam Langley [Sun, 15 Jan 2012 15:41:16 +0000 (10:41 -0500)]
exp/terminal: still trying to unbreak non-Linux builds.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5542050

13 years agoexp/terminal: add to level Makefile for the (non-Linux?) systems that need it.
Adam Langley [Sun, 15 Jan 2012 15:22:15 +0000 (10:22 -0500)]
exp/terminal: add to level Makefile for the (non-Linux?) systems that need it.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5528102

13 years agoexp/ssh: patching in the last change lost that a file was deleted.
Adam Langley [Sun, 15 Jan 2012 15:08:48 +0000 (10:08 -0500)]
exp/ssh: patching in the last change lost that a file was deleted.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5541060

13 years agoexp/ssh: remove duplicated terminal code.
Adam Langley [Sun, 15 Jan 2012 14:59:06 +0000 (09:59 -0500)]
exp/ssh: remove duplicated terminal code.

The terminal code in exp/terminal was forked from the code in exp/ssh.
This change removes the duplicated code from exp/ssh in favour of
using exp/terminal.

R=rsc
CC=golang-dev
https://golang.org/cl/5375064

13 years agohttp: Allow cookies with negative Max-Age attribute as these are
Volker Dobler [Sun, 15 Jan 2012 08:32:16 +0000 (19:32 +1100)]
http: Allow cookies with negative Max-Age attribute as these are
allowed by RFC 6265 sec 5.2.2.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5533083

13 years agonet: platform-dependent default socket options
Mikio Hara [Sun, 15 Jan 2012 05:19:44 +0000 (14:19 +0900)]
net: platform-dependent default socket options

This CL revises existing platform-dependent default socket
options to make it possible to accomodate multiple multicast
datagram listeners on a single service port.

Also removes unnecessary SO_REUSEADDR, SO_REUSEPORT socket
options from unicast datagram sockets by default.

Fixes #1692.

R=devon.odell, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5538052

13 years agogo/doc: print only one newline between paragraphs
Rob Pike [Sat, 14 Jan 2012 19:57:32 +0000 (11:57 -0800)]
go/doc: print only one newline between paragraphs
Fixes #2595.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5544068

13 years agodoc: fix comments referring to removed API funcs
Shenghou Ma [Sat, 14 Jan 2012 18:59:45 +0000 (10:59 -0800)]
doc: fix comments referring to removed API funcs
        The strconv package has removed Atob, AtoF{64,32} and Ftoa.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5540057

13 years agogc: do not compile switch on interface values into a binary search.
Rémy Oudompheng [Sat, 14 Jan 2012 16:00:14 +0000 (17:00 +0100)]
gc: do not compile switch on interface values into a binary search.

Fixes #2672.

R=golang-dev, lvd
CC=golang-dev, remy
https://golang.org/cl/5543058

13 years agoexp/terminal: add SetPrompt and handle large pastes.
Adam Langley [Sat, 14 Jan 2012 15:59:11 +0000 (10:59 -0500)]
exp/terminal: add SetPrompt and handle large pastes.

(This was missing in the last change because I uploaded it from the
wrong machine.)

Large pastes previously misbehaved because the code tried reading from
the terminal before checking whether an line was already buffered.
Large pastes can cause multiples lines to be read at once from the
terminal.

R=bradfitz
CC=golang-dev
https://golang.org/cl/5542049

13 years agoexp/proxy: new package
Adam Langley [Sat, 14 Jan 2012 15:44:35 +0000 (10:44 -0500)]
exp/proxy: new package

exp/proxy provides client support for tunneling connections through
various proxies.

This is an initial, incomplete sketch of the code to lay down an
API.

R=golang-dev, r, r, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5490062

13 years agonet: make use of the kernel state to listen on TCP, Unix
Mikio Hara [Sat, 14 Jan 2012 04:42:18 +0000 (13:42 +0900)]
net: make use of the kernel state to listen on TCP, Unix

R=golang-dev, dave, minux.ma
CC=golang-dev
https://golang.org/cl/5545044