]>
Cypherpunks repositories - gostls13.git/log
Adam Langley [Fri, 13 Nov 2009 21:00:45 +0000 (13:00 -0800)]
json: allow one to unmarshal a top-level JSON array.
Fixies issue 114.
R=rsc
CC=golang-dev
https://golang.org/cl/154121
Russ Cox [Fri, 13 Nov 2009 19:34:33 +0000 (11:34 -0800)]
path.TestWalk: disable error case if root
(chmod 0 doesn't cause errors for root)
Fixes #22.
R=gri
https://golang.org/cl/152120
Adam Langley [Fri, 13 Nov 2009 19:29:13 +0000 (11:29 -0800)]
json: fix addressing of slice indexes that are multiples of 8.
Fixes #147.
R=rsc
CC=golang-dev
https://golang.org/cl/152123
Adam Langley [Fri, 13 Nov 2009 18:08:51 +0000 (10:08 -0800)]
runtime: warn about SELinux based mmap failures on Linux.
SELinux will cause mmap to fail when we request w+x memory unless the
user has configured their policies. We have a warning in make.bash,
but it's quite likely that the policy will be reset at some point and
then all their binaries start failing.
This patch prints a warning on Linux when mmap fails with EACCES.
R=rsc
CC=golang-dev
https://golang.org/cl/152086
Russ Cox [Fri, 13 Nov 2009 07:38:48 +0000 (23:38 -0800)]
yet another attempt to avoid conflicts with
<stdio.h>, which we weren't even #including
R=r
https://golang.org/cl/154108
Rob Pike [Fri, 13 Nov 2009 07:35:45 +0000 (23:35 -0800)]
remove dead code from test
R=rsc
CC=golang-dev
https://golang.org/cl/152118
Rob Pike [Fri, 13 Nov 2009 07:19:12 +0000 (23:19 -0800)]
sudo.bash tries to install acid and db, which don't exist any more
R=rsc
CC=golang-dev
https://golang.org/cl/152117
Kevin Ballard [Fri, 13 Nov 2009 02:40:42 +0000 (18:40 -0800)]
Teach emacs M-x gofmt to save region/restrictions
R=agl, agl1
https://golang.org/cl/152078
Russ Cox [Fri, 13 Nov 2009 02:37:39 +0000 (18:37 -0800)]
codereview: clpatch tweaks
R=agl1
https://golang.org/cl/152114
Robert Griesemer [Fri, 13 Nov 2009 02:26:45 +0000 (18:26 -0800)]
Remove -align flag from gofmt.
(Making it work correctly with -spaces is a bit of work and the output
won't make much sense as it is intended as input to tabwriter.)
Fixes #100.
R=rsc
https://golang.org/cl/154102
Kai Backman [Fri, 13 Nov 2009 00:12:28 +0000 (16:12 -0800)]
fix style nit ignored in previous cl
R=rsc
https://golang.org/cl/152110
Kai Backman [Thu, 12 Nov 2009 23:23:23 +0000 (15:23 -0800)]
add support for pre arm v6 cas. set GOARM=5 to enable.
R=rsc
https://golang.org/cl/154101
Russ Cox [Thu, 12 Nov 2009 23:12:52 +0000 (15:12 -0800)]
tag new release at 4015/
cb140bac9ab0
R=r
https://golang.org/cl/154100
Russ Cox [Thu, 12 Nov 2009 22:55:26 +0000 (14:55 -0800)]
test/run: unset GREP_OPTIONS
Fixes #116.
R=r
https://golang.org/cl/152106
Russ Cox [Thu, 12 Nov 2009 22:55:04 +0000 (14:55 -0800)]
os.TestSeek: use a smaller but still 64-bit seek offset.
Might fix issue 91.
R=r
https://golang.org/cl/152108
Rob Pike [Thu, 12 Nov 2009 22:28:45 +0000 (14:28 -0800)]
produce helpful error when gotest doesn't find a Makefile
Fixes #117.
R=rsc, agl1
CC=golang-dev
https://golang.org/cl/152107
Rob Pike [Thu, 12 Nov 2009 22:10:16 +0000 (14:10 -0800)]
add a paragraph about semicolons to the tutorial.
fix a typo caught by kakugawa@gmail.com
Fixes #92.
R=rsc
CC=golang-dev
https://golang.org/cl/152105
Adam Langley [Thu, 12 Nov 2009 21:55:20 +0000 (13:55 -0800)]
exp/draw: correct Makefile.
Thanks to Allister Macleod
Fixes #112.
R=rsc
CC=golang-dev
https://golang.org/cl/152102
Rob Pike [Thu, 12 Nov 2009 19:05:20 +0000 (11:05 -0800)]
fix a couple of typos.
add a mention of range to the tutorial.
change tutorial's title.
R=rsc
CC=golang-dev
https://golang.org/cl/152098
Russ Cox [Thu, 12 Nov 2009 08:22:45 +0000 (00:22 -0800)]
cc, ld: fix more gcc 4.3 -O2 compile bugs
same as https://golang.org/cl/152088
in more files.
Fixes #83.
R=r, r1
https://golang.org/cl/152091
Kai Backman [Thu, 12 Nov 2009 07:23:11 +0000 (23:23 -0800)]
add cache flushing call after generating closure.
go/test: passes 88% (306/347)
R=rsc
https://golang.org/cl/152089
Russ Cox [Thu, 12 Nov 2009 06:20:05 +0000 (22:20 -0800)]
avoid seg fault when return type is unknown
Fixes #80.
R=ken
https://golang.org/cl/154079
Russ Cox [Thu, 12 Nov 2009 06:19:58 +0000 (22:19 -0800)]
gopack: work around gcc bug in hash function
Fixes #48. (this time for sure!)
R=r, r1
https://golang.org/cl/152088
Rob Pike [Thu, 12 Nov 2009 03:39:57 +0000 (19:39 -0800)]
fix typo in ByteSize example
R=rsc, agl1
CC=golang-dev
https://golang.org/cl/154076
David Symonds [Thu, 12 Nov 2009 01:31:28 +0000 (17:31 -0800)]
Fix capitalisation of "Git".
R=rsc
https://golang.org/cl/154071
Robert Griesemer [Thu, 12 Nov 2009 01:25:51 +0000 (17:25 -0800)]
vector: s/Element/interface{}/
Fixes #74.
R=rsc
https://golang.org/cl/154073
Adam Langley [Thu, 12 Nov 2009 01:13:14 +0000 (17:13 -0800)]
json: support \u escaping in strings
Fixes #73.
R=rsc
CC=golang-dev
https://golang.org/cl/154072
Russ Cox [Thu, 12 Nov 2009 00:58:27 +0000 (16:58 -0800)]
cgo: add more information about gcc output parsing failures
R=r
https://golang.org/cl/152084
Russ Cox [Thu, 12 Nov 2009 00:33:23 +0000 (16:33 -0800)]
fix BUFSIZ redeclaration warnings
R=r
https://golang.org/cl/152085
Russ Cox [Wed, 11 Nov 2009 23:48:38 +0000 (15:48 -0800)]
fix TestRemoveAll again (tested as root this time).
Fixes #22.
R=r
https://golang.org/cl/154069
Adam Langley [Wed, 11 Nov 2009 23:02:15 +0000 (15:02 -0800)]
make.bash: detect and warn about SELinux policy that crashes us.
The default SELinux policy on Fedora 12 (at least) disallows stack
pages to be +x. This causes all binaries written by 6g/6l to segfault
immedately. The 'true' way to fix this issue is to mark binaries with
the correct type. However, that assumes that 6l is going to detect
SELinux, figure out the correct type for the current distribution and
set the type (without libselinux).
For now we'll warn users and point them towards the way to enable
execstack for the whole system.
http://code.google.com/p/go/issues/detail?id=47
R=rsc
CC=golang-dev
http://codereview.prom.corp.google.com/
1026041
Russ Cox [Wed, 11 Nov 2009 22:52:38 +0000 (14:52 -0800)]
typo
Fixes #69.
R=r
https://golang.org/cl/152082
Russ Cox [Wed, 11 Nov 2009 22:52:29 +0000 (14:52 -0800)]
os test: do not use symlink > 255 bytes.
Fixes #62.
R=r
https://golang.org/cl/152080
Russ Cox [Wed, 11 Nov 2009 22:52:21 +0000 (14:52 -0800)]
cc: correct handling of allocn(0, 1, d)
Fixes #29.
R=r
https://golang.org/cl/152076
Russ Cox [Wed, 11 Nov 2009 22:52:15 +0000 (14:52 -0800)]
gotest: add LC_ALL=C
R=r
https://golang.org/cl/154067
Russ Cox [Wed, 11 Nov 2009 22:52:08 +0000 (14:52 -0800)]
getc/ungetc in assemblers; BUFSIZ everywhere.
Fixes #67.
R=r
https://golang.org/cl/154068
Russ Cox [Wed, 11 Nov 2009 22:51:53 +0000 (14:51 -0800)]
point at how to get easy_install on Ubuntu.
Fixes #59.
Add note about export.
R=r
https://golang.org/cl/152079
Russ Cox [Wed, 11 Nov 2009 22:48:33 +0000 (14:48 -0800)]
two gopack nits.
1. allocate an extra byte for use by write.
2. throw away the code trying to translate
uid and gid to names. i suspect it of causing
seg faults in some situations, and it is
not needed by the compilers.
Fixes #48. (I hope.)
R=r
https://golang.org/cl/152077
Adam Langley [Wed, 11 Nov 2009 21:30:47 +0000 (13:30 -0800)]
Revert make.bash which slipped into the previous revision.
R=rsc
http://codereview.prom.corp.google.com/
1024051
Adam Langley [Wed, 11 Nov 2009 21:21:37 +0000 (13:21 -0800)]
Reland
a112249da741 , this time with missing file.
Russ Cox [Wed, 11 Nov 2009 21:08:35 +0000 (13:08 -0800)]
avoid clash with stdio's getc, ungetc.
Fixes #50.
R=r
https://golang.org/cl/154064
Russ Cox [Wed, 11 Nov 2009 21:07:46 +0000 (13:07 -0800)]
log test: don't assume a fixed set of letters for $GOROOT
Fixes #27.
R=r
https://golang.org/cl/152075
Russ Cox [Wed, 11 Nov 2009 20:54:52 +0000 (12:54 -0800)]
roll back 3985: build is broken
TBR=agl1
CC=golang-dev
https://golang.org/cl/154065
Adam Langley [Wed, 11 Nov 2009 20:34:46 +0000 (12:34 -0800)]
big:
Turn methods that don't store the result in their receiver into
functions in order to preserve the convention.
Re-jig Exp and Div by moving their guts into nat.go.
Add ProbablyPrime to perform Miller-Rabin primality tests.
crypto/rsa: reenable key generation since we now have ProbablyPrime.
R=gri
CC=go-dev
http://codereview.prom.corp.google.com/
1024038
Russ Cox [Wed, 11 Nov 2009 20:00:50 +0000 (12:00 -0800)]
work with GNU Make 3.80
Fixes #30.
R=r1, r
https://golang.org/cl/154061
Russ Cox [Wed, 11 Nov 2009 20:00:41 +0000 (12:00 -0800)]
gc: increase maximum path size in getwd from 100 to 1000.
Fixes #31.
To try the fix before the next release:
hg pull -u
R=r1, r
https://golang.org/cl/154058
Russ Cox [Wed, 11 Nov 2009 20:00:34 +0000 (12:00 -0800)]
os: do not test error case of TestRemoveAll when root
Fixes #22.
R=r1, r
https://golang.org/cl/152073
Russ Cox [Wed, 11 Nov 2009 20:00:15 +0000 (12:00 -0800)]
use fully qualified names for hash interfaces
Fixes #38.
R=r1, r
https://golang.org/cl/152072
Rob Pike [Wed, 11 Nov 2009 19:44:27 +0000 (11:44 -0800)]
add a paragraph in the FAQ about the situation with Windows support
R=rsc, iant
CC=golang-dev
https://golang.org/cl/154059
Adam Langley [Wed, 11 Nov 2009 19:19:33 +0000 (11:19 -0800)]
gopack: convert long to time_t before taking a pointer.
Fixes #40.
R=rsc, r1
CC=golang-dev
https://golang.org/cl/154057
Adam Langley [Wed, 11 Nov 2009 19:18:17 +0000 (11:18 -0800)]
docs: list make as a build dep.
Fixes #45.
R=rsc, r1
CC=golang-dev
https://golang.org/cl/154055
Russ Cox [Wed, 11 Nov 2009 07:42:21 +0000 (23:42 -0800)]
lib9: rip out platform specific code that breaks on pclinuxos
R=r
CC=golang-dev
https://golang.org/cl/154049
Russ Cox [Wed, 11 Nov 2009 04:11:16 +0000 (20:11 -0800)]
move release tag
R=r
https://golang.org/cl/154045
Kevin Ballard [Wed, 11 Nov 2009 04:05:24 +0000 (20:05 -0800)]
Implement new emacs command M-x gofmt
Define a new interactive function in go-mode.el called gofmt.
This function passes the current buffer through the external `gofmt`
tool and replaces the buffer with the result.
R=agl, rsc
https://golang.org/cl/154044
Kevin Ballard [Wed, 11 Nov 2009 04:04:14 +0000 (20:04 -0800)]
Fix go-mode.el to work on empty buffers
Fixes #8.
R=agl, agl1, rsc
https://golang.org/cl/153056
Russ Cox [Wed, 11 Nov 2009 03:59:22 +0000 (19:59 -0800)]
update old comment: things are much better now
R=r
https://golang.org/cl/152057
Russ Cox [Wed, 11 Nov 2009 03:56:32 +0000 (19:56 -0800)]
gotest: avoid problems with grepping for ·
Fixes #7.
R=r
CC=golang-dev
https://golang.org/cl/154043
Russ Cox [Wed, 11 Nov 2009 03:34:31 +0000 (19:34 -0800)]
install.html: ed needs to be installed too
Fixes #14.
R=r
https://golang.org/cl/152052
Russ Cox [Wed, 11 Nov 2009 03:20:34 +0000 (19:20 -0800)]
make.bash: check $PATH indirectly via which quietgcc
R=agl1
CC=golang-dev
https://golang.org/cl/152056
Russ Cox [Wed, 11 Nov 2009 03:12:22 +0000 (19:12 -0800)]
sanity check environment variables better.
Fixes #12.
R=agl1
CC=golang-dev
https://golang.org/cl/152055
Kevin Ballard [Wed, 11 Nov 2009 02:44:20 +0000 (18:44 -0800)]
Adding myself (Kevin Ballard) to the AUTHORS/CONTRIBUTORS files
R=rsc
https://golang.org/cl/153055
Russ Cox [Wed, 11 Nov 2009 02:27:26 +0000 (18:27 -0800)]
net: fix error for connect to /etc/ on some systems
R=agl1
CC=golang-dev
https://golang.org/cl/152051
Rob Pike [Wed, 11 Nov 2009 02:24:06 +0000 (18:24 -0800)]
fix final program to have Html->HTML
R=rsc
CC=go-dev
https://golang.org/cl/152050
Russ Cox [Wed, 11 Nov 2009 02:06:50 +0000 (18:06 -0800)]
change code review link to appspot.
R=r
https://golang.org/cl/153051
Russ Cox [Wed, 11 Nov 2009 02:00:48 +0000 (18:00 -0800)]
test for invalid $GOBIN setting before trying to build
R=r
CC=golang-dev
https://golang.org/cl/153049
Russ Cox [Wed, 11 Nov 2009 02:00:27 +0000 (18:00 -0800)]
net: disable more ipv6 tests
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153050
Russ Cox [Wed, 11 Nov 2009 01:47:38 +0000 (17:47 -0800)]
net: disable ipv6 test if we know kernel won't take it.
R=agl, agl1
CC=golang-dev
https://golang.org/cl/153048
Russ Cox [Wed, 11 Nov 2009 01:39:01 +0000 (17:39 -0800)]
net: disable dns error test
some dns resolvers (opendns, for example)
are willing to make up results for any name.
R=agl, agl1
CC=golang-dev
https://golang.org/cl/152049
Russ Cox [Wed, 11 Nov 2009 01:09:33 +0000 (17:09 -0800)]
net: fix dns bug reported on irc.
if suffixes don't work, check for name directly.
also fixes short names like bit.ly when ndots>1.
tested by tossing domain and search lines from /etc/resolv.conf
Fixes #2.
R=agl, agl1
CC=golang-dev
https://golang.org/cl/152048
Russ Cox [Wed, 11 Nov 2009 01:05:07 +0000 (17:05 -0800)]
video is ready
R=r
http://codereview.prom.corp.google.com/
1024050
Robert Griesemer [Tue, 10 Nov 2009 23:33:59 +0000 (15:33 -0800)]
better code for a copy loop
R=rsc
https://golang.org/cl/152046
Russ Cox [Tue, 10 Nov 2009 23:18:40 +0000 (15:18 -0800)]
default to codereview.appspot.com
R=r
http://codereview.prom.corp.google.com/
1026040
Ken Thompson [Tue, 10 Nov 2009 23:05:15 +0000 (15:05 -0800)]
spell it with an "e"
R=rsc
http://go/go-review/
1025037
Russ Cox [Tue, 10 Nov 2009 22:47:23 +0000 (14:47 -0800)]
video is coming soon
R=r
http://go/go-review/
1024049
Russ Cox [Tue, 10 Nov 2009 22:15:36 +0000 (14:15 -0800)]
delete old release tag
Russ Cox [Tue, 10 Nov 2009 22:12:32 +0000 (14:12 -0800)]
tag for public release
Russ Cox [Tue, 10 Nov 2009 22:09:01 +0000 (14:09 -0800)]
update video links
R=r
http://go/go-review/
1024048
Robert Griesemer [Tue, 10 Nov 2009 18:55:53 +0000 (10:55 -0800)]
minor adjustments to package comments for better synopsis.
R=rsc
CC=r
http://go/go-review/
1026038
Russ Cox [Tue, 10 Nov 2009 17:44:04 +0000 (09:44 -0800)]
correct mailing list URL
R=r
http://go/go-review/
1024047
Russ Cox [Tue, 10 Nov 2009 17:37:03 +0000 (09:37 -0800)]
remove internal references from doc/install.html
and doc/contribute.html.
add #go-nuts to help section on nav bar.
R=r
http://go/go-review/
1025035
Russ Cox [Tue, 10 Nov 2009 17:36:48 +0000 (09:36 -0800)]
make regexp comment not a package comment
R=r
http://go/go-review/
1025036
Russ Cox [Tue, 10 Nov 2009 17:10:08 +0000 (09:10 -0800)]
allow user agent to mention Go.
R=r
http://go/go-review/
1024046
Ian Lance Taylor [Tue, 10 Nov 2009 08:09:53 +0000 (00:09 -0800)]
Minor tweaks.
The text changes are trivial and may be ignored, but there are
two code corrections.
R=r, rsc
CC=go-dev
http://go/go-review/
1024045
Rob Pike [Tue, 10 Nov 2009 07:54:35 +0000 (23:54 -0800)]
make the titles of the FAQs match their links; adds clarity too. requested by rsc.
R=rsc
CC=go-dev
http://go/go-review/
1025034
Robert Griesemer [Tue, 10 Nov 2009 07:22:04 +0000 (23:22 -0800)]
- add .. link to package directory listing, for easy traversal
- matches style of source file directory listing
R=rsc
http://go/go-review/
1024044
Russ Cox [Tue, 10 Nov 2009 07:12:09 +0000 (23:12 -0800)]
in addition to bison, need to have gcc and c libraries installed.
R=r
http://go/go-review/
1024043
Russ Cox [Tue, 10 Nov 2009 07:11:36 +0000 (23:11 -0800)]
drop output from nilptr tests;
too hard to make it the same everywhere.
still checking for non-zero exit status though.
disable core files while running tests
R=r
http://go/go-review/
1026037
Robert Griesemer [Tue, 10 Nov 2009 06:30:07 +0000 (22:30 -0800)]
- minor cleanups
- better debugging support
- gofmt -l src misc | wc -l is 0
R=rsc
http://go/go-review/
1024042
Robert Griesemer [Tue, 10 Nov 2009 05:23:52 +0000 (21:23 -0800)]
- replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)
R=rsc, r
http://go/go-review/
1024041
Robert Griesemer [Tue, 10 Nov 2009 05:13:17 +0000 (21:13 -0800)]
- replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/
1026036
Robert Griesemer [Tue, 10 Nov 2009 05:09:34 +0000 (21:09 -0800)]
- replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/
1024040
Rob Pike [Tue, 10 Nov 2009 04:25:45 +0000 (20:25 -0800)]
add a q&a about google's internal use of go
R=rsc
CC=go-dev
http://go/go-review/
1026035
Russ Cox [Tue, 10 Nov 2009 01:09:33 +0000 (17:09 -0800)]
noted by kaib: explicit assignment initialization
didn't match the composite literal initialization.
R=r
CC=kaib
http://go/go-review/
1024039
Russ Cox [Tue, 10 Nov 2009 00:56:17 +0000 (16:56 -0800)]
add id tags to contribute.html
R=r
http://go/go-review/
1025033
Robert Griesemer [Tue, 10 Nov 2009 00:19:38 +0000 (16:19 -0800)]
cleanup style:
- consistently remove all underbars from links
- this removes need for noline style
- removed unused info style
R=r, rsc
http://go/go-review/
1025032
Rob Pike [Tue, 10 Nov 2009 00:09:57 +0000 (16:09 -0800)]
comment out red TODO clauses except for the last one
R=rsc
CC=go-dev
http://go/go-review/
1024037
Russ Cox [Mon, 9 Nov 2009 23:25:18 +0000 (15:25 -0800)]
error rewording suggested by robert.
update comment.
R=ken
http://go/go-review/
1025031
Robert Griesemer [Mon, 9 Nov 2009 22:49:01 +0000 (14:49 -0800)]
make search box ever so slightly wider
R=rsc
http://go/go-review/
1024036
Robert Griesemer [Mon, 9 Nov 2009 22:44:16 +0000 (14:44 -0800)]
TBR:
fix typo that prevented function bodies from being indexed (ouch!)
R=rsc
http://go/go-review/
1024035
Robert Griesemer [Mon, 9 Nov 2009 20:35:56 +0000 (12:35 -0800)]
fix for incorrect composite literal grammar
(issue found by ken)
R=go-dev, rsc
http://go/go-review/
1025030