]> Cypherpunks repositories - gostls13.git/log
gostls13.git
12 years ago[release-branch.go1] cmd/gc: Don't claim type assertion would help when it wont.
Daniel Morsing [Fri, 21 Sep 2012 19:54:37 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: Don't claim type assertion would help when it wont.

««« backport b76339cc168a
cmd/gc: Don't claim type assertion would help when it wont.

Fixes #3465.

R=golang-dev, rsc, remyoudompheng, iant
CC=golang-dev
https://golang.org/cl/6448097

»»»

12 years ago[release-branch.go1] A+C: Andrew Lutomirski (individual CLA)
Ian Lance Taylor [Fri, 21 Sep 2012 19:54:37 +0000 (05:54 +1000)]
[release-branch.go1] A+C: Andrew Lutomirski (individual CLA)

««« backport 8714f560df67
A+C: Andrew Lutomirski (individual CLA)

Wrote code that was the basis for
https://golang.org/cl/6454046/

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6450142

»»»

12 years ago[release-branch.go1] runtime/pprof: fix comments
Dmitriy Vyukov [Fri, 21 Sep 2012 19:54:36 +0000 (05:54 +1000)]
[release-branch.go1] runtime/pprof: fix comments

««« backport e7e49c318134
runtime/pprof: fix comments

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/6460082

»»»

12 years ago[release-branch.go1] text/template/parse: fix bug handling /*/
Andrew Gerrand [Fri, 21 Sep 2012 19:54:36 +0000 (05:54 +1000)]
[release-branch.go1] text/template/parse: fix bug handling /*/

12 years ago[release-branch.go1] runtime: use sched_getaffinity for runtime.NumCPU() on Linux
Shenghou Ma [Fri, 21 Sep 2012 19:54:36 +0000 (05:54 +1000)]
[release-branch.go1] runtime: use sched_getaffinity for runtime.NumCPU() on Linux

««« backport 3532ab6bf5be
runtime: use sched_getaffinity for runtime.NumCPU() on Linux
        Fixes #3921.

R=iant
CC=golang-dev
https://golang.org/cl/6448132

»»»

12 years ago[release-branch.go1] go/build: correct shouldBuild bug reading whole contents of...
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:35 +0000 (05:54 +1000)]
[release-branch.go1] go/build: correct shouldBuild bug reading whole contents of file.

««« backport 307fafbc2d6f
go/build: correct shouldBuild bug reading whole contents of file.

It was caused by bytes.TrimSpace being able to return a nil
slice.

Fixes #3914.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6458091

»»»

12 years ago[release-branch.go1] spec: clarify evaluation order
Robert Griesemer [Fri, 21 Sep 2012 19:54:35 +0000 (05:54 +1000)]
[release-branch.go1] spec: clarify evaluation order

««« backport 6beada1bf6c2
spec: clarify evaluation order

Fixes #3852.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6441102

»»»

12 years ago[release-branch.go1] math: update definition of NaN in assembly language files
Charles L. Dorian [Fri, 21 Sep 2012 19:54:34 +0000 (05:54 +1000)]
[release-branch.go1] math: update definition of NaN in assembly language files

««« backport f26c1758e269
math: update definition of NaN in assembly language files

R=rsc, minux.ma, golang-dev, nigeltao
CC=golang-dev
https://golang.org/cl/6461047

»»»

12 years ago[release-branch.go1] doc: add 'Get Started with Go' video, remove some older videos
Andrew Gerrand [Fri, 21 Sep 2012 19:54:34 +0000 (05:54 +1000)]
[release-branch.go1] doc: add 'Get Started with Go' video, remove some older videos

««« backport 77b1cdceb2b2
doc: add 'Get Started with Go' video, remove some older videos

(I also updated the wiki's GoTalks page with all the latest videos.)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6441113

»»»

12 years ago[release-branch.go1] io: amend ReaderFrom doc as per r's comment
Andrew Gerrand [Fri, 21 Sep 2012 19:54:33 +0000 (05:54 +1000)]
[release-branch.go1] io: amend ReaderFrom doc as per r's comment

««« backport 5d3aaf0b717e
io: amend ReaderFrom doc as per r's comment

R=r
CC=golang-dev
https://golang.org/cl/6458097

»»»

12 years ago[release-branch.go1] crypto/rand: Example for Read.
Yves Junqueira [Fri, 21 Sep 2012 19:54:33 +0000 (05:54 +1000)]
[release-branch.go1] crypto/rand: Example for Read.

««« backport 4738fd47e7a9
crypto/rand: Example for Read.

R=adg, remyoudompheng, rsc, r
CC=golang-dev
https://golang.org/cl/6457085

»»»

12 years ago[release-branch.go1] godoc: make id attributes unique
Robert Griesemer [Fri, 21 Sep 2012 19:54:32 +0000 (05:54 +1000)]
[release-branch.go1] godoc: make id attributes unique

««« backport b5dd89dce002
godoc: make id attributes unique

Some browsers (e.g. IE9) ignore the case of 'id' attributes
which can lead to conflicts. Prefix non-generated 'id's with
"pkg-" to make them different from any generated attribute.

Also: Added missing entry for "Other packages" to top-level
index.

Fixes #3851.

R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/6449105

»»»

12 years ago[release-branch.go1] image/jpeg: send a correct Start Of Scan (SOS) header.
Nigel Tao [Fri, 21 Sep 2012 19:54:32 +0000 (05:54 +1000)]
[release-branch.go1] image/jpeg: send a correct Start Of Scan (SOS) header.

««« backport 4a67b1f1e771
image/jpeg: send a correct Start Of Scan (SOS) header.

Section B.2.3 of http://www.w3.org/Graphics/JPEG/itu-t81.pdf discusses
the End of spectral selection (Se) byte.

Apparently many JPEG decoders ignore the Se byte (or let it through
with a warning), but some configurations reject them. For example,
http://download.blender.org/source/chest/blender_2.03_tree/jpeg/jcmaster.c
has these lines:

if (Ss != 0 || Se != DCTSIZE2-1 || Ah != 0 || Al != 0)
  ERREXIT1(cinfo, JERR_BAD_PROG_SCRIPT, scanno);

Fixes #3916.

R=r
CC=golang-dev
https://golang.org/cl/6459052

»»»

12 years ago[release-branch.go1] io: document ReaderFrom and WriterTo
Brad Fitzpatrick [Fri, 21 Sep 2012 19:54:31 +0000 (05:54 +1000)]
[release-branch.go1] io: document ReaderFrom and WriterTo

««« backport 4e3a1967af09
io: document ReaderFrom and WriterTo

Fixes #3711

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6445083

»»»

12 years ago[release-branch.go1] text/template: fix range example.
Yves Junqueira [Fri, 21 Sep 2012 19:54:31 +0000 (05:54 +1000)]
[release-branch.go1] text/template: fix range example.

««« backport c37d3a28f6b0
text/template: fix range example.

R=r
CC=adg, gobot, golang-dev
https://golang.org/cl/6449096

»»»

12 years ago[release-branch.go1] doc: fix some HTML syntax errors
Shenghou Ma [Fri, 21 Sep 2012 19:54:30 +0000 (05:54 +1000)]
[release-branch.go1] doc: fix some HTML syntax errors

««« backport 4adee56240ac
doc: fix some HTML syntax errors

R=adg
CC=golang-dev
https://golang.org/cl/6458043

»»»

12 years ago[release-branch.go1] cmd/go: remove $WORK paths in generated binaries
Shenghou Ma [Fri, 21 Sep 2012 19:54:30 +0000 (05:54 +1000)]
[release-branch.go1] cmd/go: remove $WORK paths in generated binaries

««« backport c1ce95068533
cmd/go: remove $WORK paths in generated binaries
        Fixes #3748.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6357064

»»»

12 years ago[release-branch.go1] math, runtime: use a NaN that matches gcc's
Shenghou Ma [Fri, 21 Sep 2012 19:54:29 +0000 (05:54 +1000)]
[release-branch.go1] math, runtime: use a NaN that matches gcc's

««« backport 1f62df249175
math, runtime: use a NaN that matches gcc's
        our old choice is not working properly at least on VFPv2 in
ARM1136JF-S (it's not preserved across float64->float32 conversions).

        Fixes #3745.

R=dave, rsc
CC=golang-dev
https://golang.org/cl/6344078

»»»

12 years ago[release-branch.go1] runtime: remove unnecessary ROUND in alg.c
Shenghou Ma [Fri, 21 Sep 2012 19:54:29 +0000 (05:54 +1000)]
[release-branch.go1] runtime: remove unnecessary ROUND in alg.c

««« backport 4bd268b3c88a
runtime: remove unnecessary ROUND in alg.c
        Introduced in CL 6452046.

R=golang-dev, nigeltao, dave
CC=golang-dev
https://golang.org/cl/6459051

»»»

12 years ago[release-branch.go1] syscall: fix plan9 build broken by CL 6458050
Andrew Gerrand [Fri, 21 Sep 2012 19:54:29 +0000 (05:54 +1000)]
[release-branch.go1] syscall: fix plan9 build broken by CL 6458050

12 years ago[release-branch.go1] net: fix TCPListener file leak to child processes
Brad Fitzpatrick [Fri, 21 Sep 2012 19:54:28 +0000 (05:54 +1000)]
[release-branch.go1] net: fix TCPListener file leak to child processes

««« backport 75a21418ac8f
net: fix TCPListener file leak to child processes

Hold ForkLock during dup of fd + cloexec in the net pkg,
per the locking policy documented in syscall/exec_unix.go.

R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/6457080

»»»

12 years ago[release-branch.go1] syscall: return EINVAL when string arguments have NUL characters
Andrew Gerrand [Fri, 21 Sep 2012 19:54:28 +0000 (05:54 +1000)]
[release-branch.go1] syscall: return EINVAL when string arguments have NUL characters

12 years ago[release-branch.go1] syscall: add some new syscall numbers from NetBSD-current
Benny Siegert [Fri, 21 Sep 2012 19:54:27 +0000 (05:54 +1000)]
[release-branch.go1] syscall: add some new syscall numbers from NetBSD-current

««« backport 98c1ecd82cb5
syscall: add some new syscall numbers from NetBSD-current

R=golang-dev
CC=golang-dev
https://golang.org/cl/6454100

»»»

12 years ago[release-branch.go1] bufio: discourage use of ReadLine
Russ Cox [Fri, 21 Sep 2012 19:54:27 +0000 (05:54 +1000)]
[release-branch.go1] bufio: discourage use of ReadLine

««« backport 9e2011d9ed4b
bufio: discourage use of ReadLine

Too many people use it without reading what it does.
Those people want ReadBytes or ReadString.

Fixes #3906.

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/6442087

»»»

12 years ago[release-branch.go1] cmd/8g: fix miscompilation due to BADWIDTH.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:26 +0000 (05:54 +1000)]
[release-branch.go1] cmd/8g: fix miscompilation due to BADWIDTH.

««« backport f6a6fe780649
cmd/8g: fix miscompilation due to BADWIDTH.

Fixes #3899.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6453084

»»»

12 years ago[release-branch.go1] cmd/gc: accept switches on comparable arrays.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:26 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: accept switches on comparable arrays.

««« backport d68605d10a6b
cmd/gc: accept switches on comparable arrays.

The compiler is incorrectly rejecting switches on arrays of
comparable types. It also doesn't catch incomparable structs
when typechecking the switch, leading to unreadable errors
during typechecking of the generated code.

Fixes #3894.

R=rsc
CC=gobot, golang-dev, r, remy
https://golang.org/cl/6442074

»»»

12 years ago[release-branch.go1] go/build: tiny cleanup
Robert Griesemer [Fri, 21 Sep 2012 19:54:25 +0000 (05:54 +1000)]
[release-branch.go1] go/build: tiny cleanup

««« backport 30dfc01b473c
go/build: tiny cleanup

R=rsc
CC=golang-dev
https://golang.org/cl/6453083

»»»

12 years ago[release-branch.go1] os: test that IsExist and IsNotExist handle PathError and LinkError
Alex Brainman [Fri, 21 Sep 2012 19:54:25 +0000 (05:54 +1000)]
[release-branch.go1] os: test that IsExist and IsNotExist handle PathError and LinkError

««« backport 32eb6dac3ff4
os: test that IsExist and IsNotExist handle PathError and LinkError

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6442080

»»»

12 years ago[release-branch.go1] go/scanner: fix minor typo
Robert Griesemer [Fri, 21 Sep 2012 19:54:24 +0000 (05:54 +1000)]
[release-branch.go1] go/scanner: fix minor typo

««« backport c74762fb2e1d
go/scanner: fix minor typo

R=r
CC=golang-dev
https://golang.org/cl/6442076

»»»

12 years ago[release-branch.go1] go/ast: ast.Print must not crash with unexported fields
Robert Griesemer [Fri, 21 Sep 2012 19:54:24 +0000 (05:54 +1000)]
[release-branch.go1] go/ast: ast.Print must not crash with unexported fields

««« backport d134e30c4d29
go/ast: ast.Print must not crash with unexported fields

Don't print unexported struct fields; their values are
not accessible via reflection.

Fixes #3898.

Also:
- added support for arrays
- print empty maps, arrays, slices, structs on one line
  for a denser output
- added respective test cases

R=r
CC=golang-dev
https://golang.org/cl/6454089

»»»

12 years ago[release-branch.go1] runtime: round return value address in runtime.equal
Shenghou Ma [Fri, 21 Sep 2012 19:54:23 +0000 (05:54 +1000)]
[release-branch.go1] runtime: round return value address in runtime.equal

««« backport a7752d169d2e
runtime: round return value address in runtime.equal
     Fixes #3866.

R=rsc, r, nigeltao
CC=golang-dev
https://golang.org/cl/6452046

»»»

12 years ago[release-branch.go1] os: Rename error to fit IsExist
Alex Brainman [Fri, 21 Sep 2012 19:54:23 +0000 (05:54 +1000)]
[release-branch.go1] os: Rename error to fit IsExist

««« backport 104eb57df01b
os: Rename error to fit IsExist

Fixes #3828.

R=golang-dev, iant, rsc
CC=golang-dev
https://golang.org/cl/6420056

»»»

12 years ago[release-branch.go1] cmd/gc: fix inlining bug with receive operator.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:22 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: fix inlining bug with receive operator.

««« backport d872ed20fccb
cmd/gc: fix inlining bug with receive operator.

The receive operator was given incorrect precedence
resulting in incorrect deletion of parentheses.

Fixes #3843.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6442049

»»»

12 years ago[release-branch.go1] cmd/cgo: use 1 as last entry for __cgodebug_data
Shenghou Ma [Fri, 21 Sep 2012 19:54:22 +0000 (05:54 +1000)]
[release-branch.go1] cmd/cgo: use 1 as last entry for __cgodebug_data

««« backport aeaab9df5600
cmd/cgo: use 1 as last entry for __cgodebug_data
        LLVM-based gcc will place all-zero data in a zero-filled
        section, but our debug/macho can't handle that.
        Fixes #3821.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6444049

»»»

12 years ago[release-branch.go1] regexp: fix glitch in doc for FindReaderIndex
Rob Pike [Fri, 21 Sep 2012 19:54:21 +0000 (05:54 +1000)]
[release-branch.go1] regexp: fix glitch in doc for FindReaderIndex

««« backport 6f790a92b3d2
regexp: fix glitch in doc for FindReaderIndex
Fixes #3878.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6457054

»»»

12 years ago[release-branch.go1] doc: remove mention of weekly tag from source install doc
Andrew Gerrand [Fri, 21 Sep 2012 19:54:21 +0000 (05:54 +1000)]
[release-branch.go1] doc: remove mention of weekly tag from source install doc

««« backport 8c4b1b7ce761
doc: remove mention of weekly tag from source install doc

R=golang-dev, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/6442062

»»»

12 years ago[release-branch.go1] cmd/go: show $GOPATH in 'go env' output
Russ Cox [Fri, 21 Sep 2012 19:54:20 +0000 (05:54 +1000)]
[release-branch.go1] cmd/go: show $GOPATH in 'go env' output

««« backport d6d7de5aa8ed
cmd/go: show $GOPATH in 'go env' output

Also, sort output.

R=golang-dev, patrick, dave, iant
CC=golang-dev, patrick
https://golang.org/cl/6446064

»»»

12 years ago[release-branch.go1] net/http: don't allow zero byte in FileServer paths
Brad Fitzpatrick [Fri, 21 Sep 2012 19:54:20 +0000 (05:54 +1000)]
[release-branch.go1] net/http: don't allow zero byte in FileServer paths

««« backport 2307a931664e
net/http: don't allow zero byte in FileServer paths

Should probably be fixed in the syscall package, either
additional or instead of this CL.

Fixes #3842

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6442061

»»»

12 years ago[release-branch.go1] cmd/gc: point "no new variables" error at right line number.
Daniel Morsing [Fri, 21 Sep 2012 19:54:19 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: point "no new variables" error at right line number.

««« backport 98788e8973f2
cmd/gc: point "no new variables" error at right line number.

Fixes #3856.

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/6455056

»»»

12 years ago[release-branch.go1] syscall: apply comment from Mikioh
Russ Cox [Fri, 21 Sep 2012 19:54:19 +0000 (05:54 +1000)]
[release-branch.go1] syscall: apply comment from Mikioh

««« backport d191515c80fb
syscall: apply comment from Mikioh

This comment was suggested in CL 6456045
but never got applied.

R=mikioh, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6447056

»»»

12 years ago[release-branch.go1] syscall: workaround accept() bug on Darwin
Alexey Borzenkov [Fri, 21 Sep 2012 19:54:18 +0000 (05:54 +1000)]
[release-branch.go1] syscall: workaround accept() bug on Darwin

««« backport 0eae95b0307a
syscall: workaround accept() bug on Darwin

Darwin kernels have a bug in accept() where error result from
an internal call is not checked and socket is accepted instead
of ECONNABORTED error. However, such sockets have no sockaddr,
which results in EAFNOSUPPORT error from anyToSockaddr, making
Go http servers running on Mac OS X easily susceptible to
denial of service from simple port scans with nmap.
Fixes #3849.

R=golang-dev, adg, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/6456045

»»»

12 years ago[release-branch.go1] runtime/cgo: fix netbsd build
Benny Siegert [Fri, 21 Sep 2012 19:54:18 +0000 (05:54 +1000)]
[release-branch.go1] runtime/cgo: fix netbsd build

««« backport 601878acd597
runtime/cgo: fix netbsd build

Copy over freebsd.c to netbsd.c.

Fixes #3823.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6398045

»»»

12 years ago[release-branch.go1] misc/vim: fix :Import insertion heuristic.
David Symonds [Fri, 21 Sep 2012 19:54:17 +0000 (05:54 +1000)]
[release-branch.go1] misc/vim: fix :Import insertion heuristic.

««« backport 9bf2225c38eb
misc/vim: fix :Import insertion heuristic.

If a factored import group has a blank line, assume it is dividing
separate groups of imports (e.g. standard library vs. site-specific).
        import (
                "bytes"
                "io"

                "mycorp/package"
        )

The most common case is inserting new standard library imports,
which are usually (stylistically) the first group, so we should drop
"net" in the above example immediately after "io".

Since this logic is getting non-trivial, add a test.

R=golang-dev, minux.ma, franciscossouza
CC=golang-dev
https://golang.org/cl/6445043

»»»

12 years ago[release-branch.go1] flag: fix bug in handling of booleans on error
Rob Pike [Fri, 21 Sep 2012 19:54:17 +0000 (05:54 +1000)]
[release-branch.go1] flag: fix bug in handling of booleans on error

««« backport a36c0344826a
flag: fix bug in handling of booleans on error
Fixes #3869.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6448072

»»»

12 years ago[release-branch.go1] log/syslog: don't append \n if there is one
Shenghou Ma [Fri, 21 Sep 2012 19:54:16 +0000 (05:54 +1000)]
[release-branch.go1] log/syslog: don't append \n if there is one

««« backport 6556a8d85dd6
log/syslog: don't append \n if there is one
   pkg log already appends a linefeed to the log message,
so log/syslog doesn't need to append another.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6441048

»»»

12 years ago[release-branch.go1] os: move epipecheck from file_posix.go and into file_unix.go...
Alex Brainman [Fri, 21 Sep 2012 19:54:16 +0000 (05:54 +1000)]
[release-branch.go1] os: move epipecheck from file_posix.go and into file_unix.go to fix windows build

««« backport d127749038e8
os: move epipecheck from file_posix.go and into file_unix.go to fix windows build

R=golang-dev
CC=golang-dev
https://golang.org/cl/6450058

»»»

12 years ago[release-branch.go1] os: fix data race in epipecheck()
Dmitriy Vyukov [Fri, 21 Sep 2012 19:54:15 +0000 (05:54 +1000)]
[release-branch.go1] os: fix data race in epipecheck()

««« backport 8b3bf65c620c
os: fix data race in epipecheck()
Fixes #3860.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6443051

»»»

12 years ago[release-branch.go1] runtime: ignore signal 33 == SIGSETXID on GNU/Linux
Ian Lance Taylor [Fri, 21 Sep 2012 19:54:14 +0000 (05:54 +1000)]
[release-branch.go1] runtime: ignore signal 33 == SIGSETXID on GNU/Linux

««« backport bfa4e1f1027f
runtime: ignore signal 33 == SIGSETXID on GNU/Linux

When a cgo program calls setuid, setgid, etc., the GNU/Linux
pthread library sends signal SIGSETXID to each thread to tell
it to update its UID info.  If Go is permitted to intercept
the default SIGSETXID signal handler, the program will hang.

This patch tells the runtime package to not try to intercept
SIGSETXID on GNU/Linux.  This will be odd if a Go program
wants to try to use that signal, but it means that cgo
programs that call setuid, etc., won't hang.

Fixes #3871.

R=rsc, r, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/6455050

»»»

12 years ago[release-branch.go1] go/printer: don't crash if ast.FuncType.Params is nil
Robert Griesemer [Fri, 21 Sep 2012 19:54:14 +0000 (05:54 +1000)]
[release-branch.go1] go/printer: don't crash if ast.FuncType.Params is nil

««« backport 7f6a0510d3c9
go/printer: don't crash if ast.FuncType.Params is nil

The go/ast comment for FuncType.Params says that the field may be nil.
Make sure the printer accepts such a value. The go/parser always sets
the field (to provide parenthesis position information), but a program
creating a Go AST from scatch may not.

Added corresponding test case.

Fixes #3870.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6448060

»»»

12 years ago[release-branch.go1] A+C: added Andrew Wilkins (individual contributor)
Robert Griesemer [Fri, 21 Sep 2012 19:54:13 +0000 (05:54 +1000)]
[release-branch.go1] A+C: added Andrew Wilkins (individual contributor)

««« backport b22edea8aed4
A+C: added Andrew Wilkins (individual contributor)

R=rsc, minux.ma, iant
CC=golang-dev
https://golang.org/cl/6447050

»»»

12 years ago[release-branch.go1] cgo: fix declarations in _cgo_export.c
Ian Lance Taylor [Fri, 21 Sep 2012 19:54:13 +0000 (05:54 +1000)]
[release-branch.go1] cgo: fix declarations in _cgo_export.c

««« backport 6751a0e1a6a4
cgo: fix declarations in _cgo_export.c

Declare crosscall2.  Declare the functions passed to it as
returning void, rather than relying on implicit return type.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/6432060

»»»

12 years ago[release-branch.go1] testing: allow concurrent use of T and B
Brad Fitzpatrick [Fri, 21 Sep 2012 19:54:12 +0000 (05:54 +1000)]
[release-branch.go1] testing: allow concurrent use of T and B

««« backport 7a67d277c7e8
testing: allow concurrent use of T and B

Notably, allow concurrent logging and failing.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6453045

»»»

12 years ago[release-branch.go1] net: fix comment
Mikio Hara [Fri, 21 Sep 2012 19:54:12 +0000 (05:54 +1000)]
[release-branch.go1] net: fix comment

««« backport 5a0aafb7fd8d
net: fix comment

RemoteAddr returns not only UDPAddr but IPAddr.

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/6401054

»»»

12 years ago[release-branch.go1] text/template: fix bug in map indexing
Rob Pike [Fri, 21 Sep 2012 19:54:11 +0000 (05:54 +1000)]
[release-branch.go1] text/template: fix bug in map indexing

««« backport 0748cd92ed76
text/template: fix bug in map indexing
If the key is not present, return value of the type of the element
not the type of the key. Also fix a test that should have caught this case.

Fixes #3850.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6405078

»»»

12 years ago[release-branch.go1] encoding/gob: revert 6348067, which broke compatibility
Rob Pike [Fri, 21 Sep 2012 19:54:11 +0000 (05:54 +1000)]
[release-branch.go1] encoding/gob: revert 6348067, which broke compatibility

««« backport 3357d8d34ab8
encoding/gob: revert 6348067, which broke compatibility
Add commentary to explain better what's going on, but the
code change is a simple one-line reversal to the previous
form.

R=rsc
CC=golang-dev
https://golang.org/cl/6428072

»»»

12 years ago[release-branch.go1] doc: add two I/O talks to "Talks" section
Andrew Gerrand [Fri, 21 Sep 2012 19:54:10 +0000 (05:54 +1000)]
[release-branch.go1] doc: add two I/O talks to "Talks" section

««« backport ddaabb722563
doc: add two I/O talks to "Talks" section

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6422056

»»»

12 years ago[release-branch.go1] encoding/binary: fix typo: ReadVarint returns an int64, not...
Patrick Mylund Nielsen [Fri, 21 Sep 2012 19:54:10 +0000 (05:54 +1000)]
[release-branch.go1] encoding/binary: fix typo: ReadVarint returns an int64, not a uint64.

««« backport 2f39e6389d55
encoding/binary: fix typo: ReadVarint returns an int64, not a uint64.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6432062

»»»

12 years ago[release-branch.go1] net: fix file descriptor leak on FileListener, FileConn and...
Mikio Hara [Fri, 21 Sep 2012 19:54:10 +0000 (05:54 +1000)]
[release-branch.go1] net: fix file descriptor leak on FileListener, FileConn and FilePacketConn

««« backport aee5a494a65c
net: fix file descriptor leak on FileListener, FileConn and FilePacketConn

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6430062

»»»

12 years ago[release-branch.go1] cgo: add -gccgopkgpath option to match gccgo -fgo-pkgpath
Ian Lance Taylor [Fri, 21 Sep 2012 19:54:09 +0000 (05:54 +1000)]
[release-branch.go1] cgo: add -gccgopkgpath option to match gccgo -fgo-pkgpath

««« backport 06e3a4c30dfb
cgo: add -gccgopkgpath option to match gccgo -fgo-pkgpath

R=golang-dev, r, iant
CC=golang-dev
https://golang.org/cl/6416056

»»»

12 years ago[release-branch.go1] net: fix typo
Mikio Hara [Fri, 21 Sep 2012 19:54:09 +0000 (05:54 +1000)]
[release-branch.go1] net: fix typo

««« backport 3019a3e15027
net: fix typo

R=golang-dev, bsiegert, r
CC=golang-dev
https://golang.org/cl/6428050

»»»

12 years ago[release-branch.go1] sync: mention that WaitGroup.Add panics
Rob Pike [Fri, 21 Sep 2012 19:54:08 +0000 (05:54 +1000)]
[release-branch.go1] sync: mention that WaitGroup.Add panics

««« backport 05f9fa32500a
sync: mention that WaitGroup.Add panics
Fixes #3839.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6428053

»»»

12 years ago[release-branch.go1] testing: fix memory blowup when formatting many lines.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:08 +0000 (05:54 +1000)]
[release-branch.go1] testing: fix memory blowup when formatting many lines.

««« backport 5e7fd762f356
testing: fix memory blowup when formatting many lines.

Fixes #3830.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6373047

»»»

12 years ago[release-branch.go1] faq: add status section
Rob Pike [Fri, 21 Sep 2012 19:54:07 +0000 (05:54 +1000)]
[release-branch.go1] faq: add status section

««« backport 2819b5a4f07d
faq: add status section
Fixes #3822.

R=golang-dev, r, dsymonds, minux.ma, adg
CC=golang-dev
https://golang.org/cl/6395043

»»»

12 years ago[release-branch.go1] A+C: Peter Armitage (individual CLA)
Adam Langley [Fri, 21 Sep 2012 19:54:07 +0000 (05:54 +1000)]
[release-branch.go1] A+C: Peter Armitage (individual CLA)

««« backport 0423072b54f2
A+C: Peter Armitage (individual CLA)

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6392065

»»»

12 years ago[release-branch.go1] compress/flate: fix panic when nlit is out of bounds.
Nigel Tao [Fri, 21 Sep 2012 19:54:06 +0000 (05:54 +1000)]
[release-branch.go1] compress/flate: fix panic when nlit is out of bounds.

««« backport ecd688de20fb
compress/flate: fix panic when nlit is out of bounds.

Fixes #3815.

R=r
CC=golang-dev
https://golang.org/cl/6352109

»»»

12 years ago[release-branch.go1] os: add missing full stop in comment
Benny Siegert [Fri, 21 Sep 2012 19:54:06 +0000 (05:54 +1000)]
[release-branch.go1] os: add missing full stop in comment

««« backport c61c67c7b924
os: add missing full stop in comment

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6399047

»»»

12 years ago[release-branch.go1] cmd/gc: reject use of ... with multiple-valued expressions.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:05 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: reject use of ... with multiple-valued expressions.

««« backport 6d5faedd95bc
cmd/gc: reject use of ... with multiple-valued expressions.

Fixes #3334.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6350103

»»»

12 years ago[release-branch.go1] cmd/gc: avoid an internal error on invalid type switch.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:05 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: avoid an internal error on invalid type switch.

««« backport 254232c99b3e
cmd/gc: avoid an internal error on invalid type switch.

The error was caused by a call to implements() even when
the type switch variable was not an interface.

Fixes #3786.

R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6354102

»»»

12 years ago[release-branch.go1] cmd/gc: fix error message for type errors involving conversions.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:04 +0000 (05:54 +1000)]
[release-branch.go1] cmd/gc: fix error message for type errors involving conversions.

««« backport a281d4bd1ba6
cmd/gc: fix error message for type errors involving conversions.

Fixes #3818.

R=golang-dev, rsc, r
CC=golang-dev, remy
https://golang.org/cl/6352106

»»»

12 years ago[release-branch.go1] encoding/gob: fix check for short input in slice decode
Andrew Gerrand [Fri, 21 Sep 2012 19:54:04 +0000 (05:54 +1000)]
[release-branch.go1] encoding/gob: fix check for short input in slice decode

12 years ago[release-branch.go1] spec: correct typo in string conversion examples.
Rémy Oudompheng [Fri, 21 Sep 2012 19:54:03 +0000 (05:54 +1000)]
[release-branch.go1] spec: correct typo in string conversion examples.

««« backport 65de4b905541
spec: correct typo in string conversion examples.

R=golang-dev, dave, r
CC=golang-dev, remy
https://golang.org/cl/6378046

»»»

12 years ago[release-branch.go1] crypto/rsa: left-pad PKCS#1 v1.5 outputs.
Adam Langley [Fri, 21 Sep 2012 19:54:03 +0000 (05:54 +1000)]
[release-branch.go1] crypto/rsa: left-pad PKCS#1 v1.5 outputs.

««« backport 46ca86e70e96
crypto/rsa: left-pad PKCS#1 v1.5 outputs.

OpenSSL requires that RSA signatures be exactly the same byte-length
as the modulus. Currently it'll reject ~1/256 of our signatures: those
that end up a byte shorter.

Fixes #3796.

R=golang-dev, edsrzf, r
CC=golang-dev
https://golang.org/cl/6352093

»»»

12 years ago[release-branch.go1] website: various html fixes
Dave Cheney [Fri, 21 Sep 2012 19:54:02 +0000 (05:54 +1000)]
[release-branch.go1] website: various html fixes

««« backport 744f0397f41a
website: various html fixes

Fixes #3424.

R=fullung, adg
CC=golang-dev
https://golang.org/cl/6343088

»»»

12 years ago[release-branch.go1] crypto/x509: exempt broken Entrust certificate from checks.
Adam Langley [Fri, 21 Sep 2012 19:54:02 +0000 (05:54 +1000)]
[release-branch.go1] crypto/x509: exempt broken Entrust certificate from checks.

««« backport 8241ffc8686e
crypto/x509: exempt broken Entrust certificate from checks.

Entrust have issued a root certificate that's not marked as valid for
signing certificates.

This results in Go programs failing to validate certificates that
chain up to this root (i.e. gateway.push.apple.com:2195).

Although this is clearly a mistake on Entrust's part, it seems that we
will have to bodge around it.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6346064

»»»

12 years ago[release-branch.go1] pkg: Removing duplicated words ("of of", etc.), mostly from...
David G. Andersen [Fri, 21 Sep 2012 19:54:01 +0000 (05:54 +1000)]
[release-branch.go1] pkg: Removing duplicated words ("of of", etc.), mostly from comments.

««« backport ce3a981ad1ef
pkg: Removing duplicated words ("of of", etc.), mostly from comments.

Ran 'double.pl' on the pkg tree to identify doubled words.
One change to an error string return in x509;  the rest are in comments.
Thanks to Matt Jibson for the idea.

R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/6344089

»»»

12 years ago[release-branch.go1] A+C: correct Matt Jibson
Matt Jibson [Fri, 21 Sep 2012 19:54:01 +0000 (05:54 +1000)]
[release-branch.go1] A+C: correct Matt Jibson

««« backport 63dae3ba6a6d
A+C: correct Matt Jibson

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6344088

»»»

12 years ago[release-branch.go1] doc: various "the the" and other typos
Matthew William Jibson [Fri, 21 Sep 2012 19:54:01 +0000 (05:54 +1000)]
[release-branch.go1] doc: various "the the" and other typos

««« backport 74c5c02910de
doc: various "the the" and other typos

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6355076

»»»

12 years ago[release-branch.go1] A+C: Matthew Jibson (individual CLA).
David Symonds [Fri, 21 Sep 2012 19:54:00 +0000 (05:54 +1000)]
[release-branch.go1] A+C: Matthew Jibson (individual CLA).

««« backport 9349fc3302f5
A+C: Matthew Jibson (individual CLA).

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6349082

»»»

12 years ago[release-branch.go1] misc/chrome/gophertool: fix manifest
Shenghou Ma [Fri, 21 Sep 2012 19:53:59 +0000 (05:53 +1000)]
[release-branch.go1] misc/chrome/gophertool: fix manifest

««« backport 100ddb84c85d
misc/chrome/gophertool: fix manifest
according to http://code.google.com/chrome/extensions/browserAction.html,
it should use "default_popup" instead of "popup".

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6349077

»»»

12 years ago[release-branch.go1] reflect: reflect.Zero results are neither addressable nor settable
Robert Griesemer [Fri, 21 Sep 2012 19:53:59 +0000 (05:53 +1000)]
[release-branch.go1] reflect: reflect.Zero results are neither addressable nor settable

««« backport 21130d62eeb0
reflect: reflect.Zero results are neither addressable nor settable

This could be deduced from "The Laws of Reflection" but it seems
worthwhile highlighting it.

R=r
CC=golang-dev
https://golang.org/cl/6350073

»»»

12 years ago[release-branch.go1] encoding/gob: fix bug in Register
Rob Pike [Fri, 21 Sep 2012 19:53:58 +0000 (05:53 +1000)]
[release-branch.go1] encoding/gob: fix bug in Register

««« backport c89f17a9ff4f
encoding/gob: fix bug in Register
The old code added a star but did not indirect the reflect.Type.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6348067

»»»

12 years ago[release-branch.go1] doc/debugging_with_gdb: mention how to disable gc optimization
Shenghou Ma [Fri, 21 Sep 2012 19:53:58 +0000 (05:53 +1000)]
[release-branch.go1] doc/debugging_with_gdb: mention how to disable gc optimization

««« backport be7e338a8960
doc/debugging_with_gdb: mention how to disable gc optimization

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6353055

»»»

12 years ago[release-branch.go1] math/big: Remove unnecessary test from nat.go multiplication
David G. Andersen [Fri, 21 Sep 2012 19:53:57 +0000 (05:53 +1000)]
[release-branch.go1] math/big: Remove unnecessary test from nat.go multiplication

««« backport c533f48701cb
math/big: Remove unnecessary test from nat.go multiplication
The switch at the beginning of the function already ensures n > 1,
so testing for n < 2 is redundant.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/6350051

»»»

12 years ago[release-branch.go1] image: fix doc typo
Shenghou Ma [Fri, 21 Sep 2012 19:53:57 +0000 (05:53 +1000)]
[release-branch.go1] image: fix doc typo

««« backport 042bac4d6b6e
image: fix doc typo
     Fixes #3789.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6357058

»»»

12 years ago[release-branch.go1] cmd/gc: add missing case for OCOM in defaultlit()
Shenghou Ma [Fri, 21 Sep 2012 19:53:56 +0000 (05:53 +1000)]
[release-branch.go1] cmd/gc: add missing case for OCOM in defaultlit()

««« backport b5c4f411a852
cmd/gc: add missing case for OCOM in defaultlit()
        Fixes #3765.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6349064

»»»

12 years ago[release-branch.go1] cmd/go: httpGet function does not use global variable httpClient
Amir Mohammad Saied [Fri, 21 Sep 2012 19:53:56 +0000 (05:53 +1000)]
[release-branch.go1] cmd/go: httpGet function does not use global variable httpClient

««« backport 650544a058e9
cmd/go: httpGet function does not use global variable httpClient

No change, just for consistency.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6346048

»»»

12 years ago[release-branch.go1] net/http: ignore malicious or dumb Range requests
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:56 +0000 (05:53 +1000)]
[release-branch.go1] net/http: ignore malicious or dumb Range requests

««« backport d32138d8d05f
net/http: ignore malicious or dumb Range requests

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6356050

»»»

12 years ago[release-branch.go1] cmd/dist: Make windows.c's fatal() print to stderr
Pieter Droogendijk [Fri, 21 Sep 2012 19:53:55 +0000 (05:53 +1000)]
[release-branch.go1] cmd/dist: Make windows.c's fatal() print to stderr

««« backport 3f7501fdb220
cmd/dist: Make windows.c's fatal() print to stderr

Generating env.bat using dist env -wp > env.bat failed silently
if case of an error, because the message was redirected to env.bat.
Verbose messages still go to stdout, causing problems, but that's
a seperate change.
Made errprintf() identical to xprintf(), except for the output handle.
Yes, it's duplicate code, but most of the function is unpacking
the argument list and preparing it for WriteFile(), which has to be
done anyway.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6343047

»»»

12 years ago[release-branch.go1] misc/emacs: Fix the gofmt patching when the TMPDIR is not the...
Jean-Marc Eurin [Fri, 21 Sep 2012 19:53:55 +0000 (05:53 +1000)]
[release-branch.go1] misc/emacs: Fix the gofmt patching when the TMPDIR is not the default.

««« backport c5f564efc620
misc/emacs: Fix the gofmt patching when the TMPDIR is not the default.

The previous code assumed the gofmt output referred to /tmp but
that's not true if TMPDIR points somewhere else (like on Macs).
Fixes #3782.

R=sameer
CC=golang-dev
https://golang.org/cl/6346050

»»»

12 years ago[release-branch.go1] net/http: support multiple byte ranges in ServeContent
Brad Fitzpatrick [Fri, 21 Sep 2012 19:53:54 +0000 (05:53 +1000)]
[release-branch.go1] net/http: support multiple byte ranges in ServeContent

««« backport 070604630d24
net/http: support multiple byte ranges in ServeContent

Fixes #3784

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6351052

»»»

12 years ago[release-branch.go1] net/http: Fix a verb-tense mismatch and a typo in documentation.
Andrey Mirtchovski [Fri, 21 Sep 2012 19:53:54 +0000 (05:53 +1000)]
[release-branch.go1] net/http: Fix a verb-tense mismatch and a typo in documentation.

««« backport f8a77e2b7d0b
net/http: Fix a verb-tense mismatch and a typo in documentation.

R=bradfitz
CC=golang-dev
https://golang.org/cl/6357049

»»»

12 years ago[release-branch.go1] go spec: clean up section on selectors
Robert Griesemer [Fri, 21 Sep 2012 19:53:53 +0000 (05:53 +1000)]
[release-branch.go1] go spec: clean up section on selectors

««« backport eb24cee7f21b
go spec: clean up section on selectors

- point out difference between selectors and qualified identifiers
- differentiate between illegal selectors and run-time panics
- use "indirect" as opposed to "dereference" consistently
- add extra links

Fixes #3779.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6326059

»»»

12 years ago[release-branch.go1] syscall: add missing argument type
Joe Poirier [Fri, 21 Sep 2012 19:53:53 +0000 (05:53 +1000)]
[release-branch.go1] syscall: add missing argument type

««« backport 3909e0071e70
syscall: add missing argument type

And update implementation location comment.

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6352046

»»»

12 years ago[release-branch.go1] go spec: clean up use of QualifiedIdent production.
Robert Griesemer [Fri, 21 Sep 2012 19:53:52 +0000 (05:53 +1000)]
[release-branch.go1] go spec: clean up use of QualifiedIdent production.

««« backport d8bd45866999
go spec: clean up use of QualifiedIdent production.

Fixes #3763.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6333066

»»»

12 years ago[release-branch.go1] A+C: L Campbell (individual CLA)
Russ Cox [Fri, 21 Sep 2012 19:53:52 +0000 (05:53 +1000)]
[release-branch.go1] A+C: L Campbell (individual CLA)

««« backport c88692a626e9
A+C: L Campbell (individual CLA)

Guess I was wrong about being done for the day.

R=golang-dev, r
CC=golang-dev, unpantsu
https://golang.org/cl/6325060

»»»

12 years ago[release-branch.go1] fmt: set p.field before nil check
Rob Pike [Fri, 21 Sep 2012 19:53:51 +0000 (05:53 +1000)]
[release-branch.go1] fmt: set p.field before nil check

««« backport 5f13e0662e38
fmt: set p.field before nil check
Fixes #3752.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6331062

»»»

12 years ago[release-branch.go1] doc: drop video title from homepage
Andrew Gerrand [Fri, 21 Sep 2012 19:53:51 +0000 (05:53 +1000)]
[release-branch.go1] doc: drop video title from homepage

««« backport 9da3902443ca
doc: drop video title from homepage

It's just stutter.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/6334053

»»»

12 years ago[release-branch.go1] A+C: Jonathan Gold (individual CLA)
Russ Cox [Fri, 21 Sep 2012 19:53:50 +0000 (05:53 +1000)]
[release-branch.go1] A+C: Jonathan Gold (individual CLA)

««« backport ee62927ec779
A+C: Jonathan Gold (individual CLA)

This is my last one for today, I hope!

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6339052

»»»

12 years ago[release-branch.go1] A+C: add Michael Stapelberg (individual CLA)
Russ Cox [Fri, 21 Sep 2012 19:53:50 +0000 (05:53 +1000)]
[release-branch.go1] A+C: add Michael Stapelberg (individual CLA)

««« backport 04f61caa80cd
A+C: add Michael Stapelberg (individual CLA)

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6325058

»»»

12 years ago[release-branch.go1] go/build: fix doc typo
Pieter Droogendijk [Fri, 21 Sep 2012 19:53:49 +0000 (05:53 +1000)]
[release-branch.go1] go/build: fix doc typo

««« backport e12419d09635
go/build: fix doc typo

go/build section "Build Constraints", first paragraph said:
  "... they must be appear near the top of the file ..."
fixed to:
  "... they must appear near the top of the file ..."

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6329060

»»»