]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agoruntime: fix openbsd nanotime?
Russ Cox [Fri, 4 Nov 2011 11:24:39 +0000 (07:24 -0400)]
runtime: fix openbsd nanotime?

TBR=r
CC=golang-dev
https://golang.org/cl/5353041

13 years agobytes: fix typo and resolve to be less idiotic next time
Andrew Gerrand [Fri, 4 Nov 2011 06:55:21 +0000 (17:55 +1100)]
bytes: fix typo and resolve to be less idiotic next time

R=bradfitz
CC=golang-dev
https://golang.org/cl/5340044

13 years agobytes: add Contains function
Andrew Gerrand [Fri, 4 Nov 2011 06:46:52 +0000 (17:46 +1100)]
bytes: add Contains function

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5349041

13 years agohtml: properly close <tr> element when an new <tr> starts.
Andrew Balholm [Fri, 4 Nov 2011 04:48:11 +0000 (15:48 +1100)]
html: properly close <tr> element when an new <tr> starts.

Pass tests1.dat, test 87:
<table><tr><tr><td><td><span><th><span>X</table>

| <html>
|   <head>
|   <body>
|     <table>
|       <tbody>
|         <tr>
|         <tr>
|           <td>
|           <td>
|             <span>
|           <th>
|             <span>
|               "X"

R=nigeltao
CC=golang-dev
https://golang.org/cl/5343041

13 years agohttp: doc nits
Brad Fitzpatrick [Fri, 4 Nov 2011 03:37:02 +0000 (20:37 -0700)]
http: doc nits

Remove the last two "convenience" mentions.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5344041

13 years agohttp: clarify Request docs
Brad Fitzpatrick [Fri, 4 Nov 2011 03:05:13 +0000 (20:05 -0700)]
http: clarify Request docs

R=rsc
CC=golang-dev
https://golang.org/cl/5342041

13 years agohttputil: move dump and chunking functions out of http
Brad Fitzpatrick [Fri, 4 Nov 2011 01:12:51 +0000 (18:12 -0700)]
httputil: move dump and chunking functions out of http

This moves DumpRequest, DumpResponse, NewChunkedReader,
and NewChunkedWriter out of http, as part of the continued
http diet plan.

Also, adds DumpRequestOut (for dumping outbound requests),
since DumpRequest's ambiguity (the "wire representation" in
what direction?) was often a source of confusion and bug
reports.

R=rsc, adg
CC=golang-dev
https://golang.org/cl/5339041

13 years agogob: fix bug when registering the same type multiple times
Rob Pike [Fri, 4 Nov 2011 01:05:14 +0000 (18:05 -0700)]
gob: fix bug when registering the same type multiple times
Need to compare user type, not base type.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5340041

13 years agohttp: only recognize application/x-www-form-urlencoded in ParseForm
Brad Fitzpatrick [Fri, 4 Nov 2011 00:21:58 +0000 (17:21 -0700)]
http: only recognize application/x-www-form-urlencoded in ParseForm

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5322070

13 years agohttputil: move ReverseProxy out of http
Brad Fitzpatrick [Thu, 3 Nov 2011 22:54:08 +0000 (15:54 -0700)]
httputil: move ReverseProxy out of http

http diet plan, continued.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5305090

13 years agohtml: move <link> element from after <head> into <head>
Andrew Balholm [Thu, 3 Nov 2011 22:29:06 +0000 (09:29 +1100)]
html: move <link> element from after <head> into <head>

Pass tests1.dat, test 85:
<head><meta></head><link>

| <html>
|   <head>
|     <meta>
|     <link>
|   <body>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5297079

13 years agonet/http/httputil: new package; move ClientConn and ServerConn
Brad Fitzpatrick [Thu, 3 Nov 2011 21:44:29 +0000 (14:44 -0700)]
net/http/httputil: new package; move ClientConn and ServerConn

Part of http diet plan.

More of the lesser-used and newcomer-misleading parts of http will
move here.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5336049

13 years agotime: faster Nanoseconds call
Russ Cox [Thu, 3 Nov 2011 21:35:28 +0000 (17:35 -0400)]
time: faster Nanoseconds call

runtime knows how to get the time of day
without allocating memory.

R=golang-dev, dsymonds, dave, hectorchu, r, cw
CC=golang-dev
https://golang.org/cl/5297078

13 years agoruntime: fix set and not used
Russ Cox [Thu, 3 Nov 2011 21:35:11 +0000 (17:35 -0400)]
runtime: fix set and not used

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5305087

13 years agogofix: make fix order implicit by date.
David Symonds [Thu, 3 Nov 2011 21:34:37 +0000 (08:34 +1100)]
gofix: make fix order implicit by date.

This partially undoes 8fd7e6d070c8, but preserves its semantics.
More importantly, it results in the data about each fix being
decentralised, which makes it easier for new fixes to be added,
and other gofix users to slot new fixes in.

It also adds some useful metadata that could be used in the future.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5306092

13 years agoos,text,unicode: renamings
Rob Pike [Thu, 3 Nov 2011 21:18:06 +0000 (14:18 -0700)]
os,text,unicode: renamings
This is Go 1 package renaming CL #4.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into os, text, and unicode.

exec -> os/exec
scanner -> text/scanner
tabwriter -> text/tabwriter
template -> text/template
template/parse -> text/template/parse
utf16 -> unicode/utf16
utf8 -> unicode/utf8

This should be the last of the source-rearranging CLs.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5331066

13 years agoall: rename os.EOF to io.EOF in various non-code contexts
Vincent Vanackere [Thu, 3 Nov 2011 21:01:30 +0000 (14:01 -0700)]
all: rename os.EOF to io.EOF in various non-code contexts

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5334050

13 years agonet: renamings
Rob Pike [Thu, 3 Nov 2011 20:26:43 +0000 (13:26 -0700)]
net: renamings
This is Go 1 package renaming CL #3.
This one merely moves the source; the import strings will be
changed after the next weekly release.
This one moves pieces into net.

http -> net/http
http/cgi -> net/http/cgi
http/fcgi -> net/http/fcgi
http/pprof -> net/http/pprof
http/httptest -> net/http/httptest
mail -> net/mail
rpc -> net/rpc
rpc/jsonrpc -> net/rpc/jsonrpc
smtp -> net/smtp
url -> net/url

Also remove rand (now math/rand) from NOTEST - it has a test.

The only edits are in Makefiles and deps.bash.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5335048

13 years agohtml,log,math: renamings
Rob Pike [Thu, 3 Nov 2011 19:42:57 +0000 (12:42 -0700)]
html,log,math: renamings
This is Go 1 package renaming CL #2.
This one merely moves the source; the import strings will be
changed after the next weekly release.

exp/template/html -> html/template
big -> math/big
cmath -> math/cmplx
rand -> math/rand
syslog -> log/syslog

The only edits are in Makefiles and deps.bash.

Note that this CL moves exp/template/html out of exp. I decided
to do that so all the renamings can be done together, even though
the API (and that of template, for that matter) is still fluid.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5332053

13 years agohttp: don't use ClientConn in Transport
Brad Fitzpatrick [Thu, 3 Nov 2011 19:35:56 +0000 (12:35 -0700)]
http: don't use ClientConn in Transport

ClientConn's main feature (pipelining support)
wasn't being used anyway.  Ends up simpler to
just not use it.

This is prep for the http diet, moving ClientConn,
ServerConn, etc into http/httputil.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5305088

13 years agocontainer/heap: document what Push and Pop do
Russ Cox [Thu, 3 Nov 2011 19:30:57 +0000 (15:30 -0400)]
container/heap: document what Push and Pop do

Now that vector is gone, there is no precedent to refer to.
This is a confusing point for people looking to use the
package.

R=golang-dev, r, cw
CC=golang-dev
https://golang.org/cl/5322069

13 years agodeps.bash: attempt to fix the windows build
Rob Pike [Thu, 3 Nov 2011 19:19:07 +0000 (12:19 -0700)]
deps.bash: attempt to fix the windows build
Use simpler shell constructs.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5297080

13 years agoencoding: move asn1, csv, gob, json, xml into encoding
Rob Pike [Thu, 3 Nov 2011 18:39:52 +0000 (11:39 -0700)]
encoding: move asn1, csv, gob, json, xml into encoding
This is Go 1 package renaming CL #1.
This one merely moves the source; the import strings will be
changed after the next weekly release.

The only edits are in Makefiles.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5331060

13 years agogc: Don't pollute the xmethod list with non-methods.
Luuk van Dijk [Thu, 3 Nov 2011 16:51:15 +0000 (17:51 +0100)]
gc: Don't pollute the xmethod list with non-methods.

Fixes #2355.

I have a test, but not sure if it's worth adding.  Instead i've made
the patching-over in reflect.c methods more fatal and more descriptive.

R=rsc
CC=golang-dev
https://golang.org/cl/5302082

13 years agogc, ld: sync pathtoprefix + add comments
Russ Cox [Thu, 3 Nov 2011 16:44:51 +0000 (12:44 -0400)]
gc, ld: sync pathtoprefix + add comments

R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5332051

13 years agogopack: do not look for Go metadata in non-Go objects
Russ Cox [Thu, 3 Nov 2011 16:07:47 +0000 (12:07 -0400)]
gopack: do not look for Go metadata in non-Go objects

Fixes #2333.

R=r
CC=golang-dev
https://golang.org/cl/5316075

13 years ago8a: fix IMULL grammar
Russ Cox [Thu, 3 Nov 2011 15:32:37 +0000 (11:32 -0400)]
8a: fix IMULL grammar

R=ken2
CC=golang-dev
https://golang.org/cl/5298091

13 years agohtml: parse <link> elements in <head>
Andrew Balholm [Thu, 3 Nov 2011 06:12:13 +0000 (17:12 +1100)]
html: parse <link> elements in <head>

Pass tests1.dat, test 83:
<title><meta></title><link><title><meta></title>

| <html>
|   <head>
|     <title>
|       "<meta>"
|     <link>
|     <title>
|       "<meta>"
|   <body>

Also pass test 84:
<style><!--</style><meta><script>--><link></script>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5331061

13 years agobuiltin: remove errant spaces
Andrew Gerrand [Thu, 3 Nov 2011 03:52:38 +0000 (14:52 +1100)]
builtin: remove errant spaces

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5337041

13 years agohttp: update mime sniffing doc reference.
David Symonds [Thu, 3 Nov 2011 03:34:35 +0000 (14:34 +1100)]
http: update mime sniffing doc reference.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5303095

13 years agowebsocket: return an error HTTP response for bad websocket request.
Fumitoshi Ukai [Thu, 3 Nov 2011 03:13:39 +0000 (14:13 +1100)]
websocket: return an error HTTP response for bad websocket request.

websocket spec had changed server-side requiements to return
an HTTP response with an appropriate error code (such as 400 Bad
Request) when it finds client did not send a handshake that matches
websocket protocol, rather than just closing connection.
It needs to flush out response before closing connection.
Fixes issues 2396.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5318072

13 years agotest: clear execute bit from source file
Mikio Hara [Thu, 3 Nov 2011 01:26:33 +0000 (10:26 +0900)]
test: clear execute bit from source file

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5330068

13 years agohtml: properly close <marquee> elements.
Andrew Balholm [Wed, 2 Nov 2011 23:11:06 +0000 (10:11 +1100)]
html: properly close <marquee> elements.

Pass tests1.dat, test 80:
<a href=a>aa<marquee>aa<a href=b>bb</marquee>aa

| <html>
|   <head>
|   <body>
|     <a>
|       href="a"
|       "aa"
|       <marquee>
|         "aa"
|         <a>
|           href="b"
|           "bb"
|       "aa"

Also pass tests through test 82:
<!DOCTYPE html><spacer>foo

R=nigeltao
CC=golang-dev
https://golang.org/cl/5319071

13 years agogc: package paths in symbol names: don't escape periods before last slash, always...
Luuk van Dijk [Wed, 2 Nov 2011 21:33:15 +0000 (22:33 +0100)]
gc: package paths in symbol names: don't escape periods before last slash, always escape >=0x7f.

R=rsc
CC=golang-dev
https://golang.org/cl/5323071

13 years agoall: sort imports
Russ Cox [Wed, 2 Nov 2011 19:54:16 +0000 (15:54 -0400)]
all: sort imports

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5319072

13 years agogofmt, gofix: sort imports
Russ Cox [Wed, 2 Nov 2011 19:53:57 +0000 (15:53 -0400)]
gofmt, gofix: sort imports

Add ast.SortImports(fset, file) to go/ast, for use by both programs.

Fixes #346.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5330069

13 years agobuiltin: document the basic types
Rob Pike [Wed, 2 Nov 2011 19:06:36 +0000 (12:06 -0700)]
builtin: document the basic types
The recursive definitions are illegal Go, but godoc doesn't mind.

R=bradfitz, r, n13m3y3r, rsc
CC=golang-dev
https://golang.org/cl/5322067

13 years agoexp/sql: finish transactions, flesh out types, docs
Brad Fitzpatrick [Wed, 2 Nov 2011 18:46:04 +0000 (11:46 -0700)]
exp/sql: finish transactions, flesh out types, docs

Fixes #2328 (float, bool)

R=rsc, r
CC=golang-dev
https://golang.org/cl/5294067

13 years agomath: improved accuracy for Tan
Charles L. Dorian [Wed, 2 Nov 2011 18:01:21 +0000 (14:01 -0400)]
math: improved accuracy for Tan

R=rsc
CC=golang-dev
https://golang.org/cl/5298087

13 years agogc: helpful message instead of internal error on method call on pointer to pointer.
Luuk van Dijk [Wed, 2 Nov 2011 16:18:53 +0000 (17:18 +0100)]
gc: helpful message instead of internal error on method call on pointer to pointer.

Fixes #2343.

R=rsc
CC=golang-dev
https://golang.org/cl/5332048

13 years agobufio: return nil line from ReadLine on error, as documented
Brad Fitzpatrick [Wed, 2 Nov 2011 15:30:50 +0000 (08:30 -0700)]
bufio: return nil line from ReadLine on error, as documented

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5316069

13 years agogc: small fixes for printing.
Luuk van Dijk [Wed, 2 Nov 2011 14:36:33 +0000 (15:36 +0100)]
gc: small fixes for printing.

mark OADDR inserted by typecheck as implicit
OCOPY takes ->left and ->right, not ->list
OMAKE*'s can all have arguments
precedence for OIND was initalized twice

fixes #2414

R=rsc, dave
CC=golang-dev
https://golang.org/cl/5319065

13 years agoruntime: unify mutex code across OSes
Dmitriy Vyukov [Wed, 2 Nov 2011 13:42:01 +0000 (16:42 +0300)]
runtime: unify mutex code across OSes
The change introduces 2 generic mutex implementations
(futex- and semaphore-based). Each OS chooses a suitable mutex
implementation and implements few callbacks (e.g. futex wait/wake).
The CL reduces code duplication, extends some optimizations available
only on Linux/Windows to other OSes and provides ground
for futher optimizations. Chan finalizers are finally eliminated.

(Linux/amd64, 8 HT cores)
benchmark                      old      new
BenchmarkChanContended         83.6     77.8 ns/op
BenchmarkChanContended-2       341      328 ns/op
BenchmarkChanContended-4       382      383 ns/op
BenchmarkChanContended-8       390      374 ns/op
BenchmarkChanContended-16      313      291 ns/op

(Darwin/amd64, 2 cores)
benchmark                      old      new
BenchmarkChanContended         159      172 ns/op
BenchmarkChanContended-2       6735     263 ns/op
BenchmarkChanContended-4       10384    255 ns/op
BenchmarkChanCreation          1174     407 ns/op
BenchmarkChanCreation-2        4007     254 ns/op
BenchmarkChanCreation-4        4029     246 ns/op

R=rsc, jsing, hectorchu
CC=golang-dev
https://golang.org/cl/5140043

13 years agojson: fix typo in scanner_test.go.
Nigel Tao [Wed, 2 Nov 2011 07:03:45 +0000 (18:03 +1100)]
json: fix typo in scanner_test.go.

R=dsymonds
CC=golang-dev
https://golang.org/cl/5303092

13 years agonet: implement LookupTXT for windows
Alex Brainman [Wed, 2 Nov 2011 06:11:40 +0000 (17:11 +1100)]
net: implement LookupTXT for windows

R=rsc
CC=golang-dev
https://golang.org/cl/5318056

13 years agobuiltin: document built-in error type
Andrew Gerrand [Wed, 2 Nov 2011 06:03:36 +0000 (15:03 +0900)]
builtin: document built-in error type

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5307080

13 years agogc: fix spelling of "GOEXPERIMENT" in a comment.
David Symonds [Wed, 2 Nov 2011 05:25:24 +0000 (16:25 +1100)]
gc: fix spelling of "GOEXPERIMENT" in a comment.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5323070

13 years agospec: delete spurious article
Rob Pike [Wed, 2 Nov 2011 03:57:17 +0000 (20:57 -0700)]
spec: delete spurious article
A profound change to christen the new tag.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5327062

13 years agoundo CL 5330066 / 6a5647d82728
Russ Cox [Wed, 2 Nov 2011 03:26:10 +0000 (23:26 -0400)]
undo CL 5330066 / 6a5647d82728

I promised it wouldn't last very long.
People who really need this can sync to 6a5647d82728.

««« original CL description
gc: add GOEXPERIMENT=os.Error

This won't last long, I promise.

R=ken2
CC=golang-dev
https://golang.org/cl/5330066
»»»

R=ken2
CC=golang-dev
https://golang.org/cl/5333053

13 years agogc: add GOEXPERIMENT=os.Error
Russ Cox [Wed, 2 Nov 2011 03:24:28 +0000 (23:24 -0400)]
gc: add GOEXPERIMENT=os.Error

This won't last long, I promise.

R=ken2
CC=golang-dev
https://golang.org/cl/5330066

13 years agotag weekly.2011-11-02
Andrew Gerrand [Wed, 2 Nov 2011 03:01:51 +0000 (12:01 +0900)]
tag weekly.2011-11-02

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5311083

13 years agoweekly.2011-11-02 weekly.2011-11-02
Andrew Gerrand [Wed, 2 Nov 2011 03:00:13 +0000 (12:00 +0900)]
weekly.2011-11-02

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5308077

13 years agoall: rename os.Error to error in various non-code contexts
Russ Cox [Wed, 2 Nov 2011 02:58:09 +0000 (22:58 -0400)]
all: rename os.Error to error in various non-code contexts

R=adg
CC=golang-dev
https://golang.org/cl/5328062

13 years agoos: fixes for error (plan9)
Russ Cox [Wed, 2 Nov 2011 02:19:40 +0000 (22:19 -0400)]
os: fixes for error (plan9)

The Plan 9 build stops in runtime,
but might as well fix these anyway.

R=adg
CC=golang-dev
https://golang.org/cl/5336045

13 years agonet: update for error (linux)
Russ Cox [Wed, 2 Nov 2011 02:18:16 +0000 (22:18 -0400)]
net: update for error (linux)

R=adg
CC=golang-dev
https://golang.org/cl/5303091

13 years agoos, syscall: update for error
Russ Cox [Wed, 2 Nov 2011 02:12:41 +0000 (22:12 -0400)]
os, syscall: update for error

R=adg
CC=golang-dev
https://golang.org/cl/5333052

13 years agonon-pkg: gofix -r error -force=error
Russ Cox [Wed, 2 Nov 2011 02:06:05 +0000 (22:06 -0400)]
non-pkg: gofix -r error -force=error

R=golang-dev, iant, r, r
CC=golang-dev
https://golang.org/cl/5307066

13 years agosrc/pkg/[n-z]*: gofix -r error -force=error
Russ Cox [Wed, 2 Nov 2011 02:05:34 +0000 (22:05 -0400)]
src/pkg/[n-z]*: gofix -r error -force=error

R=golang-dev, bsiegert, iant
CC=golang-dev
https://golang.org/cl/5294074

13 years agosrc/pkg/[a-m]*: gofix -r error -force=error
Russ Cox [Wed, 2 Nov 2011 02:04:37 +0000 (22:04 -0400)]
src/pkg/[a-m]*: gofix -r error -force=error

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5322051

13 years agotutorial,effective_go: prepare for error change
Rob Pike [Wed, 2 Nov 2011 01:50:21 +0000 (21:50 -0400)]
tutorial,effective_go: prepare for error change

R=adg, rsc
CC=golang-dev
https://golang.org/cl/5316068

13 years agoexec: introduce ExitError
Russ Cox [Wed, 2 Nov 2011 01:49:44 +0000 (21:49 -0400)]
exec: introduce ExitError

The existing code uses *os.Waitmsg as an os.Error,
but *os.Waitmsg is really just a stringer.

Introduce an explicit error type for the real error.

Not to be submitted until just before error goes in;
the gofix for error updates type assertions
        err.(*os.Waitmsg)
to
        err.(*exec.ExitError)

The seemingly redundant String method will become
an Error method when error goes in, and will no longer
be redundant.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5331044

13 years agoexp/ebnf: manual fixup for error
Russ Cox [Wed, 2 Nov 2011 01:49:33 +0000 (21:49 -0400)]
exp/ebnf: manual fixup for error

(The definition of ErrorList is in another file, so gofix
has no hope of getting this right.)

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5330043

13 years agocgo, gotest: use error instead of os.Error in generated code
Russ Cox [Wed, 2 Nov 2011 01:49:22 +0000 (21:49 -0400)]
cgo, gotest: use error instead of os.Error in generated code

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5319057

13 years agoos: use error, io.EOF
Russ Cox [Wed, 2 Nov 2011 01:49:08 +0000 (21:49 -0400)]
os: use error, io.EOF

R=r
CC=golang-dev
https://golang.org/cl/5298073

13 years agoio: use error, add EOF, avoid os
Russ Cox [Wed, 2 Nov 2011 01:48:52 +0000 (21:48 -0400)]
io: use error, add EOF, avoid os

R=r, r
CC=golang-dev
https://golang.org/cl/5311068

13 years agoruntime: update for error
Russ Cox [Wed, 2 Nov 2011 01:48:27 +0000 (21:48 -0400)]
runtime: update for error

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/5306075

13 years agoexp/types: add error type to universe
Russ Cox [Wed, 2 Nov 2011 01:47:33 +0000 (21:47 -0400)]
exp/types: add error type to universe

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5327051

13 years agomisc/vim: add error type.
David Symonds [Wed, 2 Nov 2011 01:47:07 +0000 (21:47 -0400)]
misc/vim: add error type.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5331046

13 years agoerrors: new package
Russ Cox [Wed, 2 Nov 2011 01:46:59 +0000 (21:46 -0400)]
errors: new package

The only function is errors.New, at least for now.

R=r, gustavo, adg, r
CC=golang-dev
https://golang.org/cl/5321061

13 years agogc: add error type
Russ Cox [Wed, 2 Nov 2011 01:46:41 +0000 (21:46 -0400)]
gc: add error type

R=ken
CC=golang-dev
https://golang.org/cl/5331043

13 years agohttp: avoid name error in test
Russ Cox [Wed, 2 Nov 2011 01:45:37 +0000 (21:45 -0400)]
http: avoid name error in test

R=adg
CC=golang-dev
https://golang.org/cl/5316070

13 years agogofix: error fix
Russ Cox [Wed, 2 Nov 2011 01:45:21 +0000 (21:45 -0400)]
gofix: error fix

To make the error fix more useful, expand typecheck to gather
more information about struct fields, typecheck range statements,
typecheck indirect and index of named types, and collect information
about assignment conversions.

Also, change addImport to rename top-level uses of a to-be-imported
identifier to avoid conflicts.  This duplicated some of the code in
the url fix, so that fix is now shorter.

R=iant, r, r
CC=golang-dev
https://golang.org/cl/5305066

13 years agospec: add error
Russ Cox [Wed, 2 Nov 2011 01:45:02 +0000 (21:45 -0400)]
spec: add error

R=golang-dev, dsymonds, r, r
CC=golang-dev
https://golang.org/cl/5308072

13 years agotag weekly.2011-11-01
Andrew Gerrand [Wed, 2 Nov 2011 01:40:35 +0000 (10:40 +0900)]
tag weekly.2011-11-01

R=golang-dev, rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5305085

13 years agoweekly.2011-11-01 weekly.2011-11-01
Andrew Gerrand [Wed, 2 Nov 2011 01:37:01 +0000 (10:37 +0900)]
weekly.2011-11-01

R=rsc, r
CC=golang-dev
https://golang.org/cl/5336044

13 years agohtml: stop at scope marker node when generating implied </a> tags
Andrew Balholm [Wed, 2 Nov 2011 00:47:05 +0000 (11:47 +1100)]
html: stop at scope marker node when generating implied </a> tags

A <a> tag generates implied end tags for any open <a> elements.
But it shouldn't do that when it is inside a table cell the the open <a>
is outside the table.
So stop the search for an open <a> when we reach a scope marker node.

Pass tests1.dat, test 78:
<a href="blah">aba<table><tr><td><a href="foo">br</td></tr>x</table>aoe

| <html>
|   <head>
|   <body>
|     <a>
|       href="blah"
|       "abax"
|       <table>
|         <tbody>
|           <tr>
|             <td>
|               <a>
|                 href="foo"
|                 "br"
|       "aoe"

Also pass test 79:
<table><a href="blah">aba<tr><td><a href="foo">br</td></tr>x</table>aoe

R=nigeltao
CC=golang-dev
https://golang.org/cl/5320063

13 years agohtml: refactor the blacklist for the "render and re-parse" test.
Nigel Tao [Tue, 1 Nov 2011 22:42:25 +0000 (09:42 +1100)]
html: refactor the blacklist for the "render and re-parse" test.

R=andybalholm
CC=golang-dev, mikesamuel
https://golang.org/cl/5331056

13 years agotextproto: prevent long lines in HTTP headers from causing HTTP 400 responses.
Mike Solomon [Tue, 1 Nov 2011 17:31:29 +0000 (10:31 -0700)]
textproto: prevent long lines in HTTP headers from causing HTTP 400 responses.

This fixes the issue without an extra copy in the average case.

R=golang-dev, ality, bradfitz
CC=golang-dev
https://golang.org/cl/5272049

13 years agodoc/Makefile: add 'all' rule to build all docs
Rob Pike [Tue, 1 Nov 2011 16:45:04 +0000 (09:45 -0700)]
doc/Makefile: add 'all' rule to build all docs

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5334044

13 years agogc: test + fix escape analysis bug
Russ Cox [Tue, 1 Nov 2011 15:02:43 +0000 (11:02 -0400)]
gc: test + fix escape analysis bug

R=lvd
CC=golang-dev
https://golang.org/cl/5333049

13 years agodoc: refer to tour.golang.org instead of go-tour.appspot.com
Andrew Gerrand [Tue, 1 Nov 2011 07:09:29 +0000 (16:09 +0900)]
doc: refer to tour.golang.org instead of go-tour.appspot.com

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5331055

13 years agodoc: fix typo in spec example code comment
Charles L. Dorian [Tue, 1 Nov 2011 06:13:33 +0000 (15:13 +0900)]
doc: fix typo in spec example code comment

R=r, golang-dev, adg
CC=golang-dev
https://golang.org/cl/5308071

13 years agogo spec: introduce rune type
Robert Griesemer [Tue, 1 Nov 2011 05:09:22 +0000 (01:09 -0400)]
go spec: introduce rune type

R=r, iant, rsc, r
CC=golang-dev
https://golang.org/cl/5293048

13 years agorpc: avoid infinite loop on input error
Russ Cox [Tue, 1 Nov 2011 04:29:41 +0000 (00:29 -0400)]
rpc: avoid infinite loop on input error

Fixes #1828.
Fixes #2179.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5305084

13 years agogopack: change archive file name length back to 16
Russ Cox [Tue, 1 Nov 2011 04:29:16 +0000 (00:29 -0400)]
gopack: change archive file name length back to 16

This CL grew the archive file name length from 16 to 64:

        changeset:   909:58574851d792
        user:        Russ Cox <rsc@golang.org>
        date:        Mon Oct 20 13:53:56 2008 -0700

Back then, every x.go file in a package became an x.6 file
in the archive.  It was important to be able to allow the
use of long Go source file names, hence the increase in size.

Today, all Go source files compile into a single _go_.6 file
regardless of their names, so the archive file name length
no longer needs to be long.  The longer name causes some
problems on Plan 9, where the native archive format is the
same but with 16-byte names, so revert back to 16.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5333050

13 years agoos: do not interpret 0-length read as EOF
Russ Cox [Tue, 1 Nov 2011 04:17:05 +0000 (00:17 -0400)]
os: do not interpret 0-length read as EOF

Fixes #2402.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/5298081

13 years agohtml: process </td> tags; foster parent at most one node per token
Andrew Balholm [Tue, 1 Nov 2011 00:42:54 +0000 (11:42 +1100)]
html: process </td> tags; foster parent at most one node per token

Correctly close table cell when </td> is read.

Because of reconstructing the active formatting elements, more than one
node may be created when reading a single token.
If both nodes are foster parented, they will be siblings, but the first
node should be the parent of the second.

Pass tests1.dat, test 77:
<a href="blah">aba<table><a href="foo">br<tr><td></td></tr>x</table>aoe

| <html>
|   <head>
|   <body>
|     <a>
|       href="blah"
|       "aba"
|       <a>
|         href="foo"
|         "br"
|       <a>
|         href="foo"
|         "x"
|       <table>
|         <tbody>
|           <tr>
|             <td>
|     <a>
|       href="foo"
|       "aoe"

R=nigeltao
CC=golang-dev
https://golang.org/cl/5305074

13 years agotemplate: fix error checking on execute without parse
Scott Lawrence [Mon, 31 Oct 2011 23:07:17 +0000 (16:07 -0700)]
template: fix error checking on execute without parse

Fixed error checking in exec.go to give a sensible error message when
execution is attempted before a successful parse (rather than an
outright panic).

R=r
CC=golang-dev
https://golang.org/cl/5306065

13 years agopkg: minor cleanup
Russ Cox [Mon, 31 Oct 2011 21:53:39 +0000 (17:53 -0400)]
pkg: minor cleanup

remove some redundant .String()
change variable name to make it os.Error-proof

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5302075

13 years agotest: make bug107 os.Error-proof
Russ Cox [Mon, 31 Oct 2011 21:50:38 +0000 (17:50 -0400)]
test: make bug107 os.Error-proof

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5306087

13 years agoruntime/pprof: document OS X being broken
Russ Cox [Mon, 31 Oct 2011 21:50:25 +0000 (17:50 -0400)]
runtime/pprof: document OS X being broken

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5307078

13 years agotime: add RFC1123 with numeric timezone format
Scott Lawrence [Mon, 31 Oct 2011 19:59:06 +0000 (12:59 -0700)]
time: add RFC1123 with numeric timezone format

Fixes #841.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5322058

13 years agomath: Improved accuracy for Sin and Cos.
Charles L. Dorian [Mon, 31 Oct 2011 18:26:05 +0000 (14:26 -0400)]
math: Improved accuracy for Sin and Cos.

Fixes #1564.

R=rsc, dchest
CC=golang-dev
https://golang.org/cl/5320056

13 years agojson: Properly handle nil slices.
Alexander Reece [Mon, 31 Oct 2011 17:59:23 +0000 (13:59 -0400)]
json: Properly handle nil slices.

Marshal nil slices as null and parse null value as a nil slice.
Fixes #2278.

R=rsc
CC=golang-dev
https://golang.org/cl/5257053

13 years agoA+C: Alexander Reece (individual CLA)
Russ Cox [Mon, 31 Oct 2011 17:59:04 +0000 (13:59 -0400)]
A+C: Alexander Reece (individual CLA)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5297072

13 years agosyscall: fix Await msg on Plan 9
Andrey Mirtchovski [Mon, 31 Oct 2011 17:34:59 +0000 (13:34 -0400)]
syscall: fix Await msg on Plan 9

Plan 9's await() returns '' for nil exit status but programs, most notably gotest,
see this as an error return.

R=rsc
CC=golang-dev
https://golang.org/cl/5305079

13 years agogc: clean up printing.
Luuk van Dijk [Mon, 31 Oct 2011 17:09:40 +0000 (18:09 +0100)]
gc: clean up printing.

Got rid of all the magic mystery globals. Now
for %N, %T, and %S, the flags +,- and # set a sticky
debug, sym and export mode, only visible in the new fmt.c.
Default is error mode. Handle h and l flags consistently with
the least side effects, so we can now change
things without worrying about unrelated things
breaking.

fixes #2361

R=rsc
CC=golang-dev
https://golang.org/cl/5316043

13 years agonet: Plan 9 fixes
Fazlul Shahriar [Mon, 31 Oct 2011 15:47:44 +0000 (11:47 -0400)]
net: Plan 9 fixes

Makes all tests pass.

R=rsc
CC=golang-dev
https://golang.org/cl/5320041

13 years agomisc/emacs/go-lang.el: Fix restoration of multiple windows in a frame after gofmt
Jan Newmarch [Mon, 31 Oct 2011 15:33:14 +0000 (11:33 -0400)]
misc/emacs/go-lang.el: Fix restoration of multiple windows in a frame after gofmt
If a frame has multiple windows then the windows must all be restored
after gofmt has finished and the old windows must be restored.
Before this fix, only the Go code edit window would be left.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5280050

13 years agoexp/norm: fixed bug that creeped in with moving to the new
Marcel van Lohuizen [Mon, 31 Oct 2011 09:58:04 +0000 (10:58 +0100)]
exp/norm: fixed bug that creeped in with moving to the new
regexp, which caused the last line of a test block to be ignored.

R=r, rsc
CC=golang-dev
https://golang.org/cl/5177052