]>
Cypherpunks repositories - gostls13.git/log
Mikio Hara [Tue, 20 Aug 2013 08:32:55 +0000 (17:32 +0900)]
net: remove obsolete builtin network pollster
Update #5199
Update #6146
R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/
13112044
Mikio Hara [Tue, 20 Aug 2013 08:02:42 +0000 (17:02 +0900)]
net: enable runtime-integrated network pollster on freebsd/arm
Fixes #6146.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12927048
Mikio Hara [Tue, 20 Aug 2013 07:57:30 +0000 (16:57 +0900)]
runtime: integrated network pollster for freebsd/arm
Update #6146
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12927047
Brad Fitzpatrick [Tue, 20 Aug 2013 05:56:54 +0000 (22:56 -0700)]
net/http: support WriteString on the ResponseWriter
Fixes #5377
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12991046
Rob Pike [Tue, 20 Aug 2013 04:45:46 +0000 (14:45 +1000)]
os: fix windows build
The os windows source uses file as the receiver, not f.
TBR=golang-dev@googlegroups.com
R=adg
CC=golang-dev
https://golang.org/cl/
12922044
Rob Pike [Tue, 20 Aug 2013 04:33:03 +0000 (14:33 +1000)]
os: be consistent about File methods with nil receivers
Some crashed, some didn't. Make a nil receiver always
return ErrInvalid rather than crash.
Fixes #5824.
The program in the bug listing is silent now, at least on my Mac.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
13108044
Rob Pike [Tue, 20 Aug 2013 01:14:45 +0000 (11:14 +1000)]
api: update next.txt, except.txt
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12926046
Alan Donovan [Mon, 19 Aug 2013 21:50:22 +0000 (17:50 -0400)]
test: exit non-zero on error from nilptr2.go.
(For go.tools/ssa/interp/interp_test, which runs a subset of
these tests under this assumption.)
R=rsc, r
CC=golang-dev
https://golang.org/cl/
13108043
Carl Shapiro [Mon, 19 Aug 2013 21:16:55 +0000 (14:16 -0700)]
undo CL
12785045 /
71ce80dc4195
This has broken the 32-bit builds.
««« original CL description
cmd/gc, runtime: use type information to scan interface values
R=golang-dev, rsc, dvyukov
CC=golang-dev
https://golang.org/cl/
12785045
»»»
R=khr, golang-dev, khr
CC=golang-dev
https://golang.org/cl/
13010045
Rob Pike [Mon, 19 Aug 2013 20:44:41 +0000 (06:44 +1000)]
doc/go_faq.html: link to the SPLASH talk near the top
It's a full answer to the first question; let's let readers know that.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12788048
Aaron France [Mon, 19 Aug 2013 20:32:00 +0000 (16:32 -0400)]
misc/emacs: Detect stale coverage reports
When the coverage report file is older than the file we're
showing the coverage report for, then we show a simple message
to state this fact.
R=adonovan, dominik.honnef, bradfitz
CC=golang-dev
https://golang.org/cl/
12919044
Brad Fitzpatrick [Mon, 19 Aug 2013 20:30:31 +0000 (13:30 -0700)]
A+C: Aaron France (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/
13073044
Keith Randall [Mon, 19 Aug 2013 19:20:50 +0000 (12:20 -0700)]
runtime: don't run finalizers if we're still on the g0 stack.
R=golang-dev, rsc, dvyukov, khr
CC=golang-dev
https://golang.org/cl/
11386044
Dmitriy Vyukov [Mon, 19 Aug 2013 19:09:24 +0000 (23:09 +0400)]
net: annotate Read/Write for race detector
Fixes #6167.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
13052043
Dmitriy Vyukov [Mon, 19 Aug 2013 19:06:46 +0000 (23:06 +0400)]
runtime: do not preempt race calls
In the crash stack trace race cgocall() calls endcgo(),
this means that m->racecall is wrong.
Indeed this can happen is a goroutine is rescheduled to another M
during race call.
Disable preemption for race calls.
Fixes #6155.
R=golang-dev, rsc, cshapiro
CC=golang-dev
https://golang.org/cl/
12866045
Carl Shapiro [Mon, 19 Aug 2013 17:19:59 +0000 (10:19 -0700)]
cmd/gc, runtime: use type information to scan interface values
R=golang-dev, rsc, dvyukov
CC=golang-dev
https://golang.org/cl/
12785045
Andrew Gerrand [Mon, 19 Aug 2013 06:22:33 +0000 (16:22 +1000)]
cmd/go: only try to clean executables for package main
Fixes #5665.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12807044
Rob Pike [Mon, 19 Aug 2013 05:50:57 +0000 (15:50 +1000)]
cmd/go: diagnose import cycles better
Before this CL, the import stack was a) not printed and b) overwritten later
in the build, destroying the information about the cycle. This CL fixes both.
I made time depend on os (os already depends on time) and with this CL the error is:
/Users/r/go/src/pkg/fmt/print.go:10:2: import cycle not allowed
package code.google.com/p/XXX/YYY:
imports fmt
imports os
imports time
imports os
Doesn't give line numbers for the actual imports, as requested in the bug, but
I don't believe that's important.
Fixes #4292.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
13100043
David Symonds [Mon, 19 Aug 2013 03:47:43 +0000 (13:47 +1000)]
cmd/gc: regenerate y.tab.{c,h} with Bison 2.5.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12744048
Rob Pike [Mon, 19 Aug 2013 02:05:33 +0000 (12:05 +1000)]
test: fix build
syntax/*: update messages
sliceerr3.go: bizarre new error fixed by deleting a space.
I could have sworn I ran all.bash before submitting the CL that triggered these.
TBR=golang-dev@googlegroups.com
R=golang-dev
CC=golang-dev
https://golang.org/cl/
12812044
Anthony Martin [Mon, 19 Aug 2013 01:53:34 +0000 (11:53 +1000)]
cmd/gc: don't attempt to generate wrappers for blank interface methods
Fixes #5691.
R=golang-dev, bradfitz, daniel.morsing, rsc
CC=golang-dev
https://golang.org/cl/
10255047
Rob Pike [Mon, 19 Aug 2013 01:49:59 +0000 (11:49 +1000)]
cmd/gc: better error messages for C-style if statements.
Given
if (i == 0)
x++
The old message was
x.go:6: syntax error: unexpected semicolon or newline before {
Now we see
x.go:6: syntax error: missing { after if clause
Fixes #5687
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
12822045
Rob Pike [Mon, 19 Aug 2013 01:22:09 +0000 (11:22 +1000)]
math/big: fix nil bug in GobEncode
Update #5305.
This handles the case where the nil pointers are inside a slice.
A top-level nil pointer is harder, maybe fundamentally broken by gob's model.
Thinking required.
However, a slice is the important case since people don't expect to be sending
top-level nils much, but they can arise easily in slices.
R=golang-dev, josharian, adg
CC=golang-dev
https://golang.org/cl/
13042044
Rob Pike [Mon, 19 Aug 2013 01:18:43 +0000 (11:18 +1000)]
make.bash: exit if dist fails
The shell's -e doesn't work across "eval"; need to error-check by hand.
The recent spate of Darwin build failures pointed out that if the first
run of cmd/dist fails, we keep going. We shouldn't.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
13098043
David Symonds [Mon, 19 Aug 2013 01:11:27 +0000 (11:11 +1000)]
cmd/dist: join with TMPDIR more carefully to avoid // in path.
This might fix the mkdtemp problem on the darwin builders if they
have TMPDIR set to a path ending in a slash; at worse this will
result in cleaner path names.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
13097043
Marco Hennings [Mon, 19 Aug 2013 00:45:44 +0000 (10:45 +1000)]
archive/tar: Fix support for long links and improve PAX support.
The tar/archive code from golang has a problem with linknames with length >
100. A pax header is added but the original header still written with a too
long field length.
As it is clear that pax support is incomplete I have added missing
implementation parts.
This commit contains code from the golang project in the folder tar/archiv.
The following pax header records are now automatically written:
- gname)
- linkpath
- path
- uname
The following fields can be written with PAX, but the default is to use the
star binary extension.
- gid (value >
2097151 )
- size (value >
8589934591 )
- uid (value >
2097151 )
The string fields are written when the value is longer as the field or if the
string contains a char that is not encodable as 7-bit ASCII value.
The change was tested against a current ubuntu-cloud image tarball comparing
the compressed result.
+ added some automated tests for the new functionality.
Fixes #6056.
R=dsymonds
CC=golang-dev
https://golang.org/cl/
12561043
David Symonds [Mon, 19 Aug 2013 00:45:06 +0000 (10:45 +1000)]
A+C: Marco Hennings (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/
13096043
Rob Pike [Mon, 19 Aug 2013 00:15:30 +0000 (10:15 +1000)]
testing: don't start timing a Parallel test until it's actually starting
Fixes #5285.
R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/
13045044
Dominik Honnef [Mon, 19 Aug 2013 00:14:10 +0000 (10:14 +1000)]
encoding/xml: flush buffer after encoding token
R=rsc, bradfitz, adg
CC=golang-dev
https://golang.org/cl/
13004046
Rob Pike [Sun, 18 Aug 2013 22:29:43 +0000 (08:29 +1000)]
cmd/dist: more informative error for mkdtemp failing
The Darwin builders are all failing here but strerror doesn't provide context.
R=golang-dev, bradfitz, adg
CC=golang-dev
https://golang.org/cl/
13095043
Mikio Hara [Sun, 18 Aug 2013 10:19:36 +0000 (19:19 +0900)]
net: make protocol-specific WriteTo, WriteMsg methods return error instead of crash
R=golang-dev, dave, rsc, adg, bradfitz
CC=golang-dev
https://golang.org/cl/
11809043
Emil Hessman [Sat, 17 Aug 2013 22:11:34 +0000 (08:11 +1000)]
net/textproto: use ReadDotBytes instead of non-existent ReadDotAll.
Fixes #5893.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
13086043
Emil Hessman [Sat, 17 Aug 2013 22:10:00 +0000 (08:10 +1000)]
net/textproto: replace '3-digit' with 'three-digit'
A matter on form in documentation.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
13087043
Mikio Hara [Sat, 17 Aug 2013 04:40:55 +0000 (13:40 +0900)]
net: fix garbage connection close in dual stack tests
This may possibly be the root cause of flaky dual stack tests.
Update #4176
Update #5001
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
13050043
Mikio Hara [Sat, 17 Aug 2013 04:40:14 +0000 (13:40 +0900)]
net: enable runtime-integrated network pollster on netbsd
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
13080043
Mikio Hara [Sat, 17 Aug 2013 03:11:29 +0000 (12:11 +0900)]
runtime: integrated network pollster for netbsd/amd64,386,arm
Original CL by minux (
9545044 ).
Update #6146
R=golang-dev, rsc
CC=golang-dev, minux.ma
https://golang.org/cl/
12949045
Russ Cox [Sat, 17 Aug 2013 02:43:05 +0000 (22:43 -0400)]
net: limit number of concurrent cgo calls
The limit is 500. There is no way to change it.
This primarily affects name resolution.
If a million goroutines try to resolve DNS names,
only 500 will get to execute cgo calls at a time.
But in return the operating system will not crash.
Fixes #5625.
R=golang-dev, dan.kortschak, r, dvyukov
CC=bradfitz, golang-dev
https://golang.org/cl/
13038043
Russ Cox [Sat, 17 Aug 2013 02:25:26 +0000 (22:25 -0400)]
runtime: impose thread count limit
Actually working to stay within the limit could cause subtle deadlocks.
Crashing avoids the subtlety.
Fixes #4056.
R=golang-dev, r, dvyukov
CC=golang-dev
https://golang.org/cl/
13037043
Russ Cox [Sat, 17 Aug 2013 01:45:59 +0000 (21:45 -0400)]
cmd/gc: separate "has pointers" from "needs zeroing" in stack frame
When the new call site-specific frame bitmaps are available,
we can cut the zeroing to just those values that need it due
to scope escaping.
R=cshapiro, cshapiro
CC=golang-dev
https://golang.org/cl/
13045043
Dmitriy Vyukov [Fri, 16 Aug 2013 18:42:54 +0000 (22:42 +0400)]
doc: describe halt_on_error race detector parameter
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
13067043
Dmitriy Vyukov [Fri, 16 Aug 2013 17:54:04 +0000 (21:54 +0400)]
runtime/race: add output tests for different GORACE params
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
13065043
Dmitriy Vyukov [Fri, 16 Aug 2013 17:14:38 +0000 (21:14 +0400)]
test: say that nilptr2.go requires 256+MB stack
Fixes #6161.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
13059043
Dmitriy Vyukov [Fri, 16 Aug 2013 17:04:05 +0000 (21:04 +0400)]
runtime: fix goroutine stack accounting
Fixes #6166.
Fixes #6168.
R=golang-dev, bradfitz, remyoudompheng
CC=golang-dev
https://golang.org/cl/
12927045
Dominik Honnef [Fri, 16 Aug 2013 17:03:40 +0000 (13:03 -0400)]
misc/emacs: godef: print the entire description, not just the first line
When identifying structs or interfaces we really want to know
their makeup, not just their name.
R=adonovan
CC=golang-dev
https://golang.org/cl/
13042043
Dmitriy Vyukov [Fri, 16 Aug 2013 13:51:09 +0000 (17:51 +0400)]
runtime/race: update runtime to rev 188542
Fixes #6107.
race: output goroutine 1 as main goroutine
Fixes #6130.
race: option to abort program on first detected error
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/
12968044
Dmitriy Vyukov [Fri, 16 Aug 2013 12:02:55 +0000 (16:02 +0400)]
net: fix bug in fdMutex
Fixes #6165.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12984044
Robert Dinu [Fri, 16 Aug 2013 07:19:22 +0000 (17:19 +1000)]
A+C: change Robert Dinu's email address
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
12759043
Rob Pike [Fri, 16 Aug 2013 05:38:18 +0000 (15:38 +1000)]
doc/go1.2.txt: testing: add TB interface
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
12890044
Carl Shapiro [Fri, 16 Aug 2013 05:15:04 +0000 (01:15 -0400)]
cmd/5g, cmd/6g, cmd/8g: update frame zeroing for new bitmap format
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
12740046
Rob Pike [Fri, 16 Aug 2013 04:57:49 +0000 (14:57 +1000)]
time: fix time zones yet again.
This time we're going for 5!
http://goo.gl/3ETYH7
Fixes #3790
Yeah, right.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
13002044
David Symonds [Fri, 16 Aug 2013 04:36:06 +0000 (14:36 +1000)]
undo CL
12822043 /
96fefaa02ae3
Fixes #6160.
««« original CL description
go/doc: permit a package synopsis to end with ":\n".
R=gri, r
CC=golang-dev
https://golang.org/cl/
12822043
»»»
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
13040043
Dominik Honnef [Fri, 16 Aug 2013 04:22:38 +0000 (00:22 -0400)]
misc/emacs: allow godef to work in coverage buffers
Jumps to the same file will use the original buffer, not the
coverage buffer. Making it work for the coverage buffer isn't
worth the trouble, especially because it would break as soon as
you jump to a different file and back.
Use error instead of message so it actually terminates
R=adonovan
CC=golang-dev
https://golang.org/cl/
13041043
Dominik Honnef [Fri, 16 Aug 2013 04:06:19 +0000 (00:06 -0400)]
misc/emacs: do not use any free variables
R=adonovan
CC=golang-dev
https://golang.org/cl/
12744046
Dominik Honnef [Fri, 16 Aug 2013 03:40:38 +0000 (20:40 -0700)]
misc/emacs: when defining prog-mode, define it like GNU Emacs 24 would
Fixes #6156.
R=adonovan
CC=golang-dev
https://golang.org/cl/
13035043
Andrew Gerrand [Fri, 16 Aug 2013 03:14:13 +0000 (13:14 +1000)]
misc/dist: don't copy godoc templates to lib/godoc
They're baked into the godoc binary now.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/
12751047
Rob Pike [Fri, 16 Aug 2013 02:49:51 +0000 (12:49 +1000)]
cmd/go: fix at least some instances of double compilation
When the packages the tested package depends on don't build,
we weren't getting out early. Added a simple check for a successful
build to an existing early out.
There may be other ways that double compilation arises, but
this fixes the one listed in the issue.
Fixes #5679
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
13036043
Rob Pike [Fri, 16 Aug 2013 02:40:02 +0000 (12:40 +1000)]
cmd/gc: remove mentions of "ideal" from error messages.
_ = complex("foo", 0)
_ = complex(true, 0)
now trigger:
x.go:4: invalid operation: complex("foo", 0) (mismatched types untyped string and untyped number)
x.go:5: invalid operation: complex(true, 0) (mismatched types untyped bool and untyped number)
Fixes #4521
R=golang-dev, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/
12973043
Dominik Honnef [Fri, 16 Aug 2013 02:37:16 +0000 (22:37 -0400)]
misc/emacs: Refactor coverage code into multiple functions
Also fixes color gradient being calculated against the wrong maximum.
R=adonovan
CC=golang-dev
https://golang.org/cl/
12968043
Russ Cox [Fri, 16 Aug 2013 02:34:06 +0000 (22:34 -0400)]
runtime: impose stack size limit
The goal is to stop only those programs that would keep
going and run the machine out of memory, but before they do that.
1 GB on 64-bit, 250 MB on 32-bit.
That seems implausibly large, and it can be adjusted.
Fixes #2556.
Fixes #4494.
Fixes #5173.
R=khr, r, dvyukov
CC=golang-dev
https://golang.org/cl/
12541052
Dimitri Tcaciuc [Fri, 16 Aug 2013 01:43:43 +0000 (11:43 +1000)]
image: Inline example image data to make it runnable on playground.
Use more compressed image to reduce source clutter.
Fixes #5983.
R=nigeltao, adg
CC=golang-dev
https://golang.org/cl/
12513044
Nigel Tao [Fri, 16 Aug 2013 01:40:56 +0000 (11:40 +1000)]
A+C: Dimitri Tcaciuc (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/
13024045
Nigel Tao [Fri, 16 Aug 2013 01:23:35 +0000 (11:23 +1000)]
database/sql: make Rows.Next returning false always implicitly call
Rows.Close.
Previously, callers that followed the example code (but not call
rows.Close after "for rows.Next() { ... }") could leak statements if
the driver returned an error other than io.EOF.
R=bradfitz, alex.brainman
CC=golang-dev, rsc
https://golang.org/cl/
12677050
Russ Cox [Fri, 16 Aug 2013 01:05:05 +0000 (21:05 -0400)]
cmd/gc: ensure addable in checknil (fix race build)
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/
12791044
Brad Fitzpatrick [Fri, 16 Aug 2013 00:40:05 +0000 (17:40 -0700)]
net/http: don't send an automatic Content-Length on a 304 Not Modified
Also start of some test helper unification, long overdue.
I refrained from cleaning up the rest in this CL.
Fixes #6157
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
13030043
Rob Pike [Fri, 16 Aug 2013 00:35:22 +0000 (10:35 +1000)]
doc/go1.2.txt: delete 'go doc'
It's nearly useless and for plain 'go doc', 'godoc .' works fine.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
13004044
Rob Pike [Fri, 16 Aug 2013 00:30:31 +0000 (10:30 +1000)]
doc/go1.2.txt: three-index slices are going into 1.2
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
12931044
Rob Pike [Fri, 16 Aug 2013 00:30:05 +0000 (10:30 +1000)]
cmd/go: delete 'go doc'
It's next to useless and confusing as well. Let's make godoc better instead.
Fixes #4849.
R=golang-dev, dsymonds, adg, rogpeppe, rsc
CC=golang-dev
https://golang.org/cl/
12974043
Brad Fitzpatrick [Thu, 15 Aug 2013 23:47:31 +0000 (16:47 -0700)]
net/http: unify the confusingly-named serve_test and server_test
One was tiny. One was gigantic. Now one is gone and one is giganticer.
No code changes.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
13025043
Russ Cox [Thu, 15 Aug 2013 18:38:32 +0000 (14:38 -0400)]
cmd/gc: &x panics if x does
See golang.org/s/go12nil.
This CL is about getting all the right checks inserted.
A followup CL will add an optimization pass to
remove redundant checks.
R=ken2
CC=golang-dev
https://golang.org/cl/
12970043
Russ Cox [Thu, 15 Aug 2013 18:33:26 +0000 (14:33 -0400)]
spec: &x panics if x does
See golang.org/s/go12nil for the extended version.
R=golang-dev, r, adonovan
CC=golang-dev
https://golang.org/cl/
12964043
Russ Cox [Thu, 15 Aug 2013 15:51:04 +0000 (11:51 -0400)]
tests: remove two misuses of nil pointers
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12858044
Mikio Hara [Thu, 15 Aug 2013 14:22:55 +0000 (23:22 +0900)]
runtime: fix wrong syscall numbers on freebsd/386, openbsd/386
R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/
12876044
Mikio Hara [Thu, 15 Aug 2013 12:10:03 +0000 (21:10 +0900)]
net: enable runtime-integrated network pollster on freebsd, openbsd
Fixes #5199.
Benchmark results on freebsd/amd64 (virtual machine):
benchmark old ns/op new ns/op delta
BenchmarkTCP4OneShot-2 184566 187164 +1.41%
BenchmarkTCP4OneShotTimeout-2 215558 187722 -12.91%
BenchmarkTCP4Persistent-2 59686 41294 -30.81%
BenchmarkTCP4PersistentTimeout-2 60692 39974 -34.14%
BenchmarkTCP6OneShot-2 226595 223688 -1.28%
BenchmarkTCP6OneShotTimeout-2 253144 225161 -11.05%
BenchmarkTCP6Persistent-2 69157 55605 -19.60%
BenchmarkTCP6PersistentTimeout-2 70426 53805 -23.60%
BenchmarkTCP4ConcurrentReadWrite-2 53878 56087 +4.10%
BenchmarkTCP6ConcurrentReadWrite-2 66538 68190 +2.48%
benchmark old allocs new allocs delta
BenchmarkTCP4OneShot-2 39 36 -7.69%
BenchmarkTCP4OneShotTimeout-2 42 36 -14.29%
BenchmarkTCP4Persistent-2 1 0 -100.00%
BenchmarkTCP4PersistentTimeout-2 1 0 -100.00%
BenchmarkTCP6OneShot-2 41 36 -12.20%
BenchmarkTCP6OneShotTimeout-2 43 36 -16.28%
BenchmarkTCP6Persistent-2 1 0 -100.00%
BenchmarkTCP6PersistentTimeout-2 1 0 -100.00%
BenchmarkTCP4ConcurrentReadWrite-2 0 0 n/a%
BenchmarkTCP6ConcurrentReadWrite-2 0 0 n/a%
benchmark old bytes new bytes delta
BenchmarkTCP4OneShot-2 3084 2544 -17.51%
BenchmarkTCP4OneShotTimeout-2 3129 2519 -19.50%
BenchmarkTCP4Persistent-2 30 0 -100.00%
BenchmarkTCP4PersistentTimeout-2 31 0 -100.00%
BenchmarkTCP6OneShot-2 3297 2660 -19.32%
BenchmarkTCP6OneShotTimeout-2 3306 2655 -19.69%
BenchmarkTCP6Persistent-2 31 0 -100.00%
BenchmarkTCP6PersistentTimeout-2 29 0 -100.00%
BenchmarkTCP4ConcurrentReadWrite-2 2 0 -100.00%
BenchmarkTCP6ConcurrentReadWrite-2 7 0 -100.00%
R=dvyukov, minux.ma, dave, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/
8264043
Dmitriy Vyukov [Thu, 15 Aug 2013 10:32:10 +0000 (14:32 +0400)]
runtime: remove old preemption checks
runtime.gcwaiting checks are not needed anymore
R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/
12934043
Dmitriy Vyukov [Thu, 15 Aug 2013 10:24:28 +0000 (14:24 +0400)]
runtime: fix plan9 build
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12986043
Rémy Oudompheng [Thu, 15 Aug 2013 08:31:18 +0000 (10:31 +0200)]
doc: update go1.2.txt
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12960043
Mikio Hara [Thu, 15 Aug 2013 07:40:33 +0000 (16:40 +0900)]
net: rearrange the call order of runtime-integrated network pollster and syscall functions
This CL rearranges the call order for raw networking primitives like
the following;
- For dialers that open active connections, pollDesc.Init will be
called before syscall.Connect.
- For stream listeners that open passive stream connections,
pollDesc.Init will be called just after syscall.Listen.
- For datagram listeners that open datagram connections,
pollDesc.Init will be called just after syscall.Bind.
This is in preparation for runtime-integrated network pollster for BSD
variants.
Update #5199
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/
12730043
Rob Pike [Thu, 15 Aug 2013 06:42:54 +0000 (16:42 +1000)]
time: expand acceptance of time zones when parsing
I tried to make it absolutely correct but there are too many
conflicting definitions for the official list of time zones.
Since when we're parsing we know when to expect
a time zone and we know what they look like if not exactly
what the definitive set is, we compromise. We accept any
three-character sequence of upper case letters, possibly
followed by a capital T (all four-letter zones end in T).
There is one crazy special case (ChST) and the possibility
of a signed hour offset for GMT.
Fixes #3790
I hope forever, but I doubt that very much.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
12969043
Brad Fitzpatrick [Thu, 15 Aug 2013 06:21:57 +0000 (23:21 -0700)]
archive/zip: speed up Zip64 test
Took 76 seconds or so before. By avoiding flate and crc32 on
4GB of data, it's now only 12 seconds. Still a slow test, but
not painful to run anymore when you forget -short.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
12950043
Brad Fitzpatrick [Thu, 15 Aug 2013 06:21:32 +0000 (23:21 -0700)]
testing: add TB, an interface common to T and B
R=golang-dev, kevlar, rsc, adg, r
CC=golang-dev
https://golang.org/cl/
12962043
Rob Pike [Thu, 15 Aug 2013 04:29:04 +0000 (14:29 +1000)]
os/exec: document that LookPath's result may be a relative path
Fixes #3622
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/
12971043
Rob Pike [Thu, 15 Aug 2013 03:15:55 +0000 (13:15 +1000)]
go_spec.html: clarify that tags are part of struct type identity
One sentence says they're ignored, another says they take part.
Fix the first.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
12741046
Alex Brainman [Thu, 15 Aug 2013 02:13:00 +0000 (12:13 +1000)]
runtime/race: add end-to-end test on windows
whatever "end-to-end" means here
R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/
12898044
Rob Pike [Thu, 15 Aug 2013 00:36:46 +0000 (10:36 +1000)]
cmd/go: fix bad error message in coverage for package without non-test files
Was checking for nil map; must check for empty map instead.
Fixes #6065
Before:
go test -cover
# testmain
/var/folders/00/013l0000h01000cxqpysvccm0004fc/T/go-build233480051/_/Users/r/issue/_test/_testmain.go:11: imported and not used: "_/Users/r/issue"
FAIL _/Users/r/issue [build failed]
Now:
go test -cover
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok _/Users/r/issue 0.021s
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12916043
Rob Pike [Thu, 15 Aug 2013 00:10:49 +0000 (10:10 +1000)]
time: handle GMT possibly with offset
Update #3790
Handle time zones like GMT-8.
The more general time zone-matching problem is not yet resolved.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
12922043
David Symonds [Wed, 14 Aug 2013 23:44:23 +0000 (09:44 +1000)]
cmd/go: fix detached heads that are remnants of bad git clones.
Fixes #6042.
R=adg
CC=golang-dev
https://golang.org/cl/
12923043
Dominik Honnef [Wed, 14 Aug 2013 23:03:44 +0000 (16:03 -0700)]
misc/emacs: Allow go-coverage to work in existing coverage buffers by reusing previous arguments
R=golang-dev, adonovan, bradfitz
CC=golang-dev
https://golang.org/cl/
12721043
Russ Cox [Wed, 14 Aug 2013 22:52:09 +0000 (18:52 -0400)]
encoding/xml: support generic encoding interfaces
Remove custom support for time.Time.
No new tests: the tests for the time.Time special case
now test the general case.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12751045
Carl Shapiro [Wed, 14 Aug 2013 22:21:53 +0000 (15:21 -0700)]
cmd/go, runtime/cgo: explicitly target ARMv5T
The baseline architecture had been left to the GCC configured
default which can be more accomodating than the rest of the Go
toolchain. This prevented instructions used by the 5g compiler,
like BLX, from being used in GCC compiled assembler code.
R=golang-dev, dave, rsc, elias.naur, cshapiro
CC=golang-dev
https://golang.org/cl/
12954043
Andrew Gerrand [Wed, 14 Aug 2013 22:13:38 +0000 (08:13 +1000)]
doc: update go1.2.txt
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12957044
Brad Fitzpatrick [Wed, 14 Aug 2013 21:56:31 +0000 (14:56 -0700)]
doc: update go1.2.txt
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
12953043
Mikio Hara [Wed, 14 Aug 2013 20:53:53 +0000 (05:53 +0900)]
net: simplify dial
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12884044
Elias Naur [Wed, 14 Aug 2013 20:28:40 +0000 (16:28 -0400)]
cmd/ld: Remove superfluous redundant iself check
CL
12741044 added an extra iself condition to an if statement that already contained it. Remove it.
R=rsc
CC=golang-dev
https://golang.org/cl/
12949043
Dmitriy Vyukov [Wed, 14 Aug 2013 20:20:36 +0000 (00:20 +0400)]
runtime: fix SetBlockProfileRate
It doughtily misses all possible corner cases.
In particular on machines with <1GHz processors,
SetBlockProfileRate(1) disables profiling.
Fixes #6114.
R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
12936043
Mikio Hara [Wed, 14 Aug 2013 20:08:08 +0000 (05:08 +0900)]
net: simplify non-cgo DNS exchange
Also does less buffer allocation in case of TCP fallback.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
12925043
Mikio Hara [Wed, 14 Aug 2013 20:07:35 +0000 (05:07 +0900)]
net: fix TestTCPLookup
R=golang-dev, dvyukov, dave
CC=golang-dev
https://golang.org/cl/
12766044
Russ Cox [Wed, 14 Aug 2013 19:37:23 +0000 (15:37 -0400)]
doc: update go1.2.txt
Will submit once I can fill in the CL XXX number.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
12912044
Rémy Oudompheng [Wed, 14 Aug 2013 19:24:48 +0000 (21:24 +0200)]
cmd/5g, cmd/6g, cmd/8g: restore occurrences of R replaced by nil in comments.
R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
12842043
Russ Cox [Wed, 14 Aug 2013 18:58:28 +0000 (14:58 -0400)]
encoding/xml: add, support Marshaler interface
See golang.org/s/go12xml for design.
Repeat of CL
12603044 , which was submitted accidentally
and then rolled back.
Fixes #2771.
Fixes #4169.
Fixes #5975.
Fixes #6125.
R=golang-dev
CC=golang-dev
https://golang.org/cl/
12919043
Russ Cox [Wed, 14 Aug 2013 18:57:45 +0000 (14:57 -0400)]
encoding/xml: add, support Unmarshaler interface
See golang.org/s/go12xml for design.
R=golang-dev, dominik.honnef, dan.kortschak
CC=golang-dev
https://golang.org/cl/
12556043