]>
Cypherpunks repositories - gostls13.git/log
Robert Griesemer [Wed, 13 Jul 2011 22:10:50 +0000 (15:10 -0700)]
filepath/path: fix a comment
R=bradfitz
CC=golang-dev
https://golang.org/cl/
4704047
Rob Pike [Wed, 13 Jul 2011 21:59:04 +0000 (07:59 +1000)]
exp/template: tweak behavior of booleans.
Russ suggested this technique, making the "and" and "or" functions handier.
But it's hacky, and I can be talked out of it.
R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/
4698044
Rob Pike [Wed, 13 Jul 2011 21:52:07 +0000 (07:52 +1000)]
exp/template: allow niladic methods inside chained field references.
Also really fix the bug about dot vs. receivers.
R=rsc, r
CC=golang-dev
https://golang.org/cl/
4705047
Yasuhiro Matsumoto [Wed, 13 Jul 2011 21:39:33 +0000 (14:39 -0700)]
http: fix Content-Type of file extension.
ServeFile() pass empty string to serveFile(). serveFile() should get
file extension via joining root and filename.
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
4654089
Wei Guangjing [Wed, 13 Jul 2011 19:44:21 +0000 (12:44 -0700)]
net: windows/amd64 port
R=rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/
3790044
Matthew Horsnell [Wed, 13 Jul 2011 19:34:29 +0000 (12:34 -0700)]
debug/elf: Read ELF Program headers.
NewFile has been fixed to read ELF Program headers into the structs.
Added test coverage.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
4628062
Russ Cox [Wed, 13 Jul 2011 19:33:03 +0000 (12:33 -0700)]
A+C: Matthew Horsnell (individual CLA)
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
4700044
Wei Guangjing [Wed, 13 Jul 2011 18:44:44 +0000 (11:44 -0700)]
runtime: stdcall_raw stack 16byte align for Win64
R=alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/
4681049
Dmitriy Vyukov [Wed, 13 Jul 2011 18:22:41 +0000 (11:22 -0700)]
runtime: fix data race during Itab hash update/lookup
The data race is on newly published Itab nodes, which are
both unsafely published and unsafely acquired. It can
break on IA-32/Intel64 due to compiler optimizations
(most likely not an issue as of now) and on ARM due to
hardware memory access reorderings.
R=rsc
CC=golang-dev
https://golang.org/cl/
4673055
Brad Fitzpatrick [Wed, 13 Jul 2011 17:54:51 +0000 (10:54 -0700)]
docs: fix wrong it's -> its
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
4702046
Sam Thorogood [Wed, 13 Jul 2011 17:15:00 +0000 (10:15 -0700)]
exp/regexp/syntax: add Prog.NumCap
R=rsc, r
CC=golang-dev
https://golang.org/cl/
4662083
Robert Griesemer [Wed, 13 Jul 2011 16:40:53 +0000 (09:40 -0700)]
exp/eval, exp/ogle: remove packages eval and ogle
An externally maintained version of exp/eval can
be found at: https://bitbucket.org/binet/go-eval/ .
R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/
4695047
Bobby Powers [Wed, 13 Jul 2011 07:12:17 +0000 (17:12 +1000)]
gob: register more slice types
Without explicitly registering slice types, gob fails to encode
map[string]interface{} instances where the value is a slice,
failing with a message such as:
gob: type not registered for interface: []string
Fixes #2065.
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/
4672056
Nigel Tao [Wed, 13 Jul 2011 06:53:02 +0000 (16:53 +1000)]
html: update section references in comments to the latest HTML5 spec.
R=r
CC=golang-dev
https://golang.org/cl/
4699048
Rob Pike [Wed, 13 Jul 2011 06:10:12 +0000 (16:10 +1000)]
C+A: Bobby Powers <bobbypowers@gmail.com>
R=golang-dev, dsymonds
CC=bobbypowers, golang-dev
https://golang.org/cl/
4695050
Rob Pike [Wed, 13 Jul 2011 05:58:31 +0000 (15:58 +1000)]
exp/template: doc and API changes suggested by rsc.
- template invocation is by string constant only.
- NewSet is gone.
- no global Funcs
- writer is now first arg to Execute
R=rsc, r
CC=golang-dev
https://golang.org/cl/
4700043
Rob Pike [Wed, 13 Jul 2011 03:50:05 +0000 (13:50 +1000)]
exp/template: add Set.AddSet and Set.Union.
Document and test that Set.Parse can be called multiple times.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4703044
Rob Pike [Wed, 13 Jul 2011 03:21:18 +0000 (13:21 +1000)]
exp/template: allow variables as template names.
Just an oversight it wasn't already there.
Thanks to islandberry@live.com for pointing out the omission.
R=golang-dev, dsymonds
CC=golang-dev, islandberry
https://golang.org/cl/
4703043
Rob Pike [Wed, 13 Jul 2011 03:20:05 +0000 (13:20 +1000)]
go_tutorial: change the way it's generated.
No longer do we generate HTML from it; instead the input
file is already in HTML but has template invocations to
extract programs from other files.
Delete htmlgen, which is no longer needed.
Add tmpltohtml, which runs the templating code.
R=golang-dev, dsymonds, adg
CC=golang-dev
https://golang.org/cl/
4699041
David Anderson [Wed, 13 Jul 2011 00:49:55 +0000 (17:49 -0700)]
5l, 6l, 8l: Add a PT_LOAD PHDR entry for the PHDR.
Per the TIS ELF spec, if a PHDR entry is present in the
program header table, it must be part of the memory image of
the program. Failure to do this makes elflint complain, and
causes some tools that manipulate ELF to crash.
R=iant, rsc
CC=dave, golang-dev
https://golang.org/cl/
4650067
Robert Griesemer [Wed, 13 Jul 2011 00:45:29 +0000 (17:45 -0700)]
csv: fix spelling errors in comments
Fixes #2066.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4699045
Russ Cox [Wed, 13 Jul 2011 00:44:59 +0000 (17:44 -0700)]
tag release.r58.1: adds OS X Lion support
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/
4702043
Quan Yong Zhai [Wed, 13 Jul 2011 00:30:40 +0000 (17:30 -0700)]
runtime: replace runtime.mcpy with runtime.memmove
faster string operations, and more
tested on linux/386
runtime_test.BenchmarkSliceToString 642 532 -17.13%
runtime_test.BenchmarkStringToSlice 636 528 -16.98%
runtime_test.BenchmarkConcatString 1109 897 -19.12%
R=r, iant, rsc
CC=golang-dev
https://golang.org/cl/
4674042
Andrew Gerrand [Tue, 12 Jul 2011 23:40:49 +0000 (09:40 +1000)]
doc: gofix io2010 demo programs
R=golang-dev, gri, r, agl
CC=golang-dev
https://golang.org/cl/
4696046
Wei Guangjing [Tue, 12 Jul 2011 18:29:38 +0000 (11:29 -0700)]
debug/pe: fixes ImportedSymbols for Win64.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/
4639086
Robert Hencke [Tue, 12 Jul 2011 18:12:06 +0000 (11:12 -0700)]
gc: make size of struct{} and [0]byte 0 bytes
Fixes #1949.
R=iant, rsc
CC=golang-dev
https://golang.org/cl/
4634124
Dmitriy Vyukov [Tue, 12 Jul 2011 17:56:21 +0000 (10:56 -0700)]
runtime: eliminate false sharing during stack growth
Remove static variable from runtime·oldstack().
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows (with CL
4657091 applied):
benchmark old ns/op new ns/op delta
BenchmarkStackGrowth 1183.00 1180.00 -0.25%
BenchmarkStackGrowth-2 1249.00 1211.00 -3.04%
BenchmarkStackGrowth-4 954.00 805.00 -15.62%
BenchmarkStackGrowth-8 701.00 683.00 -2.57%
BenchmarkStackGrowth-16 465.00 415.00 -10.75%
R=rsc
CC=golang-dev
https://golang.org/cl/
4693042
Russ Cox [Tue, 12 Jul 2011 16:26:05 +0000 (09:26 -0700)]
runtime: fix comment (lost in shuffle)
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/
4710041
Dmitriy Vyukov [Tue, 12 Jul 2011 16:24:32 +0000 (09:24 -0700)]
runtime: eliminate contention during stack allocation
Standard-sized stack frames use plain malloc/free
instead of centralized lock-protected FixAlloc.
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows:
benchmark old ns/op new ns/op delta
BenchmarkStackGrowth 1045.00 949.00 -9.19%
BenchmarkStackGrowth-2 3450.00 800.00 -76.81%
BenchmarkStackGrowth-4 5076.00 513.00 -89.89%
BenchmarkStackGrowth-8 7805.00 471.00 -93.97%
BenchmarkStackGrowth-16 11751.00 321.00 -97.27%
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
4657091
Dmitriy Vyukov [Tue, 12 Jul 2011 16:24:21 +0000 (09:24 -0700)]
sync: improve RWMutex performance
The new implementation features wait-free
fast path for readers which significantly improves
performance/scalability on read-mostly workloads.
Benchmark results on HP Z600 (2 x Xeon E5620, 8 HT cores, 2.40GHz)
are as follows:
benchmark old ns/op new ns/op delta
BenchmarkRWMutexUncontended 179.00 96.60 -46.03%
BenchmarkRWMutexUncontended-2 89.10 49.10 -44.89%
BenchmarkRWMutexUncontended-4 44.70 24.70 -44.74%
BenchmarkRWMutexUncontended-8 23.30 12.90 -44.64%
BenchmarkRWMutexUncontended-16 16.80 8.75 -47.92%
BenchmarkRWMutexWrite100 79.60 26.80 -66.33%
BenchmarkRWMutexWrite100-2 305.00 33.00 -89.18%
BenchmarkRWMutexWrite100-4 245.00 113.00 -53.88%
BenchmarkRWMutexWrite100-8 330.00 147.00 -55.45%
BenchmarkRWMutexWrite100-16 371.00 152.00 -59.03%
BenchmarkRWMutexWrite10 78.30 29.80 -61.94%
BenchmarkRWMutexWrite10-2 348.00 165.00 -52.59%
BenchmarkRWMutexWrite10-4 447.00 199.00 -55.48%
BenchmarkRWMutexWrite10-8 564.00 180.00 -68.09%
BenchmarkRWMutexWrite10-16 492.00 192.00 -60.98%
BenchmarkRWMutexWorkWrite100 1077.00 1037.00 -3.71%
BenchmarkRWMutexWorkWrite100-2 659.00 596.00 -9.56%
BenchmarkRWMutexWorkWrite100-4 509.00 361.00 -29.08%
BenchmarkRWMutexWorkWrite100-8 603.00 351.00 -41.79%
BenchmarkRWMutexWorkWrite100-16 750.00 607.00 -19.07%
BenchmarkRWMutexWorkWrite10 990.00 951.00 -3.94%
BenchmarkRWMutexWorkWrite10-2 1119.00 1070.00 -4.38%
BenchmarkRWMutexWorkWrite10-4 1300.00 1199.00 -7.77%
BenchmarkRWMutexWorkWrite10-8 1424.00 1291.00 -9.34%
BenchmarkRWMutexWorkWrite10-16 1981.00 1786.00 -9.84%
R=rsc
CC=golang-dev
https://golang.org/cl/
4671051
Rob Pike [Tue, 12 Jul 2011 13:45:10 +0000 (23:45 +1000)]
effective go: tweak the words about semicolons, parens in control structures,
and make and new.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4699043
Adam Langley [Tue, 12 Jul 2011 13:29:24 +0000 (09:29 -0400)]
hash/crc32: add SSE4.2 support
Using the CRC32 instruction speeds up the Castagnoli computation by
about 20x on a modern Intel CPU.
R=rsc
CC=golang-dev
https://golang.org/cl/
4650072
Alex Brainman [Tue, 12 Jul 2011 07:27:07 +0000 (17:27 +1000)]
go/build: include processing of .c files for cgo packages
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4696041
Nigel Tao [Tue, 12 Jul 2011 07:02:55 +0000 (17:02 +1000)]
image: remove superfluous if condition.
DrawMask already returns early if r.Empty().
R=r
CC=golang-dev
https://golang.org/cl/
4703041
Nigel Tao [Tue, 12 Jul 2011 06:56:29 +0000 (16:56 +1000)]
image: re-organize draw.go.
There are no behavioral changes, only some copy-and-pastes.
Before, drawFillOver was next to drawCopyOver.
After, drawFillOver is next to drawFillSrc, which is more similar to
drawFillOver than drawCopyOver is.
Similarly, drawCopyOver is now next to drawCopySrc, etc.
R=r
CC=golang-dev
https://golang.org/cl/
4695045
Nigel Tao [Tue, 12 Jul 2011 06:39:38 +0000 (16:39 +1000)]
image: change Pix from []FooColor to []uint8.
Some benchmark numbers below. The image/draw fast-paths show dramatic
improvement, the generic slow-paths show a smaller slow-down.
BEFORE
png.BenchmarkEncodePaletted 200
8203800 ns/op 37.45 MB/s
png.BenchmarkEncodeRGBOpaque 100
26940440 ns/op 45.61 MB/s
png.BenchmarkEncodeRGBA 20
73821000 ns/op 16.65 MB/s
jpeg.BenchmarkEncodeRGBOpaque 50
35598640 ns/op 34.52 MB/s
draw.BenchmarkFillOver 500
4024226 ns/op
draw.BenchmarkFillSrc 10000 152736 ns/op
draw.BenchmarkCopyOver 500
3452824 ns/op
draw.BenchmarkCopySrc 50000 73218 ns/op
draw.BenchmarkNRGBAOver 500
3941234 ns/op
draw.BenchmarkNRGBASrc 1000
2484400 ns/op
draw.BenchmarkYCbCr 1000
2609005 ns/op
draw.BenchmarkGlyphOver 2000
1169575 ns/op
draw.BenchmarkRGBA 200
9031390 ns/op
draw.BenchmarkGenericOver 50
34636620 ns/op
draw.BenchmarkGenericMaskOver 100
16561150 ns/op
draw.BenchmarkGenericSrc 100
13873760 ns/op
draw.BenchmarkGenericMaskSrc 100
25198860 ns/op
AFTER
png.BenchmarkEncodePaletted 200
8206600 ns/op 37.43 MB/s
png.BenchmarkEncodeRGBOpaque 100
26129530 ns/op 47.03 MB/s
png.BenchmarkEncodeRGBA 20
75776750 ns/op 16.22 MB/s
jpeg.BenchmarkEncodeRGBOpaque 50
37192940 ns/op 33.04 MB/s
draw.BenchmarkFillOver 500
3008134 ns/op
draw.BenchmarkFillSrc 10000 154214 ns/op
draw.BenchmarkCopyOver 1000
2169988 ns/op
draw.BenchmarkCopySrc 50000 73095 ns/op
draw.BenchmarkNRGBAOver 1000
2491079 ns/op
draw.BenchmarkNRGBASrc 2000
1361244 ns/op
draw.BenchmarkYCbCr 1000
2554269 ns/op
draw.BenchmarkGlyphOver 2000
1042225 ns/op
draw.BenchmarkRGBA 100
10233340 ns/op
draw.BenchmarkGenericOver 50
38421560 ns/op
draw.BenchmarkGenericMaskOver 100
17521190 ns/op
draw.BenchmarkGenericSrc 100
16351200 ns/op
draw.BenchmarkGenericMaskSrc 100
26538190 ns/op
R=r
CC=golang-dev
https://golang.org/cl/
4675076
Nigel Tao [Tue, 12 Jul 2011 06:17:02 +0000 (16:17 +1000)]
image/draw: add benchmarks.
R=r
CC=golang-dev
https://golang.org/cl/
4695043
Russ Cox [Tue, 12 Jul 2011 05:39:09 +0000 (01:39 -0400)]
doc: document r58.1
R=adg, dsymonds
CC=golang-dev
https://golang.org/cl/
4700041
Dmitriy Vyukov [Tue, 12 Jul 2011 05:25:14 +0000 (01:25 -0400)]
runtime: eliminate false sharing on runtime.goidgen
runtime.goidgen can be quite frequently modified and
shares cache line with the following variables,
it leads to false sharing.
50c6b0 b nfname
50c6b4 b nfunc
50c6b8 b nfunc$17
50c6bc b nhist$17
50c6c0 B runtime.checking
50c6c4 B runtime.gcwaiting
50c6c8 B runtime.goidgen
50c6cc B runtime.gomaxprocs
50c6d0 B runtime.panicking
50c6d4 B strconv.IntSize
50c6d8 B src/pkg/runtime/_xtest_.ss
50c6e0 B src/pkg/runtime/_xtest_.stop
50c6e8 b addrfree
50c6f0 b addrmem
50c6f8 b argv
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
4673054
Dmitriy Vyukov [Tue, 12 Jul 2011 05:23:58 +0000 (01:23 -0400)]
runtime: eliminate false sharing on random number generators
Use machine-local random number generator instead of
racy global ones.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
4674049
Dmitriy Vyukov [Tue, 12 Jul 2011 05:21:06 +0000 (01:21 -0400)]
runtime: fix data race on runtime·maxstring
The data race can lead to erroneous output of
"[invalid string]" instead of a string.
R=golang-dev
CC=golang-dev
https://golang.org/cl/
4678049
Alex Brainman [Tue, 12 Jul 2011 04:22:48 +0000 (14:22 +1000)]
6l: change default output name to 6.out.exe on windows
R=golang-dev, vcc.163
CC=golang-dev
https://golang.org/cl/
4670049
Brad Fitzpatrick [Tue, 12 Jul 2011 03:56:21 +0000 (20:56 -0700)]
http: support for periodic flushing in ReverseProxy
Fixes #2012
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4662091
Rob Pike [Tue, 12 Jul 2011 03:15:26 +0000 (13:15 +1000)]
exp/template: make numbers adhere to Go's rules for ideal constants.
Without further type informatnion, 1.0 is a float and an integer
must fit in an int.
R=rsc
CC=golang-dev
https://golang.org/cl/
4696042
Alex Brainman [Tue, 12 Jul 2011 03:08:22 +0000 (13:08 +1000)]
go/build: make Nuke comment say what it does
R=rsc
CC=golang-dev
https://golang.org/cl/
4697041
Andrew Gerrand [Tue, 12 Jul 2011 02:58:40 +0000 (22:58 -0400)]
codereview: fix for Mercurial 1.9
R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/
4686049
Yasuhiro Matsumoto [Tue, 12 Jul 2011 00:02:32 +0000 (20:02 -0400)]
doc: don't specify make target for working on windwos.
makehtml does not work on windows.
R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/
4675041
Andrew Gerrand [Mon, 11 Jul 2011 23:57:39 +0000 (09:57 +1000)]
undo CL
4675045 /
0e11e08951f7
Breaks Mercurial 1.8.3.
««« original CL description
codereview: fix for Mercurial 1.9
Fixes #2038.
R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/
4675045
»»»
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
4685055
Andrew Gerrand [Mon, 11 Jul 2011 23:36:46 +0000 (09:36 +1000)]
codereview: fix for Mercurial 1.9
Fixes #2038.
R=rsc, bobbypowers
CC=golang-dev
https://golang.org/cl/
4675045
Brad Fitzpatrick [Mon, 11 Jul 2011 22:59:27 +0000 (15:59 -0700)]
cgi: close stdout reader pipe when finished
This causes the child, if still writing, to get an error or
SIGPIPE and most likely exit so our subsequent wait can
finish.
A more guaranteed fix would be putting a time limit on the
child's overall execution, but this fixes the problem
I was having.
Fixes #2059
R=rsc
CC=golang-dev
https://golang.org/cl/
4675081
Brad Fitzpatrick [Mon, 11 Jul 2011 22:47:42 +0000 (15:47 -0700)]
os: don't permit Process.Signal after a successful Wait
R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/
4689043
Brad Fitzpatrick [Mon, 11 Jul 2011 21:46:46 +0000 (14:46 -0700)]
exec: closeAfterWait append bug
Wasn't actually eager closing the fds as a result of the
copy/paste bug. (GC was doing it instead)
R=rsc
CC=golang-dev
https://golang.org/cl/
4671057
Evan Martin [Mon, 11 Jul 2011 14:31:08 +0000 (07:31 -0700)]
json: encode \r and \n in strings as e.g. "\n", not "\u000A"
This is allowed by the JSON spec and is shorter/easier to read.
R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
4678046
Brad Fitzpatrick [Mon, 11 Jul 2011 14:25:45 +0000 (07:25 -0700)]
strconv: handle [-+]Infinity in atof
This is the form as returned by Postgres, as well
as JavaScript.
I've tried and failed to find authorative docs online
about the proper string serialization, if any.
R=golang-dev, gri, r, r, rsc
CC=golang-dev
https://golang.org/cl/
4650077
Rob Pike [Mon, 11 Jul 2011 08:06:24 +0000 (18:06 +1000)]
exp/template: fix bug in argument evaluation.
Must keep dot and the receiver separate - variables broke that symmetry.
Also clean up function invocation and rename "data" to "dot" for clarity.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4678048
Alex Brainman [Mon, 11 Jul 2011 05:40:41 +0000 (15:40 +1000)]
go/build: use os.MkdirAll to create directories
Replaces "mkdir -p ..." command, as Windows mkdir command
does not support -p flag. Also, is simpler and faster then
launching new process.
R=golang-dev, mattn.jp, adg, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
4626087
Rob Pike [Mon, 11 Jul 2011 05:23:38 +0000 (15:23 +1000)]
exp/template: fields and methods on variables.
Not strictly necessary (you could achieve the same, clumsily,
via with blocks) but great to have: $x.Field, $y.Method.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4678047
Rob Pike [Mon, 11 Jul 2011 04:43:21 +0000 (14:43 +1000)]
exp/template: documentation glitches and typos.
Also explain that len(v)==0 makes v a 'zero value'
in template execution.
R=golang-dev, dsymonds, adg, r
CC=golang-dev
https://golang.org/cl/
4691041
Rob Pike [Mon, 11 Jul 2011 02:36:10 +0000 (12:36 +1000)]
exp/template: simpler parse of char constants.
We can avoid the check against empty constants (''),
which UnquoteChar doesn't handle well, by leaving on
the trailing quote and seeing that's all we have left at the end.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4657090
Rob Pike [Mon, 11 Jul 2011 01:46:22 +0000 (11:46 +1000)]
exp/template: character constants.
Easier to implement than to justify leaving them out.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4662089
Rob Pike [Mon, 11 Jul 2011 00:01:15 +0000 (10:01 +1000)]
exp/template: static check for defined variables.
Worth catching at parse time rather than execution. Plus it's really easy.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4641100
Rob Pike [Sun, 10 Jul 2011 23:36:17 +0000 (09:36 +1000)]
exp/eval: delete binary
Mistakenly checked in.
Fixes #2058.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4670057
Rob Pike [Sun, 10 Jul 2011 23:35:50 +0000 (09:35 +1000)]
flag: make -help nicer.
- suppress the print that -help is not defined.
- return a special error code if -help is set
- do not change behavior if an explict "help" flag is defined.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4641099
Rob Pike [Sun, 10 Jul 2011 23:19:18 +0000 (09:19 +1000)]
exp/template: add functions print and println.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4687041
Rob Pike [Sun, 10 Jul 2011 10:56:26 +0000 (20:56 +1000)]
exp/template: package documentation
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4675072
Nigel Tao [Sun, 10 Jul 2011 04:29:47 +0000 (14:29 +1000)]
image: change Pix[0] to mean top-left corner of an image's Rect instead
of the origin.
image/png and image/jpeg benchmarks show no significant changes.
The image/draw changes suggest to me that making a gofix for this is not
feasible. People are just going to have to make manual fixes.
R=r
CC=golang-dev
https://golang.org/cl/
4681044
Andrew Gerrand [Sun, 10 Jul 2011 01:30:16 +0000 (11:30 +1000)]
archive/zip: add Writer
R=bradfitz, dchest, r, rsc
CC=golang-dev
https://golang.org/cl/
4523077
Evan Martin [Sat, 9 Jul 2011 22:18:31 +0000 (15:18 -0700)]
multipart: use textproto to handle multiline header
R=bradfitz
CC=golang-dev
https://golang.org/cl/
4686044
Brad Fitzpatrick [Sat, 9 Jul 2011 22:18:18 +0000 (15:18 -0700)]
CONTRIBUTORS: add Evan Martin (Google CLA)
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/
4657089
Andrew Balholm [Sat, 9 Jul 2011 22:10:39 +0000 (15:10 -0700)]
http: update triv.go with gofix
Sample code in triv.go wouldn't compile because it didn't use the new
FileSystem interface.
This was discussed on golang-nuts on July 7.
https://groups.google.com/forum/#!topic/golang-nuts/NMhZk3Ft_Vc
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
4684044
Rob Pike [Sat, 9 Jul 2011 21:32:01 +0000 (07:32 +1000)]
exp/template: better template invocation
1) Make the value optional ({{template "foo"}})
2) Allow the template identifier to be a thing of type *Template.
The second makes it easy to drop templates in to a set dynamically
during invocation.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4671056
Rob Pike [Sat, 9 Jul 2011 13:17:38 +0000 (23:17 +1000)]
tutorial: remove all line numbers and references to them.
R=golang-dev, mikioh.mikioh, dsymonds
CC=golang-dev
https://golang.org/cl/
4675070
Mikio Hara [Sat, 9 Jul 2011 10:16:45 +0000 (20:16 +1000)]
doc/progs: gofmt -w
R=r, gri, r
CC=golang-dev
https://golang.org/cl/
4662085
Rob Pike [Sat, 9 Jul 2011 07:11:35 +0000 (17:11 +1000)]
exp/template: vars as arguments to functions and methods.
That should be it, bugs aside.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4671055
Rob Pike [Sat, 9 Jul 2011 02:05:39 +0000 (12:05 +1000)]
exp/template: variable evaluation.
Still need to do static checking of declarations during parse.
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/
4667070
Rob Pike [Fri, 8 Jul 2011 22:59:56 +0000 (08:59 +1000)]
exp/template: delete upward evaluation.
It was an ill-advised carryover from the previous template package.
Also clean up function evaluation.
Also add a Name method to Template.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/
4657088
Rob Pike [Fri, 8 Jul 2011 08:25:46 +0000 (18:25 +1000)]
exp/template: forgot to allow . as a function argument
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4671053
Rob Pike [Fri, 8 Jul 2011 07:54:16 +0000 (17:54 +1000)]
exp/template: parse variables and declarations
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4631099
Rob Pike [Fri, 8 Jul 2011 07:53:55 +0000 (17:53 +1000)]
exp/template: lex variables
Variables start with'$' and are declared with ':='.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4662084
Rob Pike [Fri, 8 Jul 2011 06:49:06 +0000 (16:49 +1000)]
exp/template: add a tree-walking example to the test.
Also fix a comment formatting glitch.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4672054
Andrew Gerrand [Fri, 8 Jul 2011 06:01:32 +0000 (16:01 +1000)]
exp/template: the must-have MustParse functions
R=r
CC=golang-dev
https://golang.org/cl/
4641096
Rob Pike [Fri, 8 Jul 2011 05:22:05 +0000 (15:22 +1000)]
exp/template: allow fields and methods to be found in parent structs.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
4657085
Andrew Gerrand [Fri, 8 Jul 2011 03:30:49 +0000 (13:30 +1000)]
tag weekly.2011-07-07
R=r
CC=golang-dev
https://golang.org/cl/
4664066
Andrew Gerrand [Fri, 8 Jul 2011 03:13:38 +0000 (13:13 +1000)]
weekly.2011-07-07
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/
4668061
Andrew Gerrand [Fri, 8 Jul 2011 00:52:50 +0000 (10:52 +1000)]
sort: rename helpers: s/Sort// in sort.Sort[Float64s|Ints|Strings]
Includes 'sorthelpers' gofix and updates to tree.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/
4631098
David Symonds [Fri, 8 Jul 2011 00:51:56 +0000 (10:51 +1000)]
gob: export fields in structs in the package documentation.
R=r
CC=golang-dev
https://golang.org/cl/
4648075
Brad Fitzpatrick [Fri, 8 Jul 2011 00:45:28 +0000 (17:45 -0700)]
cgi: don't depend on CGI.pm for tests
CGI.pm used to be part of the Perl core,
but some distros now bundle perl-core
and perl-modules separately.
It's not worth depending on.
R=golang-dev, mattn.jp
CC=golang-dev
https://golang.org/cl/
4675063
Nigel Tao [Thu, 7 Jul 2011 23:54:21 +0000 (09:54 +1000)]
image/draw: add draw tests where the destination image doesn't start
at (0, 0).
Also refactor the test to use the SubImage method rather than monkeying
with an image's Pix and Rect fields.
R=r
CC=golang-dev
https://golang.org/cl/
4678045
Adam Langley [Thu, 7 Jul 2011 22:06:50 +0000 (18:06 -0400)]
crypto/x509: prevent chain cycles in Verify
It's possible to include a self-signed root certificate as an
intermediate and push Verify into a loop.
I already had a test for this so I thought that it was ok, but it
turns out that the test was void because the Verisign root certificate
doesn't contain the "IsCA" flag and so it wasn't an acceptable
intermediate certificate for that reason.
R=bradfitz
CC=golang-dev
https://golang.org/cl/
4657080
Brad Fitzpatrick [Thu, 7 Jul 2011 20:45:13 +0000 (13:45 -0700)]
doc: remove ed from apt-get package list
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/
4672052
Nigel Tao [Thu, 7 Jul 2011 06:32:19 +0000 (16:32 +1000)]
image: tighten Paletted.Opaque to check only those palette entries
in the image, not all palette entries.
R=r
CC=golang-dev
https://golang.org/cl/
4672049
Rob Pike [Thu, 7 Jul 2011 06:05:38 +0000 (16:05 +1000)]
os: fix documentation for FileInfo.Name.
It's the base name, not the full name.
Fixes #2047.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4680041
Rob Pike [Thu, 7 Jul 2011 04:51:35 +0000 (14:51 +1000)]
exp/template: handle pointers and values in empty interfaces.
R=golang-dev, r, mattn.jp
CC=golang-dev
https://golang.org/cl/
4664064
Rob Pike [Thu, 7 Jul 2011 00:56:33 +0000 (10:56 +1000)]
exp/template: change the name from 'metacharacter' to 'delimiter',
because that's what they are.
No semantic change.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
4675060
Gideon Jan-Wessel Redelinghuys [Thu, 7 Jul 2011 00:49:03 +0000 (10:49 +1000)]
crypto/openpgp: fixed dangerous use of for loop variable
In function readSignedMessage a pointer to for loop variable 'key' was incorrectly being assigned
to md.SignedBy. Changed so that md.SignedBy is pointing to the 'more correct' memory position.
R=golang-dev, r, agl
CC=golang-dev
https://golang.org/cl/
4631088
Rob Pike [Thu, 7 Jul 2011 00:46:54 +0000 (10:46 +1000)]
C+A: Gideon Jan-Wessel Redelinghuys
R=golang-dev, dsymonds
CC=gjredelinghuys, golang-dev
https://golang.org/cl/
4675059
Alex Brainman [Thu, 7 Jul 2011 00:40:45 +0000 (10:40 +1000)]
syscall: rearrange windows code so 386 and amd64 can share files
R=golang-dev, r
CC=golang-dev, vcc.163
https://golang.org/cl/
4641093
Rob Pike [Thu, 7 Jul 2011 00:35:37 +0000 (10:35 +1000)]
CONTRIBUTORS: add Google contributor mpvl@golang.org
R=golang-dev, dsymonds
CC=golang-dev, mpvl
https://golang.org/cl/
4643075
Rob Pike [Wed, 6 Jul 2011 21:00:48 +0000 (07:00 +1000)]
exp/template: index: forgot the always last-to-arrive uintptr.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/
4636087
Adam Langley [Wed, 6 Jul 2011 20:25:44 +0000 (16:25 -0400)]
asn1: support T61 and UTF8 string.
There is no end to the kitchen sink of string types in ASN.1.
Fixes #1953.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/
4672045