]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agotesting: use runtime/debug to format panics
Russ Cox [Mon, 13 Feb 2012 04:39:40 +0000 (23:39 -0500)]
testing: use runtime/debug to format panics

Among other things, this avoids putting a testing.go:nnn:
prefix on every line of the stack trace.

R=golang-dev, r, dsymonds, r
CC=golang-dev
https://golang.org/cl/5651081

13 years agoruntime: delete Type and implementations (use reflect instead)
Russ Cox [Mon, 13 Feb 2012 04:26:20 +0000 (23:26 -0500)]
runtime: delete Type and implementations (use reflect instead)
unsafe: delete Typeof, Reflect, Unreflect, New, NewArray

Part of issue 2955 and issue 2968.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5650069

13 years agonet: avoid TCP self-connect
Russ Cox [Mon, 13 Feb 2012 04:25:55 +0000 (23:25 -0500)]
net: avoid TCP self-connect

Fixes #2690.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5650071

13 years agostrconv: add tests for issue 2917
Russ Cox [Mon, 13 Feb 2012 04:24:54 +0000 (23:24 -0500)]
strconv: add tests for issue 2917

Cannot reproduce the failure locally,
but add explicit test in case some other
machine can.

Fixes #2917 (for now).

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5651071

13 years agonet/http/pprof: link to blog post
Rob Pike [Mon, 13 Feb 2012 04:24:06 +0000 (15:24 +1100)]
net/http/pprof: link to blog post

Fixes #2943.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5649079

13 years agonet/http: fix http_proxy parsing
Russ Cox [Mon, 13 Feb 2012 04:19:50 +0000 (23:19 -0500)]
net/http: fix http_proxy parsing

Fixes #2919.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5645089

13 years agocmd/go: respect test -timeout flag
Russ Cox [Mon, 13 Feb 2012 04:19:24 +0000 (23:19 -0500)]
cmd/go: respect test -timeout flag

I thought that -timeout was per-test, but it is for the
whole program execution, so cmd/go can adjust its timer
(also for whole program execution) accordingly.

Fixes #2993.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5650070

13 years agocmd/dist: encoding/gob is no longer required for cmd/go
Russ Cox [Mon, 13 Feb 2012 04:15:07 +0000 (23:15 -0500)]
cmd/dist: encoding/gob is no longer required for cmd/go

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5650068

13 years agonet/http: document use of DetectContentType
Russ Cox [Mon, 13 Feb 2012 04:14:48 +0000 (23:14 -0500)]
net/http: document use of DetectContentType

Fixes #2365.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5653070

13 years agobuild: reject make.bash on Windows
Russ Cox [Mon, 13 Feb 2012 04:14:37 +0000 (23:14 -0500)]
build: reject make.bash on Windows

Also, echo cmd/dist during bootstrap build
Makes that phase look like all the others.

Fixes #2908.

R=golang-dev, alex.brainman, bradfitz
CC=golang-dev
https://golang.org/cl/5655065

13 years agogo spec: method names must be unique
Robert Griesemer [Mon, 13 Feb 2012 04:03:30 +0000 (20:03 -0800)]
go spec: method names must be unique

Fixes #2916.

R=golang-dev, remyoudompheng, r, rsc
CC=golang-dev
https://golang.org/cl/5652064

13 years agonet: disable wild use of SO_REUSEPORT on BSD variants
Mikio Hara [Mon, 13 Feb 2012 03:45:59 +0000 (12:45 +0900)]
net: disable wild use of SO_REUSEPORT on BSD variants

Fixes #2830 (again).

R=rsc
CC=golang-dev
https://golang.org/cl/5651083

13 years agospec: typographical adjustment for ellipsis
Rob Pike [Mon, 13 Feb 2012 03:38:31 +0000 (14:38 +1100)]
spec: typographical adjustment for ellipsis
The paragraph describing the ellipses presents the horizontal ellipsis
in two different fonts and at least on my screen they look too different.
Switch to a consistent rendering.

Of small steps are great journeys undertaken.

R=golang-dev, rsc, dsymonds, gri
CC=golang-dev
https://golang.org/cl/5650055

13 years agogodoc: static ids should be #lowercase
Rob Pike [Mon, 13 Feb 2012 03:34:30 +0000 (14:34 +1100)]
godoc: static ids should be #lowercase
so they don't collide with names like #Index.
Fixes #2970.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5655066

13 years agobuilder: really set $GOBUILDEXIT for Windows
Alex Brainman [Mon, 13 Feb 2012 03:32:45 +0000 (14:32 +1100)]
builder: really set $GOBUILDEXIT for Windows

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5649074

13 years agoos: clarify docs for link functions
Gustavo Niemeyer [Mon, 13 Feb 2012 03:21:39 +0000 (01:21 -0200)]
os: clarify docs for link functions

R=golang-dev, bsiegert, r
CC=golang-dev
https://golang.org/cl/5643068

13 years agostrings: more examples
Brad Fitzpatrick [Mon, 13 Feb 2012 03:05:57 +0000 (14:05 +1100)]
strings: more examples

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5645092

13 years agogo1: fix old reference to Sys method
Rob Pike [Sun, 12 Feb 2012 21:05:53 +0000 (08:05 +1100)]
go1: fix old reference to Sys method
The example was fixed; the simplifying rewrite was missed.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5651080

13 years agopprof: fix import path in the documentation
Yves Junqueira [Sun, 12 Feb 2012 14:38:51 +0000 (12:38 -0200)]
pprof: fix import path in the documentation

R=golang-dev, n13m3y3r
CC=golang-dev
https://golang.org/cl/5649072

13 years agonet: fix windows build
Mikio Hara [Sun, 12 Feb 2012 06:59:21 +0000 (15:59 +0900)]
net: fix windows build

R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5653066

13 years agobuild: get rid of deps.bash
Anthony Martin [Sun, 12 Feb 2012 04:02:50 +0000 (20:02 -0800)]
build: get rid of deps.bash

It doesn't work anymore and it's not used.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5652073

13 years agohtml/template: Added more explicit wording about examples and documentation.
Bjorn Tipling [Sun, 12 Feb 2012 01:18:00 +0000 (12:18 +1100)]
html/template: Added more explicit wording about examples and documentation.

R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5654062

13 years agogo1: update recipe for recovering Stat_t
Rob Pike [Sat, 11 Feb 2012 22:17:57 +0000 (09:17 +1100)]
go1: update recipe for recovering Stat_t

Fixes #2983.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5654063

13 years agoeffective_go: use new map deletion syntax
Rob Pike [Sat, 11 Feb 2012 22:11:44 +0000 (09:11 +1100)]
effective_go: use new map deletion syntax

Fixes #2984.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5652071

13 years agounsafe: Alignof and Offsetof now use the same style
Rob Pike [Sat, 11 Feb 2012 22:10:47 +0000 (09:10 +1100)]
unsafe: Alignof and Offsetof now use the same style

The easy part of issue 2968.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5655059

13 years agogc: diagnose field+method of same name
Russ Cox [Sat, 11 Feb 2012 06:21:12 +0000 (01:21 -0500)]
gc: diagnose field+method of same name

Fixes #2828.

R=ken2
CC=golang-dev
https://golang.org/cl/5653065

13 years agogc: print detail for typechecking loop error
Russ Cox [Sat, 11 Feb 2012 06:04:33 +0000 (01:04 -0500)]
gc: print detail for typechecking loop error

R=ken2
CC=golang-dev
https://golang.org/cl/5654060

13 years agogc: fix bug introduced earlier
Russ Cox [Sat, 11 Feb 2012 06:04:24 +0000 (01:04 -0500)]
gc: fix bug introduced earlier

Apparently l and $1 were the same register on Linux.
On the other systems, the compiler caught it.

R=ken2
CC=golang-dev
https://golang.org/cl/5654061

13 years agogc: make constant arith errors a little more friendly
Russ Cox [Sat, 11 Feb 2012 05:50:56 +0000 (00:50 -0500)]
gc: make constant arith errors a little more friendly

Fixes #2804.

R=ken2
CC=golang-dev
https://golang.org/cl/5652067

13 years agogofmt: fix error message in test
Robert Griesemer [Sat, 11 Feb 2012 05:47:18 +0000 (21:47 -0800)]
gofmt: fix error message in test

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5652066

13 years agogc: fix import of struct type in struct literal
Russ Cox [Sat, 11 Feb 2012 05:34:01 +0000 (00:34 -0500)]
gc: fix import of struct type in struct literal

Fixes #2716.

R=ken2
CC=golang-dev
https://golang.org/cl/5652065

13 years agoruntime: put lockorder before pollorder in Select memory block.
Ian Lance Taylor [Sat, 11 Feb 2012 05:24:14 +0000 (21:24 -0800)]
runtime: put lockorder before pollorder in Select memory block.

Otherwise lockorder may be misaligned, since lockorder is a
list of pointers and pollorder is a list of uint16.
Discovered running gccgo (which uses a modified copy of this
code) on SPARC.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5655054

13 years agogc: optimize interface ==, !=
Russ Cox [Sat, 11 Feb 2012 05:19:24 +0000 (00:19 -0500)]
gc: optimize interface ==, !=

If the values being compared have different concrete types,
then they're clearly unequal without needing to invoke the
actual interface compare routine.  This speeds tests for
specific values, like if err == io.EOF, by about 3x.

benchmark                  old ns/op    new ns/op    delta
BenchmarkIfaceCmp100             843          287  -65.95%
BenchmarkIfaceCmpNil100          184          182   -1.09%

Fixes #2591.

R=ken2
CC=golang-dev
https://golang.org/cl/5651073

13 years ago5g: fix out of registers bug
Russ Cox [Sat, 11 Feb 2012 05:04:37 +0000 (00:04 -0500)]
5g: fix out of registers bug

Same fix as 6g, tripped by the 6g test case.

R=ken2
CC=golang-dev
https://golang.org/cl/5651074

13 years agocmd/dist: clear execute bit from source file
Mikio Hara [Sat, 11 Feb 2012 04:23:44 +0000 (13:23 +0900)]
cmd/dist: clear execute bit from source file

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5651072

13 years agogc: add test case for issue 1743
Russ Cox [Sat, 11 Feb 2012 04:20:00 +0000 (23:20 -0500)]
gc: add test case for issue 1743

Fixes #1743.
(Actually was fixed earlier, but now we have proof.)

R=ken2
CC=golang-dev
https://golang.org/cl/5649064

13 years agogc: diagnose init loop involving func
Russ Cox [Sat, 11 Feb 2012 04:10:45 +0000 (23:10 -0500)]
gc: diagnose init loop involving func

Fixes #2295.

R=ken2
CC=golang-dev
https://golang.org/cl/5655057

13 years agogc: eliminate duplicate ambiguous selector message
Russ Cox [Sat, 11 Feb 2012 03:46:56 +0000 (22:46 -0500)]
gc: eliminate duplicate ambiguous selector message

Also show actual expression in message when possible.

Fixes #2599.

R=ken2
CC=golang-dev
https://golang.org/cl/5654059

13 years ago8g: fix opt bug
Russ Cox [Sat, 11 Feb 2012 03:32:02 +0000 (22:32 -0500)]
8g: fix opt bug

Was trying to optimize a duplicate float64 move
by registerizing an int64.

Fixes #2588.

R=ken2
CC=golang-dev
https://golang.org/cl/5645086

13 years agotext/template/parse: deep Copy method for nodes
Rob Pike [Sat, 11 Feb 2012 03:21:16 +0000 (14:21 +1100)]
text/template/parse: deep Copy method for nodes
This will help html/template copy templates.

R=golang-dev, gri, nigeltao, r
CC=golang-dev
https://golang.org/cl/5653062

13 years ago6g: fix out of registers bug
Russ Cox [Sat, 11 Feb 2012 03:19:34 +0000 (22:19 -0500)]
6g: fix out of registers bug

Fix it twice: reuse registers more aggressively in cgen abop,
and also release R14 and R15, which are no longer m and g.

Fixes #2669.

R=ken2
CC=golang-dev
https://golang.org/cl/5655056

13 years agonet: fix comment, make use of listenerBacklog
Mikio Hara [Sat, 11 Feb 2012 02:51:12 +0000 (11:51 +0900)]
net: fix comment, make use of listenerBacklog

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5653056

13 years agonet: enable SO_REUSEADDR, SO_REUSEPORT options on stream, multicast listeners only
Mikio Hara [Sat, 11 Feb 2012 02:50:51 +0000 (11:50 +0900)]
net: enable SO_REUSEADDR, SO_REUSEPORT options on stream, multicast listeners only

This CL changes default SOL_SOCKET settings to mitigate connect
failure on OpenBSD or similar platforms which support randomized
transport protocol port number assignment.

Fixes #2830.

R=rsc, jsing
CC=golang-dev
https://golang.org/cl/5648044

13 years agofix build: update image/png test
Robert Griesemer [Sat, 11 Feb 2012 01:26:40 +0000 (17:26 -0800)]
fix build: update image/png test

R=nigeltao
CC=golang-dev
https://golang.org/cl/5649062

13 years agoflate: delete WrongValueError type.
Nigel Tao [Sat, 11 Feb 2012 01:09:11 +0000 (12:09 +1100)]
flate: delete WrongValueError type.

Fixes #2838.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5651060

13 years agonet/http: fix reference to URL.RawPath in docs
Bjorn Tipling [Sat, 11 Feb 2012 00:39:57 +0000 (22:39 -0200)]
net/http: fix reference to URL.RawPath in docs

R=go.peter.90, n13m3y3r, gustavo
CC=golang-dev
https://golang.org/cl/5655053

13 years agoCONTRIBUTORS: add Bjorn Tipling <bjorn.tipling@gmail.com>
Gustavo Niemeyer [Sat, 11 Feb 2012 00:35:42 +0000 (22:35 -0200)]
CONTRIBUTORS: add Bjorn Tipling <bjorn.tipling@gmail.com>

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5645085

13 years agocmd/dist: reset version during bootstrap
Gustavo Niemeyer [Sat, 11 Feb 2012 00:26:36 +0000 (22:26 -0200)]
cmd/dist: reset version during bootstrap

Fixes #2927.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5651062

13 years agocompress: add comments to gzip and zlib.
Nigel Tao [Fri, 10 Feb 2012 22:42:07 +0000 (09:42 +1100)]
compress: add comments to gzip and zlib.

Fixes #2939.

R=rsc, r
CC=golang-dev
https://golang.org/cl/5655050

13 years agocmd/gc: suspend safemode during typecheck of inlined bodies.
Luuk van Dijk [Fri, 10 Feb 2012 21:50:55 +0000 (22:50 +0100)]
cmd/gc: suspend safemode during typecheck of inlined bodies.

Should be obviously correct.  Includes minimal test case.
A future CL should clear up the logic around typecheckok and importpkg != nil someday.

R=rsc, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/5652057

13 years agoos,syscall: fix windows build
Brad Fitzpatrick [Fri, 10 Feb 2012 21:47:19 +0000 (08:47 +1100)]
os,syscall: fix windows build

make syscall.ProcAttr.Files be []uintptr

all.bash passes on Linux.
things seem to compile on GOOS={darwin,windows}

R=golang-dev, mattn.jp, alex.brainman, rsc
CC=golang-dev
https://golang.org/cl/5653055

13 years agoexp/types: Use build.FindTree in GcImporter
James Whitehead [Fri, 10 Feb 2012 21:35:03 +0000 (13:35 -0800)]
exp/types: Use build.FindTree in GcImporter

Fixes #2932

R=gri
CC=golang-dev
https://golang.org/cl/5654046

13 years agogo/printer: test that formatted code is parseable
Robert Griesemer [Fri, 10 Feb 2012 21:28:29 +0000 (13:28 -0800)]
go/printer: test that formatted code is parseable

- Added test case for issue 1542.

Fixes #1542.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5645080

13 years agogo/printer: implement SourcePos mode
Robert Griesemer [Fri, 10 Feb 2012 21:27:32 +0000 (13:27 -0800)]
go/printer: implement SourcePos mode

If a printer is configured with the SourcePos mode
set, it will emit //-line comments as necessary to
ensure that the result - if reparsed - reflects the
original source position information.

This change required a bit of reworking of the
output section in printer.go. Specifically:

- Introduced new Config mode 'SourcePos'.

- Introduced new position 'out' which tracks the
position of the generated output if it were read
in again. If there is a discrepancy between out
and the current AST/source position, a //line
comment is emitted to correct for it.

- Lazy emission of indentation so that //line
comments can be placed correctly. As a result,
the trimmer will have to do less work.

- Merged writeItem into writeString.

- Merged writeByteN into writeByte.

- Use a []byte instead of a byte.Buffer both in the
printer and in the trimmer (eliminates dependency).

Also: introduced explicit printer.Mode type (in
sync w/ parser.Mode, scanner.Mode, etc.)

Runs all tests. Applied gofmt to src, misc w/o changes.

Fixes #1047.
Fixes #2697.

R=rsc, rsc
CC=golang-dev
https://golang.org/cl/5643066

13 years agocompress: make flate, gzip and zlib's NewWriterXxx functions all return
Nigel Tao [Fri, 10 Feb 2012 07:49:19 +0000 (18:49 +1100)]
compress: make flate, gzip and zlib's NewWriterXxx functions all return
(*Writer, error) if they take a compression level, and *Writer otherwise.
Rename gzip's Compressor and Decompressor to Writer and Reader, similar to
flate and zlib.

Clarify commentary when writing gzip metadata that is not representable
as Latin-1, and fix io.EOF comment bug.

Also refactor gzip_test to be more straightforward.

Fixes #2839.

R=rsc, r, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5639057

13 years agobuilder: set $GOBUILDEXIT for Windows
Russ Cox [Fri, 10 Feb 2012 06:27:59 +0000 (01:27 -0500)]
builder: set $GOBUILDEXIT for Windows

Actually %GOBUILDEXIT% I suppose.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5651058

13 years agoregexp/syntax: delete old package comment
Russ Cox [Fri, 10 Feb 2012 06:11:56 +0000 (01:11 -0500)]
regexp/syntax: delete old package comment

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5651057

13 years agoall.bat: report error code back to the gobuilder
Alex Brainman [Fri, 10 Feb 2012 05:29:50 +0000 (16:29 +1100)]
all.bat: report error code back to the gobuilder

not sure that it will work, but.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5649051

13 years agodebug/macho: dropped monstrous URL from package comment
Andrew Gerrand [Fri, 10 Feb 2012 05:03:24 +0000 (16:03 +1100)]
debug/macho: dropped monstrous URL from package comment

Relax. It's still in macho.go.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5653054

13 years agoregexp/syntax: add package and Parse commentary
Rob Pike [Fri, 10 Feb 2012 04:57:12 +0000 (15:57 +1100)]
regexp/syntax: add package and Parse commentary

Fixes #2954.

R=golang-dev, bradfitz, rsc, r
CC=golang-dev
https://golang.org/cl/5645077

13 years agomath: fix gamma doc, link to OEIS
Rob Pike [Fri, 10 Feb 2012 04:56:51 +0000 (15:56 +1100)]
math: fix gamma doc, link to OEIS

Fixes #2940.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5645078

13 years agodashboard: add gobuilder -fail mode
Russ Cox [Fri, 10 Feb 2012 04:46:48 +0000 (23:46 -0500)]
dashboard: add gobuilder -fail mode

This is for filling a column with "fail", like I just did for
Windows, when the builder would get stuck running that
build.  (We have safeguards against the tests getting stuck
but this was the bootstrap build getting stuck.)

I usually use -cmd=/bin/false, but this avoids the Mercurial
checkouts, which means it runs instantly instead of requiring
~1 minute per "fail".

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5649049

13 years agodist: prevent recusive loop on windows when fatal() is called.
Daniel Theophanes [Fri, 10 Feb 2012 04:10:27 +0000 (23:10 -0500)]
dist: prevent recusive loop on windows when fatal() is called.

Fixes #2931.

R=golang-dev, alex.brainman
CC=golang-dev, rsc
https://golang.org/cl/5651049

13 years agoreflect: documentation tweaks
Rob Pike [Fri, 10 Feb 2012 04:09:09 +0000 (15:09 +1100)]
reflect: documentation tweaks

Fixes #2952.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5651054

13 years agoos/exec: add Cmd.Waitmsg, fix a misleading comment
Brad Fitzpatrick [Fri, 10 Feb 2012 03:52:08 +0000 (14:52 +1100)]
os/exec: add Cmd.Waitmsg, fix a misleading comment

Fixes #2948

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5655048

13 years agostrings: delete method comments implied by interface satisfaction
Rob Pike [Fri, 10 Feb 2012 03:45:11 +0000 (14:45 +1100)]
strings: delete method comments implied by interface satisfaction

Fixes #2957.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5653053

13 years agotesting/quick: documentation tweaks
Rob Pike [Fri, 10 Feb 2012 03:37:50 +0000 (14:37 +1100)]
testing/quick: documentation tweaks

Fixes #2960.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5652055

13 years agotesting/iotest: adjust adverbial imprecision in package comment
Rob Pike [Fri, 10 Feb 2012 03:37:20 +0000 (14:37 +1100)]
testing/iotest: adjust adverbial imprecision in package comment

Fixes #2959.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5651053

13 years agotesting/script: delete
Rob Pike [Fri, 10 Feb 2012 03:31:08 +0000 (14:31 +1100)]
testing/script: delete
Dead code.

Fixes #2961.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5650053

13 years agounicode: various documentation tweaks
Rob Pike [Fri, 10 Feb 2012 03:30:44 +0000 (14:30 +1100)]
unicode: various documentation tweaks

The comment on IsOneOf regarding Latin-1 was an implementation detail:
when the function is called internally, that condition is true. It used to matter,
but now the comment is a dreg. The function works fine if the character is
Latin-1, so we just delete the comment.

Fixes #2966.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5655047

13 years agotemplate: refer HTML users to html/template
Rob Pike [Fri, 10 Feb 2012 03:21:36 +0000 (14:21 +1100)]
template: refer HTML users to html/template

Fixes #2963.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5650051

13 years agoos: delete Exec, NewFile takes uintptr, rename ShellExpand, doc fixes
Brad Fitzpatrick [Fri, 10 Feb 2012 03:16:15 +0000 (14:16 +1100)]
os: delete Exec, NewFile takes uintptr, rename ShellExpand, doc fixes

Delete O_NDELAY, O_NONBLOCK, O_NOCTTY, O_ASYNC.

Clean up some docs.

Rename ShellExpand -> ExpandEnv.

Make NewFile take a uintptr; change File.Fd to return one.
(for API compatibility between Unix and Windows)

Fixes #2947

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5655045

13 years agounicode/utf8: document return value for decode errors
Rob Pike [Fri, 10 Feb 2012 03:12:17 +0000 (14:12 +1100)]
unicode/utf8: document return value for decode errors
Also replace archaic definition of rune.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5654048

13 years agotime: improve commentary about standard time and formatting/parsing
Rob Pike [Fri, 10 Feb 2012 02:52:19 +0000 (13:52 +1100)]
time: improve commentary about standard time and formatting/parsing

Fixes #2965.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5652054

13 years agotesting: fix references to "gotest"
Rob Pike [Fri, 10 Feb 2012 02:49:50 +0000 (13:49 +1100)]
testing: fix references to "gotest"

Fixes #2958.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5650050

13 years agomake.bat: remove double quotes
Alex Brainman [Fri, 10 Feb 2012 00:48:22 +0000 (11:48 +1100)]
make.bat: remove double quotes

Fixes #2974.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5653052

13 years agoos: remove Time; callers should use time.Time.
Brad Fitzpatrick [Fri, 10 Feb 2012 00:44:51 +0000 (11:44 +1100)]
os: remove Time; callers should use time.Time.

Part of issue 2947

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5651051

13 years agonet/http/fcgi: don't mention threads in docs
Brad Fitzpatrick [Thu, 9 Feb 2012 23:29:57 +0000 (10:29 +1100)]
net/http/fcgi: don't mention threads in docs

Fixes #2942

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5650049

13 years agotext/scanner: update comments
Robert Griesemer [Thu, 9 Feb 2012 23:26:08 +0000 (15:26 -0800)]
text/scanner: update comments

Fixes #2962.

R=rsc
CC=golang-dev
https://golang.org/cl/5652048

13 years agoregexp: name result parameters referenced from docs
Brad Fitzpatrick [Thu, 9 Feb 2012 23:22:01 +0000 (10:22 +1100)]
regexp: name result parameters referenced from docs

Fixes #2953

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5653051

13 years agodatabase/sql: remove Into from ScannerInto/ScanInto
Brad Fitzpatrick [Thu, 9 Feb 2012 23:20:49 +0000 (10:20 +1100)]
database/sql: remove Into from ScannerInto/ScanInto

Also fix a doc error.

Fixes #2843

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/5653050

13 years agocontainer/heap: add example
Rob Pike [Thu, 9 Feb 2012 23:07:55 +0000 (10:07 +1100)]
container/heap: add example
godoc doesn't have the fu to present the example well, but this gives
us an example of an example to develop example fu.

Fixes #2840.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5645063

13 years agocmd/api: follow constant references
Brad Fitzpatrick [Thu, 9 Feb 2012 23:05:26 +0000 (10:05 +1100)]
cmd/api: follow constant references

For gccgo. Also removes bunch of special cases.

Fixes #2906

R=golang-dev, remyoudompheng
CC=golang-dev
https://golang.org/cl/5644050

13 years agonet/http: add ServeContent
Brad Fitzpatrick [Thu, 9 Feb 2012 23:02:06 +0000 (10:02 +1100)]
net/http: add ServeContent

Fixes #2039

R=r, rsc, n13m3y3r, r, rogpeppe
CC=golang-dev
https://golang.org/cl/5643067

13 years agoencoding/binary: another attempt to describe the type of Read and Write's data
Rob Pike [Thu, 9 Feb 2012 22:55:48 +0000 (09:55 +1100)]
encoding/binary: another attempt to describe the type of Read and Write's data

R=golang-dev, rsc, gri, r
CC=golang-dev
https://golang.org/cl/5641062

13 years agocmd/dist: fix GOROOT_FINAL
Gustavo Niemeyer [Thu, 9 Feb 2012 22:47:12 +0000 (20:47 -0200)]
cmd/dist: fix GOROOT_FINAL

R=rsc, gustavo
CC=golang-dev
https://golang.org/cl/5642045

13 years agoencoding/hex: vet the test prints
Rob Pike [Thu, 9 Feb 2012 22:44:56 +0000 (09:44 +1100)]
encoding/hex: vet the test prints

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5642075

13 years agocompress/gzip: remove dead code
Alex Brainman [Thu, 9 Feb 2012 22:33:51 +0000 (09:33 +1100)]
compress/gzip: remove dead code

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5645074

13 years agodatabase/sql: support ErrSkip in Tx.Exec
Andrew Balholm [Thu, 9 Feb 2012 22:19:22 +0000 (09:19 +1100)]
database/sql: support ErrSkip in Tx.Exec

If the database driver supports the Execer interface but returns
ErrSkip, calling Exec on a transaction was returning the error instead
of using the slow path.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5654044

13 years agocmd/dist: do not use HEAP_GENERATE_EXCEPTIONS flag
Alex Brainman [Thu, 9 Feb 2012 22:14:00 +0000 (09:14 +1100)]
cmd/dist: do not use HEAP_GENERATE_EXCEPTIONS flag

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5650048

13 years agodatabase/sql: rename ErrTransactionFinished to ErrTxDone
Brad Fitzpatrick [Thu, 9 Feb 2012 22:12:32 +0000 (09:12 +1100)]
database/sql: rename ErrTransactionFinished to ErrTxDone

Part of issue 2843

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5646063

13 years agoruntime: Linux/ARM: exit early on OABI systems, and give an error message
Shenghou Ma [Thu, 9 Feb 2012 21:18:21 +0000 (16:18 -0500)]
runtime: Linux/ARM: exit early on OABI systems, and give an error message
Fixes #2533.

R=rsc
CC=golang-dev
https://golang.org/cl/5654045

13 years agostrings: add Seek method to Reader
Brad Fitzpatrick [Thu, 9 Feb 2012 06:28:41 +0000 (17:28 +1100)]
strings: add Seek method to Reader

strings.Reader is already stateful and read-only.

This permits a *Reader with http.ServeContent.

R=golang-dev, r, rsc, rsc
CC=golang-dev
https://golang.org/cl/5639068

13 years agoos: talk about errors and PathError in the package documentation
Rob Pike [Thu, 9 Feb 2012 05:55:36 +0000 (16:55 +1100)]
os: talk about errors and PathError in the package documentation

Fixes #2383.

R=golang-dev, bradfitz, adg, rsc
CC=golang-dev
https://golang.org/cl/5641061

13 years agoruntime: fix compiler warnings
Russ Cox [Thu, 9 Feb 2012 05:48:52 +0000 (16:48 +1100)]
runtime: fix compiler warnings

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5642068

13 years agonet/http/httptest: add a test
Brad Fitzpatrick [Thu, 9 Feb 2012 05:45:24 +0000 (16:45 +1100)]
net/http/httptest: add a test

Less ironic. Don't you think?

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5643069

13 years agogc: implicit type bug fix in export data
Russ Cox [Thu, 9 Feb 2012 05:26:08 +0000 (00:26 -0500)]
gc: implicit type bug fix in export data

TBR=lvd
CC=golang-dev
https://golang.org/cl/5644064

13 years agodatabase/sql: more tests
Brad Fitzpatrick [Thu, 9 Feb 2012 04:01:29 +0000 (15:01 +1100)]
database/sql: more tests

Higher level tests for the pointer parameters
and scanning, complementing the existing ones
included in the previous CL.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5646050

13 years agogobuilder: fix windows builder
Alex Brainman [Thu, 9 Feb 2012 03:52:01 +0000 (14:52 +1100)]
gobuilder: fix windows builder

Do not rewrite commands if they have .bash extnsion.
Use path/filepath to manipulate file paths everywhere.
Use all.bat on windows, not all.bash.
Use HOMEDRIVE/HOMEPATH to find .gobuildkey on windows.

R=rsc
CC=golang-dev
https://golang.org/cl/5630062

13 years agolog/syslog: fix documentation for NewLogger
Rob Pike [Thu, 9 Feb 2012 03:40:56 +0000 (14:40 +1100)]
log/syslog: fix documentation for NewLogger
Fixes #2798.

R=golang-dev, bradfitz, r, rsc, rsc
CC=golang-dev
https://golang.org/cl/5642071