]> Cypherpunks repositories - gostls13.git/log
gostls13.git
13 years agoruntime: use HOST_CC to compile mkversion
Dave Cheney [Tue, 31 May 2011 17:46:11 +0000 (10:46 -0700)]
runtime: use HOST_CC to compile mkversion

HOST_CC is set in Make.inc, so use that rather
than hardcoding quietgcc

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4515163

13 years agogc: check parameter declarations in interface fields
Anthony Martin [Tue, 31 May 2011 17:41:32 +0000 (13:41 -0400)]
gc: check parameter declarations in interface fields

Fixes #1663.
Fixes #1871.

R=rsc, lstoakes
CC=golang-dev
https://golang.org/cl/4530084

13 years agoencoding/hex: add hex dumping.
Adam Langley [Tue, 31 May 2011 16:58:09 +0000 (12:58 -0400)]
encoding/hex: add hex dumping.

I found this useful, esp with an io.MultiWriter. But I fear that
it may be bloat in such a low-level package so please feel free to
decline if you feel likewise.

R=rsc, ality
CC=golang-dev
https://golang.org/cl/4530088

13 years agohttp: have client set Content-Length when possible
Brad Fitzpatrick [Tue, 31 May 2011 15:47:03 +0000 (08:47 -0700)]
http: have client set Content-Length when possible

Also some cleanup, removing redundant code. Make more
things use NewRequest. Add some tests, docs.

R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/4561047

13 years agonet: name-based destination address selection
Christopher Wedgwood [Tue, 31 May 2011 15:40:11 +0000 (11:40 -0400)]
net: name-based destination address selection

getaddrinfo() orders the addresses according to RFC 3484.

This means when IPv6 is working on a host we get results like:
    []string = {"2001:4810::110", "66.117.47.214"}

and when it's not working we get:
    []string = {"66.117.47.214", "2001:4810::110"}

thus can drop firstFavoriteAddr.

This also means /etc/gai.conf works on relevant systems.

R=rsc, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/4557058

13 years agoruntime: reset GOMAXPROCS during tests
Dmitriy Vyukov [Tue, 31 May 2011 14:38:51 +0000 (10:38 -0400)]
runtime: reset GOMAXPROCS during tests

Fix the fact that the test leaves GOMAXPROCS=3
and a running goroutine behind.

R=golang-dev, rsc
CC=dvyukov, golang-dev
https://golang.org/cl/4517121

13 years agosyscall : add ProcAttr field to pass an unescaped command line on windows
Vincent Vanackere [Tue, 31 May 2011 14:21:38 +0000 (10:21 -0400)]
syscall : add ProcAttr field to pass an unescaped command line on windows

On windows, the command line is passed as a single null-terminated string. While the automatic parameter escaping done by syscall.StartProcess works fine with most Windows programs, some applications do their own custom parsing of the command line, in which case the automatic escaping becomes harmful.
This CL adds a new extra CmdLine field to syscall.ProcAttr that will be used as the raw/unescaped command line if not empty.
Fixes #1849.

R=golang-dev, alex.brainman, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4548050

13 years agoruntime: save cdecl registers in Windows SEH handler
Alexey Borzenkov [Tue, 31 May 2011 14:11:47 +0000 (10:11 -0400)]
runtime: save cdecl registers in Windows SEH handler

Fixes #1779

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4566041

13 years agofilepath: Abs must always return a clean path
Gustavo Niemeyer [Tue, 31 May 2011 01:28:59 +0000 (22:28 -0300)]
filepath: Abs must always return a clean path

When I was first coding Abs, I wondered if people wouldn't
expect the path to be consistently clean, even if the path
passed in was already absolute.

CL 4524078 has a potential problem based on exactly that
assumption, so it feels like this behavior is indeed the
most useful and least surprising.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548074

13 years agounicode: make the tables smaller.
Rob Pike [Mon, 30 May 2011 23:58:07 +0000 (09:58 +1000)]
unicode: make the tables smaller.
By splitting the ranges into 16-bit values and 32-bit values,
we can reduce about 3000 entries by 48 bits per entry, or about
16KB, at the cost of a little more complexity in the code.

R=iant, bradfitz, rsc, r
CC=golang-dev
https://golang.org/cl/4547066

13 years agogoinstall: skip standard packages
Russ Cox [Mon, 30 May 2011 22:23:16 +0000 (18:23 -0400)]
goinstall: skip standard packages

R=adg, n13m3y3r
CC=golang-dev
https://golang.org/cl/4526084

13 years agotemplate: fix and clean interaction between quotes and formatters
Gustavo Niemeyer [Mon, 30 May 2011 14:53:09 +0000 (11:53 -0300)]
template: fix and clean interaction between quotes and formatters

Fixes issue #1897.

R=r, gustavo, r
CC=golang-dev
https://golang.org/cl/4561049

13 years agogobuilder: remove some windows-specificity
Andrew Gerrand [Mon, 30 May 2011 10:19:56 +0000 (20:19 +1000)]
gobuilder: remove some windows-specificity

R=alex.brainman
CC=golang-dev
https://golang.org/cl/4528109

13 years agopkg: spelling tweaks, I-Z
Robert Hencke [Mon, 30 May 2011 08:02:59 +0000 (18:02 +1000)]
pkg: spelling tweaks, I-Z

also, a few miscellaneous fixes to files outside pkg

R=golang-dev, dsymonds, mikioh.mikioh, r
CC=golang-dev
https://golang.org/cl/4517116

13 years agogoinstall: use bash to execute gomake
Alex Brainman [Mon, 30 May 2011 06:15:08 +0000 (16:15 +1000)]
goinstall: use bash to execute gomake

R=golang-dev, r, adg
CC=golang-dev
https://golang.org/cl/4551074

13 years agosrc: Make.pkg don't create $(TARGDIR) with goinstall.
Yasuhiro Matsumoto [Mon, 30 May 2011 02:35:55 +0000 (12:35 +1000)]
src: Make.pkg don't create $(TARGDIR) with goinstall.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4548071

13 years agomisc/vim: limit Fmt command to Go buffers.
Yasuhiro Matsumoto [Mon, 30 May 2011 02:20:00 +0000 (12:20 +1000)]
misc/vim: limit Fmt command to Go buffers.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4548072

13 years agodashboard: send notification emails when the build breaks
Andrew Gerrand [Mon, 30 May 2011 01:27:31 +0000 (11:27 +1000)]
dashboard: send notification emails when the build breaks

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4530061

13 years agogobuilder: fixes for windows
Alex Brainman [Mon, 30 May 2011 01:20:46 +0000 (11:20 +1000)]
gobuilder: fixes for windows

R=r, devon.odell, iant, rsc, adg
CC=bradfitz, golang-dev, jdpoirier
https://golang.org/cl/4536053

13 years agoimage/png: fix encoding of images that don't start at (0, 0).
Nigel Tao [Mon, 30 May 2011 00:55:37 +0000 (10:55 +1000)]
image/png: fix encoding of images that don't start at (0, 0).

R=r
CC=golang-dev
https://golang.org/cl/4560049

13 years agogob: fix documentation on Decoder.Decode.
David Symonds [Mon, 30 May 2011 00:48:08 +0000 (10:48 +1000)]
gob: fix documentation on Decoder.Decode.

R=r, adg
CC=golang-dev
https://golang.org/cl/4515159

13 years agohttp: let Transport use a custom net.Dial function
Brad Fitzpatrick [Sun, 29 May 2011 16:32:36 +0000 (09:32 -0700)]
http: let Transport use a custom net.Dial function

Permits the use of SOCKS proxy dialer with
the transport.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4536091

13 years agotemplate: cosmetic cleanups.
Rob Pike [Sun, 29 May 2011 06:13:41 +0000 (16:13 +1000)]
template: cosmetic cleanups.
Remove the idea of space being white.  Sometimes space is green.
Simplify a comment and remove the Latin.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4532096

13 years agotemplate: fix quote-handling with formatters
Gustavo Niemeyer [Sun, 29 May 2011 03:23:32 +0000 (00:23 -0300)]
template: fix quote-handling with formatters

Fixes issue #1896.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4539093

13 years agoos: fix os.MkdirAll with backslash path separator.
Yasuhiro Matsumoto [Sun, 29 May 2011 03:03:49 +0000 (13:03 +1000)]
os: fix os.MkdirAll with backslash path separator.
MkdirAll() need to use isSeparator().
Move primary defines of filepath.Separator/filepath.ListSeparator
 to os.PathSeparator/os.PathListSeparator.
Move filepath.isSeparator() to os.IsPathSeparator().
filepath package refer them from os package.
Fixes #1831.

R=rsc, alex.brainman
CC=golang-dev
https://golang.org/cl/4535100

13 years agoos: fix windows version of Readdir(0)
Alex Brainman [Sun, 29 May 2011 01:59:35 +0000 (11:59 +1000)]
os: fix windows version of Readdir(0)

Fixes #1893.

R=golang-dev
CC=bradfitz, golang-dev
https://golang.org/cl/4528106

13 years agogotest, pkg/exec: use bash instead of sh to execute shell scripts on windows
Alex Brainman [Sat, 28 May 2011 11:26:03 +0000 (21:26 +1000)]
gotest, pkg/exec: use bash instead of sh to execute shell scripts on windows

As suggested by dho, iant2.

R=golang-dev, rsc
CC=devon.odell, golang-dev, iant
https://golang.org/cl/4515147

13 years agogo/scanner: don't allow "0x" and "0X" as integers
Evan Shaw [Fri, 27 May 2011 23:47:26 +0000 (16:47 -0700)]
go/scanner: don't allow "0x" and "0X" as integers

R=gri
CC=golang-dev
https://golang.org/cl/4560047

13 years agohttp: client+server benchmark
Brad Fitzpatrick [Fri, 27 May 2011 23:43:02 +0000 (16:43 -0700)]
http: client+server benchmark

baseline runs: (6g, gopher.mtv)

http_test.BenchmarkClientServer  5000  412588 ns/op
http_test.BenchmarkClientServer  5000  403346 ns/op
http_test.BenchmarkClientServer  5000  413936 ns/op
http_test.BenchmarkClientServer  5000  410287 ns/op
http_test.BenchmarkClientServer  5000  388037 ns/op
http_test.BenchmarkClientServer  5000  405545 ns/op
http_test.BenchmarkClientServer  5000  405179 ns/op
http_test.BenchmarkClientServer  5000  413827 ns/op
http_test.BenchmarkClientServer  5000  392723 ns/op

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4515155

13 years agoencoding/binary: add a non-reflect fast path for Write
Brad Fitzpatrick [Fri, 27 May 2011 23:29:33 +0000 (16:29 -0700)]
encoding/binary: add a non-reflect fast path for Write

before/after:
binary.BenchmarkWrite   100000      18312 ns/op
binary.BenchmarkWrite   500000       4468 ns/op

R=rsc, gri
CC=golang-dev
https://golang.org/cl/4515154

13 years agobig: make Int and Rat implement fmt.Scanner
Evan Shaw [Fri, 27 May 2011 22:51:00 +0000 (15:51 -0700)]
big: make Int and Rat implement fmt.Scanner

R=gri
CC=golang-dev
https://golang.org/cl/4552056

13 years agotime: midnight is 12AM.
Rob Pike [Fri, 27 May 2011 21:06:53 +0000 (07:06 +1000)]
time: midnight is 12AM.
This is the other half of the problem fixed at noon by the previous change.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4515150

13 years agoos: yet more Readdir tests and fix earlier regression
Brad Fitzpatrick [Fri, 27 May 2011 19:58:59 +0000 (12:58 -0700)]
os: yet more Readdir tests and fix earlier regression

R=golang-dev, fshahriar
CC=golang-dev
https://golang.org/cl/4548068

13 years agoos: improve Readdir test coverage, fix Readdir(0) on EOF
Brad Fitzpatrick [Fri, 27 May 2011 19:14:48 +0000 (12:14 -0700)]
os: improve Readdir test coverage, fix Readdir(0) on EOF

Adds tests for Readdir and Readdirnames with different n
values.  No good way to inject faults during full reads,
though.

Also fixes bug report from fshahriar:
Readdir(0) wasn't behaving like Readdir(-1).

R=rsc, fshahriar
CC=golang-dev
https://golang.org/cl/4529092

13 years agohttp: propagate Set-Cookie in reverse proxy
Brad Fitzpatrick [Fri, 27 May 2011 18:06:53 +0000 (11:06 -0700)]
http: propagate Set-Cookie in reverse proxy

Also adds Host header tests.

Fixes #1886

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4556063

13 years agohttp/spdy: temporarily disable some failing tests
Brad Fitzpatrick [Fri, 27 May 2011 17:08:31 +0000 (10:08 -0700)]
http/spdy: temporarily disable some failing tests

Issue 1886 has details

R=golang-dev, willchan
CC=golang-dev
https://golang.org/cl/4527083

13 years agotime: fix Format bug: noon is 12PM, not 0PM.
Rob Pike [Fri, 27 May 2011 13:24:39 +0000 (23:24 +1000)]
time: fix Format bug: noon is 12PM, not 0PM.
Fixes #1882.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/4556062

13 years agocgo: restrict #cgo directives to prevent shell expansion
Gustavo Niemeyer [Fri, 27 May 2011 11:46:51 +0000 (08:46 -0300)]
cgo: restrict #cgo directives to prevent shell expansion

Fixes issue #1879.

Directives were not directly expanded, but since their
content ended up in makefiles, further expansion would
take place there.  This prevents such artifacts by
restricting the set of characters that may be used in
a directive value.

To build the list of safe characters I went through the
contents of /usr/lib/pkgconfig and extracted LDFLAGS
and CFLAGS information, so hopefully this is a
reasonable default to get started.

R=rsc
CC=golang-dev
https://golang.org/cl/4532092

13 years agocrypto/tls/generate_cert.go: fix misspelling of O_CREATE.
Rob Pike [Fri, 27 May 2011 11:06:50 +0000 (21:06 +1000)]
crypto/tls/generate_cert.go: fix misspelling of O_CREATE.
Fixes #1888.

R=ken
CC=golang-dev
https://golang.org/cl/4515148

13 years agoos: another attempt to handle OpenFile flag parameter properly on Windows
Alex Brainman [Fri, 27 May 2011 07:02:24 +0000 (17:02 +1000)]
os: another attempt to handle OpenFile flag parameter properly on Windows

Fixes #1791.

R=rsc, r, r, iant
CC=golang-dev
https://golang.org/cl/4551046

13 years agodoc: put Release History link on 'Documentation' page
Andrew Gerrand [Fri, 27 May 2011 06:07:30 +0000 (16:07 +1000)]
doc: put Release History link on 'Documentation' page
Also put Weekly Snapshot History link on 'Contributing' page

Fixes #1885.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4559049

13 years agoruntime: fix mmap error return on linux.
Dmitry Chestnykh [Fri, 27 May 2011 04:43:27 +0000 (21:43 -0700)]
runtime: fix mmap error return on linux.

Fixes #1511 again.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/4527070

13 years agocgo: support pkg-config for flags and libs
Gustavo Niemeyer [Fri, 27 May 2011 01:19:23 +0000 (22:19 -0300)]
cgo: support pkg-config for flags and libs

Fixes issue #1853.

R=golang-dev, mattn.jp, adg
CC=golang-dev
https://golang.org/cl/4550084

13 years agosyscall: add routing messages support for BSD variants
Mikio Hara [Fri, 27 May 2011 00:02:03 +0000 (20:02 -0400)]
syscall: add routing messages support for BSD variants

R=rsc
CC=golang-dev
https://golang.org/cl/4539084

13 years agoos: TestMkdirAll should not fail to delete _test/_TestMkdirAll_ on Windows
Alex Brainman [Thu, 26 May 2011 23:52:15 +0000 (09:52 +1000)]
os: TestMkdirAll should not fail to delete _test/_TestMkdirAll_ on Windows

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4515142

13 years agosyscall: add routing messages support for Linux
Mikio Hara [Thu, 26 May 2011 21:04:58 +0000 (17:04 -0400)]
syscall: add routing messages support for Linux

R=rsc
CC=golang-dev
https://golang.org/cl/4515135

13 years agocompress/flate: fix Huffman tree bug
Ivan Krasin [Thu, 26 May 2011 21:02:11 +0000 (17:02 -0400)]
compress/flate: fix Huffman tree bug
Incorporate refactoring and a regression test from https://golang.org/cl/4538090/

R=rsc, go.peter.90, imkrasin
CC=golang-dev, mirtchovski
https://golang.org/cl/4524070

13 years agofix build: temporarily disable the use of strings.Reader UnreadRune in fmt
Robert Griesemer [Thu, 26 May 2011 18:54:10 +0000 (11:54 -0700)]
fix build: temporarily disable the use of strings.Reader UnreadRune in fmt

R=r
CC=golang-dev
https://golang.org/cl/4532090

13 years agogc: patch y.tab.c to fix build when using Bison 2.5
Ian Lance Taylor [Thu, 26 May 2011 18:28:23 +0000 (11:28 -0700)]
gc: patch y.tab.c to fix build when using Bison 2.5

Fixes #1843.

R=rsc
CC=golang-dev
https://golang.org/cl/4535101

13 years agoio: add ByteScanner, RuneScanner interfaces
Robert Griesemer [Thu, 26 May 2011 18:03:52 +0000 (11:03 -0700)]
io: add ByteScanner, RuneScanner interfaces

R=r, rsc
CC=golang-dev
https://golang.org/cl/4530069

13 years agostrings: implement UnreadByte, UnreadRune
Robert Griesemer [Thu, 26 May 2011 18:02:07 +0000 (11:02 -0700)]
strings: implement UnreadByte, UnreadRune

Added corresponding tests.

R=rsc
CC=golang-dev
https://golang.org/cl/4560045

13 years agohttp/spdy: redo interfaces, flesh out implementation & frame types
William Chan [Thu, 26 May 2011 16:54:54 +0000 (09:54 -0700)]
http/spdy: redo interfaces, flesh out implementation & frame types

Added a new Framer to handle reading/writing Frames. This is necessary since we have to maintain a compression context across streams.

TODO:
* Separate the types and read/write routines into different files.
* Improve error handling.

R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/4503042

13 years agoCONTRIBUTORS: add William Chan (Google CLA)
Brad Fitzpatrick [Thu, 26 May 2011 16:53:28 +0000 (09:53 -0700)]
CONTRIBUTORS: add William Chan (Google CLA)

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/4552066

13 years agoencoding/binary: add a non-reflect fast path for Read
Brad Fitzpatrick [Thu, 26 May 2011 16:01:05 +0000 (09:01 -0700)]
encoding/binary: add a non-reflect fast path for Read

before/after:
binary.BenchmarkRead  200000     10860 ns/op
binary.BenchmarkRead  500000      2846 ns/op

R=rsc
CC=golang-dev
https://golang.org/cl/4547062

13 years agoexp/eval: fix compile error.
Yasuhiro Matsumoto [Thu, 26 May 2011 12:05:25 +0000 (22:05 +1000)]
exp/eval: fix compile error.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4550086

13 years agomime/multipart: misc code/doc fixes
Brad Fitzpatrick [Thu, 26 May 2011 02:21:05 +0000 (19:21 -0700)]
mime/multipart: misc code/doc fixes

R=rsc
CC=golang-dev
https://golang.org/cl/4532089

13 years agohttp: Transport hook to register non-http(s) protocols
Brad Fitzpatrick [Wed, 25 May 2011 19:31:11 +0000 (12:31 -0700)]
http: Transport hook to register non-http(s) protocols

This permits external packages implementing e.g.
FTP or gopher to register themselves with the
http.DefaultClient:

package ftp
func init() {
    http.DefaultTransport.RegisterProtocol("ftp", &ftp{})
}

Client code would look like:

import (
    _ "github.com/exampleuser/go/gopher"
    _ "github.com/exampleuser/go/ftp"
)

func main() {
    resp, err := http.Get("ftp://example.com/path.txt")
    ...
}

R=dsymonds, rsc
CC=golang-dev
https://golang.org/cl/4526077

13 years agoencoding/base64: add DecodeString and EncodeToString
Brad Fitzpatrick [Wed, 25 May 2011 19:24:36 +0000 (12:24 -0700)]
encoding/base64: add DecodeString and EncodeToString

... like encoding/hex. Same signatures.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4530070

13 years agonet: If we stop polling, remove any pending events for the socket
Ian Lance Taylor [Wed, 25 May 2011 19:21:10 +0000 (12:21 -0700)]
net: If we stop polling, remove any pending events for the socket

Fixes #1872.

R=rsc
CC=golang-dev, lars.pensjo
https://golang.org/cl/4559046

13 years agogo/scanner: use strconv.QuoteRune now that it is available
Robert Griesemer [Wed, 25 May 2011 18:16:17 +0000 (11:16 -0700)]
go/scanner: use strconv.QuoteRune now that it is available

R=r, rsc
CC=golang-dev
https://golang.org/cl/4538096

13 years agotest: test cases for issue 1708.
Robert Griesemer [Wed, 25 May 2011 17:26:06 +0000 (10:26 -0700)]
test: test cases for issue 1708.

R=rsc
CC=golang-dev
https://golang.org/cl/4548058

13 years agoquietgcc: fix typo, respect $TMPDIR
Russ Cox [Wed, 25 May 2011 17:20:50 +0000 (13:20 -0400)]
quietgcc: fix typo, respect $TMPDIR

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4529087

13 years agoio, net, http: sendfile support
Brad Fitzpatrick [Wed, 25 May 2011 17:15:26 +0000 (10:15 -0700)]
io, net, http: sendfile support

Speeds up static fileserver, avoiding kernel/userspace copies.

Numbers: downloading 14 MB AppEngine Go SDK with ab (Apache Bench)
with 5 threads:

Before/after numbers:

CPU:
user    0m3.910s
sys     0m23.650s
->
user    0m0.720s
sys     0m4.890s

Time taken for tests:   8.906 seconds
->
Time taken for tests:   8.545 seconds

Percentage of the requests served within a certain time (ms)
50%     44
66%     45
75%     46
80%     46
90%     48
95%     51
98%     59
99%     71
100     74 (longest request)
->
50%     42
66%     43
75%     43
80%     44
90%     46
95%     57
98%     62
99%     63
100%    64 (longest request)

R=iant, gary.burd, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/4543071

13 years agogc: typo
Russ Cox [Wed, 25 May 2011 14:19:50 +0000 (10:19 -0400)]
gc: typo

R=ken2
CC=golang-dev
https://golang.org/cl/4539086

13 years ago5g: alignment fixes
Russ Cox [Wed, 25 May 2011 14:18:49 +0000 (10:18 -0400)]
5g: alignment fixes

Makes all.bash work after echo 4 >/proc/cpu/alignment,
which means kill the process on an unaligned access.

The default behavior on DreamPlug/GuruPlug/SheevaPlug
is to simulate an ARMv3 and just let the unaligned accesses
stop at the word boundary, resulting in all kinds of surprises.

Fixes #1240.

R=ken2
CC=golang-dev
https://golang.org/cl/4551064

13 years ago5l: fix build
Russ Cox [Wed, 25 May 2011 13:44:05 +0000 (09:44 -0400)]
5l: fix build

R=ken2
CC=golang-dev
https://golang.org/cl/4538095

13 years agold: add -w to disable dwarf, make errors obviously from dwarf
Russ Cox [Wed, 25 May 2011 12:25:33 +0000 (08:25 -0400)]
ld: add -w to disable dwarf, make errors obviously from dwarf

Reenable dwarf output on Mac.
Was writing headers but no actual dwarf data.

Fixes #1877 (accidentally).
Workaround for issue 1878.

R=lvd
CC=golang-dev
https://golang.org/cl/4515139

13 years ago8l: emit resources (.rsrc) in Windows PE.
Wei Guangjing [Wed, 25 May 2011 11:53:00 +0000 (07:53 -0400)]
8l: emit resources (.rsrc) in Windows PE.

R=alex.brainman, rsc
CC=golang-dev, vcc.163
https://golang.org/cl/4516055

13 years agofmt: make %q work for integers, printing a quoted character literal.
Rob Pike [Wed, 25 May 2011 11:25:15 +0000 (21:25 +1000)]
fmt: make %q work for integers, printing a quoted character literal.

R=rsc
CC=golang-dev
https://golang.org/cl/4556060

13 years agoos: Fix test to work on Solaris.
Ian Lance Taylor [Wed, 25 May 2011 05:53:37 +0000 (22:53 -0700)]
os: Fix test to work on Solaris.

On Solaris /bin is a symlink to /usr/bin, so running "pwd" in
the directory "/bin" prints out "/usr/bin".

R=rsc, r, bradfitz
CC=golang-dev
https://golang.org/cl/4559043

13 years agostrconv: add QuoteRune, which is analogous to Quote, but for runes rather than strings.
Rob Pike [Wed, 25 May 2011 05:04:07 +0000 (15:04 +1000)]
strconv: add QuoteRune, which is analogous to Quote, but for runes rather than strings.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4556059

13 years agodoc: mention go/printer instead of container/vector in effective go
Andrew Gerrand [Wed, 25 May 2011 01:39:40 +0000 (11:39 +1000)]
doc: mention go/printer instead of container/vector in effective go

Fixes #1876.

R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/4538093

13 years agospec: delete spurious tag.
Rob Pike [Wed, 25 May 2011 00:58:58 +0000 (10:58 +1000)]
spec: delete spurious tag.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4536082

13 years ago6l, 8l: fix Mach-O binaries with many dynamic libraries
Russ Cox [Tue, 24 May 2011 23:50:13 +0000 (19:50 -0400)]
6l, 8l: fix Mach-O binaries with many dynamic libraries

R=ken2
CC=golang-dev
https://golang.org/cl/4529084

13 years agogc: relax assignability of method receivers
Anthony Martin [Tue, 24 May 2011 23:48:19 +0000 (19:48 -0400)]
gc: relax assignability of method receivers

The spec was adjusted in commit df410d6a4842 to allow the
implicit assignment of strutures with unexported fields in
method receivers.  This change updates the compiler.

Also moved bug322 into fixedbugs and updated golden.out
to reflect the removal of the last known bug.

Fixes #1402.

R=golang-dev, gri, rsc
CC=golang-dev
https://golang.org/cl/4526069

13 years agogo/scanner: remove some code
Robert Griesemer [Tue, 24 May 2011 22:00:42 +0000 (15:00 -0700)]
go/scanner: remove some code

R=r
CC=golang-dev
https://golang.org/cl/4550077

13 years agogo spec: be precise with the use of the informal ellipsis … and the Go token ...
Robert Griesemer [Tue, 24 May 2011 21:18:44 +0000 (14:18 -0700)]
go spec: be precise with the use of the informal ellipsis  … and the Go token ...

Fixes #1867.

R=r
CC=golang-dev
https://golang.org/cl/4538092

13 years agodocs: remove some prose-unworthy empty parentheses.
Rob Pike [Tue, 24 May 2011 20:44:09 +0000 (06:44 +1000)]
docs: remove some prose-unworthy empty parentheses.
In our evolving style, prose should name a function "f" not "f()".

R=gri, rsc
CC=golang-dev
https://golang.org/cl/4550075

13 years agospec: add missing comma.
Rob Pike [Tue, 24 May 2011 20:00:07 +0000 (06:00 +1000)]
spec: add missing comma.
A real humdinger.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4538089

13 years agohttp: Client test for streaming responses (no code changes)
Brad Fitzpatrick [Tue, 24 May 2011 16:02:01 +0000 (09:02 -0700)]
http: Client test for streaming responses (no code changes)

I had a report that this was broken. It seems fine.

I think the reporter was just never flushing their response
headers.  If I omit the test server's initial Flush I get the
same behavior as reported. (a hang at Client.Get)

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4552062

13 years agohttp: fix Set-Cookie date parsing
Brad Fitzpatrick [Tue, 24 May 2011 15:31:43 +0000 (08:31 -0700)]
http: fix Set-Cookie date parsing

Fixes #1855

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4527073

13 years agoencoding/line: delete package.
Rob Pike [Tue, 24 May 2011 06:05:26 +0000 (16:05 +1000)]
encoding/line: delete package.
Its functionality is now in bufio.
Fixes #1869.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/4553061

13 years agogodoc: display advert for the package dashboard on package list page
Andrew Gerrand [Tue, 24 May 2011 05:45:08 +0000 (15:45 +1000)]
godoc: display advert for the package dashboard on package list page

R=golang-dev, bradfitz, ality
CC=golang-dev
https://golang.org/cl/4526070

13 years agomisc/emacs: don't select the mark after gofmt
Eric Eisner [Tue, 24 May 2011 02:47:25 +0000 (22:47 -0400)]
misc/emacs: don't select the mark after gofmt

R=ajmani
CC=golang-dev
https://golang.org/cl/4553054

13 years agoimage/gif: simplify blockReader.Read.
Rob Pike [Tue, 24 May 2011 01:02:44 +0000 (11:02 +1000)]
image/gif: simplify blockReader.Read.
Inverting the tests avoids recursion and simplifies the flow.

R=nigeltao
CC=golang-dev
https://golang.org/cl/4551057

13 years agogophertool: also accept commit form 8486:ab29d2698a47
Brad Fitzpatrick [Mon, 23 May 2011 21:27:51 +0000 (14:27 -0700)]
gophertool: also accept commit form 8486:ab29d2698a47

... as "hg log" produces by default.

And add a README.

R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/4529080

13 years agogo spec: clarify rules for shifts
Robert Griesemer [Mon, 23 May 2011 21:12:42 +0000 (14:12 -0700)]
go spec: clarify rules for shifts

Note: This is not a spec change.

The spec was not clear on the result type of
constant shift expressions. Made it more
explicit and added additional examples.

Also: Remove paragraph on send expressions (they
are statements, now).

Fixes #1708.

R=rsc, r, iant, r
CC=golang-dev
https://golang.org/cl/4517074

13 years agogophertool: Chrome extension to aid in Go development
Brad Fitzpatrick [Mon, 23 May 2011 21:05:18 +0000 (14:05 -0700)]
gophertool: Chrome extension to aid in Go development

Contains common links & a smart text box that recognizes various
identifiers and jumps to one of:

* issue URL,
* codereview URL,
* commit URL,
* package docs

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4553058

13 years agotime: Remove unnecessary call to Nanoseconds() in after().
Kyle Consalus [Mon, 23 May 2011 19:38:51 +0000 (12:38 -0700)]
time: Remove unnecessary call to Nanoseconds() in after().

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4528091

13 years agotag weekly.2011-05-22
Andrew Gerrand [Mon, 23 May 2011 06:32:58 +0000 (16:32 +1000)]
tag weekly.2011-05-22

R=dsymonds
CC=golang-dev
https://golang.org/cl/4550070

13 years agoweekly.2011-05-22 weekly.2011-05-22
Andrew Gerrand [Mon, 23 May 2011 06:30:06 +0000 (16:30 +1000)]
weekly.2011-05-22

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4523090

13 years agohttp: add docs/warning on incorrect use of NewChunkedWriter
Brad Fitzpatrick [Mon, 23 May 2011 01:46:48 +0000 (18:46 -0700)]
http: add docs/warning on incorrect use of NewChunkedWriter

R=golang-dev, adg, r
CC=golang-dev
https://golang.org/cl/4536075

13 years agosyscall: add IPv6 scope zone ID support
Mikio Hara [Sun, 22 May 2011 17:09:07 +0000 (10:09 -0700)]
syscall: add IPv6 scope zone ID support

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/4515124

13 years agonet: re-enable wildcard listening
Mikio Hara [Sun, 22 May 2011 16:48:04 +0000 (09:48 -0700)]
net: re-enable wildcard listening

Fixes #1854.

R=bradfitz, golang-dev
CC=golang-dev
https://golang.org/cl/4550062

13 years agoruntime: fix function args not checked warning on arm
Dave Cheney [Sun, 22 May 2011 04:59:25 +0000 (14:59 +1000)]
runtime: fix function args not checked warning on arm

This tiny nit was driving me nuts

R=rsc, ken, r
CC=golang-dev
https://golang.org/cl/4550069

13 years agodoc: close paragraph tags in FAQ
Evan Shaw [Sun, 22 May 2011 04:56:12 +0000 (14:56 +1000)]
doc: close paragraph tags in FAQ

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4532076

13 years agoflag: fix build
Andrew Gerrand [Sun, 22 May 2011 01:55:02 +0000 (11:55 +1000)]
flag: fix build

R=r
CC=golang-dev
https://golang.org/cl/4543064

13 years agocrypto/x509: fix incorrect prints found by govet
Robert Hencke [Sat, 21 May 2011 23:23:22 +0000 (09:23 +1000)]
crypto/x509: fix incorrect prints found by govet

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/4526073

13 years agoflags: allow distinct sets of flags.
Rob Pike [Sat, 21 May 2011 23:22:00 +0000 (09:22 +1000)]
flags: allow distinct sets of flags.

A FlagSet is an independent set of flags that may be used,
for example, to provide flag processing for subcommands
in a CLI.  The standard, os.Args-derived set of flags is a
global but non-exported FlagSet and the standard functions
are wrappers for methods of that FlagSet.

Allow the programmer to control whether the program
exits if there is a parse error.  For the default set, the behavior
remains to exit on error.

The handling of Usage is odd due to backward compatibility.

R=golang-dev, bradfitz, r, bradfitz
CC=golang-dev
https://golang.org/cl/4517092

13 years ago5l: fix set but not used warnings
Dave Cheney [Sat, 21 May 2011 15:00:53 +0000 (08:00 -0700)]
5l: fix set but not used warnings

R=rsc, iant
CC=golang-dev
https://golang.org/cl/4538083