]> Cypherpunks repositories - gostls13.git/commit
[dev.regabi] strconv: add to bootstrap packages
authorMatthew Dempsky <mdempsky@google.com>
Tue, 24 Nov 2020 05:48:38 +0000 (21:48 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Tue, 24 Nov 2020 19:42:42 +0000 (19:42 +0000)
commit015423a15bcfae148d5121bcf4ba5b50d0847cd0
tree303fe9c0618b07879bb10da33cd1aa1ab1b55afb
parentc767d73227704ba4e22e366e89d1885f52d4b6cc
[dev.regabi] strconv: add to bootstrap packages

go/constant relies on strconv for parsing Go literals, while older
versions of strconv either lack recent Go language features (e.g., Go
1.13's new numeric literals) or have errors (e.g., mishandling of
carriage returns in raw string literals prior to Go 1.8).

This requires two changes:

1. Splitting out the internal/bytealg dependency into a separate file,
which can be easily substituted with a simple loop for bootstrap
builds.

2. Updating eisel_lemire.go to not utilize Go 1.13 functionality
(underscores in numeric literals and signed shift counts).

Change-Id: Ib48a858a03b155eebdcd08d577aec2254337e70e
Reviewed-on: https://go-review.googlesource.com/c/go/+/272749
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/dep_test.go
src/cmd/dist/buildtool.go
src/strconv/bytealg.go [new file with mode: 0644]
src/strconv/bytealg_bootstrap.go [new file with mode: 0644]
src/strconv/eisel_lemire.go
src/strconv/quote.go