]> Cypherpunks repositories - gostls13.git/commit
runtime/pprof: document possibility of empty stacks
authorAustin Clements <austin@google.com>
Thu, 5 Jan 2023 14:08:25 +0000 (09:08 -0500)
committerAustin Clements <austin@google.com>
Mon, 9 Jan 2023 20:25:19 +0000 (20:25 +0000)
commit0bbd67e52f98ce45e39e9a43e3c87a8c32aabbd2
tree7cc323a3c6697c77f94c84072bec105f5ba568d9
parentd9f23cfe78eadcdbde31fd931e90bebb72455648
runtime/pprof: document possibility of empty stacks

I spent quite a while determining the cause of empty stacks in
profiles and reasoning out why this is okay. There isn't a great place
to record this knowledge, but a documentation comment on
appendLocsForStack is better than nothing.

Updates #51550.

Change-Id: I2eefc6ea31f1af885885c3d96199319f45edb4ce
Reviewed-on: https://go-review.googlesource.com/c/go/+/460695
Reviewed-by: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/runtime/pprof/proto.go