]> Cypherpunks repositories - gostls13.git/commit
[dev.unified] cmd/compile: make Unified IR always writes concrete type for const...
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Wed, 20 Jul 2022 13:27:58 +0000 (20:27 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Fri, 22 Jul 2022 16:26:22 +0000 (16:26 +0000)
commit131f981df0a7d17361839b55fd4d588e652f16a9
tree78aba14c0195cf79464df776b969df6ca7ded5b3
parentae43bdc3e3f87f8ba05ba12a17104ddbb0e6b30c
[dev.unified] cmd/compile: make Unified IR always writes concrete type for const exprs

So we don't have to depend on typecheck pass to fixup the concrete
type for some constant expressions. Previously, the problem won't show up,
until CL 418475 sent, which removes an un-necessary type conversion in
"append(a, b...) to help the optimization kicks in.

For #53888

Change-Id: Idaecd38b7abbaa3ad5b00ff3b1fb0fd8bbeb6726
Reviewed-on: https://go-review.googlesource.com/c/go/+/418514
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/compile/internal/noder/expr.go
src/cmd/compile/internal/noder/helpers.go
src/cmd/compile/internal/noder/writer.go