]> Cypherpunks repositories - gostls13.git/commit
runtime/race: add build tag to internal amd64vN packages
authorCherry Mui <cherryyz@google.com>
Tue, 20 Dec 2022 22:19:09 +0000 (17:19 -0500)
committerCherry Mui <cherryyz@google.com>
Thu, 22 Dec 2022 04:34:09 +0000 (04:34 +0000)
commit18baca6765f75c0973b9d90cb6123f1eb339ad4c
tree43ea52d32d1701ab684276167bad9e23fa8fd238
parent13ed4f42f03cac6d9ad701a3041dba06c84dc70d
runtime/race: add build tag to internal amd64vN packages

Only one of the runtime/race/internal/amd64vN packages should be
included in a build. Generally this is true because the
runtime/race package would import only one of them depending on
the build configuration. But for "go install -buildmode=shared std"
it includes all Go packages in std, which includes both, which
then causes link-time failure due to duplicated symbols. To avoid
this, we add build tags to the internal packages, so, depending on
the build configuation, only one package would contain buildable
go files therefore be included in the build.

For #57334.

Change-Id: I52ddc3a40e16c7d04b4dd861e9689918d27e8509
Reviewed-on: https://go-review.googlesource.com/c/go/+/458695
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
src/runtime/race/internal/amd64v1/doc.go
src/runtime/race/internal/amd64v3/doc.go
src/runtime/race/race_v1_amd64.go
src/runtime/race/race_v3_amd64.go