]> Cypherpunks repositories - gostls13.git/commit
cmd/test2json: do not emit a final Action if the result is not known
authorBryan C. Mills <bcmills@google.com>
Fri, 14 Aug 2020 21:44:22 +0000 (17:44 -0400)
committerBryan C. Mills <bcmills@google.com>
Mon, 17 Aug 2020 19:43:21 +0000 (19:43 +0000)
commit1b86bdbdc3991c13c6ed156100a5f4918fdd9c6b
tree1630f7d8bec19ca853d9e9804aeb532e44df6f28
parentf30044a03bc7cf107dbec03c02fb6d0072878252
cmd/test2json: do not emit a final Action if the result is not known

If we are parsing a test output, and the test does not end in the
usual PASS or FAIL line (say, because it panicked), then we need the
exit status of the test binary in order to determine whether the test
passed or failed. If we don't have that status available, we shouldn't
guess arbitrarily — instead, we should omit the final "pass" or "fail"
action entirely.

(In practice, we nearly always DO have the final status, such as when
running 'go test' or 'go tool test2json some.exe'.)

Fixes #40132

Change-Id: Iae482577361a6033395fe4a05d746b980e18c3de
Reviewed-on: https://go-review.googlesource.com/c/go/+/248624
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/test/test.go
src/cmd/go/testdata/script/test_json_exit.txt [new file with mode: 0644]
src/cmd/internal/test2json/test2json.go
src/cmd/internal/test2json/testdata/benchshort.json
src/cmd/internal/test2json/testdata/empty.json
src/cmd/test2json/main.go