]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: fix outgoing calls with GOEXPERIMENT=regabiargs
authorAustin Clements <austin@google.com>
Wed, 31 Mar 2021 21:41:07 +0000 (17:41 -0400)
committerAustin Clements <austin@google.com>
Thu, 1 Apr 2021 00:51:24 +0000 (00:51 +0000)
commit1f29e69bad3673aa4f9d1c4d1016170b9ced634a
tree4c37387847dd574509f36acf82dd5a6f7d00d587
parent3304b2235af0a88ba0bb21edaf2c60df47b6e0a8
cmd/compile: fix outgoing calls with GOEXPERIMENT=regabiargs

The logic for constructing calls in (*state).call is based around
targeted experiments with register-based calls. However, when the
register ABI is turned on everywhere, it currently doesn't account for
direct calls to non-ABIInternal functions. This CL adds a much simpler
path to (*state).call when regabiargs is turned on that looks at the
ABI of the target function.

For #40724.

Change-Id: I7f4f5fed8a5ec131bcf1ce5b9d94d45672a304cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/306410
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/ssagen/ssa.go