]> Cypherpunks repositories - gostls13.git/commit
cmd/link: do not pass -no-pie to host linker when -linkshared is passed
authorMichael Hudson-Doyle <michael.hudson@canonical.com>
Wed, 4 Apr 2018 22:07:41 +0000 (10:07 +1200)
committerMichael Hudson-Doyle <michael.hudson@canonical.com>
Thu, 12 Apr 2018 10:21:35 +0000 (10:21 +0000)
commit2d26a65f8f1a6fcb0948803589061d99b94fa993
treeb735c9ded6a12976a61e5e8b004cc6e1fa98b33f
parent94ef1dafbd9b490bdf7fc40b33df8399eea03b8e
cmd/link: do not pass -no-pie to host linker when -linkshared is passed

As the comment above the code I'm changing says, when building with
-buildmode=exe, the default compiler flags produce code incompatible with PIE.
But when -linkshared is passed, the default compiler flags are not used so this
does not apply. And now I've found a system (linux/arm64 with glibc 2.27) where
this combination of flags causes a problem, albeit for reasons I don't really
understand, so stop passing -no-pie when -linkshared is passed.

Change-Id: I412ec7941dc0cb89e6d1b171fc29288aadcb9f20
Reviewed-on: https://go-review.googlesource.com/104815
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/link/internal/ld/lib.go