]> Cypherpunks repositories - gostls13.git/commit
runtime: simplify histogram buckets considerably
authorMichael Anthony Knyszek <mknyszek@google.com>
Fri, 21 Jan 2022 06:52:43 +0000 (06:52 +0000)
committerMichael Knyszek <mknyszek@google.com>
Thu, 10 Feb 2022 00:07:14 +0000 (00:07 +0000)
commit2e9dcb508647dc473a37ecfa244d2bc4a1843ab4
tree226bff50124279335293c045c90ef7c3735ede27
parent2bf5ae0c28a28244c3e20ef65b75e9e90adb5251
runtime: simplify histogram buckets considerably

There was an off-by-one error in the time histogram buckets calculation
that caused the linear sub-buckets distances to be off by 2x.

The fix was trivial, but in writing tests I realized there was a much
simpler way to express the calculation for the histogram buckets, and
took the opportunity to do that here. The new bucket calculation also
fixes the bug.

Fixes #50732.

Change-Id: Idae89986de1c415ee4e148f778e0e101ca003ade
Reviewed-on: https://go-review.googlesource.com/c/go/+/380094
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
src/runtime/export_test.go
src/runtime/histogram.go
src/runtime/histogram_test.go