]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: relax overly strict assertion
authorMatthew Dempsky <mdempsky@google.com>
Tue, 21 Feb 2023 21:16:22 +0000 (13:16 -0800)
committerGopher Robot <gobot@golang.org>
Wed, 1 Mar 2023 20:26:10 +0000 (20:26 +0000)
commit37a2004b431df6cdd3260cbfe2ddb7673e94b9ef
treecc757915c16f21d92f621db221c9192383077ba4
parent70efe9f721d70f57eba8896ffd3939723e0f0b4a
cmd/compile: relax overly strict assertion

The assertion here was to make sure the newly constructed and
typechecked expression selected the same receiver-qualified method,
but in the case of anonymous receiver types we can actually end up
with separate types.Field instances corresponding to each types.Type
instance. In that case, the assertion spuriously failed.

The fix here is to relax and assertion and just compare the method's
name and type (including receiver type).

Fixes #58563.

Change-Id: I67d51ddb020e6ed52671473c93fc08f283a40886
Reviewed-on: https://go-review.googlesource.com/c/go/+/471676
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/cmd/compile/internal/noder/reader.go
test/fixedbugs/issue58563.dir/a.go [new file with mode: 0644]
test/fixedbugs/issue58563.dir/main.go [new file with mode: 0644]
test/fixedbugs/issue58563.go [new file with mode: 0644]