]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: disable CBC cipher suites with SHA-256 by default
authorFilippo Valsorda <hi@filippo.io>
Mon, 16 Jan 2017 23:54:45 +0000 (23:54 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 17 Jan 2017 16:41:09 +0000 (16:41 +0000)
commit48d8edb5b21db190f717e035b4d9ab61a077f9d7
tree2419a16e1b04d0c84623af8256bff22813f16ea4
parent92ecd7893308ad222bfdd33b10be1cce769a3cdf
crypto/tls: disable CBC cipher suites with SHA-256 by default

As is, they were fully vulnerable to the Lucky13 attack. The SHA1
variants implement limited countermeasures (see f28cf8346c4) but the
SHA256 ones are apparently used rarely enough (see 8741504888b) that
it's not worth the extra code.

Instead, disable them by default and update the warning.

Updates #13385
Updates #15487

Change-Id: I45b8b716001e2fa0811b17e25be76e2512e5abb2
Reviewed-on: https://go-review.googlesource.com/35290
Reviewed-by: Adam Langley <alangley@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Matt Layher <mdlayher@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/crypto/tls/cipher_suites.go
src/crypto/tls/tls.go