]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: simplify value coding for unified IR
authorMatthew Dempsky <mdempsky@google.com>
Tue, 7 Sep 2021 20:23:08 +0000 (13:23 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 9 Sep 2021 00:29:35 +0000 (00:29 +0000)
commit4c52eac49b7e3f2a107419583012e5251ccbfde9
tree4d2065f74e7b06dd8ff073f1d2c78ad6219b8839
parente30a09013b24853cbe6d3d3a919e639df0bdf41c
cmd/compile: simplify value coding for unified IR

In indexed export, values are always exported along with their type
and are encoded in a type-sensitive manner, because this matches how
cmd/compile handled constants internally.

However, go/types intentionally differs from this, decoupling type
from value representation. As unified IR strives to be more
go/types-centric, it makes sense to embrace this and make values a
more first-class encoding.

Change-Id: If21d849c4f610358bd776d5665469d180bcd5f6e
Reviewed-on: https://go-review.googlesource.com/c/go/+/348014
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/noder/decoder.go
src/cmd/compile/internal/noder/encoder.go
src/cmd/compile/internal/noder/reader.go
src/cmd/compile/internal/noder/reader2.go
src/cmd/compile/internal/noder/writer.go