]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: omit file:pos for non-existent, permission errors
authorEmmanuel T Odeke <emmanuel@orijtech.com>
Wed, 22 Apr 2020 06:31:59 +0000 (23:31 -0700)
committerEmmanuel Odeke <emm.odeke@gmail.com>
Thu, 30 Apr 2020 01:17:47 +0000 (01:17 +0000)
commit4f7053c87f9ebf3acab7669d380f53bdfba0566b
treedd2c6110e506383e8017c3d778d0e4d62a47f9db
parent4e00b4c366f06036509201d3bf19ee2c8fd767c8
cmd/compile: omit file:pos for non-existent, permission errors

Omits printing the file:line:column when trying to open either
* non-existent files
* files without permission

Given:
    go tool compile x.go

For either of x.go not existing, or if no read permissions:

* Before:
    x.go:0: open x.go: no such file or directory
    x.go:0: open x.go: permission denied

* After:
    open x.go: no such file or directory
    open x.go: permission denied

While here, noticed an oddity with the Linux builders, that appear
to always be running under root, hence the test for permission errors
with 0222 -W-*-W-*-W- can't pass on linux-amd64 builders.
The filed bug is #38608.

Fixes #36437

Change-Id: I9645ef73177c286c99547e3a0f3719fa07b35cb5
Reviewed-on: https://go-review.googlesource.com/c/go/+/229357
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/gc/subr.go
test/fixedbugs/issue36437.go [new file with mode: 0644]