]> Cypherpunks repositories - gostls13.git/commit
cmd/go/internal/modload: remove SetBuildList
authorBryan C. Mills <bcmills@google.com>
Wed, 18 Nov 2020 04:16:30 +0000 (23:16 -0500)
committerBryan C. Mills <bcmills@google.com>
Thu, 19 Nov 2020 04:02:59 +0000 (04:02 +0000)
commit5ba1c3f290ef8f3c373c560d3608325b07f44f7a
tree7af8cfc5e997446c20a539b22077ab53cc57120a
parentff2824d4b3391c644b264273f98a47302e2d4ab6
cmd/go/internal/modload: remove SetBuildList

For the last remaining call site (in cmd/go/internal/work, added for
the new 'go install pkg@version' codepath in CL 254365), use
EditBuildList instead.

SetBuildList assumes that the caller has enough information to produce
a complete, coherent build list. With lazy loading, producing a
complete, coherent build list is no longer quite so trivial.

In CL 263267, I rewrote the main caller of SetBuildList (the 'go get'
command), and in the process added a more targeted modload hook
(EditBuildList). That hook also suffices for 'go install pkg@version'.
The resulting error messages are perhaps not as smooth as they ought
to be, but if they are too awkward we should probably fix them for
'go get' too, and the commands can continue to share the edit hook.

For #36460
Updates #40276

Change-Id: I698a9dcd2efe6378a4d91f21362880aa8e50001b
Reviewed-on: https://go-review.googlesource.com/c/go/+/270980
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/modload/buildlist.go
src/cmd/go/internal/modload/mvs.go
src/cmd/go/internal/work/build.go
src/cmd/go/testdata/script/mod_install_pkg_version.txt