]> Cypherpunks repositories - gostls13.git/commit
runtime: ensure stack is aligned in _rt0_amd64_windows_lib
authorqmuntal <quimmuntal@gmail.com>
Tue, 18 Jul 2023 14:55:26 +0000 (16:55 +0200)
committerQuim Muntal <quimmuntal@gmail.com>
Wed, 19 Jul 2023 11:55:15 +0000 (11:55 +0000)
commit5fe3f0a265c90a9c0346403742c6cafeb154503b
tree3f2605433be6a5cea4454163bc0625a5ebfcaaff
parent700727151fe3772ecc2315af101d2e5d93269c0c
runtime: ensure stack is aligned in _rt0_amd64_windows_lib

The Windows DLL loader may call a DLL entry point, in our case
_rt0_amd64_windows_lib, with a stack that is
not 16-byte aligned. In theory, it shouldn't, but under some
circumstances, it does (see below how to reproduce it).

Having an unaligned stack can, and probably will, cause problems
down the line, for example if a movaps instruction tries to store
a value in an unaligned address it throws an Access Violation exception
(code 0xc0000005).

I managed to consistently reproduce this issue by loading a Go DLL into
a C program that has the Page Heap Verification diagnostic enabled [1].

Updates #54187 (and potentially fixes)

[1] https://learn.microsoft.com/en-us/windows-hardware/drivers/debugger/example-12---using-page-heap-verification-to-find-a-bug

Change-Id: Id0fea7f407e024c9b8cdce10ce4802d7535e7542
Reviewed-on: https://go-review.googlesource.com/c/go/+/510755
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
src/runtime/rt0_windows_amd64.s