]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] cmd/compile: allow embedding Type.Vargen into Sym.Name
authorMatthew Dempsky <mdempsky@google.com>
Fri, 11 Jun 2021 10:47:07 +0000 (03:47 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Fri, 11 Jun 2021 14:47:33 +0000 (14:47 +0000)
commit61888d47c4c49afc2e4ac3aeea42e83cda84d37b
tree4ff8c8d518fc41dff7888b68e97b5d7ea0ba5ac9
parent62e32dd386103b5ee8dfe921eb791b14277843b5
[dev.typeparams] cmd/compile: allow embedding Type.Vargen into Sym.Name

Unified IR currently works by hoisting local type definitions to
package scope, which requires giving them a unique name. Its current
solution is to directly embed the ·N suffix in Sym.Name, rather than
set Type.Vargen. This CL extends types/fmt.go to support trimming this
suffix again when appropriate.

Longer term, I want to revisit this hack, but this seemed like the
least invasive solution while also handling generics and local types.

Change-Id: If99fcdcc1e19e37d5887de3b021c256a3fe46b98
Reviewed-on: https://go-review.googlesource.com/c/go/+/327052
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/types/fmt.go