]> Cypherpunks repositories - gostls13.git/commit
cmd/cgo: preserve type information across loadDWARF loop
authorIan Lance Taylor <iant@golang.org>
Wed, 5 Dec 2018 22:04:27 +0000 (14:04 -0800)
committerIan Lance Taylor <iant@golang.org>
Tue, 11 Dec 2018 03:29:27 +0000 (03:29 +0000)
commit6d4358705301e06e71b99977b77ae2c0a6b16b86
tree9d51ccca2e04c2a9e9eb44842136dc81a402b030
parent1ac3b0618170279474fcdf9c625b2e237bf2881c
cmd/cgo: preserve type information across loadDWARF loop

CL 122575 and its successors introduced a loop calling loadDWARF,
whereas before we only called it once. Pass a single typeConv to each
call, rather than creating a new one in loadDWARF itself. Change the
maps from dwarf.Type to use string keys rather than dwarf.Type keys,
since when the DWARF is reloaded the dwarf.Type pointers will be
different. These changes permit typeConv.Type to return a consistent
value for a given DWARF type, avoiding spurious type conversion errors
due to typedefs loaded after the first loop iteration.

Fixes #27340

Change-Id: Ic33467bbfca4c54e95909621b35ba2a58216d96e
Reviewed-on: https://go-review.googlesource.com/c/152762
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
misc/cgo/test/issue27340.go [new file with mode: 0644]
misc/cgo/test/issue27340/a.go [new file with mode: 0644]
misc/cgo/test/issue9026/issue9026.go
src/cmd/cgo/gcc.go