]> Cypherpunks repositories - gostls13.git/commit
cmd/go: fix error stacks when there are scanner errors
authorMichael Matloob <matloob@golang.org>
Tue, 4 Aug 2020 17:24:37 +0000 (13:24 -0400)
committerMichael Matloob <matloob@golang.org>
Wed, 5 Aug 2020 18:24:52 +0000 (18:24 +0000)
commit6f08e89ec3280bf6577c2bdb01243cbeeb1a259d
tree191fb7f22875be7e127baf6cb871fba64f6b1e20
parentf235275097eb68b36d171908cea6a0be23351a94
cmd/go: fix error stacks when there are scanner errors

After golang.org/cl/228784 setLoadPackageDataError tries to decide whether an
error is caused by an imported package or an importing package by examining the
error itself to decide. Ideally, the errors themselves would belong to a
specific interface or some other property to make it unambiguous that they
were import errors. Since they don't, setLoadPackageDataError just checked
for nogoerrors and classified all other errors as import errors. But
it missed scanner errors which are also "caused" by the imported
package.

Fixes #40544

Change-Id: I39159bfdc286bee73697decd07b8aa9451f2db06
Reviewed-on: https://go-review.googlesource.com/c/go/+/246717
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/load/pkg.go
src/cmd/go/testdata/script/list_err_stack.txt [new file with mode: 0644]