]> Cypherpunks repositories - gostls13.git/commit
cmd/compile/internal/types2: remove most asX converters (cleanup)
authorRobert Griesemer <gri@golang.org>
Mon, 8 Nov 2021 04:08:13 +0000 (20:08 -0800)
committerRobert Griesemer <gri@golang.org>
Mon, 8 Nov 2021 16:15:01 +0000 (16:15 +0000)
commit759eaa22adb0ab883959e4a36c19f2dfe77b5895
tree6b2713a7672a245dbbba28b84ad764aa9ffed59e
parent3e41b18a46ea0cf033be4d9baa2d99f7c8c985dc
cmd/compile/internal/types2: remove most asX converters (cleanup)

Make it explicit in the code where we call under.
The asNamed and asTypeParam converters need to
stay: asNamed does resolution if necessary, and
asTypeParam may or may not call under() depending
on the next CL.

Reviewed uses of asNamed and .(*Named) for correctness.
Removed unnecessary Named.resolve call in lookup.

Change-Id: I2acf176925e00bd1703a00230a779aa65a8f5a51
Reviewed-on: https://go-review.googlesource.com/c/go/+/362254
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
13 files changed:
src/cmd/compile/internal/types2/assignments.go
src/cmd/compile/internal/types2/builtins.go
src/cmd/compile/internal/types2/call.go
src/cmd/compile/internal/types2/context.go
src/cmd/compile/internal/types2/conversions.go
src/cmd/compile/internal/types2/expr.go
src/cmd/compile/internal/types2/index.go
src/cmd/compile/internal/types2/lookup.go
src/cmd/compile/internal/types2/predicates.go
src/cmd/compile/internal/types2/sizes.go
src/cmd/compile/internal/types2/type.go
src/cmd/compile/internal/types2/typestring.go
src/cmd/compile/internal/types2/typexpr.go