]> Cypherpunks repositories - gostls13.git/commit
go/internal/typeparams: remove typeparams.{Get,Set} (cleanup)
authorRobert Findley <rfindley@google.com>
Tue, 31 Aug 2021 20:24:00 +0000 (16:24 -0400)
committerRobert Findley <rfindley@google.com>
Tue, 31 Aug 2021 21:25:03 +0000 (21:25 +0000)
commit7637345b6ea00faf6c453a5f8128d8b548ee0a2c
treebb7b2d8184ce4a7fea9ad9b6953d1499c0dcdf97
parent78d0f8c870f9bc6e2f6dde22d3191e33be8d0c8f
go/internal/typeparams: remove typeparams.{Get,Set} (cleanup)

These helper functions are no longer necessary, now that type parameters
are enabled; we can access type parameters directly.

When considering the existence or non-existence of type parameters, we
can either check whether node.TParams != nil, or whether
node.TParams.NumFields() > 0. The heuristic I'm using for deciding
between these checks is as follows:
 - For data access, just check node.TParams != nil.
 - For producing errors if type parameters exist, check NumFields() > 0.

Change-Id: I6597536898e975564e9e8bf6a3a91bc798e0f110
Reviewed-on: https://go-review.googlesource.com/c/go/+/346549
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
src/go/internal/typeparams/typeparams.go
src/go/parser/parser.go
src/go/parser/resolver.go
src/go/printer/nodes.go
src/go/types/decl.go
src/go/types/interface.go
src/go/types/signature.go