]> Cypherpunks repositories - gostls13.git/commit
cmd/go: in TestTerminalPassthrough, delay subprocess exit until the PTY has been...
authorBryan C. Mills <bcmills@google.com>
Wed, 7 Dec 2022 16:18:50 +0000 (11:18 -0500)
committerGopher Robot <gobot@golang.org>
Wed, 7 Dec 2022 18:18:50 +0000 (18:18 +0000)
commit7c7cd56870ba617f964014fa4694e9b61e29cf97
treecde200fb9158810fcc01516562e4ad2ec1b250f6
parente57e673e7ff4f5b61180a07a1a73bd5bd524981a
cmd/go: in TestTerminalPassthrough, delay subprocess exit until the PTY has been read

Empirically, unread PTY output may be discarded on macOS when the
child process exits.

Fixes #57141.

Tested with 'go test cmd/go -run=TestTerminalPassthrough -count=1000'
on a darwin-amd64-12_0 gomote.

Change-Id: I11508e6429c61488f30e10d9ae0cc94fdf059257
Reviewed-on: https://go-review.googlesource.com/c/go/+/455915
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/go/terminal_test.go