]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: make typecheckaste correctly report invalid use of "..."
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Sun, 2 May 2021 19:19:10 +0000 (02:19 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Mon, 3 May 2021 15:03:57 +0000 (15:03 +0000)
commit844e1fc6f1d0dacd92534dba7f8d71f377017742
treee1d023794320439a18c34487814a38731f2724c3
parent9ed736ac2a99aa2e7ef7d8bed3b01ca8b20a6f80
cmd/compile: make typecheckaste correctly report invalid use of "..."

Currently, when "..." argument is passed to non-variadic function, the
compiler may skip that check, but continue checking whether the number
of arguments matches the function signature.

That causes the sanity check which was added in CL 255241 trigger.

Instead, we should report an invalid use of "...", which matches the
behavior of new type checker and go/types.

Fixes #45913

Change-Id: Icbb254052cbcd756bbd41f966c2c8e316c44420f
Reviewed-on: https://go-review.googlesource.com/c/go/+/315796
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/typecheck/typecheck.go
test/ddd1.go
test/fixedbugs/issue45913.go [new file with mode: 0644]