]> Cypherpunks repositories - gostls13.git/commit
image/jpeg: increase TestLargeImageWithShortData timeout by an order of magnitude
authorBryan C. Mills <bcmills@google.com>
Wed, 25 May 2022 15:09:56 +0000 (11:09 -0400)
committerGopher Robot <gobot@golang.org>
Tue, 12 Jul 2022 21:23:11 +0000 (21:23 +0000)
commit85486bcccb506514d67034e39f3ed588b5900f1c
treeec4c9b26d64eeec9028a4344b954a6739904afeb
parent27794c4d4a18c61d8c158d253421d72b5a6a8673
image/jpeg: increase TestLargeImageWithShortData timeout by an order of magnitude

Also dump goroutines on failure.

The original bug report in #10413 reported a hang of “several
minutes”. An apparently-spurious failure was observed in
https://build.golang.org/log/e5ac3ce3fb7d04ec13e5bbfadea8bb5869a4dd1e,
with a delay of only 3.64s.

Moreover, if the test does fail due to a regression, we will want a
goroutine dump to diagnose where it got stuck. The current call to
t.Fatalf does not produce such a dump, so is not nearly as useful if
the failure only occasionally reproduces.

Updates #10413.

Change-Id: I6ab9d112f14f438a0c54e02ec95934627acdc64b
Reviewed-on: https://go-review.googlesource.com/c/go/+/408355
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Yuval Pavel Zholkover <paulzhol@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/image/jpeg/reader_test.go