]> Cypherpunks repositories - gostls13.git/commit
crypto/tls: make Config.Clone also clone the GetClientCertificate field
authorMike Danese <mikedanese@google.com>
Wed, 1 Mar 2017 18:43:57 +0000 (10:43 -0800)
committerAdam Langley <agl@golang.org>
Thu, 2 Mar 2017 19:43:07 +0000 (19:43 +0000)
commit87649d32ad16a9a0b7bd5dbd1c124b2032a270f1
tree8a49214279be0e0cb20a384c66b2ca06665c2010
parent2f5aea7c1305158a6d87ea356f0ed2a8186bc73d
crypto/tls: make Config.Clone also clone the GetClientCertificate field

Using GetClientCertificate with the http client is currently completely
broken because inside the transport we clone the tls.Config and pass it
off to the tls.Client. Since tls.Config.Clone() does not pass forward
the GetClientCertificate field, GetClientCertificate is ignored in this
context.

Fixes #19264

Change-Id: Ie214f9f0039ac7c3a2dab8ffd14d30668bdb4c71
Signed-off-by: Mike Danese <mikedanese@google.com>
Reviewed-on: https://go-review.googlesource.com/37541
Reviewed-by: Filippo Valsorda <hi@filippo.io>
Reviewed-by: Adam Langley <agl@golang.org>
Run-TryBot: Adam Langley <agl@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/crypto/tls/common.go
src/crypto/tls/tls_test.go