]> Cypherpunks repositories - gostls13.git/commit
strings: re-introduce noescape wrapper
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Mon, 15 Jul 2024 16:20:52 +0000 (23:20 +0700)
committerGopher Robot <gobot@golang.org>
Mon, 15 Jul 2024 17:08:26 +0000 (17:08 +0000)
commit8f1ec59bdb2d095b9caf31f6f3fd3e167b14ef0a
treeafa8553a8b60f34358c2cc00a6b5ccef4cedbda9
parent5d36bc18d56fa5d7ad10b675dd82892ed3100332
strings: re-introduce noescape wrapper

CL 573955 added internal/abi:NoEscape function, and use it in strings
builder copyCheck code.

However, internal/abi is a runtime package, which can not be built with
-d=checkptr flag yet. This causes incorrect inlining decision, since
NoEscape must not be inlined when -d=checkptr is used.

Fixing this by re-introducing noescape wrapper.

Fixes #68415

Change-Id: I776cab4c9e9e4b3e58162dcce6ec025cb366bdee
Reviewed-on: https://go-review.googlesource.com/c/go/+/598295
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/strings/builder.go
test/fixedbugs/issue68415.go [new file with mode: 0644]