]> Cypherpunks repositories - gostls13.git/commit
crypto/x509: consider parents by Subject if AKID has no match
authorFilippo Valsorda <filippo@golang.org>
Mon, 4 Feb 2019 23:08:43 +0000 (18:08 -0500)
committerFilippo Valsorda <filippo@golang.org>
Thu, 7 Feb 2019 17:57:03 +0000 (17:57 +0000)
commit95e5b07cf5fdf3352f04f5557df38f22c55ce8e8
tree09ff2af02c2cff46611aaa3de55bd13ec5c7652e
parentaa161ad17e65df8f615f25c5dca84e505a8c8315
crypto/x509: consider parents by Subject if AKID has no match

If a certificate somehow has an AKID, it should still chain successfully
to a parent without a SKID, even if the latter is invalid according to
RFC 5280, because only the Subject is authoritative.

This reverts to the behavior before #29233 was fixed in 770130659. Roots
with the right subject will still be shadowed by roots with the right
SKID and the wrong subject, but that's been the case for a long time, and
is left for a more complete fix in Go 1.13.

Updates #30079

Change-Id: If8ab0179aca86cb74caa926d1ef93fb5e416b4bb
Reviewed-on: https://go-review.googlesource.com/c/161097
Reviewed-by: Adam Langley <agl@golang.org>
src/crypto/x509/cert_pool.go
src/crypto/x509/verify_test.go