]> Cypherpunks repositories - gostls13.git/commit
[dev.regabi] cmd/compile: improve ascompatee
authorMatthew Dempsky <mdempsky@google.com>
Sun, 3 Jan 2021 07:24:16 +0000 (23:24 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Sun, 3 Jan 2021 19:20:20 +0000 (19:20 +0000)
commita317067d65c2f9814cb05e573974d416949bace8
treef5d9f1db31733886022099c559fcd6f80df88331
parent5d80a590a2abc26dcc6cc4455f7cb2bf78fd9123
[dev.regabi] cmd/compile: improve ascompatee

order.go has already ordered function calls, so ascompatee only needs
to worry about expressions that might access a variable after it's
already been re-assigned. It already handles this, so the safeExpr
calls simply result in unnecessarily pessimistic code.

Does not pass toolstash -cmp, because it allows more efficient code
generation. E.g., cmd/go on linux/ppc64le is about 2kB smaller.

Change-Id: Idde0588eabe7850fa13c4e281fc46bbeffb4f68c
Reviewed-on: https://go-review.googlesource.com/c/go/+/281152
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/walk/assign.go