]> Cypherpunks repositories - gostls13.git/commit
cmd/compile: make sure to initialize static entries of slices
authorKeith Randall <khr@google.com>
Mon, 13 May 2019 20:43:49 +0000 (13:43 -0700)
committerKeith Randall <khr@golang.org>
Tue, 14 May 2019 16:36:38 +0000 (16:36 +0000)
commita9e107c85cf69d735ac81c29f4a354643e40b2b5
tree872a2fd4984d2d79044bd564aafb585ac96bc56d
parent2637f1f9505fec6d1e5db39ebc5a182a54356aa6
cmd/compile: make sure to initialize static entries of slices

If a slice's entries are sparse, we decide to initialize it dynamically
instead of statically. That's CL 151319.

But if we do initialize it dynamically, we still need to initialize
the static entries. Typically we do that, but the bug fixed here is
that we don't if the entry's value is itself an array or struct.

To fix, use initKindLocalCode to ensure that both static and
dynamic entries are initialized via code.

Fixes #31987

Change-Id: I1192ffdbfb5cd50445c1206c4a3d8253295201dd
Reviewed-on: https://go-review.googlesource.com/c/go/+/176904
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/cmd/compile/internal/gc/sinit.go
test/fixedbugs/issue31987.go [new file with mode: 0644]