]> Cypherpunks repositories - gostls13.git/commit
reflect: fix _faststr optimization
authorKeith Randall <khr@golang.org>
Mon, 13 Sep 2021 16:17:22 +0000 (09:17 -0700)
committerKeith Randall <khr@golang.org>
Mon, 13 Sep 2021 18:38:15 +0000 (18:38 +0000)
commitac40c9872f6e8ef095dcc6ee556236782eee4f76
treefc3e6168541f973c796be3deb83a4ba9eceee31b
parentc8a58f29dcb2b4f38ca4fcf4d2a2a80f606c9573
reflect: fix _faststr optimization

CL 345486 introduced an optimization to reflect's map accesses
which is not quite correct. We can't use the optimized code if the
value type is >128 bytes.

See cmd/compile/internal/walk/walk.go:mapfast

Fixes #48357

Change-Id: I8e3c7858693083dd4393a8de48ca5fa47bab66f2
Reviewed-on: https://go-review.googlesource.com/c/go/+/349593
Trust: Keith Randall <khr@golang.org>
Trust: Joe Tsai <joetsai@digital-static.net>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Trust: Martin Möhrmann <martin@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Run-TryBot: Joe Tsai <joetsai@digital-static.net>
Reviewed-by: Joe Tsai <joetsai@digital-static.net>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Martin Möhrmann <martin@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
src/reflect/value.go
test/fixedbugs/issue48357.go [new file with mode: 0644]