]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] test: rename blank functions
authorMatthew Dempsky <mdempsky@google.com>
Wed, 28 Jul 2021 19:59:14 +0000 (12:59 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Wed, 28 Jul 2021 21:41:07 +0000 (21:41 +0000)
commitadedf54288e826bd93ccf22ad104f768d42289d4
tree2fe786ecc9202827525f52896b45ce1e43bbf671
parent53557530093938e19c21f6b02a482939ac6e634b
[dev.typeparams] test: rename blank functions

This CL renames blank functions in the test/ directory so that they
don't rely on the compiler doing anything more than typechecking them.

In particular, I ran this search to find files that used blank
functions and methods:

$ git grep -l '^func.*\b_(' | xargs grep -n '^' | grep '\.go:1:' | grep -v '// errorcheck$'

I then skipped updating a few files:

* blank.go
* fixedbugs/issue11699.go
* fixedbugs/issue29870.go

  These tests specifically check that blank functions/methods work.

* interface/fail.go

  Not sure the motivation for the blank method here, but it's empty
  anyway.

* typeparam/tparam1.go

  Type-checking test, but uses "-G" (to use types2 instead of typecheck).

Updates #47446.

Change-Id: I9ec1714f499808768bd0dcd7ae6016fb2b078e5e
Reviewed-on: https://go-review.googlesource.com/c/go/+/338094
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
test/escape5.go
test/escape_goto.go
test/fixedbugs/bug267.go
test/fixedbugs/issue22076.go
test/fixedbugs/issue27557.go
test/fixedbugs/issue45258.go
test/fixedbugs/issue8042.go
test/fixedbugs/issue8761.go
test/inline.go
test/typeparam/issue45547.go
test/typeparam/typelist.go