]> Cypherpunks repositories - gostls13.git/commit
runtime: scan gp._panic in stack scan
authorCherry Zhang <cherryyz@google.com>
Sun, 10 Feb 2019 04:31:59 +0000 (23:31 -0500)
committerCherry Zhang <cherryyz@google.com>
Wed, 13 Feb 2019 15:49:22 +0000 (15:49 +0000)
commitaf8f4062c24cb36af4dc24fbaffd23aa7f7bde36
tree9b3c719fea5208f3acb4a402790f1c551247b09e
parentffd096db2b1cff6399eb1f86e5652564ee8ee362
runtime: scan gp._panic in stack scan

In runtime.gopanic, the _panic object p is stack allocated and
referenced from gp._panic. With stack objects, p on stack is dead
at the point preprintpanics runs. gp._panic points to p, but
stack scan doesn't look at gp. Heap scan of gp does look at
gp._panic, but it stops and ignores the pointer as it points to
the stack. So whatever p points to may be collected and clobbered.
We need to scan gp._panic explicitly during stack scan.

To test it reliably, we introduce a GODEBUG mode "clobberfree",
which clobbers the memory content when the GC frees an object.

Fixes #30150.

Change-Id: I11128298f03a89f817faa221421a9d332b41dced
Reviewed-on: https://go-review.googlesource.com/c/161778
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
src/runtime/crash_test.go
src/runtime/extern.go
src/runtime/mgcmark.go
src/runtime/mgcsweep.go
src/runtime/runtime1.go
src/runtime/testdata/testprog/crash.go