]> Cypherpunks repositories - gostls13.git/commit
net: add (*Resolver).LookupIP
authorIan Gudger <igudger@google.com>
Fri, 17 Apr 2020 11:04:23 +0000 (04:04 -0700)
committerIan Gudger <igudger@google.com>
Tue, 28 Apr 2020 21:46:16 +0000 (21:46 +0000)
commitb1b67841d1e229b483b0c9dd50ddcd1795b0f90f
tree7376ded69e869e1e87292b3117bf51b34497aea7
parent17d5cef257dbb50bbe38c4f2f79cd000e01c97a6
net: add (*Resolver).LookupIP

Previously, looking up only IPv4 or IPv6 addresses was only possible
with DefaultResolver via ResolveIPAddr. Add this functionality to the
Resolver type with a new method, LookupIP. This largely brings Resolver
functionally to parity with the global functions. The name LookupIP is
used over ResolveIPAddr to be consistent with the other Resolver
methods.

There are two main benefits to (*Resolver).LookupIP over
(*Resolver).LookupHost. First is an ergonomic benefit. Wanting a
specific family of address is common enough to justify a method, evident
by the existence of ResolveIPAddr. Second, this opens the possibility of
not performing unnecessary DNS requests when only a specific family of
addresses are needed. This optimization is left to follow up work.

Updates #30452

Change-Id: I241f61019588022a39738f8920b0ddba900cecdd
Reviewed-on: https://go-review.googlesource.com/c/go/+/228641
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
src/net/lookup.go
src/net/lookup_test.go